Simple Multidomain Support question

2008-04-08 Thread Michael Bien
Hi, i checked out from trunk and tried to apply the patch ( http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Simple+Multidomain+Support ) but roller was not able to boot. after adding this line to JPAMultiDomainWebloggerModule: binder.bind(WeblogEntryManager.class).to( JPA

Re: Simple Multidomain Support question

2008-04-10 Thread Michael Bien
Dave wrote: On Tue, Apr 8, 2008 at 10:06 PM, Michael Bien <[EMAIL PROTECTED]> wrote: i checked out from trunk and tried to apply the patch ( http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Simple+Multidomain+Support ) but roller was not able to boot. after adding this l

PlanetManagerLocalTest.testRefreshEntries() doesn't clean up properly

2019-07-31 Thread Michael Bien
Hello, it seems as if PlanetManagerLocalTest.testRefreshEntries() doesn't clean up properly and one subscription remains after the test finishes. This causes other, unrelated tests to fail. E.g in my case its SubscriptionFunctionalTests.testSubscriptionLookups. best regards, michael

Re: PlanetManagerLocalTest.testRefreshEntries() doesn't clean up properly

2019-08-19 Thread Michael Bien
seems to be a leftover from the PlanetManagerLocalTest. best regards -michael On 18.08.19 15:27, Dave wrote: Sorry, I missed this message. What branch are you working in. All tests pass for me in master and roller-5.2.x. Dave On Thu, Aug 1, 2019 at 12:56 AM Michael Bien wrote: Hello, it

Re: Jenkins build is still unstable: Roller #1576

2019-09-25 Thread Michael Bien
On 20.09.19 11:05, Swapnil M Mane wrote: Hi team, It seems the SubscriptionFunctionalTests.testSubscriptionLookups() test case is getting failed. Does anyone have any idea about this? PlanetManagerLocalTest.testRefreshEntries() seemed to leave some subs attached last time i checked (which cau

Velocity Renovation

2019-11-29 Thread Michael Bien
Hello Rollers, just wanted to mention that before I updated roller to use latest apache lucene, I tried to update apache velocity, but had to give up fairly early on. The problem was that the build is using the texen ant task of velocity 1.7* to generate the db scripts and velocity 2.1 doesn

Re: [VOTE] to release candidate #3 as Apache Roller 6.0.0

2019-12-20 Thread Michael Bien
+1 (not part of the team) its running great on JDK 13 best regards, michael On 19.12.19 23:39, Dave wrote: I'm going to leave voting open through the weekend to give folks time to review/test the RC. Thanks, Dave On Wed, Dec 18, 2019 at 8:11 AM Aditya Sharma wrote: +1 Thanks Dave! Than

a few things i was working on

2020-07-13 Thread Michael Bien
Hello Rollers, i just pushed a few commits i had locally to a my wip branch (https://github.com/mbien/roller/commits/wip ). Please don't pull from my WIP branch to a non-wip branch since i might sometimes -f push into it. a few highlights: - spring now at v5.x (it was at 2 before I started :

Re: a few things i was working on

2020-07-16 Thread Michael Bien
The way it would work is to have a default log4j2.xml in the war, which can be copied and overwritten by putting it in the classpath of the server. Would this be ok? best regards, -michael On Mon, Jul 13, 2020 at 5:55 AM Michael Bien wrote: Hello Rollers, i just pushed a few commits i had lo

Re: a few things i was working on

2020-07-19 Thread Michael Bien
On 18.07.20 00:09, Dave wrote: Hi Michael, Answers inline below: On Fri, Jul 17, 2020 at 2:22 AM Michael Bien <mailto:mbie...@gmail.com>> wrote: 1) I submitted the ICLA but I can't find me on the committer-index yet - not sure if that is a problem. Your I

StylesheetEdit.jsp never receives custom stylesheets

2020-08-06 Thread Michael Bien
Hello, is the master branch currently up2date? if yes then i might have just fixed a bug: StylesheetEdit only sets the stylesheet if it is shared, never when its a custom theme. This causes the Design/Stylesheet page to think that the theme doesn't have a stylesheet. the file in roller mas

Re: StylesheetEdit.jsp never receives custom stylesheets

2020-08-23 Thread Michael Bien
ping On 06.08.20 14:48, Michael Bien wrote: Hello, is the master branch currently up2date? if yes then i might have just fixed a bug: StylesheetEdit only sets the stylesheet if it is shared, never when its a custom theme. This causes the Design/Stylesheet page to think that the theme

Re: StylesheetEdit.jsp never receives custom stylesheets

2020-08-23 Thread Michael Bien
awesome! best regards, michael On 23.08.20 15:49, Dave wrote: Yes, master is now up-dated with the latest from the 6.0.x branch. And, your stylesheet fix looks good. Thanks! Dave On Sun, Aug 23, 2020 at 8:00 AM Michael Bien wrote: ping On 06.08.20 14:48, Michael Bien wrote: Hello

Retargeted old PR#63 to master

2020-08-23 Thread Michael Bien
I just changed the target branch of my old Lucene PR* to master. I haven't noticed that github added this feature 4 years ago :) since the changes in my WIP branch are not independent from each other i am going to wait until its integrated before i create new PRs. Otherwise it could get compli

Roller Updates

2020-09-21 Thread Michael Bien
I noticed that the db upgrade step for future roller 6.1 didn't exist yet which would cause roller (master branch) to fail during start - so i added it (due to blacklist column renaming). (I am mostly mentioning it here so that nobody else has to implement it in parallel) I did also rebase eve

Re: Enable CodeQL scanning for the Roller repositories

2020-10-02 Thread Michael Bien
this can't hurt +1 from me -michael On 02.10.20 15:11, Aditya Sharma wrote: Hi team, I think we can enable the code scanning security feature for all the Roller repositories available with GitHub that helps identifying security vulnerabilities using CodeQL. https://github.com/apache/roller/s

Re: Jenkins build is still unstable: Roller #1576

2021-03-26 Thread Michael Bien
ache.org/job/Roller/1576/display/redirect?page=changes> other thread Sorry, I missed this message. What branch are you working in. All tests pass for me in master and roller-5.2.x. Dave On Thu, Aug 1, 2019 at 12:56 AM Michael Bien wrote: Hello, it

Re: [ANNOUNCE] Welcome Michael Bien as new PMC member

2021-05-25 Thread Michael Bien
On 25.05.21 09:53, Yash Maheshwari wrote: Congratulations, Michael! On Tue, 25 May 2021 at 10:35, Aditya Sharma wrote: Hello everyone, The Roller PMC has invited Michael Bien to become a member of the committee and we are glad to announce he has accepted the nomination. On behalf of the Roller PMC, welcome onboard Michael!

Re: Splitting the struts.xml file

2021-06-02 Thread Michael Bien
Hi Yash, i actually don't mind central configs - at least until they grow large and become difficult to maintain. It has currently ~650 lines which isn't too bad IMO. There is also an alternative to splitting: a lot of it could be moved to annotations which would shrink the file. i would p

Re: [GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

2021-07-11 Thread Michael Bien
Hi Greg, those are java 8 functional streams* - not IO streams. So they don't really have to be closed, the method collect() "runs" the stream in this example by putting all results into a list. There are no system resources involved which would have to be freed. this code snipped creates a

Re: [GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

2021-07-11 Thread Michael Bien
tream.  Says it closes it once read, and should maintain the order. too many ways of doing the same stuff. On 11/07/2021 08:36, Michael Bien wrote: Hi Greg, those are java 8 functional streams* - not IO streams. So they don't really have to be closed, the method collect() "runs

Re: [GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

2021-07-14 Thread Michael Bien
021 15:13, Michael Bien wrote: no worries. I remember the first time i heard of java getting streams my first thought was io too. Streams are great as long you don't overuse them. -michael On 11.07.21 10:09, Greg Huber wrote: Sorry you are right, was thinking more of io streams,

Re: [GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

2021-07-15 Thread Michael Bien
On 15.07.21 10:12, Greg Huber wrote: You are correct, it is easy to read, and a good one liner. Alas, like most frameworks nowadays, we lean how the framework works (former) rather than programming (latter). having the main class WeblogEntry getTag() initially from the db in the correc

CodeQL & Roller

2021-07-18 Thread Michael Bien
Hello, does anyone know if there is a way to run the github CodeQL scan locally? I was about to abuse a PR for that but then i thought there must be a better way. regards, michael

Re: CodeQL & Roller

2021-07-20 Thread Michael Bien
please ignore the PR run failed warning mail - it was just a test. -michael On 19.07.21 14:03, Dave wrote: There is a CodeQL CLI, but I've never used it https://codeql.github.com/docs/codeql-cli/#codeql-cli Dave On Sun, Jul 18, 2021 at 7:02 AM Michael Bien wrote: Hello, does anyone

Re: CodeQL & Roller

2021-07-20 Thread Michael Bien
after* the CodeQL init, since CodeQL is monitoring what is happening in the gh action https://github.com/apache/roller/pull/98/commits/22e090b5b2856e493b9e9c03777f040caf42550f -michael On 20.07.21 13:19, Michael Bien wrote: please ignore the PR run failed warning mail - it was just a test. -m

Re: VOTE: Release Apache Roller 6.0.2

2021-08-09 Thread Michael Bien
+1 I did some minimal manual testing (create blog+user, post entry etc) in a container and everything worked fine. -michael On 08.08.21 21:57, Dave wrote: Please vote to release the release candidate (RC2) at the link below as Apache Roller 6.0.2 The release candidate is here https://dist.ap

Re: MediaFileView.jsp

2021-08-09 Thread Michael Bien
On 09.08.21 09:51, Greg Huber wrote: Spotted this one when deleting a folder: MediaFileView.jsp function onDeleteFolder() {     if (confirm("/>")) {     document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';     document.bookmarks.submit();     }     } g

Re: MediaFileView.jsp

2021-08-10 Thread Michael Bien
On 10.08.21 09:05, Greg Huber wrote: > looks like a copy and paste bug on first glance. However deleting folders actually works, right? I ran a quick test and the folder is gone. Yes it works, but I get this error in the console (forgot to add this to the first email) after delete: Uncaught

next roller release

2021-09-16 Thread Michael Bien
Hello Everyone, now that JDK 17 is out I was wondering if apache roller should get an update release too. The master branch was compatible with Java 17 for a while already. My blog container is also using early access builds of Java 17 for months without problems. maybe in next month or two,

Re: rollerweblogger.org

2021-10-04 Thread Michael Bien
I have a spare raspi if you need one :P On 04.10.21 23:16, Dave wrote: Just FYI, I'm working on bringing rollerweblogger.org back up. Running a blog-site on Kubernetes is total overkill, so of course, that is exactly what I am doing and now it's time to pay the cost. It's Kubernetes upgrade tim

heads up when running roller from master branch

2021-12-11 Thread Michael Bien
Hello Everyone, Just a heads up in case you are building and running apache roller from master, please rebuild your instance with the latest changes. It contains an important dependency update (https://github.com/apache/roller/pull/106) for log4j 2 which suffered from a RCE security vulnerab

Re: next roller release

2021-12-11 Thread Michael Bien
go through and learn the process. Dave On Thu, Sep 16, 2021 at 1:36 AM Michael Bien wrote: Hello Everyone, now that JDK 17 is out I was wondering if apache roller should get an update release too. The master branch was compatible with Java 17 for a while already. My blog container is also usi

Re: next roller release

2021-12-11 Thread Michael Bien
master), but now I'm thinking we should just do one 6.1 release and encourage folks to upgrade to that. Thoughts? Dave On Sat, Dec 11, 2021 at 4:32 PM Michael Bien wrote: all PRs are integrated, would be good timing for 6.1 :) -michael On 18.09.21 03:19, Dave wrote: >

Re: heads up when running roller from master branch

2021-12-11 Thread Michael Bien
egards, michael On 11.12.21 23:05, Dave wrote: Nice! I did not remember that 6.0.2 still used Log4j 1. On Sat, Dec 11, 2021 at 4:20 PM Michael Bien wrote: Hello Everyone, Just a heads up in case you are building and running apache roller from master, please rebuild your instance with the

Re: VOTE: Release Roller v6.1.0

2021-12-14 Thread Michael Bien
red a release candidate and some release notes, below. Please vote in the next 72 hours to approve this release. +1 to release -1 not to release (with reasons) Thanks to Michael Bien for all his work since the 6.0.1 release on bug fixes, general improvements and dependency updates like the important o

Re: roller 6.1.0 release/log4j?

2021-12-16 Thread Michael Bien
it is currently in the voting process. more info and link to the candidate in that mail: https://mail-archives.apache.org/mod_mbox/roller-dev/202112.mbox/%3CCAF1aazBVAwdj8wofDHt1Fj2LapBz%3Dfwgegs64EaA7qf-08ZdTQ%40mail.gmail.com%3E feel free to test it and give feedback. best regards, michael O

Re: VOTE: Release Roller v6.1.0

2021-12-17 Thread Michael Bien
propose that we release Roller v6.1.0 based on the code that is currently in the master branch. I have prepared a release candidate and some release notes, below. Please vote in the next 72 hours to approve this release. +1 to release -1 not to release (with reasons) Thanks to Michael Bien for all

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

2021-12-18 Thread Michael Bien
based on the code that is currently in the master branch. I have prepared a release candidate and some release notes, below. Please vote in the next 72 hours to approve this release. +1 to release -1 not to release (with reasons) Thanks to Michael Bien for all his work since the 6.0.1 release on bug

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

2021-12-19 Thread Michael Bien
18/12/2021 20:48, Dave wrote: I propose that we release Roller v6.1.0 based on the code that is currently in the master branch. I have prepared a release candidate and some release notes, below. Please vote in the next 72 hours to approve this release. +1 to release -1 not to release (with reason

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

2021-12-21 Thread Michael Bien
20.12.21 07:04, Greg Huber wrote: It was a tomcat start and stop, no deploy/redeploy.  Seems to do it all the time. On 19/12/2021 10:46, Michael Bien wrote: this looks like you redeployed or undeployed roller? App/web servers don't like it when unmanaged threads are started, AsyncAppender

Re: VOTE: Release Roller v6.1.0

2021-12-22 Thread Michael Bien
On 15.12.21 11:53, Greg Huber wrote: When doing a search, and logged, we get a login url on the bottom of search page. http://localhost:8080/roller/mainpage/search?q=test  * Front Page  * Weblog  * Login

Re: VOTE: Release Roller v6.1.0

2021-12-22 Thread Michael Bien
On 15.12.21 11:53, Greg Huber wrote: may be worth checking: From the docs: The quotes are wrong ie ` possibly make users check the script??: grant all on rollerdb.* to scott@`%' identified by `tiger'; grant all on rollerdb.* to scott@localhost identified by `tiger'; i haven't touche

Re: [ANNOUNCEMENT] Apache Roller 6.1.0 release is available

2021-12-22 Thread Michael Bien
excellent! Great job with the release Dave. a few notes for users: - Apache Roller supports JDK 17 now (11 is still supported) - one db table got renamed, for automatic migration set installation.type=auto in your roller-custom.properties before first start - logger config can't be put into

Re: Roller 6.1.1 RC #1 to fix MySQL 5.7 upgrade problem

2021-12-24 Thread Michael Bien
i keep getting surprised how bad the compatibility of SQL is. Even simple statements need special casing. At lest newer MySQL can use the standard alter/rename syntax. thanks for fixing this Dave, michael On 24.12.21 23:49, Dave wrote: I put together a release that fixes the upgrade problem

Re: Roller 6.1.1 RC #1 to fix MySQL 5.7 upgrade problem

2021-12-27 Thread Michael Bien
I noticed when upgrading from 6.1 to 6.1.1, Roller ran the upgrade scripts again, is that intended? Its probably fine to run them twice even though nothing db related changed in the patch release - i was still wondering. -michael On 24.12.21 23:49, Dave wrote: I put together a release that

latest spring vulnerability and roller

2022-04-01 Thread Michael Bien
Hello Roller users, you probably heard of "spring shell"* by now. if you don't want to wait for a roller update release, building roller yourself is really easy. follow first two steps described here: https://github.com/apache/roller#quick-start-running-via-maven The master branch already

Re: latest spring vulnerability and roller

2022-04-01 Thread Michael Bien
/apache/roller/actions/runs/2080694025 (see bottom of the page for artifacts) best regards, michael On 02.04.22 01:50, Michael Bien wrote: Hello Roller users, you probably heard of "spring shell"* by now. if you don't want to wait for a roller update release, building roller yourself

Re: latest spring vulnerability and roller

2022-04-02 Thread Michael Bien
PM Michael Bien wrote: Hello again, dev builds are now also uploaded automatically after PR integration. index for master builds: https://github.com/apache/roller/actions/workflows/main.yml?query=branch%3Amaster example of the most recent build (would be the first link of the index above

Re: VOTE: Release Roller 6.1.1

2022-04-03 Thread Michael Bien
+1 - sha256s of sources and bin gz matched - ran quick test in a fresh container using tomcat 9, postgres 14.1, jdk 17 and everything worked fine - checked that the right spring version is in the war best regards, michael bien On 03.04.22 15:44, Dave wrote: Roller 6.1.1 is a minor bug fix

Re: Apache tiles

2023-03-21 Thread Michael Bien
roller would need some updates before it can go beyond struts 2.5.29: https://github.com/apache/roller/pull/119#issuecomment-1344814362 probably easy to do but I never got to it. (bump the version and you should see failing integration tests) the bootstrap dependency is also locked to 3.4.x

Roller v6.1.2 rc1

2023-07-20 Thread Michael Bien
Hi Dave, /WEB-INF/lib/ contains now Jetty 9.4 which pulled due to the new org.apache.solr:solr-solrj dependency. I don't think the apache solr client is used anywhere, I removed the dependency and build/junit/integration works with 9 MB less libs deployed. Would it be better to remove it ag

Re: Release rc1 as Roller v6.1.2

2023-07-20 Thread Michael Bien
we could use the github release feature, which essentially creates a PR list between two tags and can be generated with a few clicks. Roller 6.1.1 tag is missing at the moment, this draft creates a list down to 6.1.0 as demonstration: https://github.com/apache/roller/releases/tag/untagged-180

Release rc2 as Roller v6.1.2

2023-07-29 Thread Michael Bien
Hi Greg, I could reproduce it, this seems to be a cache invalidation issue. the entry will disappear if you clear the cache via the Maintenance UI. Roller has also various cache settings which can be set in roller properties, e.g age based eviction which would further mitigate this. This is

Re: [VOTE] Release rc2 as Roller v6.1.2

2023-07-29 Thread Michael Bien
+1 (binding) super sorry for the delay Dave.  * tested a fresh blog setup using JDK 17, tomcat 9 + postgresql in containers and everything worked fine (except the cache issue Greg mentioned)  * tested blog upgrade using JDK 20, jetty + hsqldb  * sha256 sigs look good  * lib folder looks good

Re: Upgrade to latest struts

2023-10-06 Thread Michael Bien
Hi Greg, you could open a PR which will let tests run against it. This produces a dev build too for manual testing. on first glance: app/tools/roller.xml is probably not intended on the commit there are also a lot of whitespace changes in the commit. PR diffs can filter some of them out, bu

Re: [VOTE] Release Apache Roller 6.1.3 based on rc1

2024-06-03 Thread Michael Bien
+1 (binding) Hi Dave!  - checked sha256 sigs  - checked WEB-INF/lib  - tested first deployment+first post using containers (podman, tomcat 9, JDK 17, postgresql 42.x)  - indirectly tested the functionality by having a similar build deployed for a few month by now (JDK 21, jetty, hsqldb) look

Re: [VOTE] Release Apache Roller 6.1.3 based on rc1

2024-06-03 Thread Michael Bien
On 03.06.24 10:05, Greg Huber wrote: Looks great. Database upgrade no problems. looks like a debug setting made it into the candidate: https://github.com/apache/roller/blob/f6b3aa448d7703430e11b761b703b69020ea38a7/app/src/main/resources/log4j2.xml#L73 this would be set to "info" normally. -mb

Re: [VOTE] Release Roller 6.1.4 (rc2)

2024-10-07 Thread Michael Bien
+1 (binding)  - sigs ok, archive contents look good  - tested fresh blog setup in a debian container (JDK 17, postgresql 14, tomcat 9)  - checked the new defaults and also that they can be toggled on again  - checked a few things regarding authentication looks like a good release! best regard

Re: Problems with Struts2 Bootstrap 5.0.4

2024-10-13 Thread Michael Bien
On 13.10.24 09:59, Greg Huber wrote: Same here. you see errors in roller 6.1.4? If you want to upgrade struts2-bootstrap, you will need to switch to v6 as 2.5 is eol. v4.0.3 works on struts 6.  From what I can remember the 2.5 to 6 was an easy upgrade. yep, however i would recommend a

Re: Problems with Struts2 Bootstrap 5.0.4

2024-10-12 Thread Michael Bien
Hi Dave, On 12.10.24 22:58, Dave Johnson wrote: I am seeing errors in several Roller 6.1.4 pages including weblog edit and related to Struts2 Bootstrap. These errors prevent correct rendering of the pages. We recently upgraded the Struts2 Bootstrap dependency to I don't see 5.x bootstrap in

Re: Problems with Struts2 Bootstrap 5.0.4

2024-10-13 Thread Michael Bien
awesome - I thought that something like that might have happened :) -mbien On 13.10.24 16:12, Dave Johnson wrote: Sorry, I got confused by too many branches. I now see that Roller 6.1.4 has Struts 2 Bootstrap 4.0.0 which works fine. Dave On Oct 13, 2024, at 4:09 AM, Michael Bien wrote

Re: [VOTE] Release Apache Roller 6.1.4 (RC1)

2024-09-28 Thread Michael Bien
+1 (binding) checked:  - sigs match, dependencies in war look good  - tested fresh weblog installation on JDK 17, tomcat 9, postgresql, debian + podman (new defaults seem to work)  - deployed update to personal blog and everything looks fine (Jetty, JDK 21, hsqldb) thanks for rollin' a releas

Re: [VOTE] Release Apache Roller 6.1.5

2025-03-16 Thread Michael Bien
thanks for the reminder, i got swamped with things, then I forgot about this vote - sorry. Unfortunately I encountered the same security violation errors (code 500) as Greg. e.g table creation for example doesn't work for me without navigating back again and pressing the button again - second

Re: [VOTE] Release Apache Roller 6.1.5 - RC2

2025-04-06 Thread Michael Bien
+1 (binding)  - sigs ok  - zip content looks good  - new blog creation smoke test succeeded (using docker.io/tomcat:9-jdk17) everything worked - great job dave! best regards, michael On 4/5/25 16:02, Dave wrote: > Dear Apache Roller Community, > > I am pleased to call for a vote on the relea

Re: Roller on Tomcat 10 question

2025-04-27 Thread Michael Bien
Hi Phil, struts likely would have to be updated first before attempting the namespace switch. https://github.com/apache/roller/blob/395cfa30a7b274f8540424d11404c3e7433243f8/app/pom.xml#L61 The next point release (.30) has some breaking changes, so it would be good to stabilize roller on latest