On 18.07.20 00:09, Dave wrote:
Hi Michael,
Answers inline below:
On Fri, Jul 17, 2020 at 2:22 AM Michael Bien <mbie...@gmail.com
<mailto:mbie...@gmail.com>> wrote:
1) I submitted the ICLA but I can't find me on the committer-index
yet -
not sure if that is a problem.
Your ICLA is on file according to this page:
http://people.apache.org/unlistedclas.html
awesome.
2) which branch should the PRs target? roller-6.0.x is up-to-date
and my
wip branch is based on it, but this might be the wrong branch for
larger
changes. Maybe fork roller-6.0.x into the next version or a fresh
master
(current master had some commits missing which caused me to fix
things
which were not broken https://github.com/apache/roller/pull/58 )
I would recommend targeting the master branch. Any changes in
roller-6.0.x should be merged to master. I think your changes should
go into the next non-patch release, i.e. 6.1.0.
understood. I will add the next PR as soon the open PR
(https://github.com/apache/roller/pull/63) is integrated so that i don't
have to rebase. I already sorted the commits in my wip branch so the
hardest part is done.
3) roller currently supports having log4j1 configuration in
roller.properties + roller-custom.properties and merges them to
directly
initialize log4j1 (breaking through the commons.logging layer). This
won't work anymore once roller moved to log4j2. The way it would
work is
to have a default log4j2.xml in the war, which can be copied and
overwritten by putting it in the classpath of the server. Would
this be ok?
I'm OK with that change. Anybody else want to comment?
the original plan changed a little. Custom configs must be set with the
standard log4j.configurationFile system property (can be put in
custom-roller.props if desired or set via JVM -D etc) but everything
else stayed the same.
details in commit msg
https://github.com/mbien/roller/commit/c3da29e5be2d7d104edae5b928c2dd86e9087382
-michael
Dave
