On 16.07.20 15:49, Dave wrote:
Wow, these sound great! Please create some PRs, break them up and order
them as you wish.
Dave
Hello Dave,
a few questions:
1) I submitted the ICLA but I can't find me on the committer-index yet -
not sure if that is a problem.
2) which branch should the PRs target? roller-6.0.x is up-to-date and my
wip branch is based on it, but this might be the wrong branch for larger
changes. Maybe fork roller-6.0.x into the next version or a fresh master
(current master had some commits missing which caused me to fix things
which were not broken https://github.com/apache/roller/pull/58 )
3) roller currently supports having log4j1 configuration in
roller.properties + roller-custom.properties and merges them to directly
initialize log4j1 (breaking through the commons.logging layer). This
won't work anymore once roller moved to log4j2. The way it would work is
to have a default log4j2.xml in the war, which can be copied and
overwritten by putting it in the classpath of the server. Would this be ok?
best regards,
-michael
On Mon, Jul 13, 2020 at 5:55 AM Michael Bien <mbie...@gmail.com> wrote:
Hello Rollers,
i just pushed a few commits i had locally to a my wip branch
(https://github.com/mbien/roller/commits/wip ). Please don't pull from
my WIP branch to a non-wip branch since i might sometimes -f push into it.
a few highlights:
- spring now at v5.x (it was at 2 before I started :) )
- velocity at v2.x
- integration tests are fixed
- up2date password encoders for the db usecase, including upgrade logic
from old to new encodings
details in the commit msgs.
some collateral damage:
When I updated velocity i didn't update the GeneratePlanetTask util,
since i wasn't quite sure what it is supposed to do. It uses the texen
generator class directly which is part of an ant task which has been
removed after velocity 1.6. The build-time db script generation does
also still use 1.6 for the same reason, but it is a plugin dependency
now - so that it won't end up in the roller distribution.
I only manually tested the pw-in-db usecase with the new encoders. I am
not sure if LDAP logins still work (but they should). I also haven't
tested any of the blogging API functionality since it is also something
i don't personally use. RollerAtomHandler has also some user auth code -
I don't even know how to test that, but if it worked before it might
still now - whatever the usecase is :)
Things i have still locally is an update from log4j1 (which is also EOL)
to log4j2 and some JFR integration, both is already running on my own
blog instance. If there is interest i could contribute that too.
Let me know what you think and if/when i should create PRs. I wanted to
wait at least until the Lucene PR is closed before opening new PRs from
separate branches.
best regards,
michael
