Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-01-30 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Tue, Jan 31, 2023 at 6:57 AM wrote: > > Hello everyone. > > I would like to start the vote for PIP-242 > https://github.com/apache/pulsar/issues/19239, > Please let me know if you have any concerns or questions. > > Best, > Mattison > > --- Paste original PIP c

Pulsar Python client 3.1.0 release

2023-01-31 Thread Yunze Xu
There is a serious regression bug in Pulsar C++ client 3.1.0 [1], on which the Python client is based. And the Python client 3.0.0 also introduces a deadlock problem [2]. In addition, now the Python client supports Python 3.11. I'll start a 3.1.0 release for Pulsar Python client. [1] https://list

[VOTE] Pulsar Client Python Release 3.1.0 Candidate 1

2023-02-01 Thread Yunze Xu
This is the 1st release candidate for Apache Pulsar Client Python, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-python/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Python wheel

Re: [DISCUSS] Topic name restriction

2023-02-01 Thread Yunze Xu
The topic name character validation is already done by `NamedEntity#checkName`. And I agree that the system topic should be taken carefully as well. But I have a concern that whether we should treat all topics that start with the long underscore ("__") as system topics? Users might have defined the

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 1

2023-02-01 Thread Yunze Xu
(tested Mac & Linux) and the checksums are all > correct, though the version is `3.1.0a1`. We need to remove `a1` for > final release that are uploaded to PyPI > -- > Matteo Merli > > > On Wed, Feb 1, 2023 at 1:00 AM Yunze Xu wrote: > > > > This is the 1st r

[VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-02 Thread Yunze Xu
This is the 2nd release candidate for Apache Pulsar Client Python, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-python/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Python wheel

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-02 Thread Yunze Xu
letely different topic. > > I wonder what the maintainers think about this. > > On Mon, Jan 30, 2023 at 4:16 AM Yunze Xu > wrote: > > > In summary, the core issue is that ServiceUrlProvider could be > > misused. A user might want to implement its own ServiceUrlProvider by >

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-05 Thread Yunze Xu
Xiaolong Ran >>> >>> 丛搏 于2023年2月3日周五 13:39写道: >>> >>>> +1(binding) >>>> os: mac 12.6 >>>> python: 3.9.6 >>>> >>>> python3 ./examples/consumer.py >>>> python3 ./examples/producer.py >>>> >&

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-06 Thread Yunze Xu
oducer > > Thanks, > Zike Yang > > On Mon, Feb 6, 2023 at 1:31 PM Yunze Xu wrote: > > > > This wheel works for me. I tested the following commands on macOS Monterey > > 12.6: > > > > ```bash > > brew install python@3.7 > > python3.7 -m pip in

[DISCUSS] Fix OAuth2 regression for C++, Python, Node.js clients

2023-02-07 Thread Yunze Xu
Hi all, Recently I found a serious bug for OAuth2 authentication [1]. Here are some related issues: [2], [3]. The affected client versions are: - C++ client 3.0.0, 3.1.0, 3.1.1 - Python client 3.0.0 - Node.js client 1.8.0 Users have to downgrade back to old releases, which might suffer the CVE-20

Pulsar Cpp client release 3.1.2

2023-02-07 Thread Yunze Xu
Hi all, There is a serious OAuth2 authentication regression [1] for all existing C++ client 3.x.y releases. I see many users tend to downgrade to old versions like 2.10.2. This behavior is dangerous because of the CVE. The fix [2] is now merged, so I decided to start a 3.1.2 release ASAP, though

[VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-08 Thread Yunze Xu
This is the first release candidate for Apache Pulsar Client C++, version 3.1.2. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/issues?q=label%3Arelease%2F3.1.2 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note

Re: [VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-12 Thread Yunze Xu
o > > Baodi Shi 于2023年2月9日周四 18:28写道: > > > > +1 (non-binding) > > > > * Verify checksum and signatures > > * Build from source (MacOS arm64 13.1) > > * Verify oauth2 set `TlsTrustCertsFilePath`(libpulsarwithdeps.a) > > * Verify the oauth2 set `TlsT

Re: [VOTE] PIP-175: Extend time based release process

2023-02-12 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Thu, Feb 9, 2023 at 6:47 PM Nicolò Boschi wrote: > > +1 (binding) > > Nicolò Boschi > > > Il giorno gio 9 feb 2023 alle ore 11:17 Zike Yang ha > scritto: > > > +1 (non-binding) > > > > Thanks, > > Zike Yang > > > > On Thu, Feb 9, 2023 at 5:28 PM PengHui Li wrote:

Re: [DISCUSS] PIP-242 Topic name restrictions

2023-02-14 Thread Yunze Xu
Could you list all existing system topic names that are used so we can understand the rule better? Such as the "-RETRY" and "-DLQ" topics mentioned above. And I saw that this proposal only forbids the creation of these topics. What about writing messages to them? I think it's better not to allow P

Re: [VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-15 Thread Yunze Xu
un unit tests > > > > > > I have found an issue when running the unit test [0]. But it seems not > > > a regression bug and only affects the test code. So I am +1. > > > > > > [0] https://github.com/apache/pulsar-client-cpp/issues/193 > > > &g

Re: [DISCUSS] Switch the client complier to JDK 11 or 17 from JDK 8

2023-02-15 Thread Yunze Xu
-1 Upgrading the client is harder than upgrading the broker. Pulsar usually acts as a service to serve many lines of business and only a single team is responsible to maintain the server side. It would be hard to push all the client sides to upgrade the JDK. Instead of upgrading the minimum requi

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
Just saw the mail after the PR. > Pulsarctl is not an apache official repository net It does not make sense to me. Why cannot add it as a dependency? Thanks, Yunze On Fri, Feb 17, 2023 at 10:16 AM ZhangJian He wrote: > > Pulsarctl is not an apache official repository net, and given the > popul

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
rporating the functionality of the HTTP admin into pulsar-client-go > might be even better. Developers can use pulsar-client-go to perform > administrative tasks without having to switch to a separate tool like > pulsarctl. > > Thanks > ZhangJian He > > > On Fri, 17 Feb 20

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
concern, but for a small HTTP interaction, it's > probably too many layers of encapsulation. Let's see what other people say > > Thanks > ZhangJian He > > > On Fri, 17 Feb 2023 at 11:06, Yunze Xu wrote: > > > It's better to reuse existing code rather tha

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
> I notice that the Java Client and the Java Admin Client are separate dependencies. Is this boundary important to maintain for other language admin clients? IMO, separating them is better to maintain. I had an idea to implement a pure C implementation of the Pulsar admin API. Only libcurl and ope

Inconsistent GPG keys in dev and release repositories

2023-02-16 Thread Yunze Xu
Hi all, I found the GPG keys, which are used in verifying the signatures of release candidates, are much different in dev and release repositories: https://dist.apache.org/repos/dist/dev/pulsar/KEYS https://dist.apache.org/repos/dist/release/pulsar/KEYS >From here [1], it seems like we need to ap

Re: Inconsistent GPG keys in dev and release repositories

2023-02-17 Thread Yunze Xu
n > checking the GPG signature on the release file. > > BR, > Zike Yang > > On Fri, Feb 17, 2023 at 2:16 PM Yunze Xu wrote: > > > > Hi all, > > > > I found the GPG keys, which are used in verifying the signatures of > > release candidate

Re: Inconsistent GPG keys in dev and release repositories

2023-02-17 Thread Yunze Xu
CBA27442BB6AFB6CD26FA6 > gpg: Can't check signature: No public key > ``` > > I think you need to upload your kesy to [1]. > > [0] https://archive.apache.org/dist/pulsar/KEYS > [1] https://dist.apache.org/repos/dist/release/pulsar/KEYS > > BR, > Zike Yang > > O

Re: Inconsistent GPG keys in dev and release repositories

2023-02-17 Thread Yunze Xu
I've synchronized the missed keys from dev to release, including the following committers: - Yunze Xu - Yuto Furuta - xiangying - Baodi Shi See https://dist.apache.org/repos/dist/release/pulsar/KEYS Regarding whether to drop the KEYS in the dev repo, let's wait more opinions. Thanks,

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread Yunze Xu
; > > using github. > > > > > > > > > Has anyone tried generating an admin client from our generated open > > > > api spec? > > > > > > > > I have attempted it, but it requires us to modify our Swagger file. Our > >

[ANNOUNCE] Apache Pulsar Client C++ 3.1.2 released

2023-02-17 Thread Yunze Xu
The Apache Pulsar team is proud to announce Apache Pulsar Client C++ version 3.1.2. Pulsar is a highly scalable, low latency messaging platform running on commodity hardware. It provides simple pub-sub semantics over topics, guaranteed at-least-once delivery of messages, automatic cursor managemen

[VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-17 Thread Yunze Xu
This is the 3rd release candidate for Apache Pulsar Client Python, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-python/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Python wheel

Re: [VOTE][PIP-242] Topic name restriction

2023-02-19 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Sun, Feb 19, 2023 at 6:58 PM Asaf Mesika wrote: > > +1 (non-binding) > > On Sat, Feb 18, 2023 at 10:58 AM wrote: > > > Hi, All > > > > After a fascinating discussion, I would start the vote of PIP-242. > > > > We have chosen to drop out the `system topic` related i

Re: [DISCUSS] ClientVersion conflict across multiple language client

2023-02-21 Thread Yunze Xu
+1 But I'm wondering if it's possible to support configuring the client version string by users? For example, if users forked their own client, they might want to differ the client version with the official client. The disadvantage could be that users can configure any version string as they want.

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-21 Thread Yunze Xu
+1 (binding) * Verified checksum and signature * Build from source * Install from npm on Ubuntu 20.04 * Run an end-to-end test with custom `tlsTrustCertsFilePath` config on StreamNative cloud with OAuth2 authentication BTW, from the discussion here [1], it would be better to use https://downloads.

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Yunze Xu
arUri = pulsarUrl; > > >> const topicName = asTopic; > > >> > > >> const auth = new Pulsar.AuthenticationToken({ token: tokenStr }); > > >> const client = new Pulsar.Client({ > > >>serviceUrl: pulsarUri, > > >>authentication:

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Yunze Xu
I just noticed the `AuthenticationToken` is used here, so it's not related to #16064. The root cause is only that the prebuilt C++ add-on might have a different CA cert store path with the local env. Thanks, Yunze On Wed, Feb 22, 2023 at 10:30 PM Yunze Xu wrote: > > Hi Enrico

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-23 Thread Yunze Xu
t; > -- > > Matteo Merli > > > > > > > > On Fri, Feb 17, 2023 at 3:27 AM Yunze Xu > > wrote: > > > > > This is the 3rd release candidate for Apache Pulsar Client Python, > > > version 3.1.0. > > > > > > It fixes th

TLS regression verification for Python client 3.1.0 and Node.js client 1.8.1

2023-02-23 Thread Yunze Xu
Hi all, Currently there are two ongoing releases: Python client 3.1.0 [1] and Node.js client 1.8.1 [2]. Both these two releases depend on the C++ client 3.1.2, which fixes an issue that when performing OAuth2 authentication with an issuer URL whose protocol is HTTPS, users can configure the tls ce

Re: TLS regression verification for Python client 3.1.0 and Node.js client 1.8.1

2023-02-23 Thread Yunze Xu
ot;, O_RDONLY) = -1 ENOENT (No such file or directory) 1891 openat(AT_FDCWD, "/etc/pki/tls/certs/ca-bundle.crt", O_RDONLY) = -1 ENOENT (No such file or directory) ``` Thanks, Yunze On Thu, Feb 23, 2023 at 11:50 PM Yunze Xu wrote: > > Hi all, > > Currently there are two ongoi

Re: TLS regression verification for Python client 3.1.0 and Node.js client 1.8.1

2023-02-23 Thread Yunze Xu
ot;, // SLES10/SLES11, > https://golang.org/issue/12139 > "/etc/pki/tls/certs", // Fedora/RHEL > "/system/etc/security/cacerts", // Android > } > ``` > > Thanks, > Zixuan > > > > Yunze Xu 于2023年2月24日周五 02:06写道: > &g

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-28 Thread Yunze Xu
look? Thanks. > > BR, > Zike Yang > > On Tue, Feb 28, 2023 at 10:37 AM PengHui Li wrote: > > > > +1 (binding) > > > > - install on macos > > - start a standalone (latest master) > > - run the example > > https://github.com/apache/pulsar-c

Re: [DISCUSS] The GET_TOPICS_OF_NAMESPACE command should filter out system topics

2023-02-28 Thread Yunze Xu
I agree with Enrico that we should revert this change in 2.11. BTW, I see https://github.com/apache/pulsar-client-go/pull/969 tried to upgrade the Pulsar version to 2.11 for Go client. I think we'd better skip this version. There is no need to upgrade the server version unless we have to add a new

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-28 Thread Yunze Xu
the program to crash. > > I'm using the example codes here: > https://github.com/apache/pulsar-client-python/tree/main/examples > > Could you take a look? Thanks. > > BR, > Zike Yang > > On Tue, Feb 28, 2023 at 10:37 AM PengHui Li wrote: > > > > +1 (bin

Re: [DISCUSS] Release Pulsar Go Client 0.10.0

2023-03-01 Thread Yunze Xu
Please wait for a performance fix for the case when batch index ACK is enabled, I'm working on it. Currently, the throughput cannot exceed even 20MB/s when it's enabled. Thanks, Yunze On Wed, Mar 1, 2023 at 8:39 PM Baodi Shi wrote: > > Hi, zike. > > The current pulsar-client-go master branch has

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-03-01 Thread Yunze Xu
Hi Zike, I've fixed this crash and showed some explanations in https://github.com/apache/pulsar-client-python/pull/99. PTAL. After it's cherry-picked to branch-3.1, I will open the candidate 4. Thanks, Yunze On Wed, Mar 1, 2023 at 2:57 PM Yunze Xu wrote: > > Hi Zike, > >

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 2

2023-03-01 Thread Yunze Xu
+1 (binding) - Verified checksum and signature - Build from source on Ubuntu 20.04 WSL2 - Test produce and consume with examples in this repo - Test TLS encryption and OAuth2 authentication on Ubuntu 20.04 and Windows 10 with https://github.com/BewareMyPower/pulsar-tls-examples Thanks, Yunze On T

Re: [DISCUSS] PMC/Committer Emiratus status

2023-03-02 Thread Yunze Xu
As a PMC member, I don't like playing a game of determining who should be removed from PMC as well. I hear a viewpoint that someone is only participating in the community only to join a PMC so that he can benefit from it. After becoming a PMC member, he is never active in the community. It might b

[DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-03 Thread Yunze Xu
Hi all, Based on the previous discussion [1], I created a proposal to support configuring client version at SDK level: https://github.com/apache/pulsar/issues/19705 I've added more explanations in the motivation part, let's use this PIP as a subsequent discussion of [1]. BTW, there is a PR [2] i

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-04 Thread Yunze Xu
sal, you mention the case of client c++ at first, > but don't talk about it later. Is the scope of this proposal in the Java > client only? > > Best, > tison. > > > Enrico Olivelli 于2023年3月4日周六 06:38写道: > > > Yunze, > > > > Il Ven 3 Mar 2023, 12:31 Yun

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-03-05 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Fri, Mar 3, 2023 at 11:46 AM PengHui Li wrote: > > +1 (binding) > > Penghui > > > On Feb 13, 2023, at 14:56, Jiuming Tao > > wrote: > > > > Hi all, > > > > I would like to start a VOTE on `PIP-245: Make subscriptions of > > non-persistent topic non-durable`. > >

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-08 Thread Yunze Xu
Hi, I have changed this proposal to just add a config to `ClientBuilder`. And here is the demo implementation: https://github.com/BewareMyPower/pulsar/pull/21/files PTAL again. Thanks, Yunze On Sat, Mar 4, 2023 at 10:39 PM Yunze Xu wrote: > > Hi Enrico, > > Thanks for your su

[VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-08 Thread Yunze Xu
This is the 4th release candidate for Apache Pulsar Client Python, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-python/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Python wheel

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-09 Thread Yunze Xu
ed fine when I > upgraded it to the latest version of python 3.10: 3.10.10. > However, python 3.7.16, which is the latest version of python 3.7 > still not working. > > Not sure if it's a python issue, but only some python versions have > fixed it. Could you take a look again

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-09 Thread Yunze Xu
icial example uses a try-except block to avoid this issue. Thanks, Yunze On Thu, Mar 9, 2023 at 9:48 PM Yunze Xu wrote: > > Hi Zike, > > Did you run the latest example? I still see the exceptional info: > > ``` > line 1243, in receive > msg = self._consumer.receive(

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-09 Thread Yunze Xu
C++ client on their own. This > way, we can know exactly which underlying C++ client version the user > uses. > > Thanks, > Zike Yang > > On Wed, Mar 8, 2023 at 5:17 PM Yunze Xu wrote: > > > > Hi, > > > > I have changed this proposal to just ad

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-09 Thread Yunze Xu
I've updated this proposal to retain the original client version string. I'd rather use the "description" term, which indicates the client version has extra description in addition to the client version string. Thanks, Yunze On Fri, Mar 10, 2023 at 10:11 AM Yunze Xu wrote: &

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread Yunze Xu
tter to provide the user with good > practice for this. > > Thanks, > Zike Yang > > On Thu, Mar 9, 2023 at 10:10 PM Yunze Xu wrote: > > > > The reason is caused by the `client.close()` not being called. You > > should make sure `client.close()` is called when r

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-12 Thread Yunze Xu
eld to prevent > descriptions that are too long. > > Thanks, > Michael > > On Thu, Mar 9, 2023 at 8:28 PM Yunze Xu wrote: > > > > I've updated this proposal to retain the original client version > > string. I'd rather use the "description&qu

Re: Reuse Jetty server between unit test class.

2023-03-12 Thread Yunze Xu
Yeah, we should do that. There are many test classes that use BeforeMethod and AfterMethod for setup and teardown. We should use BeforeClass and AfterClass and take care of each single test to avoid affecting other tests in the same class. Thanks, Yunze On Sat, Mar 11, 2023 at 9:26 PM adobewjl w

Re: [VOTE] PIP-250: Add proxyVersion to CommandConnect

2023-03-13 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Mon, Mar 13, 2023 at 3:48 PM Zike Yang wrote: > > +1 (non-binding) > > Thanks > Zike Yang > > On Sat, Mar 11, 2023 at 12:08 PM Yubiao Feng > wrote: > > > > +1 (non-binding) > > > > Thanks > > Yubiao Feng > > > > On Sat, Mar 11, 2023 at 3:31 AM Michael Marshall > >

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-13 Thread Yunze Xu
nfusing for the user. Are there any strong cases where > the field `description` makes sense to the general user and not just > the library developer? > > Thanks, > Zike Yang > > On Mon, Mar 13, 2023 at 9:31 AM Yunze Xu wrote: > > > > > I think we > &

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-13 Thread Yunze Xu
gt; (apachepulsar/pulsar:2.11.0) > > > > Thanks, > > Bo > > > > Matteo Merli 于2023年3月11日周六 00:15写道: > > > > > > +1 (binding) > > > -- > > > Matteo Merli > > > > > > > > > > > > On Fri, Mar 10, 2023 at 7:44 AM Yunze

Re: [Discussion] Add a new default method to to the ManagedLedgerInterceptor

2023-03-14 Thread Yunze Xu
+1. I support cherry-picking it to release branches even if new default methods are added. It won't affect any existing use because the interface is customized by the 3rd party provider. No compatibility issue will happen. Thanks, Yunze On Tue, Mar 14, 2023 at 4:27 PM Enrico Olivelli wrote: > >

[VOTE] PIP-254: Support configuring client version with a description suffix

2023-03-15 Thread Yunze Xu
Hi all, This thread is to start the vote for PIP-254. Discussion thread: https://lists.apache.org/thread/65cf7w76tt23sbsjnr8rpfxqf1nt9s9l PIP link: https://github.com/apache/pulsar/issues/19705 Thanks, Yunze

Re: [VOTE] PIP-229: Add a common interface to get fields of MessageIdData

2023-03-15 Thread Yunze Xu
1:01 AM PengHui Li wrote: > > > > > > > +1(binding) > > > > > > > > Thanks, > > > > Penghui > > > > > > > > On Fri, Dec 23, 2022 at 10:31 AM 丛搏 wrote: > > > > > > > > > +1 (non-

[ANNOUNCE] Apache Pulsar Client Python 3.1.0 released

2023-03-15 Thread Yunze Xu
The Apache Pulsar team is proud to announce Apache Pulsar Client Python version 3.1.0. Pulsar is a highly scalable, low latency messaging platform running on commodity hardware. It provides simple pub-sub semantics over topics, guaranteed at-least-once delivery of messages, automatic cursor manage

Re: [VOTE] PIP-253 Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-20 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Tue, Mar 14, 2023 at 4:52 PM Asaf Mesika wrote: > > +1 (non binding) > > On Fri, Mar 10, 2023 at 11:36 PM Enrico Olivelli > wrote: > > > +1 (binding) > > > > Enrico > > > > Il Ven 10 Mar 2023, 21:36 Michael Marshall ha > > scritto: > > > > > +1 (binding) > > > > >

Re: [VOTE] PIP-259: Make the config httpMaxRequestHeaderSize of the pulsar web server to configurable

2023-03-21 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Tue, Mar 21, 2023 at 2:59 PM 丛搏 wrote: > > +1 (binding) > > Thanks, > Bo > > Yubiao Feng 于2023年3月20日周一 17:11写道: > > > > Hi Pulsar Community > > > > This thread is to start the vote for PIP 259. > > > > Discussion: https://lists.apache.org/thread/f11cld5cbc8sodhgvs5

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-21 Thread Yunze Xu
First, I agree with Yubiao that we can avoid calling the `isDuplicate` method once this option is enabled. Then, I'm wondering in which case would users want to disable this option? What's the disadvantage to disable the option? I think we can just record the latest position (ledger id, entry id,

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-21 Thread Yunze Xu
I just missed the point that the reset cursor operations do not work for the consumer. IIUC, the seek operation does not work as well. Then I think the option is not user-friendly as the PIP says: > It needs to be enabled with a complete understanding of this configuration. If users want, they c

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-24 Thread Yunze Xu
> At least it will simplify the process of using cumulative ack with the > transaction. So the transaction use cases assume the cursor will never be reset by other applications? We cannot ignore the impact brought by this proposal that resetting the cursor could have an unexpected effect. If the

Re: Unstable codecov action

2023-03-24 Thread Yunze Xu
The codecov is really annoying to me and never helps me during the coding or reviewing process. Just a complaint from me. I'm also curious how many developers benefit from it. Thanks, Yunze On Tue, Mar 21, 2023 at 6:50 PM tison wrote: > > For example > https://github.com/apache/pulsar/actions/r

Re: [VOTE] PIP-254: Support configuring client version with a description suffix

2023-03-24 Thread Yunze Xu
Bump. Please take a look and vote for this proposal. Thanks, Yunze On Mon, Mar 20, 2023 at 3:13 PM Zike Yang wrote: > > +1 (non-binding) > > Thanks, > Zike Yang > > On Wed, Mar 15, 2023 at 3:54 PM Yunze Xu wrote: > > > > Hi all, > > > >

Re: [DISCUSS] PIP-258: Deprecation of the consumer subscribeTopicMode configuration

2023-03-24 Thread Yunze Xu
I think we don't need to do such changes. Instead, we should fix the documentation of `ConsumerBuilder#topicsPattern`. From the implementation here [1], the prefix before "://" in the topic pattern should be ignored. [1] https://github.com/apache/pulsar/blob/f1f8dab972b098be69ad35ab3d307f19284c4e

Re: [VOTE] Pulsar Release 2.11.1 Candidate-1

2023-03-26 Thread Yunze Xu
+1 (binding) - Checked the signature - Build from source (Java 17, Ubuntu 20.04 WSL2) - Start standalone with both RocksDB and ZooKeeper - Run basic end-to-end Pulsar tests and topic operations via pulsar-shell - Run basic end-to-end Kafka tests with KoP 2.11.0.4 Thanks, Yunze On Wed, Mar 22, 20

[Python] Should we make the schema default compatible with Java client?

2023-03-29 Thread Yunze Xu
Hi all, Recently I found the default generated schema definition in the Python client is different from the Java client, which leads to some unexpected behavior. For example, given the following class definition in Python: ```python class Data(Record): i = Integer() ``` The type of `i` fiel

Re: [ANNOUNCE] Qiang Zhao as new PMC member in Apache Pulsar

2023-03-29 Thread Yunze Xu
Congratulations! Thanks, Yunze On Wed, Mar 29, 2023 at 3:52 PM Lari Hotari wrote: > > Congrats, Qiang Zhao! Well deserved! > > -Lari > > On 2023/03/29 03:22:43 guo jiwei wrote: > > Dear Community, > > > > We are thrilled to announce that Qiang Zhao > > (https://github.com/mattisonchao) has been

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-29 Thread Yunze Xu
It's better to describe how it could bring the benefit to transaction use cases, since now it's designed to be a configuration related to the transaction. I've thought about some cases: 1. A consumer received N messages, then the cursor was reset to the earliest. 2. A consumer received N messages

Re: [Python] Should we make the schema default compatible with Java client?

2023-03-29 Thread Yunze Xu
lds` true by default and `_required` true for all types other than `String` by default. Thanks, Yunze On Wed, Mar 29, 2023 at 4:00 PM Yunze Xu wrote: > > Hi all, > > Recently I found the default generated schema definition in the Python > client is different from the Java clien

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-29 Thread Yunze Xu
Thanks for your explanation. It now makes sense to me. So I suggest: 1. Document this use case in the PIP 2. Document the result that resetting cursor might lead to in the API doc of this configuration Thanks, Yunze On Wed, Mar 29, 2023 at 9:11 PM 丛搏 wrote: > > Hi, Yunze: > > > It's better to de

Re: [VOTE] Pulsar Client Go Release 0.10.0 Candidate 1

2023-03-30 Thread Yunze Xu
+1 (binding) - Checked the signature and checksum - Ran basic end-to-end tests - Ran pulsar-perf with batch index ACK enabled Thanks, Yunze On Thu, Mar 30, 2023 at 3:17 PM Nozomi Kurihara wrote: > > +1 (binding) > > - verified checksum and signature > - ran producer and consumer in examples > >

Re: [Python] Should we make the schema default compatible with Java client?

2023-03-30 Thread Yunze Xu
nk it is > good to be consistent with other clients. > > Thanks, > Bo > > Eric Hare 于2023年3月29日周三 22:42写道: > > > > +1 - i think keeping the `_sorted_fields` and `_required` defaults > > consistent between the clients is the way to go. > > > > >

Re: [Python] Should we make the schema default compatible with Java client?

2023-03-30 Thread Yunze Xu
ting is enabled by default, > > > is the sorting rule the same as java or other clients? > > > > > > Putting aside the above two problems, I think it is > > > good to be consistent with other clients. > > > > > > Thanks, > > > Bo > > > > >

Re: [DISCUSS] We must change the way we review PIPs

2023-03-30 Thread Yunze Xu
+1 to me. Once the discussion thread of a PIP became too long, it would be hard to continue the discussion. Thanks, Yunze On Fri, Mar 31, 2023 at 9:13 AM PengHui Li wrote: > > +1 for creating a folder named "pip" in the main pulsar repo > So far, it is good enough to solve the problems we've had

Re: [DISCUSS] Dropping the StreamingDispatcher

2023-04-04 Thread Yunze Xu
If the flaky tests were the only concern, I think we can just disable these tests. Whatever, this config in `ServiceConfiguration` has existed for a long time, though when it was introduced, the PIP rule was not clear so there is no PIP for it. Thanks, Yunze On Tue, Apr 4, 2023 at 3:09 PM Gavin g

Re: [VOTE] PIP-254: Support configuring client version with a description suffix

2023-04-04 Thread Yunze Xu
nrico Olivelli wrote: > > > > +1 (binding) > > > > Enrico > > > > Il giorno mer 29 mar 2023 alle ore 09:16 丛搏 ha scritto: > > > > > > +1 (binding) > > > > > > Thanks, > > > Bo > > > > > > Lin Lin 于2023年3月2

Re: [DISCUSS] Dropping the StreamingDispatcher

2023-04-07 Thread Yunze Xu
t; > If the code isn't being used or maintained, I support removing it. The > > > code will be available in the git history in case someone decides to > > > resurrect it. > > > > > > Thanks, > > > Michael > > > > > > On Wed, A

[Discuss] Add a phase to process pending PRs before code freeze

2023-04-09 Thread Yunze Xu
Hi community, I see the code freeze of Pulsar 3.0.0 is coming tomorrow. But I found the release process still lacks a key step that pending PRs should be taken carefully of instead of simply delaying them to the next release. The following cases were very often seen: 1. A PR has opened for some d

Re: [Discuss] Add a phase to process pending PRs before code freeze

2023-04-09 Thread Yunze Xu
nge. [1] https://lists.apache.org/thread/ky2bkzlz93njx3ntnvkpd0l77qzzgcmv Thanks, Yunze On Mon, Apr 10, 2023 at 10:56 AM Yunze Xu wrote: > > Hi community, > > I see the code freeze of Pulsar 3.0.0 is coming tomorrow. But I found > the release process still lacks a key step that pending P

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-10 Thread Yunze Xu
+1 (binding) * Checked signatures and checksums * Build from source and run e2e examples (Ubuntu 20.04 and Node.js v16.19.0) * Install from NPM and run e2e examples with OAuth2 authentication through StreamNative cloud (Ubuntu 20.04 and Node.js v16.19.0, node:19-bullseye container) Thanks, Yunze

Re: [DISCUSS] Sorting out pulsar's internal thread pools

2023-04-17 Thread Yunze Xu
I agree with this improvement. I had the same idea before but it would take too much time so I didn't continue at that time. Thanks, Yunze On Tue, Apr 18, 2023 at 10:08 AM wrote: > > > Hello, folks. > > I would like to start discussing the pulsar internal thread pool sorting out. > > How did I g

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-04-17 Thread Yunze Xu
Basically I think describing how much work the reviewer did to give his +1 is good. Just like the vote for a release, each +1 follows with the verifications he did, e.g. here [1] is a vote for Pulsar 2.11.1 candidate 1: > • Built from the source package (maven 3.8.6 OpenJDK 17.0) > • Ran binary pa

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 4

2023-04-18 Thread Yunze Xu
+1 (binding) * Checked signatures and checksums * Build from source and run e2e examples (Ubuntu 20.04 and Node.js v16.19.0) * Install from NPM and run e2e examples with OAuth2 authentication through StreamNative cloud, including the `node:19-bullseye` and `node:19-alpine3.16` containers Thanks,

Re: [VOTE] Pulsar Release 2.9.5 Candidate 3

2023-04-18 Thread Yunze Xu
+1 (binding) * Verified checksum and signatures * Build from source with JDK 8 on Ubuntu 20.04 * Start the standalone with KoP 2.9.x (build from source) with JDK 8, test producing and consuming among Pulsar clients (2.11.0) and Kafka clients (2.8.2) Thanks, Yunze On Wed, Apr 19, 2023 at 11:17 AM

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-04-18 Thread Yunze Xu
ay be super bad > suggestions and hopefully some will be good :) > This specific one - I validated with the PMC members in the weekly zoom > meeting roughly 3 weeks ago, and got +1 across the board (we had 5 people). > I did it since I felt it was a touchy subject. > > Thanks, > &

Re: [VERIFY] Pulsar Release 3.0.0 Candidate 2

2023-04-19 Thread Yunze Xu
I have opened a PR to move the new interface to the pulsar-common module. https://github.com/apache/pulsar/pull/20139 Thanks, Yunze On Wed, Apr 19, 2023 at 8:44 PM PengHui Li wrote: > > There is a discussion about the new API introduced in 3.0.0 > but it should not be a public API. > > Details t

[DISCUSS] Separate the Python Functions from the installation of the Python client

2023-04-19 Thread Yunze Xu
Hi all, The Python client has been separated since PIP-209 [1] and now the Python client is maintained in a separated repository [2]. However, the Python Function is still maintained in the main repo [3]. Currently, we can install the Python client with the following ways: 1. pip install pulsar-c

Re: [DISCUSS] Separate the Python Functions from the installation of the Python client

2023-04-19 Thread Yunze Xu
ical versions, what can we do? > > > > On 2023/04/19 15:23:49 Yunze Xu wrote: > > Hi all, > > > > The Python client has been separated since PIP-209 [1] and now the > > Python client is maintained in a separated repository [2]. However, > > the Python Function

Re: [DISCUSS] Separate the Python Functions from the installation of the Python client

2023-04-19 Thread Yunze Xu
age's Dockerfile should be updated to install the > required python dependencies so it can run in k8s runtime mode > > Regards, > Pengcheng Jiang > > > Yunze Xu 于2023年4月20日周四 10:46写道: > > > Hi Neng, > > > > I think currently a simp

[DISCUSS] Release Pulsar C++ Client 3.2.0

2023-04-20 Thread Yunze Xu
Hi all, I would like to propose releasing the Pulsar C++ Client 3.2.0. It has been over 2 months since the last release (3.1.2). There have been many new features and bug fixes since then. It's time to release a new version. Please let me know if you have any PRs that need to be included in 3.2.

Re: [VERIFY] Pulsar Release 3.0.0 Candidate 2

2023-04-21 Thread Yunze Xu
Hi Zike, Before the next candidate, I'd like to include https://github.com/apache/pulsar/pull/20163 to avoid a breaking change. Thanks, Yunze On Wed, Apr 19, 2023 at 10:40 PM Yunze Xu wrote: > > I have opened a PR to move the new interface to the pulsar-common > module. http

Re: Re:Re: [DISCUSS] PIP-255: Assign topic partitions to bundle by round robin

2023-04-24 Thread Yunze Xu
This proposal is easier to understand than before. Overall LGTM. But I think these `onBundleXXX` methods could be default so that we can implement it with a simple lambda. Thanks, Yunze On Wed, Apr 19, 2023 at 10:22 AM Lin Lin wrote: > > We make this configuration item to be a dynamic configura

Re: [DISCUSS] Release Pulsar C++ Client 3.2.0

2023-04-25 Thread Yunze Xu
t; > Thanks, > > Zike Yang > > > > On Fri, Apr 21, 2023 at 12:42 PM Yunze Xu > > wrote: > > > > > > Hi all, > > > > > > I would like to propose releasing the Pulsar C++ Client 3.2.0. > > > > > > It has been over 2 months

<    1   2   3   4   5   6   7   >