> I have a point of concern, but for a small HTTP interaction, it's probably > too many layers of encapsulation.
It makes sense to me. Then I agree to go head for an independent API implementation. Thanks, Yunze On Fri, Feb 17, 2023 at 11:32 AM ZhangJian He <shoot...@gmail.com> wrote: > > > It's better to reuse existing code rather than reinventing the wheel. > No objection. > > I didn't mean using pulsarctl directly. We only need to wrap the > provided API from pulsarctl and provide our own public API in > pulsar-client-go. > It works, I have a point of concern, but for a small HTTP interaction, it's > probably too many layers of encapsulation. Let's see what other people say > > Thanks > ZhangJian He > > > On Fri, 17 Feb 2023 at 11:06, Yunze Xu <y...@streamnative.io.invalid> wrote: > > > It's better to reuse existing code rather than reinventing the wheel. > > I didn't mean using pulsarctl directly. We only need to wrap the > > provided API from pulsarctl and provide our own public API in > > pulsar-client-go. > > > > Thanks, > > Yunze > > > > On Fri, Feb 17, 2023 at 10:48 AM ZhangJian He <shoot...@gmail.com> wrote: > > > > > > > It does not make sense to me. Why cannot add it as a dependency? > > > > > > I am not saying it can't. Of course, adding pulsarctl as a dependency is > > > possible. I also recommended this repository in > > > https://github.com/apache/pulsar-client-go/issues/842. I think > > > incorporating the functionality of the HTTP admin into pulsar-client-go > > > might be even better. Developers can use pulsar-client-go to perform > > > administrative tasks without having to switch to a separate tool like > > > pulsarctl. > > > > > > Thanks > > > ZhangJian He > > > > > > > > > On Fri, 17 Feb 2023 at 10:39, Yunze Xu <y...@streamnative.io.invalid> > > wrote: > > > > > > > Just saw the mail after the PR. > > > > > > > > > Pulsarctl is not an apache official repository net > > > > > > > > It does not make sense to me. Why cannot add it as a dependency? > > > > > > > > Thanks, > > > > Yunze > > > > > > > > On Fri, Feb 17, 2023 at 10:16 AM ZhangJian He <shoot...@gmail.com> > > wrote: > > > > > > > > > > Pulsarctl is not an apache official repository net, and given the > > > > > popularity of operators and Go-based dev-ops-tools, would it be > > possible > > > > to > > > > > consider merging some of the functionalities of pulsarctl into > > > > > pulsar-client-go > > > > > > > > > > Thanks > > > > > ZhangJian He > > > > > > > > > > > > > > > On Fri, 17 Feb 2023 at 10:00, PengHui Li <codelipeng...@gmail.com> > > > > wrote: > > > > > > > > > > > The pulsarctl is an admin CLI tool for Pulsar, written in go. > > > > > > Does it match your requirement? > > > > > > > > > > > > Penghui > > > > > > > > > > > > > On Feb 17, 2023, at 09:47, ZhangJian He <shoot...@gmail.com> > > wrote: > > > > > > > > > > > > > > I would like to express that the current Pulsar client for Go > > > > > > > (pulsar-client-go) is missing the pulsar Admin API. As such, I > > would > > > > like > > > > > > > to propose that we work towards adding this feature to > > > > pulsar-client-go. > > > > > > > > > > > > > > I believe that this new feature would be a valuable addition to > > > > > > > pulsar-client-go, and I am excited to work to make it happen. > > > > > > > > > > > > > > I have submitted a PR: > > > > > > https://github.com/apache/pulsar-client-go/pull/959 > > > > > > > The full api is not currently available, but we are adding. > > > > > > > > > > > > > > Below is a simple example about how to use > > > > > > > > > > > > > > ## usage > > > > > > > > > > > > > > ```go > > > > > > > package main > > > > > > > > > > > > > > import ( > > > > > > > "fmt" > > > > > > > "github.com/apache/pulsar-client-go/padmin" > > > > > > > ) > > > > > > > > > > > > > > func main() { > > > > > > > admin, err := padmin.NewDefaultPulsarAdmin() > > > > > > > if err != nil { > > > > > > > panic(err) > > > > > > > } > > > > > > > // get namespace topic list > > > > > > > topics, err := > > admin.PersistentTopics.ListNamespaceTopics("tenant", > > > > > > > "namespace") > > > > > > > if err != nil { > > > > > > > panic(err) > > > > > > > } > > > > > > > fmt.Println(topics) > > > > > > > } > > > > > > > ``` > > > > > > > > > > > > > > Thanks > > > > > > > ZhangJian He > > > > > > > > > > > > > > > > > >
