+1. I support cherry-picking it to release branches even if new default methods are added. It won't affect any existing use because the interface is customized by the 3rd party provider. No compatibility issue will happen.
Thanks, Yunze On Tue, Mar 14, 2023 at 4:27 PM Enrico Olivelli <eolive...@gmail.com> wrote: > > Il giorno mar 14 mar 2023 alle ore 06:47 Gavin gao > <gaozhang...@gmail.com> ha scritto: > > > > The issue is: https://github.com/apache/pulsar/pull/19727 > > > > This issue tries to address the index generator rolled back problem when > > entries add failed. > > > > A new default method `afterFailedAddEntry` is added to interface > > ManagedLedgerInterceptor. > > > > And this change should be also cherry-picked to release branches. > > > > We are here to discuss whether it's proper to make this change or not. > > I support this change. > The impact is minimal and ManagedLedgerInterceptor is basically a > limited private customization point. > The implementations are usually dependent on the Pulsar version > > +1 > > Enrico
