I noticed the `gradlew` and `gradlew.bat` files are missing. Is it expected?
Thanks,
Yunze
On Thu, Jun 13, 2024 at 10:37 PM Lari Hotari wrote:
>
> +1 (binding)
>
> Validated source artifacts
> - checked sha512 checksum
> - checked signature
>
> Validated binaries
> - ran sample app
>
> -Lari
>
>
+1 (binding)
Thanks,
Yunze
On Fri, Jun 14, 2024 at 8:30 PM guo jiwei wrote:
>
> +1 (binding)
>
>
> Regards
> Jiwei Guo (Tboy)
>
>
> On Fri, Jun 14, 2024 at 11:04 AM Yubiao Feng
> wrote:
>
> > +1 (binding)
> >
> > Thanks
> > Yubiao Feng
> >
> > On Fri, Jun 14, 2024 at 10:09 AM thetumbled wrote:
ar-client-reactive-0.5.6-candidate-1-source: gradlew.bat
>
> Thanks,
> Chris
>
> On 2024/06/15 12:57:32 Yunze Xu wrote:
> > I noticed the `gradlew` and `gradlew.bat` files are missing. Is it expected?
> >
> > Thanks,
> > Yunze
> >
> > On Thu, Jun 13, 2024 a
+1 (binding)
Thanks,
Yunze
On Thu, Jun 27, 2024 at 8:39 AM Kai Wang wrote:
>
> +1 (non-binding)
>
> Thanks
> Kai
>
> On 2024/06/26 03:00:02 thetumbled wrote:
> > Hi, Pulsar Community.
> > I would like to start the voting thread for PIP-364: Introduce a new load
> > balance algorithm AvgShedde
Hi all,
I'm doubting the value of the widely used Netty Recycler in Pulsar.
When I checked the recent commits today, I found even a pair of
Boolean and Integer is wrapped as a recyclable object. See
TopicExistsInfo in https://github.com/apache/pulsar/pull/22838. It's
really a mess, especially comp
+1 (binding)
- Verified checksum and signatures
- Built from source and ran examples on macOS with Node.js v20.4.0
- Install the npm and ran examples on Rocky Linux 8 with Node.js v16.6.0
Thanks,
Yunze
On Wed, Jul 3, 2024 at 10:01 AM Baodi Shi wrote:
>
> Hi everyone,
>
> This is the second rele
+1
Thanks,
Yunze
On Thu, Jul 18, 2024 at 4:59 PM Kai Wang wrote:
>
> +1
>
> Thanks,
> Kai
+1 (binding)
- Verified checksum and signatures
- Built from source with Golang 1.22 on macOS
Thanks,
Yunze
On Wed, Jul 17, 2024 at 12:21 PM Baodi Shi wrote:
>
> +1(binding)
>
> - verified the shasum and asc.
> - `make build` and `make test` fine on go1.20.13
>
> Thanks,
> Baodi Shi
>
> Zixuan
+1 (binding)
Regarding the questions from Heesung, the customized load manager
could implement its own lookup logic when the `LookupOptions` has a
specific property.
For example, given a topic "my-topic" and two brokers with
"lookup.broker" as "A" and "B".
- The client with lookup property "broke
+1 (binding)
Thanks,
Yunze
On Thu, Aug 1, 2024 at 9:39 PM Jie crossover wrote:
>
> +1 nonbinding
> --
> Best Regards!
> crossoverJie
>
>
> Tao Jiuming 于2024年8月1日周四 19:38写道:
>
> > +1 nonbinding
> >
> > Zike Yang 于2024年8月1日 周四19:08写道:
> >
> > > Hi, everyone,
> > >
> > > I want to start a vote on
TL;DR, such a repository is not necessary to be contributed to Apache.
Actually, only the "Collect user best practices" point makes sense to
me. The reason to have so many pluggables is exactly to avoid the core
repo being not so bloated.
Yeah, OTel is a good example. But IMHO, Pulsar is far less
-1 (binding)
See reasons here:
https://lists.apache.org/thread/0mold5ko1z3t8pjwb46bt07o2lcqh0oy
Thanks,
Yunze
On Mon, Aug 5, 2024 at 9:27 AM lushiji(apache) wrote:
>
> +1 (non-binding) , we will try our best to make it happen
>
> On Sat, Aug 3, 2024 at 5:25 PM xiangying meng wrote:
>
> > Hi a
I just thought again about the "best practice" part. Why not
contribute it to the Apache official website
(https://github.com/apache/pulsar-site)?
Thanks,
Yunze
On Mon, Aug 5, 2024 at 8:46 PM Yunze Xu wrote:
>
> TL;DR, such a repository is not necessary to be contributed to Apac
lifetime, this repo still does not
make sense to me so it's still -1.
Thanks,
Yunze
On Mon, Aug 5, 2024 at 9:05 PM Yunze Xu wrote:
>
> I just thought again about the "best practice" part. Why not
> contribute it to the Apache official website
> (https://github.com/apac
+1 (binding)
- Verified checksum and signatures
- Built from source with Go 1.22.1 darwin/arm64
- Ran the perf tool
Thanks,
Yunze
On Fri, Aug 2, 2024 at 5:59 PM Zike Yang wrote:
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the version
> 0.13.1, as follows:
> [ ] +1,
+1 (binding)
- Verified checksum and signatures
- Built from source with dotnet 8.0.100 on macOS
- Validated the NuGet package 3.3.2-rc.1
Thanks,
Yunze
On Tue, Aug 6, 2024 at 4:28 PM Daniel Blankensteiner wrote:
>
> +1 (binding)
>
> - Ran tests
>
> Using dotnet sdk 8.0.303 (dotnet --version) on
+1 (binding)
BTW, I don't think such a proposal needs a formal PIP. It only affects
the APIs in the `impl` package that is not guaranteed to be stable.
If you're going to grant the stability guarantee on the `SendCallback`
interface, please add the corresponding `InterfaceStability`
annotation in
, 2024 at 6:52 PM Baodi Shi wrote:
>
> +1(binding)
>
> - Verified checksum and signatures
> - Built from source with Go 1.22.1 darwin/arm64
> - Ran the make test passed
>
> Thanks,
> Baodi Shi
>
> Yunze Xu 于2024年8月7日周三 15:05写道:
> >
> > +1 (binding)
> >
Just like Lari mentioned, it's added in PIP-335. Actually I was +0 so
I didn't vote. AFAIK, StreamNative keeps evolving the Oxia so having
it as a built-in metadata store for now is not bad. I didn't have much
context about why it's contributed to the core Pulsar repo. I guess
the metadata store is
mits/stable/
Thanks,
Yunze
On Tue, Aug 13, 2024 at 12:34 AM Dave Fisher wrote:
>
> Hi Yunze,
>
> A few of your points are of concern and to me could be good arguments for
> this extra code repository.
>
> On 2024/08/05 13:25:24 Yunze Xu wrote:
> > Let's ignore the
ed by committers. What I have concern
is that each commit requires approvals from Pulsar committers and it's
less convenient than maintaining it by individuals. For the 2nd
solution, we must need an official review process on it, not just by
the PIP vote.
Thanks,
Yunze
On Tue, Aug 13, 2024 at 5:02 P
Well, let me change my binding -1 to binding +1.
Thanks,
Yunze
On Mon, Aug 19, 2024 at 3:22 PM steven lu wrote:
>
> In the past period of time, we have initiated several discussions with
> other companies and Pulsar community developers, and improved the project
> as follows:
>
> As you can see,
Hi Baodi,
Could you help include this fix
https://github.com/apache/pulsar-client-cpp/pull/443?
Thanks,
Yunze
On Wed, Aug 28, 2024 at 8:40 PM Baodi Shi wrote:
>
> +1(binding)
>
> - Check source sums
> - Test by node.js client ci:
> https://github.com/shibd/pulsar-client-node/actions/runs/105953
+1 (binding)
- Verified checksum and signatures
- Built from source on macOS with vcpkg and ran examples
- Verified arm64 RPM packages that
https://github.com/apache/pulsar-client-cpp/pull/443 works
- Verified the Python client with this candidate:
https://github.com/apache/pulsar-client-python/pu
Hi all,
I drafted a proposal to make topic policies service pluggable.
https://github.com/apache/pulsar/pull/23248 Feel free to leave your
comments or concerns.
Thanks,
Yunze
+1 (binding)
- Verified checksum and signatures
- Built from source on macOS m1 and ran examples
Thanks,
Yunze
On Fri, Sep 6, 2024 at 4:40 PM Baodi Shi wrote:
>
> +1(binding)
>
> - verify source checksum
> - verify producer, consumer, batch_receve on MacOS arm64
>
> Thanks,
> Baodi Shi
>
> Baod
+1 (binding)
Thanks,
Yunze
On Mon, Sep 16, 2024 at 3:06 AM Lari Hotari wrote:
>
> +1 (binding)
>
> -Lari
>
> On Sun, 15 Sept 2024 at 21:34, Heesung Sohn wrote:
> >
> > Hi all,
> >
> > I would like to start a vote on PIP-378 to add
> > ServiceUnitStateTableView abstraction and make it pluggable.
Hi Enrico,
> There is no way to confirm that the MessageId really belongs to the
> partition and you can pass whatever you want
True. But still, the existing `acknowledgeCumulative` API is not
convenient to use. The original purpose for this new overload is
allowing users to maintain each partiti
;> http://www.shivjijha.com/
>>> +91 8884075512
>>>
>>>
>>> On Fri, 9 Sept 2022 at 11:44, Shivji Kumar Jha
>> wrote:
>>>
>>>> Tarun is a colleague at Nutanix who is very eager to do his first patch
>>> in
>>&g
es,-main -T 1C clean install -DskipTests -Dspotbugs.skip=true
>>
>> Running the check on your machine can be especially helpful when CI is
>> backed up or when you want to apply many commits.
>>
>> Thanks,
>> Michael
>>
>> On Wed, Sep 7, 2022 at 6:35
Hi Lari,
This proposal LGTM. But I have some questions about the details.
In short, IIUC, each contributor should:
1. Follow https://pulsar.apache.org/contributing/#ci-testing-in-your-fork to
2. Paste the link of the same PR in contributor’s fork to the PR in Apache repo
Then a committer should
all tests, right?
>
> Exactly. One small detail: It should be the PR author's responsibility to
> follow up and request for a review and an approval after the tests pass.
> If there are later changes in the PR after the "ready-to-test" label has been
> added, we coul
PRs in
> apache/pulsar and your own fork. When the branch gets updated, the
> builds in the forked repository would run. That's why I think it's
> better to keep on iterating on the PR until it's really ready for
> final
> testing in apache/pulsar repository.
>
> -
The Apache Pulsar team is proud to announce Apache Pulsar version 2.8.4.
Pulsar is a highly scalable, low latency messaging platform running on
commodity hardware. It provides simple pub-sub semantics over topics,
guaranteed at-least-once delivery of messages, automatic cursor management for
subsc
Sorry I should have sent the email in my Apache mail. I will send it again.
Thanks,
Yunze
> On Sep 19, 2022, at 16:41, Yunze Xu wrote:
>
> The Apache Pulsar team is proud to announce Apache Pulsar version 2.8.4.
>
> Pulsar is a highly scalable, low latency messaging plat
The Apache Pulsar team is proud to announce Apache Pulsar version 2.8.4.
Pulsar is a highly scalable, low latency messaging platform running on
commodity hardware. It provides simple pub-sub semantics over topics,
guaranteed at-least-once delivery of messages, automatic cursor management for
subsc
LGTM. I also listed the related files outside the pulsar-client-cpp
directory recently:
- pulsar-common/src/main/proto/PulsarApi.proto: the Pulsar binary
proto file
- src/gen-pulsar-version-macro.py: generate the internal version info
- pulsar-client/src/test/proto/*.proto: test the protobuf nat
already write:
>
>> git filter-repo --subdirectory-filter pulsar-client-cpp
>
> So you will retain the git history.
>
> Best,
> tison.
>
>
> Yunze Xu 于2022年9月20日周二 16:27写道:
>
>> LGTM. I also listed the related files outside the pulsar-client-cpp
&g
spective, the image is mainly used as a server, perhaps we can
> remove these clients from bundling.
>
> Best,
> tison.
>
>
> Yunze Xu 于2022年9月20日周二 16:50写道:
>
>> Hi Tison,
>>
>> Sorry I just missed that. Thanks for your reminder.
>>
>>
+1 (non-binding)
Thanks,
Yunze
> On Sep 27, 2022, at 11:11, Zixuan Liu wrote:
>
> +1(non-binding)
>
> Thanks,
> Zixuan
>
> Haiting Jiang 于2022年9月27日周二 09:56写道:
>
>> +1 (non)
>>
>> Haiting
>>
>> On Tue, Sep 27, 2022 at 9:30 AM Zike Yang wrote:
>>>
>>> +1 (non-binding)
>>>
>>>
>>> Zi
The release note of 2.8.4 seems to be lost after a commit in pulsar-site repo:
https://github.com/apache/pulsar-site/pull/227
I will ping the author to fix the missed release note.
Thanks,
Yunze
> On Oct 2, 2022, at 21:56, Asaf Mesika wrote:
>
> link
hanks,
> Haiting
>
> On Tue, Oct 4, 2022 at 8:50 PM Yunze Xu wrote:
>>
>> The release note of 2.8.4 seems to be lost after a commit in pulsar-site
>> repo:
>>
>> https://github.com/apache/pulsar-site/pull/227
>>
>> I will ping the author to fi
Hi Asaf,
I opened a PR here to add back the 2.8.4 release notes:
https://github.com/apache/pulsar-site/pull/242
Thanks,
Yunze
> On Oct 2, 2022, at 21:56, Asaf Mesika wrote:
>
> I don't see the release notes in the provided link for 2.8.4
>
> On Mon, Sep 19, 2022
TL; DR, we should add the Markdown documents about the pulsar-site repo
in GitHub. DON'T USE GOOGLEDOCS EVERYWHERE!
Currently Pulsar's website is maintained in
https://github.com/apache/pulsar-site. However, I cannot find any
document of this document repo.
As a contributor, if I want to co
+1
Thanks,
Yunze
> On Oct 7, 2022, at 02:07, Matteo Merli wrote:
>
> We have moved the C++ client to its own separate repo
> (https://github.com/apache/pulsar-client-cpp) as part of PIP-209.
>
> There are several new features and fixes in the main branch that it
> would be good to get relea
che/pulsar-site/pull/242#issuecomment-1272700632
> [3] https://github.com/apache/pulsar/tree/master/wiki/release
> [4] https://pulsar.apache.org/contributing/
>
> Yu
>
> On Tue, Oct 4, 2022 at 10:21 PM Yunze Xu
> wrote:
>
> > TL; DR, we should add the Ma
Hi, Michael,
The failure is caused by the wrong format, here is the fix:
https://github.com/apache/pulsar-client-cpp/pull/45
We should include this PR and begin another vote process.
However, IMO, these `docker-*.sh` should be removed in future. `docker-build.sh`
was original written for tests
Congrats!
Thanks,
Yunze
On Tue, Oct 18, 2022 at 4:06 PM Hang Chen wrote:
>
> Hi all,
>
> The Apache Pulsar Project Management Committee (PMC) has invited Haiting Jiang
> (https://github.com/Jason918) as a member of the PMC and we are
> pleased to announce that he has accepted.
>
> He is very act
+1 for me.
Thanks,
Yunze
On Fri, Oct 21, 2022 at 9:45 AM tison wrote:
>
> Hi,
>
> Here is the pull request: https://github.com/apache/pulsar/pull/17508
>
> Motivation:
>
> When reformatting Java files, JAVADOC_STYLE cause the license header be
> treated as doc comments and it will be affected fr
Hi Kai,
Yeah, it's an issue that currently the scripts all use `git` command
to determine the root directory.
I'm not sure if it could be a blocker.
Thanks,
Yunze
On Mon, Oct 24, 2022 at 2:36 PM Kai Wang wrote:
>
> +1 (non-binding)
>
> Environment: M1 macOS 12.6 and Ubuntu 20.04 x86_64
>
> * ve
https://github.com/BewareMyPower/pulsar-client-cpp-demo
Thanks,
Yunze
On Mon, Oct 24, 2022 at 5:20 PM Yunze Xu wrote:
>
> Hi Kai,
>
> Yeah, it's an issue that currently the scripts all use `git` command
> to determine the root directory.
> I'm not sure if it could be a blocke
+1
Thanks,
Yunze
On Wed, Oct 26, 2022 at 12:06 PM Qiang Huang wrote:
>
> +1
>
> Enrico Olivelli 于2022年10月25日周二 22:32写道:
>
> > +1
> >
> > awesome work
> >
> > Enrico
> >
> > Il giorno mar 25 ott 2022 alle ore 16:28 PengHui Li
> > ha scritto:
> > >
> > > +1
> > >
> > > Penghui
> > >
> > > On Tue
+1 (non-binding)
Thanks,
Yunze
On Thu, Oct 27, 2022 at 9:14 PM 丛搏 wrote:
>
> Hi, pulsar community:
>
> I start a PIP about `User-friendly acknowledgeCumulative API on a
> partitioned topic or multi-topics`
>
> discuss thread:
> https://lists.apache.org/thread/30rwksz4gmvgspkgcfsk708sgb1n7vbo
>
Hang
> >
> > PengHui Li 于2022年10月25日周二 14:34写道:
> > >
> > > +1 (binding)
> > >
> > > - Verified the signatures
> > > - Build from the source (osx 12.6)
> > >
> > > Thanks,
> > > Penghui
> > >
> > > On M
Hi Michael,
Thanks for your explanation. I think now we can mark #16064 [1] as the
fix to the CVE.
In addition, the Apache Node.js client [2] is also based on the C++
client. I'm not familiar
with how to install the Node.js client at the moment. It looks like it
requires a pre-installation
of the
Hi all,
Currently we have the following 5 implementations of MessageId:
- MessageIdImpl: (ledger id, entry id, partition index)
- BatchMessageIdImpl: adds (batch index, batch size, acker), where
acker is a wrapper of a BitSet.
- ChunkMessageIdImpl: adds another MessageIdImpl that represen
Hi Enrico,
> We also need a way to represent this as a String or a byte[]
We already have the `toByteArray` method, right?
Thanks,
Yunze
On Tue, Nov 8, 2022 at 6:43 PM Enrico Olivelli wrote:
>
> Il giorno mar 8 nov 2022 alle ore 11:25 Yunze Xu
> ha scritto:
> >
> > H
I didn't look into these two methods at the moment. But I think it's possible to
retain only the `fromByteArray`.
Thanks,
Yunze
On Tue, Nov 8, 2022 at 7:02 PM Enrico Olivelli wrote:
>
> Il giorno mar 8 nov 2022 alle ore 11:52 Yunze Xu
> ha scritto:
> >
> > Hi E
ails, and an application should not be interpreting that at all.
> -j
>
>
> On Tue, Nov 8, 2022 at 3:43 AM Yunze Xu
> wrote:
>
> > I didn't look into these two methods at the moment. But I think it's
> > possible to
> > retain only the `fromByteArray`.
>
as already
> done the parsing and got the ledgerId and entryId from it.
>
>
> Thanks,
> Haiting
>
> On Tue, Nov 8, 2022 at 6:25 PM Yunze Xu wrote:
> >
> > Hi all,
> >
> > Currently we have the following 5 implementations of MessageId:
> >
> &
.
>
> A user shouldn't have to know what this means. That's the point.
>
> Pulsar itself changed the messageId multiple times as it added
> partitioning, batching and so on, and it might do so again. And bookkeeper
> could change its representation of ledgers, (for eg
t;a:b:-b-b", or "#xba4231!haxcy1826923f" or as a serialized binary
> > object or..whatever it may be.
> >
> > >>But it would be harder to know a tuple like "0:1:-1:-1" means.
> >
> > A user shouldn't have to know what this means
er).
> Pulsar is used for many large scale business usecaeses with a large number
> of users and it can create a nightmare for operators and users if we remove
> abstractions and start following the practice of exposing system internals
> to user applications.
>
> Thanks,
> Ra
Hi all,
>From the previous discussion [1], we reached a consensus that
MessageId should only be a comparable and serializable opaque object
(only in Java client though). However, the APIs that return or accept
a MessageId have some hidden requirements.
Let's introduce the 5 implementations first
Hi Bo,
It makes sense to me. I will write the demo this week.
Thanks,
Yunze
Hi Enrico,
It's okay for me to cut the current master as 2.11.0, but since many new PRs
were merged recently, I'm afraid some regressions might be introduced. I found
some flaky tests (like [1]) recently, not sure whether they are caused
by bugs. And
there is also a PR [2] that tries to solve a bu
Hi Matteo,
The download URL seems to be wrong. It's the Pulsar's download URL.
Thanks,
Yunze
On Thu, Nov 17, 2022 at 5:38 AM Matteo Merli wrote:
>
> The Apache Pulsar team is proud to announce Apache Pulsar Client C++
> version 3.0.0.
>
> Pulsar is a highly scalable, low-latency messaging platf
+1
Thanks,
Yunze
On Fri, Nov 18, 2022 at 3:12 AM Enrico Olivelli wrote:
>
> +1
>
> Enrico
>
> Il Gio 17 Nov 2022, 18:40 Matteo Merli ha scritto:
>
> > +1 Good suggestion
> >
> >
> > --
> > Matteo Merli
> >
> >
> > On Thu, Nov 17, 2022 at 7:32 AM tison wrote:
> > >
> > > Hi,
> > >
> > > When s
https://github.com/apache/pulsar/pull/18486 should be cherry-picked to
2.9.4 because it fixes a bug introduced in
https://github.com/apache/pulsar/pull/18454, which has already been
cherry-picked.
Thanks,
Yunze
On Thu, Nov 17, 2022 at 8:26 PM 丛搏 wrote:
>
> Hello, Pulsar community:
>
> The cherry
Hi all,
There is a breaking change for old version clients when using HTTP
lookup, see details in discussion here[1]. The affected clients I know
are:
- Java client 2.4.1 or earlier
- C++/Python clients 2.8.0 or earlier
In short, #10601 changed the behavior for querying the partition
metadata of
allowAutoTopicCreationForLegacyClients` is true, we should make
the behavior consistent.
Thanks,
Yunze
On Fri, Nov 18, 2022 at 12:02 PM Yunze Xu wrote:
>
> Hi all,
>
> There is a breaking change for old version clients when using HTTP
> lookup, see details in discussion here[1]. T
+1
Thanks,
Yunze
On Mon, Nov 21, 2022 at 5:32 PM Zike Yang wrote:
>
> Hi everyone,
>
> I would like to propose releasing the Pulsar Client C++ 3.1.0
>
> There are several new features and bug fixes in the main branch[0].
> And it’s time to release a new version.
> Please remind me if you have an
Hi all,
It has been about 2 months since the official Python client was moved
out of the main repo. I'm going to release the first Python client
release after that.
There are some efforts for the easy usage of the Python client, the
most exciting news is that now it supports Windows after #23 [1]
I pushed a PR: https://github.com/apache/pulsar/pull/18594
Thanks,
Yunze
On Fri, Nov 18, 2022 at 12:17 PM Yunze Xu wrote:
>
> I've investigated more on this issue. The `allowAutoTopicCreationType`
> config introduced in https://github.com/apache/pulsar/pull/4963 also
> brings a
Hi Pulsar community,
I've opened a PIP to discuss: https://github.com/apache/pulsar/issues/18616.
PTAL.
Thanks,
Yunze
Hi Nozomi,
I didn't look into the proposal at the moment. But I noticed the
producer name generation logic you mentioned here. At least in C++
clients, the producer name can only be set from the CommandProducer
response. i.e. PIP-79 is not catched up in C++ clients.
Thanks,
Yunze
On Fri, Nov 25,
+1. We should never introduce API changes in minor releases. Though
there were some exceptional cases where new APIs were added into C++
clients as a catch-up, which might be caused by the slowness of a
major release. But we should avoid it because the C++ clients are
separated now.
Thanks,
Yunze
+1
* verify checksum and signatures
* build from source (Ubuntu 20.04 x86_64)
* verify artifacts on Windows (`pulsar.dll` and `pulsarWithDeps.a` for
both x86 and x64 architectures)
* verify rpm, deb, apk packages in x86_64 architecture (`libpulsar.so`
and `libpulsar.a`)
In addition, I created a r
Hi Zike,
There are two PRs to fix the regression introduced from 3.0.0, I hope
they can be included:
https://github.com/apache/pulsar-client-cpp/pull/127
https://github.com/apache/pulsar-client-cpp/pull/125
Thanks,
Yunze
On Fri, Nov 25, 2022 at 5:19 PM Yunze Xu wrote:
>
> +1
>
&
Hi all,
I've opened a PIP to discuss: https://github.com/apache/pulsar/issues/18616.
The consumer's MessageId related APIs have some hidden requirements
and flakiness and some behaviors are not documented well. This
proposal will introduce a TopicMessageId interface that exposes a
method to get a
rn null when getting the topic from
> TopicMessageId for backward compatibility. The current
> TopicMessageIdImpl doesn't serialize the topic information.
>
>
> [0] https://github.com/apache/pulsar/issues/18616#issuecomment-1328609346
>
> Thanks,
> Zike Yang
>
> On Mo
Hi Zike,
Sorry for the late notification that there is a PR [1] that I want to
include in the 3.1.0 release. What do you think? It could be delayed
to the next release like 3.1.1 or 3.2.0. But users who want to use the
`acknowledge` API for a list of MessageId objects cannot configure
immediate ac
se it.
>
> In this way, users are clearly aware that TopicMessageId is used when using
> MultiTopicConsumer and MessageId is used when using
> SingleTopicConsumer.(Maybe it's not a good idea)
>
>
> Thanks,
> Baodi Shi
>
> > 2022年11月29日 15:57,Yunze Xu 写道:
>
+1 (non-binding)
* verify checksum and signatures
* build from source (Ubuntu 20.04 x86_64)
* verify artifacts on Windows (`pulsar.dll` and `pulsarWithDeps.a` for
both x86 and x64 architectures)
* verify rpm, deb, apk packages in x86_64 architecture (`libpulsar.so`
and `libpulsarwithdeps.a`)
All
Hi all,
I'm starting the vote for PIP-224: Introduce TopicMessageId for
consumer's MessageId related APIs:
https://github.com/apache/pulsar/issues/18616
Here is the discussion thread:
https://lists.apache.org/thread/jhqy65cdyxzmmxnfsjm8rv9pbk76noxy
The vote will be open for at least 3 days.
Tha
The change of a default value is acceptable in a major release. But
since it's changed back in the next 2.12 release, it could be a little
confusing. My perspective is to include this PR in the 2.11.0 release.
Thanks,
Yunze
On Wed, Dec 7, 2022 at 11:00 AM Zixuan Liu wrote:
>
> Pulsar 2.11 standa
I agree. It should have required the PIP.
I have another question. Is there any document to describe these
metrics? I think the metrics body should be documented well to avoid
breaking changes. Some external applications might parse the metrics
according to a specific structure.
Thanks,
Yunze
On
I'm afraid it's very hard to avoid these API changes. Take the
protocol handler as example, it could make use of nearly all modules
via the `PulsarService` object. The cost to keep the compatibility
might be high so that much legacy code could be left. For example,
each time a new argument is added
ybe some are missed.
>
> Thanks,
> Penghui
>
> On Wed, Dec 7, 2022 at 11:46 AM Yunze Xu
> wrote:
>
> > I agree. It should have required the PIP.
> >
> > I have another question. Is there any document to describe these
> > metrics? I think the metrics
arly aware that TopicMessageId is used when using
> MultiTopicConsumer and MessageId is used when using
> SingleTopicConsumer.(Maybe it's not a good idea)
>
>
> Thanks,
> Baodi Shi
>
> > 2022年11月29日 15:57,Yunze Xu 写道:
> >
> >> Is there a case where
Actually, from the user side, this comparison would never happen.
Users could never receive two MessageId objects with the same ledger
id, entry id while the batch index fields are different. This
comparison could only exist in the `pulsar-client` implementation.
If users touch the case, the Messa
cannot guarantee that everyone can
> find the problem of compareTo() in time when writing code or reviewing
> pr. The current implementation is Very anti-human.
>
> Thanks,
> bo
>
> Yunze Xu 于2022年12月8日周四 18:02写道:
> >
> > Actually, from the user side, this compariso
Hi Jiaqi,
Let's move to https://lists.apache.org/thread/mbrpjsgrgwrlkdpvkk738jxnlk7rf4qk
for the vote.
Thanks,
Yunze
On Fri, Dec 9, 2022 at 1:54 PM Jiaqi Shen wrote:
>
> This is make sense to me, +1
>
> Thanks,
> Jiaqi Shen
>
>
> Yunze Xu 于2022年12月7日周三 13:51
feature.
> > > > > > > > >> > I think it should be ok for a standalone.
> > > > > > > > >> >
> > > > > > > > >> > Penghui
> > > > > > > > >> >
> > > > > > > > >> > On Wed, Dec 7, 2022
41999
[2] https://github.com/apache/pulsar/pull/17864
Thanks,
Yunze
On Fri, Dec 9, 2022 at 3:08 PM Yunze Xu wrote:
>
> FYI, the latest branch-2.11 is broken for cpp tests [1]. But the root
> cause is the Pulsar standalone could no longer start
>
> ```
> org.apache.pulsar.
rokerClientAuthenticationPlugin and
> brokerClientAuthenticationParameters in the broker config file.
>
> Thanks,
> Zixuan
>
> Yunze Xu 于2022年12月9日周五 16:18写道:
>
> > The breaking change is introduced by
> > https://github.com/apache/pulsar/pull/18755. It can be reproduced by
> > the pulsar-
when a broker connects to another broker.
However, there is only one broker in the standalone deployment.
Thanks,
Yunze
On Fri, Dec 9, 2022 at 4:45 PM Yunze Xu wrote:
>
> > I don't think https://github.com/apache/pulsar/pull/18755 brings the
> breaking change.
>
> So how could
c/main/java/org/apache/pulsar/PulsarStandalone.java#L387
>
> Thanks,
> Zixuan
>
> Yunze Xu 于2022年12月9日周五 16:46写道:
>
> > > I don't think https://github.com/apache/pulsar/pull/18755 brings the
> > breaking change.
> >
> > So how could you explain the failed c
an Liu wrote:
>
> I appreciate your explanation. Right now it's clear.
>
> I think when an admin hasn't permission to create the namespace, the Pulsar
> should be exited.
>
> Thanks,
> Zixuan
>
>
> Yunze Xu 于2022年12月9日周五 17:20写道:
>
> > Yeah
+1 for both two listed reasons. There were a lot of emails from GitBox
recently. Most of them are caused by converting a very old issue to a
discussion. We can subscribe to the GitHub discussion if we want. But
these emails are sent to the dev mail list.
Thanks,
Yunze
On Fri, Dec 9, 2022 at 7:46
201 - 300 of 654 matches
Mail list logo