Hi, Michael, The failure is caused by the wrong format, here is the fix:
https://github.com/apache/pulsar-client-cpp/pull/45 We should include this PR and begin another vote process. However, IMO, these `docker-*.sh` should be removed in future. `docker-build.sh` was original written for tests within a image that contains all required dependencies. The libraries built by `docker-build.sh` should not be delivered because the dependencies are all dynamically linked. Maintaining a based image manually is not good. As we can see from the existing workflow [1], installing dependencies quickly for test is not complicated. And there are also some build related scripts but unfortunately not documented yet. For RedHat and Debian users, they can install the rpm [2] or deb [3] binaries in https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp-3.0.0-candidate-1/. These binaries are statically linked. For those want to compile from source, they can follow the guide here: https://github.com/apache/pulsar-client-cpp#compilation [1] https://github.com/apache/pulsar-client-cpp/blob/aa8347724c217b8c2ff8513fbcaae00df5c97dc9/.github/workflows/ci-pr-validation.yaml#L43-L56 [2] https://pulsar.apache.org/docs/client-libraries-cpp#install-rpm [3] https://pulsar.apache.org/docs/client-libraries-cpp#install-debian Thanks, Yunze > On Oct 12, 2022, at 10:35, Michael Marshall <mmarsh...@apache.org> wrote: > > I am getting an error when building from the downloaded source tarball > while following the instructions in the README. I get this error: > > $ ./docker-build.sh > fatal: not a git repository (or any of the parent directories): .git > > The issue is in the script. I believe we have already solved this in > the apache/pulsar repo. > > I am not certain, but it seems like we need to end this vote and fix > the build script so that users can build from source. Let me know what > you think. > > Before getting to the above issues, I verified the following: > > - Verified signatures for 33 artifacts. All are signed using > C46D6658489DDE09CE938AF87B6A6401BF99B4A3. > - Verified checksums for 33 artifacts. > > - Verified source equivalence between the original apache/pulsar repo > and the apache/pulsar-client-cpp repo by using diff and comparing > relevant commit hashes. I checked out > 4a864f20530e230ecee7e4ab09430bd65fb9789c for pulsar-client-cpp and > 5f079433c3706d994e6d0210cfc87e483ad53e52 for pulsar. Below is the > resulting diff. > > $ diff pulsar-client-cpp/ pulsar/pulsar-client-cpp/ > Only in pulsar-client-cpp/: .git > Common subdirectories: pulsar-client-cpp/build-support and > pulsar/pulsar-client-cpp/build-support > Common subdirectories: pulsar-client-cpp/cmake_modules and > pulsar/pulsar-client-cpp/cmake_modules > Common subdirectories: pulsar-client-cpp/docker and > pulsar/pulsar-client-cpp/docker > Common subdirectories: pulsar-client-cpp/docs and > pulsar/pulsar-client-cpp/docs > Common subdirectories: pulsar-client-cpp/examples and > pulsar/pulsar-client-cpp/examples > Common subdirectories: pulsar-client-cpp/include and > pulsar/pulsar-client-cpp/include > Common subdirectories: pulsar-client-cpp/lib and pulsar/pulsar-client-cpp/lib > Common subdirectories: pulsar-client-cpp/perf and > pulsar/pulsar-client-cpp/perf > Common subdirectories: pulsar-client-cpp/pkg and pulsar/pulsar-client-cpp/pkg > Common subdirectories: pulsar-client-cpp/python and > pulsar/pulsar-client-cpp/python > Common subdirectories: pulsar-client-cpp/templates and > pulsar/pulsar-client-cpp/templates > Common subdirectories: pulsar-client-cpp/test-conf and > pulsar/pulsar-client-cpp/test-conf > Common subdirectories: pulsar-client-cpp/tests and > pulsar/pulsar-client-cpp/tests > Common subdirectories: pulsar-client-cpp/wireshark and > pulsar/pulsar-client-cpp/wireshark > > Also, if we look at tag v3.0.0-candidate-1, the diff shows that the > primary changes being voted on are changes to the build: > > $ diff pulsar-client-cpp/ pulsar/pulsar-client-cpp/ -q > Only in pulsar-client-cpp/: .asf.yaml > Only in pulsar-client-cpp/: .git > Only in pulsar-client-cpp/: .github > Files pulsar-client-cpp/.gitignore and > pulsar/pulsar-client-cpp/.gitignore differ > Files pulsar-client-cpp/CMakeLists.txt and > pulsar/pulsar-client-cpp/CMakeLists.txt differ > Only in pulsar-client-cpp/: CONTRIBUTING.md > Only in pulsar-client-cpp/: LICENSE > Only in pulsar-client-cpp/: NOTICE > Files pulsar-client-cpp/README.md and pulsar/pulsar-client-cpp/README.md > differ > Only in pulsar-client-cpp/: SECURITY.md > Common subdirectories: pulsar-client-cpp/build-support and > pulsar/pulsar-client-cpp/build-support > Common subdirectories: pulsar-client-cpp/cmake_modules and > pulsar/pulsar-client-cpp/cmake_modules > Only in pulsar-client-cpp/: dependencies.yaml > Common subdirectories: pulsar-client-cpp/docker and > pulsar/pulsar-client-cpp/docker > Only in pulsar/pulsar-client-cpp/: docker-build-centos7.sh > Only in pulsar/pulsar-client-cpp/: docker-build-python3.9.sh > Files pulsar-client-cpp/docker-build.sh and > pulsar/pulsar-client-cpp/docker-build.sh differ > Files pulsar-client-cpp/docker-format.sh and > pulsar/pulsar-client-cpp/docker-format.sh differ > Files pulsar-client-cpp/docker-tests.sh and > pulsar/pulsar-client-cpp/docker-tests.sh differ > Common subdirectories: pulsar-client-cpp/docs and > pulsar/pulsar-client-cpp/docs > Common subdirectories: pulsar-client-cpp/examples and > pulsar/pulsar-client-cpp/examples > Common subdirectories: pulsar-client-cpp/include and > pulsar/pulsar-client-cpp/include > Common subdirectories: pulsar-client-cpp/lib and pulsar/pulsar-client-cpp/lib > Common subdirectories: pulsar-client-cpp/perf and > pulsar/pulsar-client-cpp/perf > Common subdirectories: pulsar-client-cpp/pkg and pulsar/pulsar-client-cpp/pkg > Only in pulsar-client-cpp/: proto > Files pulsar-client-cpp/pulsar-test-service-start.sh and > pulsar/pulsar-client-cpp/pulsar-test-service-start.sh differ > Files pulsar-client-cpp/pulsar-test-service-stop.sh and > pulsar/pulsar-client-cpp/pulsar-test-service-stop.sh differ > Only in pulsar/pulsar-client-cpp/: python > Files pulsar-client-cpp/run-unit-tests.sh and > pulsar/pulsar-client-cpp/run-unit-tests.sh differ > Common subdirectories: pulsar-client-cpp/templates and > pulsar/pulsar-client-cpp/templates > Common subdirectories: pulsar-client-cpp/test-conf and > pulsar/pulsar-client-cpp/test-conf > Common subdirectories: pulsar-client-cpp/tests and > pulsar/pulsar-client-cpp/tests > Only in pulsar-client-cpp/: version.txt > Common subdirectories: pulsar-client-cpp/wireshark and > pulsar/pulsar-client-cpp/wireshark > > > Thanks, > Michael > > On Tue, Oct 11, 2022 at 7:54 PM Matteo Merli <matteo.me...@gmail.com> wrote: >> >> This is the first release candidate for Apache Pulsar Client C++, version >> 3.0.0. >> >> It fixes the following issues: >> https://github.com/apache/pulsar-client-cpp/milestone/1?closed=1 >> >> *** Please download, test and vote on this release. This vote will stay open >> for at least 72 hours *** >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary files: >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp-3.0.0-candidate-1/ >> >> SHA-512 checksums: >> cbb719c3644b8cc60f1efa95e5d0645f5bd07d6d00c87bf91322eefb42fafb31573a317ea42764a5f913d05a1905580aa51243724c0c3fbc4ad2abeca32c58f0 >> ./apache-pulsar-client-cpp-3.0.0.tar.gz >> >> The tag to be voted upon: >> v3.0.0-candidate-1 (1eb861f78f31a484bceb0f64ca1ff809b61eff06) >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.0.0-candidate-1 >> >> Pulsar's KEYS file containing PGP keys you use to sign the release: >> https://dist.apache.org/repos/dist/dev/pulsar/KEYS >> >> Please download the source package, and follow the README to compile and >> test. >> >> -- >> Matteo Merli >> <matteo.me...@gmail.com>
