Re: Detect unused variables in CI

2021-12-11 Thread Yunze Xu
Looks good. Could you open an issue for it so we can add it later? Thanks, Yunze > 2021年12月10日 下午8:27,Yufei Zhang 写道: > > From what I read it can be used in Maven projects. Basically it needs a > SonarScanner (different versions for multiple languages and build tools) > for Maven as in [1]. Then

Note for pulsar-client checkstyle PR

2022-01-25 Thread Yunze Xu
Hi all (especially committers), I opened a PR to enable checkstyle plugin for pulsar-client module just now. See https://github.com/apache/pulsar/pull/13940 . It’s really a huge PR but I hope it could be included in Pulsar 2.10 release because pulsar-

Re: [DISCUSS] The default value of maxPendingChunkedMessage

2022-01-30 Thread Yunze Xu
ition in production. Thanks, Yunze Xu > 2022年1月30日 下午6:32,Zike Yang 写道: > > Hi, Pulsar community, > > We found that there are inconsistencies between the code and the > documentation regarding the default value of maxPendingChunkedMessage. > > In the java client code, we use

Re: [DISCUSS] PIP-142 Increase default numHttpServerThreads value to 200 to prevent Admin API unavailability

2022-02-17 Thread Yunze Xu
My only concern is the same with Matteo: > Dedicating 200 threads to that would be > a massive waste of resources (CPU & memory). And we should make it clear whether numHttpServerThread=200 could solve the existing problem like https://github.com/apache/pulsar/pull/13666

[Discuss] Generate cert and key files automatically

2022-03-21 Thread Yunze Xu
Hi all, Recently I found a document error when configuring Pulsar client for TLS encryption. See https://github.com/apache/pulsar/issues/14762. However, the code example in the official documents is more intuitive. See https://pulsar.apache.org/docs/en/security-tls-transport/#java-client, the exa

Re: [Discuss] Generate cert and key files automatically

2022-03-22 Thread Yunze Xu
22 alle ore 16:31 Yunze Xu > ha scritto: >> >> Hi all, >> >> Recently I found a document error when configuring Pulsar client for TLS >> encryption. See https://github.com/apache/pulsar/issues/14762. However, the >> code >> example in

Re: [Discuss] Generate cert and key files automatically

2022-03-22 Thread Yunze Xu
e(), > authParams) >.build(); > ``` > > When using the TLS auth, we don't need to set > tlsCertFilePath("client-ca.pem") and tlsKeyFilePath("client-key.pem"), the > authentication instead of this. > > There have an important t

Re: Abount add TDengine Connector to Pulsar.

2022-03-29 Thread Yunze Xu
Hi JueShan, AFAIK, the Pulsar main repository already contains some connectors and it increases the complexity to maintain them, so for new connectors, it's better to maintain them in your own repositories. Thanks, Yunze > 2022年3月28日 下午8:29,刘梓霖 写道: > > Hi EveryOne, > I would like to contrib

Re: [DISCUSS] PIP-155: Drop support for Python2

2022-04-17 Thread Yunze Xu
+1 Thanks, Yunze > 2022年4月16日 00:06,Matteo Merli 写道: > > https://github.com/apache/pulsar/issues/15185 > > - > > ## Motivation > > Python 2.x has been deprecated for many years now and it was > officially end-of-lifed 2.5 years ago > (https://www.python.org/doc/sunset-python-2/).

Re: [Discuss] Generate cert and key files automatically

2022-04-18 Thread Yunze Xu
uld use the `AuthenticationTls` data to set up, `AuthenticationTls` > must be higher. When the user set up two config, we need to throw an > expectation that only use the `AuthenticationTls`, or `tlsCertFilePath` and > `tlsKeyFilePath`. > > > Yunze Xu 于2022年3月23日周三 01:57写道: >

Re: [DISCUSS] PIP-158: Split client TLS transport encryption from authentication

2022-05-08 Thread Yunze Xu
It totally LGTM. I have a suggestion that it might be better to configure a class like `TlsConfiguration` instead of multiple TLS related configs added to `ClientBuilder`. Thanks, Yunze > 2022年4月24日 14:15,Zixuan Liu 写道: > > Hi Pulsar community, > > I open a https://github.com/apache/pulsar/

Re: [DISCUSS] PIP-158: Split client TLS transport encryption from authentication

2022-05-08 Thread Yunze Xu
Builder`, so I use this style. > > Thanks, > Zixuan > > Yunze Xu 于2022年5月9日周一 13:31写道: > >> It totally LGTM. I have a suggestion that it might be better to configure a >> class like `TlsConfiguration` instead of multiple TLS related configs >>

Re: [VOTE] [PIP-158] Split client TLS transport encryption from authentication

2022-05-10 Thread Yunze Xu
+1 (non-binding) Thanks, Yunze

Re: [DISCUSSION] PIP-156: Enable system topic by default

2022-05-10 Thread Yunze Xu
+1 (non-binding) Thanks, Yunze

Re: [VOTE] [PIP-158] Split client TLS transport encryption from authentication

2022-05-14 Thread Yunze Xu
+1 (non-binding) Thanks, Yunze

Re: [DISCUSS] Byte schema compatibility issue

2022-05-16 Thread Yunze Xu
For case 1, if you are using bytes schema to produce messages, it will be user's responsibility to ensure the schema compatibility. Then at consumer side, `Message#getValue`, which decodes the bytes internally via the schema, should throw a `SchemaSerializationException` if the bytes of the value c

Re: [DISCUSS] Apache Pulsar 2.10.1 release

2022-05-23 Thread Yunze Xu
+1 Thanks, Yunze > 2022年5月23日 11:34,Hang Chen 写道: > > +1 > > There are a lot of transaction fixes. > > Thanks, > Hang > > PengHui Li 于2022年5月21日周六 13:06写道: >> >> Hello, Pulsar community: >> >> I'd like to propose to release Apache Pulsar 2.10.1 >> >> Currently, we have 190 commits [0]

Re: About 2.10.1, 2.9.2, 2.8.4 has this been cherry picked yet? [fix][java-client] Fix performance regression with message listener

2022-05-31 Thread Yunze Xu
We use the `cherry-picked` label to mark the PR has been cherry-picked into the specific branch. For example, the `cherry-picked/branch-2.10` label means the PR has been cherry-picked to branch-2.10. Thanks, Yunze > 2022年6月1日 09:57,Dave Fisher 写道: > > This is a fix for a severe performance r

New proposal for chunk messages with shared subscriptions

2022-06-07 Thread Yunze Xu
Hi folks, Recently I'm working on the implementation of PIP-37, see https://github.com/apache/pulsar/wiki/PIP-37%3A-Large-message-size-handling-in-Pulsar#usecase-3-multiple-producers-with-shared-consumers As we can see, https://github.com/apache/pulsar/pull/4400 only implements chunking message

Re: New proposal for chunk messages with shared subscriptions

2022-06-14 Thread Yunze Xu
I opened an initial PR for it: https://github.com/apache/pulsar/pull/16061 It doesn’t adopt any option of the original PIP 37. I think we need another proposal for it, just like the chunked message ID in PIP 107. Thanks, Yunze > 2022年6月7日 22:12,Yunze Xu 写道: > > Hi folks, >

[DISCUSS] User-friendly acknowledgeCumulative API on a partitioned topic or multi-topics

2022-07-15 Thread Yunze Xu
Hi all, Long days ago I opened a PR to support cumulative acknowledgement for C++ client, but it's controversial about whether should a partitioned consumer acknowledge a message ID cumulatively. See https://github.com/apache/pulsar/pull/6796 for discussion. Currently, the Java client acknowledg

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-07-17 Thread Yunze Xu
In addition to #16202, there is a following PR to support the correct ACK implementation for chunked messages. It should depend on #16202 But I think I can submit an initial PR this week and change the tests after #16202 is merged. Thanks, Yunze > 2022年7月18日 11:22,PengHui Li 写道: > > Hi all,

[DISCUSS] Apache Pulsar 2.8.4 release

2022-07-21 Thread Yunze Xu
Hello Pulsar Community, It has been several months since the 2.8.3 release and there are many important fixes after that. For example, there is a performance regression for message listener that was introduced from 2.8.3 and fixed in https://github.com/apache/pulsar/pull/15162. I volunteer to be

Re: [DISCUSS] Apache Pulsar 2.8.4 release

2022-07-21 Thread Yunze Xu
Sure, I will take it carefully for those PRs not cherry-picked to branch-2.8 but labeled as `release/2.8.4`. Thanks, Yunze > 2022年7月22日 00:09,Dave Fisher 写道: > > Thank you for volunteering! > >> On Jul 21, 2022, at 12:57 AM, Yunze Xu wrote: >> >> Hello P

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-07-26 Thread Yunze Xu
hui for the reminder. >>>>>>> I'd like to also include PIP: 181 Pulsar shell if the time >> permits. >>>>>>> >>>>>>> I believe that is a good idea to start testing the code freeze >>>> proposed >>>>>> by >>>&

Re: [ANNOUNCE] Micheal Marshall as a new PMC member in Pulsar

2022-07-26 Thread Yunze Xu
Congratulations Michael! Thanks, Yunze > 2022年7月26日 23:21,Enrico Olivelli 写道: > > I am glad to announce that the Apache Pulsar PMC invited Micheal to > join the PMC and he accepted. > > Micheal is doing a great job in stewarding our community > > Please join me and celebrate ! > > Enrico

Re: [DISCUSS] Apache Pulsar 2.8.4 release

2022-08-05 Thread Yunze Xu
Hi, all I have cherry-picked all necessary PRs into branch-2.8 now, see https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.8.4+-label%3Acherry-picked%2Fbranch-2.8+ For some PRs with `release/2.8.4` label but not cherry-picked into branch-2.8, I changed the label to `release/2.8.

Re: [DISCUSS] Create a new Github Project to track the flaky tests

2022-08-10 Thread Yunze Xu
+1. Though the image url is broken :( Thanks, Yunze > 2022年8月10日 16:35,PengHui Li 写道: > > Hi all, > > For better tracking flaky test fix, I have tried to create a Github Project > under the Pulsar repo https://github.com/apache/pulsar/projects/11 (It can be > removed if we don't like this

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread Yunze Xu
LGTM Thanks, Yunze > 2022年8月10日 15:36,Zike Yang 写道: > > Hi, Pulsar community > > Currently, Java tests consume significant CI resources. And it is not > necessary to run all the tests for changes that are only on the C++ or > python parts of the code. I have created a PR [0] to improve the

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-08-10 Thread Yunze Xu
h-2.11[1]. > > [1] https://github.com/apache/pulsar/tree/branch-2.11 > > > Regards > Jiwei Guo (Tboy) > > > On Wed, Jul 27, 2022 at 10:59 AM Zixuan Liu wrote: > >> +1 >> >> Thanks, >> Zixuan >> >> Yunze Xu 于2022年7月26日周二 23:34

Questions about the release process

2022-08-11 Thread Yunze Xu
Hi all, Recently I'm working on the release of 2.8.4 and it's near the vote of the 1st candidate but I have some questions. From the tutorial [1] we can see, the 8th step is "Run the vote". However, the 7th step is "Write release notes", should we execute this step later? I see the 16th step is a

Re: [Discuss] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-11 Thread Yunze Xu
+1 on the customized one Thanks, Yunze > 2022年8月12日 00:25,Alexander Preuss > 写道: > > Hi together, > > Thank you for driving this topic! > I agree that our customized convention is better than the Angular one. > > +1 on the customized one > > Best, > Alex > > > > On Thu, Aug 11, 2022 a

Re: Questions about the release process

2022-08-12 Thread Yunze Xu
e passed few days. The documents could, and should be better. Anyway, I will open a VOTE soon. Thanks, Yunze > 2022年8月11日 21:48,Yunze Xu 写道: > > Hi all, > > Recently I'm working on the release of 2.8.4 and it's near the vote of > the 1st candidate but I have s

[VOTE] Pulsar Release 2.8.4 Candidate 1

2022-08-12 Thread Yunze Xu
This is the first release candidate for Apache Pulsar, version 2.8.4. It fixes the following issues: https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.8.4 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note th

Re: Questions about the release process

2022-08-12 Thread Yunze Xu
es". >> >> Confused +1, If we do add docker image as part of release vote, we should >> also add validation method in [1] >> >> [1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation >> >> Thanks, >> Haiting >> >> O

Re: Questions about the release process

2022-08-12 Thread Yunze Xu
; details on this topic here. Again, just for your information :) >> >> Best, >> tison. >> >> [1] https://pingcap.github.io/tidb-dev-guide/ >> [2] https://kvrocks.apache.org/community/how-to-release >> >> >> Yunze Xu 于2022年8月12日周五 21:57写道: >

Re: [VOTE] Pulsar Release 2.8.4 Candidate 1

2022-08-14 Thread Yunze Xu
You can see https://lists.apache.org/thread/rg1g083c06ozm5go6zo1jophg9y9zl2f for more details about the LTS release. Thanks, Yunze > 2022年8月14日 11:00,Qiang Huang 写道: > > +1 (non-binding) > Is 2.8.4 a long term support release? > > Yunze Xu 于2022年8月12日周五 16:20写道: >

Re: Questions about the release process

2022-08-15 Thread Yunze Xu
> One example is that `pool.sks-keyservers.net` in [1] seems not available anymore, but I am not that confident enough to edit it directly. Yeah. It’s not available in my env as well. I made some changes recently, but I’m also not sure about this point. > I think we can consider using a BOT (like

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-17 Thread Yunze Xu
LGTM. Thanks, Yunze > 2022年8月17日 11:15,Yu 写道: > > Hi team, > > For PIP 198: Standardize PR Naming Convention using GitHub Actions [1] > > How to define [type] and [scope]? Do these abbreviations LGTY? > > *[Guide] Pulsar Pull Request Naming Convention* [2] contains everything > about the

Re: [ANNOUNCE] Jiwei Guo as a new PMC member in Pulsar

2022-08-18 Thread Yunze Xu
Congratulations! Thanks, Yunze > 2022年8月18日 19:24,PengHui Li 写道: > > Hi, all > > I'm glad to announce that the Apache Pulsar PMC invited Jiwei Guo to join > the > PMC and he accepted. > > Please join in celebrating! > > Best, > Penghui

Re: [DISCUSS] Enable non-mandatory updating PR branches

2022-08-18 Thread Yunze Xu
I’m glad to see the “update branch” option enabled for contributors. Thanks, Yunze > 2022年8月18日 21:01,tison 写道: > > Hello, > > The short version > = > > Vote if you agree on enabling the non-mandatory updating PR branches > button, i.e., the "Always suggest updating pull reques

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-21 Thread Yunze Xu
A, A Thanks, Yunze > 2022年8月22日 12:47,Yu 写道: > > Hi developers, > > Two quick questions need your vote! > > Which do you prefer? > > > > # 1. Use "branch" or "BP"? > > Choice A: [fix][broker][branch-2.9] xxx > Choice B: [fix][broker][BP-2.9] xxx > > ~~~

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-21 Thread Yunze Xu
The motivation and goal LGTM, but the API changes look very simple and hard to use. Do we have to implement all these interfaces for an admin extension? If yes, could you show an example in the proposal as a guidance? For example, if I just want to implement a simple command: ```bash ./bin/pulsar

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-22 Thread Yunze Xu
gt; Yunze, > > Il giorno lun 22 ago 2022 alle ore 08:06 Yunze Xu > ha scritto: >> >> The motivation and goal LGTM, but the API changes look very simple and >> hard to use. Do we have to implement all these interfaces for an admin >> extension? If yes, coul

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Yunze Xu
+1 (non binding) Thanks, Yunze > 2022年8月24日 15:38,Nicolò Boschi 写道: > > +1 (non binding) > Nicolò Boschi > > > Il giorno mer 24 ago 2022 alle ore 09:11 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > >> Hello, >> this is the official thread VOTE for PIP-201 Extensions mechanism for

[DISCUSS] Deprecate KeyValue schema factory methods with Class parameters

2022-08-24 Thread Yunze Xu
Hi folks, Recently I'm looking into the KeyValue schema and found **FOUR** static methods in `Schema` to create a `KeyValueSchema` object: 1. KeyValue(Class key, Class value); 2. KeyValue(Class key, Class value, SchemaType type); 3. KeyValue(Schema key, Schema value); 4. KeyValue(Schema key, Sche

Re: [VOTE] Pulsar Release 2.8.4 Candidate 1

2022-08-29 Thread Yunze Xu
the standalone server >> - Confirmed that producer and consumer work properly >> - Validated functions, connectors, and stateful functions >> >> >> Regards >> Jiwei Guo (Tboy) >> >> >> On Mon, Aug 15, 2022 at 10:18 AM Qiang Huang

Re: [VOTE] Pulsar Release 2.8.4 Candidate 1

2022-09-02 Thread Yunze Xu
eck passes >> >> - Compile from source >> >> - Run Pulsar standalone and produce-consume from CLI >> >> - Tested K8S installation with Datastax Pulsar helm chart and verified TLS, >> offloads and ElasticSearch sink >> >> >> >> Nic

Re: [DISCUSS] User-friendly acknowledgeCumulative API on a partitioned topic or multi-topics

2022-09-04 Thread Yunze Xu
+1 >> >> Penghui >> On Jul 28, 2022, 20:14 +0800, lordcheng10 <1572139...@qq.com.invalid>, >> wrote: >>> Nice feature! >>> >>> >>> >>> >>> -- Original -- >>> From: "Y

[DISCUSS] Improvements on the release process

2022-09-05 Thread Yunze Xu
Hi all, I'm working on 2.8.4 release recently. When I followed the release process, I found many steps are outdated so that I turned to the previous release managers for help frequently. Since the release process is now in the codebase [1], I opened a PR for some improvements on it. [2] PTAL espe

Re: [DISCUSS] Improvements on the release process

2022-09-05 Thread Yunze Xu
he/pulsar/issues/16637 > > ~~~~~~ > > Feel free to comment, thank you! > > Yu > > On Tue, Sep 6, 2022 at 10:57 AM Yunze Xu > wrote: > >> Hi all, >> >> I'm working on 2.8.4 release recently. When I followed the release >> proces

Re: [DISCUSS] User-friendly acknowledgeCumulative API on a partitioned topic or multi-topics

2022-09-07 Thread Yunze Xu
ke my-topic-partition-0 > void acknowledgeCumulative(Map topicToMessageId); > ``` > > If you are busy with other things, do you mind Tarun taking this up ? Happy > to have you as a reviewer. > > Regards, > Shivji Kumar Jha > http://www.shivjijha.com/ > +91 8884075512 >

Re: [DISCUSS] Improvements on the release process

2022-09-07 Thread Yunze Xu
Good suggestion. I will update in the PR soon. Thanks, Yunze > On Sep 6, 2022, at 15:46, Haiting Jiang wrote: > > There are a lot of work before current release process, maybe we should > also include these: > > 1. Start a discussion on the mail list about the release. We can provide a > te

Re: [DISCUSS] PIP-70: Introduce lightweight raw Message metadata

2020-11-15 Thread Yunze Xu
I think protobuf has the ability to check if a field is enabled. i.e. RAW_METADATA_MAGIC_NUMBER and RAW_METADATA_SIZE are included in the protobuf-ed struct. In Kafka, a magic number represents the version of protocol not if the feature is enabled. If we need a *real* magic number, we must make

Re: Virtual Pulsar Community Meetings

2021-01-29 Thread Yunze Xu
+1 > 2021年1月29日 下午4:53,Sijie Guo 写道: > > That's a super great idea! Thank you for bringing this up! > > Given there are a lot of committers/contributors are from North America and > Asia, I think we should pick up a better time that would be suitable for > people from Asia (Japan and China). >

Re: Pulsar Server on JDK11 - initial discussion

2021-02-09 Thread Yunze Xu
LGTM if I don’t understand wrong. In short, there’re two key points: 1. Keep the code compatible with Java 8. 2. Release the binaries that are built on JDK 11 to get the benefit. So Java 8 users can still build Pulsar with JDK 8 but the default releases are built on JDK 11. - Yunze

Re: Very flaky CPP tests - BasicEndToEndTest.testLookupThrottling

2021-04-05 Thread Yunze Xu
e a CI environment to test my ideas, but you know, the Pulsar’s workflows cost too much time, a tiny change may wait too long. Is there any way to run similar CI in my own repo and verify if the change could fix the flaky test? Regards Yunze Xu > 2021年4月2日 下午3:09,Enrico Olivelli 写道: > > Hello,

Re: Very flaky CPP tests - BasicEndToEndTest.testLookupThrottling

2021-04-05 Thread Yunze Xu
Thanks for the instruction, I’ll take a look later. Regards Yunze Xu > 2021年4月6日 上午1:38,Devin Bost 写道: > > Check out the instructions by Lari Hotari here about how to setup your > personal Github CI: > https://markmail.org/message/xapp7aguh44osqhm > > I've been work

Re: [DISCUSS] Apache Pulsar 2.8.0 Release

2021-05-11 Thread Yunze Xu
We need a PR to upgrade BK to 4.14.0 before Pulsar 2.8.0 release, see https://github.com/apache/pulsar/pull/10330 <https://github.com/apache/pulsar/pull/10330> Thanks, Yunze Xu

Re: Pulsar WebSite Builder is failing

2021-05-21 Thread Yunze Xu
Hi Enrico, could you try https://github.com/apache/pulsar/pull/10668 in your local env? Thanks, Yunze > 2021年5月18日 下午5:24,Enrico Olivelli 写道: > > Hello, > we are still stuck. > > the website builder does not work. > This time is because the build

Correct TopicName#getPartitionIndex implementation

2021-06-08 Thread Yunze Xu
Hi all, Currently the Java implementation to get the partition index of a topic name is not correct. See https://github.com/apache/pulsar/pull/8341/files#diff-445b0cfa56ca0c784df78e73d9294f2a37f079ca3c15c345b03c09d56f81ebff

Re: Correct TopicName#getPartitionIndex implementation

2021-06-11 Thread Yunze Xu
Okay, I Just had a offline discussion with @yangl about this problem before. And he or I will fix the getPartitionIndex implementation later. Thanks, Yunze

Update for apachepulsar/pulsar-build images

2021-07-20 Thread Yunze Xu
sh-images.sh under pulsar-client-cpp/docker directory. However, further more, it's better to add a workflow to push these images if necessary. Can anyone help with it? Thanks, Yunze Xu

Re: [DISCUSS] PIP-91: Separate lookup timeout from operation timeout

2021-08-09 Thread Yunze Xu
+1 It makes sense to me. I also encountered TooManyRequests in topic lookup when there’re a lot of topics. It should be retriable instead of a simple error response to client. Thanks, Yunze > 2021年8月9日 下午10:11,Ivan Kelly 写道: > > Hi folks, > > I've created a PIP to do some rework on lookup t

Re: [ANNOUNCE] New committer: Rui Fu

2021-08-10 Thread Yunze Xu
Congrats Rui! Thanks, Yunze

Re: PIP-93 Pulsar Proxy Protocol Handlers

2021-08-30 Thread Yunze Xu
+1. Great idea. I’m not familiar with Pulsar Proxy and have a question. How can a proxy protocol handler Reuse the existing code of a protocol handler? Thanks, Yunze > 2021年8月30日 下午4:47,Enrico Olivelli 写道: > > Hello Pulsar fellows, > > I have prepared a PIP about adding support for Protocol

Re: PIP-93 Pulsar Proxy Protocol Handlers

2021-08-30 Thread Yunze Xu
, like PRODUCE and FETCH requests Right? Thanks, Yunze > 2021年8月30日 下午11:56,Enrico Olivelli 写道: > > Il giorno lun 30 ago 2021 alle ore 17:22 Yunze Xu > ha scritto: > >> +1. Great idea. >> >> I’m not familiar with Pulsar Proxy and have a question. How can a proxy

Re: PIP-93 Pulsar Proxy Protocol Handlers

2021-08-30 Thread Yunze Xu
Thanks for your explanation and I’m looking forward for the prototype implementation. Thanks, Yunze > 2021年8月31日 上午4:17,Enrico Olivelli 写道: > > Yunze, > > Il Lun 30 Ago 2021, 18:48 Yunze Xu ha > scritto: > >> If I didn’t understand wrong, we’re going to use both

[PIP 94] Message converter at broker level

2021-09-07 Thread Yunze Xu
Hi, folks I’ve created PIP 94, see https://github.com/apache/pulsar/issues/11962 for details. PTAL and give your suggestions if you have any concern. Thanks, Yunze

[PIP 96] Payload converter for Pulsar client

2021-09-18 Thread Yunze Xu
Hi, folks I’ve created PIP 94 before for a message converter at broker level. However, after the dicussion, I determined to discard the proposal. And now, for the same motivation, I've created PIP 96 to add a payload converter for Pulsar client. It should be noted that the converter works on a pay

Correct semantics of producer close

2021-09-27 Thread Yunze Xu
Hi all, Recently I found a PR (https://github.com/apache/pulsar/pull/12195 ) that modifies the existing semantics of producer close. There're already some communications in this PR, but I think it's better to start a discussion here to let more know.

Re: Correct semantics of producer close

2021-09-28 Thread Yunze Xu
s to wait for the ack. > The correct model should be to wait for return on the blocking API, or wait > for future completion of the async API, then handle any publish errors and > then only close the producer. > > > On Mon, Sep 27, 2021 at 8:50 PM Yunze Xu > wrote: >

Re: [VOTE] PIP-99 Pulsar Proxy Extensions

2021-09-28 Thread Yunze Xu
+1 (non binding) Thanks, Yunze

Re: [PIP 100] Add seekByIndex for consumer api

2021-09-28 Thread Yunze Xu
You need to create an issue first to start a discussion for your PIP. Here’s the process of PIP: 1. The author(s) of the proposal will create a GitHub issue ticket choosing the template for PIP proposals. 2. The author(s) will send a note to the dev@pulsar.apache.org

Re: [PIP 100] Add seekByIndex for consumer api

2021-09-28 Thread Yunze Xu
I have edited the Wiki page for PIP https://github.com/apache/pulsar/wiki/Pulsar-Improvement-Proposal-(PIP) Thanks, Yunze

Re: Correct semantics of producer close

2021-09-28 Thread Yunze Xu
lay application > shutdown indefinitely to deliver its last messages. If users need > stronger guarantees about whether their messages are delivered, they > are probably already using the flush methods to ensure that the > producer's queues are empty before calling `closeAsync`. >

[VOTE] PIP-96 Message payload processor for Pulsar client

2021-09-29 Thread Yunze Xu
Hi folks, It has been about two weeks since I opened the PIP-96 issue and the design has changed a lot. Thanks a lot for @eolivelli's suggestions. I think now it's time to start a vote. PIP-96 issue: https://github.com/apache/pulsar/issues/12087 T

Re: Correct semantics of producer close

2021-09-30 Thread Yunze Xu
concept  of  "maybe published". OR >>>> > > "published-if-no_real_errors".  What does that even >>>> mean?  That is only a >>>> > > can of worms which is going to add to developer confusion and >>>> lead to >>>> > &

Re: [VOTE] PIP-96 Message payload processor for Pulsar client

2021-10-03 Thread Yunze Xu
I see there’re already three +1 now. Here’s the related PR: https://github.com/apache/pulsar/pull/12088 <https://github.com/apache/pulsar/pull/12088> > 2021年9月30日 下午12:08,Yunze Xu 写道: > > Hi folks, > > It has been about two weeks since I opened the PIP-96 issue and the

Re: Cutting 2.9.0 RC - final call

2021-10-04 Thread Yunze Xu
Just a reminder of review for PIP 96: https://github.com/apache/pulsar/pull/12088 And I’ve pinged reviewers again just now. Thanks, Yunze > 2021年10月4日 下午3:01,Enrico Olivelli 写道: > > > > There are a few approved PIP that needs review and mergin

Re: [VOTE] PIP-96 Message payload processor for Pulsar client

2021-10-04 Thread Yunze Xu
Done. Thanks for your reminder. Thanks, Yunze > 2021年10月4日 下午2:16,Enrico Olivelli 写道: > > Yunze > You can move the PIP to Approved and copy it to the Wiki. > > Now that it is approved we can review and finally merge the PR > > Enrico > > Il Lun 4 Ott 20

Remove deprecated tlsEnabled config from broker and functions worker

2021-10-24 Thread Yunze Xu
Hi all, I’ve opened a PR to remove `tlsEnabled` config: https://github.com/apache/pulsar/pull/12473 For built-in admin or client used for replication or system topic, we have isBrokerClientTlsEnabled config to determine whether to connect the TLS e

Re: Creating Good Release notes

2021-12-02 Thread Yunze Xu
First I agree with Jonathan that we should perform some changes with the original PR descriptions. Then, classifying these PRs is also necessary, otherwise the release notes would be meaningless. There are a lot of PRs that should be classfied in Misc part of https://github.com/apache/pulsar/pull/

Detect unused variables in CI

2021-12-10 Thread Yunze Xu
Hi, all Recently I found a bug that could be avoided if we have a CI to detect unused variables. See https://github.com/apache/pulsar/pull/13233 . We can see the private field `recycleHandle` was not used before this PR. Generally, we should avoid all

Re: Detect unused variables in CI

2021-12-10 Thread Yunze Xu
My previous team used SonarQube for detecting such issues. I saw a free > version can be used. Also there is sonarlint for local checks which i found > useful. > > Cheers > Yufei > > On Fri, Dec 10, 2021 at 6:08 PM Yunze Xu > wrote: > >> Hi, all >> >> Rece

[Discuss] Release RPM packages with cxx11 ABI

2023-09-04 Thread Yunze Xu
Hi all, Currently the official released pre-built binaries for Linux include: - RPM packages for RedHat-based Linux distros - DEB packages for Debian-based Linux distros - APK packages for Alpine-based Linux distros Though they are provided in different Linux distributions, they are all compiled

Re: [DISCUSS] Replace Customized Map with ConcurrentHashMap

2023-09-06 Thread Yunze Xu
I support replacing it with JDK's ConcurrentHashMap. Maintaining a customized concurrent hash map whose algorithm is essentially the same with the implementation of a very old version of JDK is painful. The PROs listed like no boxing and linear probing have not proved to be better by any benchmark.

Re: [VOTE] Pulsar DotPulsar Release 3.0.0 Candidate 1

2023-09-07 Thread Yunze Xu
+1 (binding) - Verified signature and checksums - Build from source with dotnet 7.0.400 on Windows 11 - Run the example by adding the dotpulsar 3.0.0 dependency But I think there are some points to improve with the document. I'm new to the dotnet CLI though I have some experiences of C# a few yea

Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread Yunze Xu
Totally I'm +0 at the moment. I'm still wondering which issue you really want to resolve. I left a comment https://github.com/apache/pulsar/pull/21271#issuecomment-1751899833. Generally you can get latest value unless the producer is far quicker than the reader. However, even with the refreshAsync(

Re: [VOTE] PIP-307: Support subscribing multi-topics for WebSocket

2023-10-19 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Fri, Oct 20, 2023 at 10:59 AM mattison chao wrote: > > +1(binding) > > Best, > Mattison > > > On 19 Oct 2023, at 20:47, guo jiwei wrote: > > > > Hi dev, > > Currently WebSocket only supports the consumption of a single topic, > > which cannot satisfy users' consu

Re: [VOTE] Pulsar Client Go Release 0.11.1 Candidate 1

2023-10-20 Thread Yunze Xu
+1 (binding) - Verified checksum and signatures - Build the perf tool from source - Run the perf to produce and consumer for some time Thanks, Yunze On Mon, Sep 11, 2023 at 6:08 PM Zike Yang wrote: > > Hi everyone, > Please review and vote on the release candidate #1 for the version > 0.11.1, a

[Discuss] Release Pulsar C++ Client 3.4.0

2023-10-22 Thread Yunze Xu
I would like to propose releasing the Pulsar C++ Client 3.4.0. It has been about 3 months since the last release. There have been many new features and bug fixes since then. Besides, from my own perspective, it's better to let Python and Node.js clients depend on this new version of C++ client. Es

Re: [VOTE] PIP-298 Consumer supports specifying consumption isolation level

2023-10-22 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Mon, Oct 23, 2023 at 1:08 PM PengHui Li wrote: > > +1 (binding) > > Regards, > Penghui > > On Mon, Oct 23, 2023 at 10:37 AM hzh0425 wrote: > > > Dave previously mentioned in the discussion thread that he will continue > > to support this pip if the documentation is

Re: [VOTE] Pulsar Release 3.1.1 Candidate 1

2023-10-23 Thread Yunze Xu
+1 (binding) - Verified checksum and signatures - Built from source with Java 17.0.7 and Maven 3.9.3 on macOS m1 - Started standalone and verified produce and consume - Ran it with StreamNative KoP and verified produce and consume with Kafka clients 3.5.0 Thanks, Yunze On Thu, Oct 19, 2023 at 5:

Re: Question about Pulsar gRPC client(s)

2023-10-31 Thread Yunze Xu
It's a protocol handler like https://github.com/streamnative/kop that supports the Kafka protocol. The protocol handler should not be maintained in the core repo because there are a few people maintaining the plugin. And just like Christophe and Zike said, compared with the native Pulsar protocol,

[VOTE] Pulsar Client C++ Release 3.4.0 Candidate 1

2023-11-01 Thread Yunze Xu
This is the first release candidate for Apache Pulsar Client C++, version 3.4.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we are

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 1

2023-11-05 Thread Yunze Xu
inding) > > - Checked the sign and checksum > - Build the source > - Test SampleProducer and SampleConsumer > > Thanks, > Baodi Shi > > > On Nov 1, 2023 at 18:18:21, Yunze Xu wrote: > > > This is the first release candidate for Apache Pulsar Client C++, vers

Re: [VOTE] PIP-300: Add custom dynamic configuration for plugins

2023-11-05 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Mon, Nov 6, 2023 at 10:47 AM guo jiwei wrote: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Sun, Oct 8, 2023 at 2:13 PM 太上玄元道君 wrote: > > > +1 (no-binding) > > > > > > Zixuan Liu 于2023年9月26日 周二10:54写道: > > > > > Hi Pulsar Community, > > > > > > Voting

[VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-06 Thread Yunze Xu
This is the second release candidate for Apache Pulsar Client C++, version 3.4.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we ar

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-08 Thread Yunze Xu
t; > Hi all > > > > Sorry, I'll send another email explaining what tests were done. > > > > Please ignore the previous email. > > > > Thanks > > Yubiao Feng > > > > > > On Wed, Nov 8, 2023 at 11:48 AM Yubiao Feng > > wrote:

  1   2   3   4   5   6   7   >