[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
tisonkun commented on code in PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#discussion_r962603706 ## docbot/main.go: ## @@ -607,26 +31,8 @@ func main() { logger.Fatalln("Action type is not string") Review Comment: Perhaps we can rem

[GitHub] [pulsar] opswfit created a discussion: How do I convert a None-partitioned topic to Partitioned topic

2022-09-05 Thread GitBox
GitHub user opswfit created a discussion: How do I convert a None-partitioned topic to Partitioned topic I have a None-partitioned topic that needs to be converted into Partitioned Topic. What should I do? https://user-images.githubusercontent.com/13762962/188404976-29e59310-15b0-4ee9-8631-904

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
tisonkun commented on code in PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#discussion_r962618120 ## docbot/action_config.go: ## @@ -0,0 +1,119 @@ +package main + +import ( + "fmt" + "os" + "strings" +) + +type ActionConfig struct { + t

[GitHub] [pulsar-client-node] equanz commented on pull request #229: Update C++ client version and compatiblity table to v2.10.1

2022-09-05 Thread GitBox
equanz commented on PR #229: URL: https://github.com/apache/pulsar-client-node/pull/229#issuecomment-1236727617 It seems https://github.com/apache/pulsar/pull/15009 causes the following errors. This change was released as `v2.9.3` and `v2.10.1` . I modified test codes to address this cha

Re: [DISCUSS] Apache Pulsar 2.10.2 release

2022-09-05 Thread lin chen
+1 Michael Marshall 于2022年9月3日周六 10:50写道: > +1, thanks for volunteering to do another release, Haiting! > > Thanks, > Michael > > On Thu, Aug 25, 2022 at 7:43 AM Anon Hxy wrote: > > > > +1 > > > > Thanks, > > Xiaoyu Hou > > > > Haiting Jiang 于2022年8月23日周二 22:10写道: > > > > > Hello, Pulsar commu

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-09-05 Thread lordcheng10
+1 Haiting Jiang 于2022年8月26日周五 09:52写道: > +1 > > Thanks, > Haiting > > On Thu, Aug 25, 2022 at 9:52 AM Baodi Shi > wrote: > > > +1 > > > > Thanks, > > Baodi Shi > > > > > On Aug 24, 2022, at 20:1312, Qiang Huang > > wrote: > > > > > > +1 > > > > > > Zike Yang 于2022年8月22日周一 15:32写道: > > > > >

Re: [VOTE] PIP-195: New bucket based delayed message tracker

2022-09-05 Thread lordcheng10
+1 guo jiwei 于2022年9月1日周四 11:00写道: > +1 Great work! > > > Regards > Jiwei Guo (Tboy) > > > On Wed, Aug 31, 2022 at 6:19 PM Ran Gao wrote: > > > +1 Great work! > > > > Thanks, > > Ran Gao > > > > On 2022/08/29 10:37:31 Cong Zhao wrote: > > > Hi Pulsar Community, > > > > > > In order to facilitat

Re: [VOTE] PIP-195: New bucket based delayed message tracker

2022-09-05 Thread Enrico Olivelli
+1 (binding) Enrico Il giorno lun 5 set 2022 alle ore 11:54 lordcheng10 ha scritto: > > +1 > > guo jiwei 于2022年9月1日周四 11:00写道: > > > +1 Great work! > > > > > > Regards > > Jiwei Guo (Tboy) > > > > > > On Wed, Aug 31, 2022 at 6:19 PM Ran Gao wrote: > > > > > +1 Great work! > > > > > > Thanks, >

[GitHub] [pulsar-test-infra] nodece commented on a diff in pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
nodece commented on code in PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#discussion_r962750783 ## docbot/action_test.go: ## @@ -0,0 +1,320 @@ +package main + +import ( Review Comment: Yes, it is simple. To reduce external dependencies, I did not use this.

[GitHub] [pulsar-test-infra] nodece commented on pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
nodece commented on PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#issuecomment-1236821960 Hi @tisonkun, Thanks for your review, these request has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
tisonkun commented on code in PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#discussion_r962755814 ## docbot/action_test.go: ## @@ -0,0 +1,326 @@ +package main + +import ( + "context" + "fmt" + "os" + "strings" + "testing" + +

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
tisonkun commented on code in PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#discussion_r962756759 ## docbot/action_test.go: ## @@ -0,0 +1,320 @@ +package main + +import ( Review Comment: Make sense. IIRC Golang will download test dependencies even in produ

Re: [VOTE] PIP-205: Reactive Java client for Apache Pulsar

2022-09-05 Thread Lari Hotari
Hi, The vote for PIP-205: Reactive Java client for Apache Pulsar passed with 4x +1 (binding) and 11x +1 (non-binding). +1 (binding) - Enrico - Matteo - Michael - Penghui +1 (non-binding) - Tison - ZhangJian - Christophe - Nicolo - Zixuan - Lan - Soby - Sankaran - Aloys - Haiting - Max Thanks,

[GitHub] [pulsar-test-infra] nodece commented on a diff in pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
nodece commented on code in PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#discussion_r962760646 ## docbot/action_test.go: ## @@ -0,0 +1,326 @@ +package main + +import ( + "context" + "fmt" + "os" + "strings" + "testing" + +

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-09-05 Thread guo jiwei
Hi dev, We find two new issues[1] that block the release. After the two issues are resolved, I will start the release. [1] : https://github.com/apache/pulsar/pull/17474 https://github.com/apache/bookkeeper/issues/3466 Regards Jiwei Guo (Tboy) On Fri, Aug 26, 2022 at 10:02 AM guo

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-09-05 Thread Enrico Olivelli
Got it thanks fro the update and also thanks for being so careful in following the issues and we are finding on Pulsar Il giorno lun 5 set 2022 alle ore 13:00 guo jiwei ha scritto: > > Hi dev, > We find two new issues[1] that block the release. > After the two issues are resolved, I will

[GitHub] [pulsar-test-infra] tisonkun commented on pull request #69: Refactor docbot and add tests

2022-09-05 Thread GitBox
tisonkun commented on PR #69: URL: https://github.com/apache/pulsar-test-infra/pull/69#issuecomment-1236972369 @maxsxu Aha, I see your point. @nodece doesn't describe the changes he made despite of refactoring. I read the new code file by file and confirm that the functionality change

Re: [DISCUSS] ARM Support for Pulsar 2.11 Docker Image

2022-09-05 Thread Asaf Mesika
What ended up for this? On Tue, Aug 9, 2022 at 11:11 AM Alexander Preuss wrote: > Hi Michael, > > Thank you for bringing up this topic. > I was just running into an issue that prevented me from using the standard > Pulsar image in Testcontainers and found this discussion. > > In my opinion, refa

[DISCUSS] Changing MetadataStore interface to support configuring cache expiration, fixing bug with leader broker leader election

2022-09-05 Thread Lari Hotari
Hi, There's a bug in Pulsar where a broker loses the leader broker information after 10 minutes. Logs will contain entries such as: WARN org.apache.pulsar.broker.namespace.NamespaceService - The information about the current leader broker wasn't available. Handling load manager decisions in a

[DISCUSS] Pulsar 3.0 - dreaming of the ability to rename objects

2022-09-05 Thread Enrico Olivelli
Hello, Now that we have started to think about Pulsar 3.0, let me share another long standing feature that can be implemented mostly only with such big changes that would deserve a major version bump. Currently every object managed by Pulsar is directly handled and referred using a logical, human

Re: CloudEvents binding requires standard for Pulsar

2022-09-05 Thread Devin Bost
Maybe this is something we could discuss as part of Pulsar 3.0? Seems like there's a pretty big difference between SchemaInfo and CloudEvents in terms of the fields. CloudEvents requires: id: String source: URI-reference specversion: String type: String and optionally: datacontentt

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-09-05 Thread Rajan Dhabalia
Message deduplication always comes with memory and CPU cost and making it default means charging this penalty to every user without having this requirement. Enabling by default means you are impacting every user who is not aware about this feature after upgrading the release. This is purely requir

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-09-05 Thread Dave Fisher
Excellent point Rajan! We had a significant decrease in performance with consumption in 2.8.3 which was not fixed until 2.10.1. Let’s take care to solve problems without surprising users and impacting performance. Best, Dave Sent from my iPhone > On Sep 5, 2022, at 5:11 PM, Rajan Dhabalia w

[DISCUSS] Improvements on the release process

2022-09-05 Thread Yunze Xu
Hi all, I'm working on 2.8.4 release recently. When I followed the release process, I found many steps are outdated so that I turned to the previous release managers for help frequently. Since the release process is now in the codebase [1], I opened a PR for some improvements on it. [2] PTAL espe

Re: [DISCUSS] Improvements on the release process

2022-09-05 Thread Yu
Hi Yunze, Thanks for updating the workflow! ~~ Hi all, For the release process, we've updated the doc-related workflow [1] since we changed the doc maintenance strategy [2]. TL;DR Breaking change: For release managers: from 2.8.x, you do not need to generate an independent doc set for

[GitHub] [pulsar-client-node] hrsakai merged pull request #229: Update C++ client version and compatiblity table to v2.10.1

2022-09-05 Thread GitBox
hrsakai merged PR #229: URL: https://github.com/apache/pulsar-client-node/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsa

Re: [DISCUSS] Pulsar 3.0 - dreaming of the ability to rename objects

2022-09-05 Thread Lari Hotari
I have been thinking of the need for supporting renaming tenants, namespaces and topics while doing some initial design for "Pulsar 3.0 brainstorming: Going beyond PIP-45 Pluggable metadata interface", thread https://lists.apache.org/thread/roohoc9h2gthvmd7t81do4hfjs2gphpk . (the thread doesn't

Re: [VOTE] PIP-195: New bucket based delayed message tracker

2022-09-05 Thread Cong Zhao
Hi, The vote for PIP-195: New bucket based delayed message tracker passed with 3 +1 (binding) and 2 +1 (non-binding). +1 (binding) - Penghui - Jiwei Guo - Enrico Olivelli +1 (non-binding) - Ran Gao - lordcheng Thanks, Cong Zhao On 2022/08/08 06:51:31 Cong Zhao wrote: > Hi Pulsar Community, >

Re: [DISCUSS] Improvements on the release process

2022-09-05 Thread Yunze Xu
Hi Yu, Thanks for your reminder@ Thanks, Yunze > On Sep 6, 2022, at 11:56, Yu wrote: > > Hi Yunze, > > Thanks for updating the workflow! > > ~~ > > Hi all, > > For the release process, we've updated the doc-related workflow [1] since > we changed the doc maintenance strategy [2]