+1 Haiting Jiang <jianghait...@gmail.com> 于2022年8月26日周五 09:52写道:
> +1 > > Thanks, > Haiting > > On Thu, Aug 25, 2022 at 9:52 AM Baodi Shi <baodi....@icloud.com.invalid> > wrote: > > > +1 > > > > Thanks, > > Baodi Shi > > > > > On Aug 24, 2022, at 20:1312, Qiang Huang <qiang.huang1...@gmail.com> > > wrote: > > > > > > +1 > > > > > > Zike Yang <z...@apache.org> 于2022年8月22日周一 15:32写道: > > > > > >> +1 > > >> > > >> Thanks, > > >> Zike Yang > > >> > > >> On Mon, Aug 22, 2022 at 3:16 PM mattison chao < > mattisonc...@apache.org> > > >> wrote: > > >>> > > >>> +1 > > >>> > > >>> Best, > > >>> Mattison > > >>> > > >>> On Fri, 19 Aug 2022 at 01:40, Enrico Olivelli <eolive...@gmail.com> > > >> wrote: > > >>> > > >>>> I agree > > >>>> > > >>>> Enrico > > >>>> > > >>>> Il Gio 18 Ago 2022, 18:23 PengHui Li <peng...@apache.org> ha > scritto: > > >>>> > > >>>>> Hi all, > > >>>>> > > >>>>> When I tried to fix a problem related to replicator > > >>>>> https://github.com/apache/pulsar/pull/17154 > > >>>>> It surprised me that the message deduplication will not work by > > >> default > > >>>>> with the replicator. > > >>>>> I always thought it was enabled for replicators by default. Details > > >> to > > >>>> see > > >>>>> [0]. > > >>>>> > > >>>>> I think we should enable the deduplication for the replicator. > > >> Otherwise, > > >>>>> we will see duplicated > > >>>>> messages on the remote cluster. And the producer of the replicator > > >> always > > >>>>> has a fixed producer > > >>>>> name, this will make the message deduplication work properly. > > >>>>> > > >>>>> The test introduced in https://github.com/apache/pulsar/pull/17154 > > >> will > > >>>>> check the message > > >>>>> replication ordering. Without the message deduplication enabled, > the > > >> test > > >>>>> is flaky with received > > >>>>> duplicated messages. After enabling, everything is fine. > > >>>>> > > >>>>> Best, > > >>>>> Penghui > > >>>>> > > >>>>> [0] > > >> https://github.com/apache/pulsar/pull/17154#discussion_r948736894 > > >>>>> > > >>>> > > >> > > > > > > > > > -- > > > BR, > > > Qiang Huang > > > > >