Re: [DISCUSS] Release Pulsar Client Go 0.15.0

2024-12-24 Thread Jie crossover
+1 -- Best Regards! crossoverJie Zixuan Liu 于2024年12月24日周二 15:32写道: > Hi all, > > I would like to release the Pulsar Client Go 0.15.0. > > https://github.com/apache/pulsar-client-go/milestone/17?closed=1 > > Thanks, > Zixuan >

Re: [DISCUSS] Add Common Integ Test Modules

2024-10-31 Thread Jie crossover
LGTM, the current test code is relatively confusing, and this proposal can improve this situation. -- Best Regards! crossoverJie Heesung Sohn 于2024年11月1日周五 06:16写道: > Hi all, > > I think we can refactor/split the `tests` module(the integration test > module) to reuse the integration test code

Re: [DISCUSS] Removing Pulsar-Trino plugin from main repo and call for volunteers to maintain it

2024-10-18 Thread Jie crossover
Hi lari, I still have some pending PRs, can I just copy them over? https://github.com/apache/pulsar/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen+author%3AcrossoverJie+sql -- Best Regards! crossoverJie Zixuan Liu 于2024年10月18日周五 16:20写道: > Hi lari, > > I can drive the build system and CI setu

Re: [VOTE] PIP-375 Expose the Admin client configs: readTimeout, requestTimeout, and connectionTimeout

2024-08-27 Thread Jie crossover
+1 nonbinding -- Best Regards! crossoverJie Yubiao Feng 于2024年8月28日周三 12:46写道: > Hi all > > I want to start a vote on PIP-375: expose the Admin client configs: > readTimeout, requestTimeout, and connectionTimeout > > Proposal link: https://github.com/apache/pulsar/pull/23222 > Discussion link:

Re: [VOTE] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-08-08 Thread Jie crossover
Thanks, everyone. Close this vote with 3 binding +1s: - Zike Yang - Yunze - Haiting Jiang And 3 non-binding +1: - Tao Jiuming -- Best Regards! crossoverJie Zike Yang 于2024年8月8日周四 18:39写道: > +1 (binding) > > BR, > Zike Yang > > On Thu, Aug 8, 2024 at 9:59 AM Jie

Re: [VOTE] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-08-07 Thread Jie crossover
ckage that is not guaranteed to be stable. > > If you're going to grant the stability guarantee on the `SendCallback` > interface, please add the corresponding `InterfaceStability` > annotation in the implementation PR. > > Thanks, > Yunze > > On Tue, Jul 23, 202

Re: [VOTE] PIP-368: Support lookup based on the lookup properties

2024-08-01 Thread Jie crossover
+1 nonbinding -- Best Regards! crossoverJie Tao Jiuming 于2024年8月1日周四 19:38写道: > +1 nonbinding > > Zike Yang 于2024年8月1日 周四19:08写道: > > > Hi, everyone, > > > > I want to start a vote on PIP-368: Support lookup based on the lookup > > properties > > > > You can find the proposal at > > https://gi

Re: [DISCUSS] PIP-368: Support client properties for the lookup

2024-07-25 Thread Jie crossover
+1 I left some comments in the PR. -- Best Regards! crossoverJie Zike Yang 于2024年7月25日周四 11:15写道: > Hi, all, > > I proposed a new proposal to add client properties support for the > lookup: https://github.com/apache/pulsar/pull/23075 > > PTAL and share your thoughts. Thanks! > > BR, > Zike Yan

Re: [VOTE] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-07-23 Thread Jie crossover
bump -- Best Regards! crossoverJie 太上玄元道君 于2024年7月8日周一 14:24写道: > bump > > Jie crossover 于2024年6月24日周一 10:01写道: > > > Hi, Pulsar Community. > > > > I would like to start the voting thread for PIP-363: Add callbac

Re: [DISCUSS] Release Pulsar Go Client 0.13.0

2024-06-25 Thread Jie crossover
+1 But why do I find that some PRs have already been released in version v0.12.1? https://github.com/apache/pulsar-client-go/pull/1156 -- Best Regards! crossoverJie Zike Yang 于2024年6月26日周三 10:16写道: > Hi everyone, > > I would like to propose releasing the Pulsar Go Client 0.13.0. > > It has be

[VOTE] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-23 Thread Jie crossover
Hi, Pulsar Community. I would like to start the voting thread for PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete. PIP: https://github.com/apache/pulsar/pull/22940 Discussion thread: https://lists.apache.org/thread/8pgmsvx1bxz4z1w8prpvpnfpt1

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-21 Thread Jie crossover
Hi Jiuming, Thank you for fixing this. -- Best Regards! crossoverJie 太上玄元道君 于2024年6月21日周五 17:55写道: > Hi Jie, > > Thanks, so we don't need to fix Skywalking, for OpenTelemetry-javaagent, > I'll create a PR to fix this. > > Jie crossover 于2024年6月21日周五 17:52写道: &g

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-21 Thread Jie crossover
``` > void sendComplete(Exception e, OpSendMsgStats stats); > ``` > > Thanks, > Tao Jiuming > > Jie crossover 于2024年6月21日周五 14:05写道: > > > Hi Jiuming, > > You are right, because the data sent in batches cannot be obtained in the > > current pulsar-client, so when this f

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-20 Thread Jie crossover
emetry/javaagent/instrumentation/pulsar/v2_8/ProducerImplInstrumentation.java > [2] > > https://github.com/dao-jun/skywalking-java/blob/main/apm-sniffer/apm-sdk-plugin/pulsar-common/src/main/java/org/apache/skywalking/apm/plugin/pulsar/common/SendCallbackInterceptor.java > > Thanks, > Tao Jiuming > >

[DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-19 Thread Jie crossover
Hi, Pulsar Community. I have created a PIP to add an `OpSendMsgStats` parameter to the `SendCallback` interface. This will help us implement `messaging.publish.messages` metric. PIP link: https://github.com/apache/pulsar/pull/22940 OpenTelemetry Messaging Metrics link: https://opentelemetry.io/do

Re: [DISCUSS] Plan for Pulsar Go Client 1.0.0

2024-04-01 Thread Jie crossover
Greet plan. > We maintain two versions of the API, but they could share the same > internal code. I don't think this will add much complexity. I agree with this. BTW, there is another issue that needs to be considered. https://github.com/apache/pulsar-client-go/issues/919 -- Best Regards! cros

Re: [DISCUSS] PIP-334:Create a new admin API: pck (Pulsar Consistency Checker)

2024-02-06 Thread Jie crossover
dmin API? > My main concern is this method may run for quite a while. And it's not > easy to see the progress if it's implemented on the server. > > Thanks, > Haiting > > On Tue, Jan 30, 2024 at 6:50 PM Jie crossover > wrote: > > > > Hi dev,

[DISCUSS] PIP-334:Create a new admin API: pck (Pulsar Consistency Checker)

2024-01-30 Thread Jie crossover
Hi dev, I proposed a PIP: https://github.com/apache/pulsar/pull/21988 Sometimes we need to check if there are any orphan ledgers in the bookkeeper. So I'm planning to create an admin API. Specific implementation logic is referred to in this link

Re: [DISCUSS] PIP-328: Add a topicDeleteProtectionEnable configuration option.

2023-12-27 Thread Jie crossover
 PM Yubiao Feng > wrote: > > > Hi Jie > > > > Maybe a limitation of Authorization permissions is better? > > > > Thanks > > Yubiao Feng > > > > On Mon, Dec 25, 2023 at 7:05 PM Jie crossover > > wrote: > > > > > Hi dev, > > &

[DISCUSS] PIP-328: Add a topicDeleteProtectionEnable configuration option.

2023-12-25 Thread Jie crossover
Hi dev, I proposed a PIP: https://github.com/apache/pulsar/pull/21800 to avoid mistaken data deletion. Please take a look and give your feedback. -- Best Regards! crossoverJie

Re: [VOTE] PIP-303: Add optional parameters for getPartitionedStats

2023-11-19 Thread Jie crossover
Close the vote with 3+ (binding): Yunze Jiwei Yubiao -- Best Regards! crossoverJie Yubiao Feng 于2023年11月20日周一 10:47写道: > +1 (binding) > > Thanks > Yubiao Feng > > On Thu, Nov 16, 2023 at 11:01 AM Jie crossover > wrote: > > > Hi All, This thread is to start a vo

[VOTE] PIP-303: Add optional parameters for getPartitionedStats

2023-11-15 Thread Jie crossover
Hi All, This thread is to start a vote for PIP-303. PIP: https://github.com/apache/pulsar/pull/21228 Discussion thread: https://lists.apache.org/thread/c92043zq6lyrsd5z1hnln48mx858n7vj -- Best Regards! crossoverJie

[DISCUSS] PIP-316 Create a producerName field for DeadLetterPolicy

2023-11-08 Thread Jie crossover
Hi dev, I proposed a PIP: https://github.com/apache/pulsar/pull/21507 to create a producerName for DeadLetterPolicy. Please take a look and give your feedback. -- Best Regards! crossoverJie

[DISCUSS] PIP-303 Add optional parameters for getPartitionedStats

2023-09-21 Thread Jie crossover
Hi dev, I proposed a PIP: https://github.com/apache/pulsar/pull/21228, to add optional parameters to `getPartitionedStats` to determine whether to return publishers and subscriptions data. Please take a look and give your feedback. -- Best Regards! crossoverJie

[DISCUSS] Add metrics related interfaces for BrokerInterceptor

2023-07-16 Thread Jie crossover
Hi pulsar community, I have created an issue to discuss the observability of BrokerInterceptor. The issue link: https://github.com/apache/pulsar/issues/20772 Thanks. -- Best Regards! crossoverJie

Re: [DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread Jie crossover
etter to leave it to user handle. We try not to add APIs > that > > users can handle themselves. And I don't think there are many scenarios > > using this API, which brings about higher complexity. I tend to add a new > > interface beforeClose() in ConsumerInterceptor to allo

[DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread Jie crossover
Hi, pulsar community, I’ve opened a PIP to discuss: PIP-227: New API for closing the consumer after waiting for the job to complete. The PIP link: https://github.com/apache/pulsar/issues/18799 Thanks. -- Best Regards! crossoverJie