LGTM, the current test code is relatively confusing, and this proposal can improve this situation. -- Best Regards! crossoverJie
Heesung Sohn <hees...@apache.org> 于2024年11月1日周五 06:16写道: > Hi all, > > I think we can refactor/split the `tests` module(the integration test > module) to reuse the integration test code better. > > Currently, there are good test classes to reuse(such as topic message > test cases, container setup, and other test util funcs), but this > module is built under "test" scope only, making it hard to reuse in > other projects. > > I propose the following module structure. > > `tests` : contains actual integ test runners built under test > scope(e.g. test-ng test classes, depending on `pulsar-inttest-lib, > `pulsar-inttest-client` and other modules) > > `pulsar-inttest-lib` : contains common test libraries(test-utils, test > containers, and other sharable integ test setups) > > `pulsar-inttest-client` : contains common integ-test client cases (it > should contain only client side test logic, depending on PulsarClient > and PulsarAdmin). These test cases can be used in `tests`. > > I am looking forward to your feedback. > > Thanks, > Heesung >