Re: [DISCUSS] PIP-242 Topic name restrictions

2023-02-16 Thread Enrico Olivelli
Mattison, Il giorno gio 16 feb 2023 alle ore 00:27 ha scritto: > > > I am sorry but I am not sure that this is enough to preventreads/writes > > from unallowed clients. > IMO, We can consider the authorisation part in another PIP because We are > just focusing on adding the topic name constrain

Re: [DISCUSS] PIP-242 Topic name restrictions

2023-02-16 Thread Enrico Olivelli
Il giorno gio 16 feb 2023 alle ore 14:39 Asaf Mesika ha scritto: > > On Wed, Feb 15, 2023 at 4:36 PM wrote: > > > Hi, All > > > > First of all, I want to list all of the system topics as follows. That > > Yunze has mentioned before. > > > > Namespace level: > > > > • pulsar/system > > • trans

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Zixuan Liu
Hi Zhangjian, This is a good idea to write the admin client by golang, but I don't suggest add the admin features to pulsar-go-client, it's better to use a new repository to do that to separate dependencies. BTW, StreamNative has a pulsarctl [0] tool, which includes the admin api. > > It's bett

Re: [VOTE][PIP-240] A new API to unload subscriptions

2023-02-16 Thread Yubiao Feng
The PIP passes with 3 bindings +1: Bo Cong, Jiwei Guo, and Haiting Jiang. I will start working, Please help to move to the wiki. Thanks Yubiao Feng On Tue, Feb 14, 2023 at 10:21 AM Haiting Jiang wrote: > +1 binding > > > Thanks > Haiting > > On Mon, Feb 13, 2023 at 10:27 AM 丛搏 wrote: > > > > +1

Re: Inconsistent GPG keys in dev and release repositories

2023-02-16 Thread Zike Yang
Hi, Yunze I think the KEYS file in the release repo is necessary. They are both used to verify the release file. Otherwise, the user will fail when checking the GPG signature on the release file. BR, Zike Yang On Fri, Feb 17, 2023 at 2:16 PM Yunze Xu wrote: > > Hi all, > > I found the GPG keys,

Inconsistent GPG keys in dev and release repositories

2023-02-16 Thread Yunze Xu
Hi all, I found the GPG keys, which are used in verifying the signatures of release candidates, are much different in dev and release repositories: https://dist.apache.org/repos/dist/dev/pulsar/KEYS https://dist.apache.org/repos/dist/release/pulsar/KEYS >From here [1], it seems like we need to ap

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
Separating dependencies is better. For example, I think Pulsar-admin-go can only have golang standard tls and http dependencies. But it seems impossible to have two go modules when publishing packages using github. > Has anyone tried generating an admin client from our generated open api spec? I

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
> I notice that the Java Client and the Java Admin Client are separate dependencies. Is this boundary important to maintain for other language admin clients? IMO, separating them is better to maintain. I had an idea to implement a pure C implementation of the Pulsar admin API. Only libcurl and ope

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
> I have a point of concern, but for a small HTTP interaction, it's probably > too many layers of encapsulation. It makes sense to me. Then I agree to go head for an independent API implementation. Thanks, Yunze On Fri, Feb 17, 2023 at 11:32 AM ZhangJian He wrote: > > > It's better to reuse ex

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Michael Marshall
I think it would be valuable to have admin clients in many languages. Has anyone tried generating an admin client from our generated open api spec? I notice that the Java Client and the Java Admin Client are separate dependencies. Is this boundary important to maintain for other language admin cli

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
> It's better to reuse existing code rather than reinventing the wheel. No objection. > I didn't mean using pulsarctl directly. We only need to wrap the provided API from pulsarctl and provide our own public API in pulsar-client-go. It works, I have a point of concern, but for a small HTTP interact

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
It's better to reuse existing code rather than reinventing the wheel. I didn't mean using pulsarctl directly. We only need to wrap the provided API from pulsarctl and provide our own public API in pulsar-client-go. Thanks, Yunze On Fri, Feb 17, 2023 at 10:48 AM ZhangJian He wrote: > > > It does

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
> It does not make sense to me. Why cannot add it as a dependency? I am not saying it can't. Of course, adding pulsarctl as a dependency is possible. I also recommended this repository in https://github.com/apache/pulsar-client-go/issues/842. I think incorporating the functionality of the HTTP adm

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
Just saw the mail after the PR. > Pulsarctl is not an apache official repository net It does not make sense to me. Why cannot add it as a dependency? Thanks, Yunze On Fri, Feb 17, 2023 at 10:16 AM ZhangJian He wrote: > > Pulsarctl is not an apache official repository net, and given the > popul

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
Pulsarctl is not an apache official repository net, and given the popularity of operators and Go-based dev-ops-tools, would it be possible to consider merging some of the functionalities of pulsarctl into pulsar-client-go Thanks ZhangJian He On Fri, 17 Feb 2023 at 10:00, PengHui Li wrote: > Th

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread PengHui Li
The pulsarctl is an admin CLI tool for Pulsar, written in go. Does it match your requirement? Penghui > On Feb 17, 2023, at 09:47, ZhangJian He wrote: > > I would like to express that the current Pulsar client for Go > (pulsar-client-go) is missing the pulsar Admin API. As such, I would like >

Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
I would like to express that the current Pulsar client for Go (pulsar-client-go) is missing the pulsar Admin API. As such, I would like to propose that we work towards adding this feature to pulsar-client-go. I believe that this new feature would be a valuable addition to pulsar-client-go, and I a

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-16 Thread Baodi Shi
+1 (non-binding) Thanks, Baodi Shi 在 2023年2月16日 21:44:17 上,Asaf Mesika 写道: > +1 (non-binding) > > > On Thu, Feb 16, 2023 at 11:11 AM Jiuming Tao > > wrote: > > > I’ve added the `Compatibility` selection into the PIP, please help review > > and vote the PIP > > > Thanks, > > Tao Jiuming > > >

Re: Force redirect questions from Slack to GitHub Discussions or StackOverflow?

2023-02-16 Thread Kiryl Valkovich
Played with Slack and StackOverflow APIs a bit. The Slack API works as expected. After clicking the message button, it sends a message descriptor to my app where I can do anything with its content. It’s possible to post messages via the StackOverflow API, but it’s unlikely that any Slack messag

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-16 Thread Yan Zhao
> If understood correctly, every broker will have a consumer right? You will > use a fail-over subscription? The retry-topic is consumed by the same > subscription, same consumer? Yes, you are right, there is the case you mention. The deletion is idempotent, I'm not sure if it's worth making it sy

Re: [DISCUSS] Using jetty-client instead of async-http-client

2023-02-16 Thread Asaf Mesika
Oh. I looked at the commits, it seems pretty active to me. On Thu, Feb 16, 2023 at 3:31 PM Zixuan Liu wrote: > I point to async-http-client. > > Although there is a recent update. > > Thanks, > Zixuan > > Asaf Mesika 于2023年2月16日周四 21:19写道: > > > On Tue, Feb 14, 2023 at 11:36 AM Zixuan Liu wro

Re: Force redirect questions from Slack to GitHub Discussions or StackOverflow?

2023-02-16 Thread Asaf Mesika
+1 Funny thing is that I was thinking just this morning that Slack's biggest downside is that it is not searchable, hence although you get that personal touch by instant messaging people, and the answers can be quicker, the unsearchable is a big issue. On Thu, Feb 16, 2023 at 2:33 PM Kiryl Valkov

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-16 Thread Asaf Mesika
+1 (non-binding) On Thu, Feb 16, 2023 at 11:11 AM Jiuming Tao wrote: > > I’ve added the `Compatibility` selection into the PIP, please help review > and vote the PIP > > Thanks, > Tao Jiuming > > > > > 2023年2月15日 14:58,Zike Yang 写道: > > > > Hi, Jiuming > > > >> bump > > > > As for the discussi

Re: [DISCUSS] PIP-242 Topic name restrictions

2023-02-16 Thread Asaf Mesika
On Wed, Feb 15, 2023 at 4:36 PM wrote: > Hi, All > > First of all, I want to list all of the system topics as follows. That > Yunze has mentioned before. > > Namespace level: > > • pulsar/system > • transaction_coordinator_assign > • __transaction_log_ > • resource-usage > • pulsar/ >

Re: [DISCUSS] Using jetty-client instead of async-http-client

2023-02-16 Thread Zixuan Liu
I point to async-http-client. Although there is a recent update. Thanks, Zixuan Asaf Mesika 于2023年2月16日周四 21:19写道: > On Tue, Feb 14, 2023 at 11:36 AM Zixuan Liu wrote: > > > Hi all, > > > > Our admin-client using the async-http-client [0] to request the web > > service, the async-http-client

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-16 Thread Asaf Mesika
Regarding "+1 to throw this exception in future versions." - this means you complete this issue once it throws an exception right? On Wed, Feb 15, 2023 at 8:54 AM Zike Yang wrote: > > if we change the default > subscription mode to be non-durable for non-persistent topics, then what > will happ

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-16 Thread Asaf Mesika
On Tue, Feb 14, 2023 at 1:02 PM Yan Zhao wrote: > > Shouldn't you specify the changes you are going to make in > > `PulsarApi.proto`? > We didn't change the proto file, we use the Restful API(AdminAPI). > > Also, shouldn't you change the wording in this sentence in the PIP to > > clarify you will

Re: [DISCUSS] Using jetty-client instead of async-http-client

2023-02-16 Thread Asaf Mesika
On Tue, Feb 14, 2023 at 11:36 AM Zixuan Liu wrote: > Hi all, > > Our admin-client using the async-http-client [0] to request the web > service, the async-http-client implements network request based on the > netty, which has very good performance, but this project is not very > active. > Netty -

Re: Force redirect questions from Slack to GitHub Discussions or StackOverflow?

2023-02-16 Thread Kiryl Valkovich
If there are no hidden obstacles, we can implement it. StackOverflow supports question creation using REST API: https://api.stackexchange.com/docs/create-question From: Zike Yang Date: Thursday, February 16, 2023 at 11:41 AM To: dev@pulsar.apache.org Subject: Re: Force redirect questions from S

Re: [DISCUSS] Switch the client complier to JDK 11 or 17 from JDK 8

2023-02-16 Thread Zixuan Liu
Hi all, Thank you for your suggestion! Close this discussion now. Thanks, Zixuan Enrico Olivelli 于2023年2月16日周四 18:19写道: > -1 > We should still stick to JDK8 for a while on the client side (and > shared modules). > > I see that slowly the ecosystem is moving di JDK11, but it is not yet our > ti

Re: Force redirect questions from Slack to GitHub Discussions or StackOverflow?

2023-02-16 Thread Zike Yang
+1, That sounds great to me. > 2. You click the three dots button on his message -> “Convert to a GitHub > discussion”. Is it a similar workflow for converting to a StackOverflow question? BR, Zike Yang On Thu, Feb 16, 2023 at 12:14 PM wrote: > > +1 > > Since web pages are more easily and pub

Re: [DISCUSS] Switch the client complier to JDK 11 or 17 from JDK 8

2023-02-16 Thread Enrico Olivelli
-1 We should still stick to JDK8 for a while on the client side (and shared modules). I see that slowly the ecosystem is moving di JDK11, but it is not yet our time. This year is Pulsar momentum, please do not add blockers to the adoption Enrico Il giorno gio 16 feb 2023 alle ore 09:39 Horizo

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-16 Thread Jiuming Tao
I’ve added the `Compatibility` selection into the PIP, please help review and vote the PIP Thanks, Tao Jiuming > 2023年2月15日 14:58,Zike Yang 写道: > > Hi, Jiuming > >> bump > > As for the discussion here[0], could you add a `Compatibility` section > to talk about compatibility in more detai

Re: [DISCUSS] Switch the client complier to JDK 11 or 17 from JDK 8

2023-02-16 Thread Horizon
-1. We could know the user dependency. Maybe the user dependent the third lib is not compatible with 11 or 17. It will introduce some problem for user. And the user need to pay more effort to test the project compatibility after upgrade the client. >> Hi all, >> >> We are using JDK 17 to comp

Re: [DISCUSS] Switch the client complier to JDK 11 or 17 from JDK 8

2023-02-16 Thread mattisonchao
-1 The reason is the same as Yunze mentioned. It's a kind of break for the user. We can't force our user upgrade the application JDK version by pulsar's bug. That will make our users frustrated. Plus, the pulsar LTS is 3.0. I think it's better to keep the JDK 1.8 in this version. as users will