On Tue, Feb 14, 2023 at 1:02 PM Yan Zhao <horizo...@apache.org> wrote:
> > Shouldn't you specify the changes you are going to make in > > `PulsarApi.proto`? > We didn't change the proto file, we use the Restful API(AdminAPI). > > Also, shouldn't you change the wording in this sentence in the PIP to > > clarify you will use AdminAPI / Pulsar RPC? > We use AdminAPI, I will tune the pip. > > > > > > You need to specify in the PIP that you will publish one message for > > deletion from BK, and one message for deletion of from offloader and > > explain why. Also provide the context you just gave me about where you > find > > if it is actually offloaded or not. > Ok. > > > Let me see if I understand correctly. Now the PIP says: > > > > private MLDataFormats.ManagedLedgerInfo.LedgerInfo context; > > > > and you say it should be: > > > > private MLDataFormats.ManagedLedgerInfo.LedgerInfo.OffloadContext > > offloadContext; > > > > ? > Yes. > > > > > > In that case I'm not sure I understand the need for > > > > /** > > * Extent properties. > > */ > > private Map<String, String> properties = new HashMap<>(); > > > > It can be removed. > > > Not just the title, your PIP needs to explain everything we wrote above > > about trim. > > I know, and I will tune the PIP contents. > > > Ok, say you only delete from ZK in the first step. Still what I wrote > above > > still applies: You might have 2 messages trying to delete same ledger at > > the same time. Shouldn't this have a lock to protect against it? > > We design that the consumer only handles one message at the same time, > which can ensure sync. > If understood correctly, every broker will have a consumer right? You will use a fail-over subscription? The retry-topic is consumed by the same subscription, same consumer? In this very long mailing list thread, we have mentioned many fixes to be done. Can you ping in the mailing list once you have managed to fix it all?
