kiwiwings commented on pull request #207:
URL: https://github.com/apache/poi/pull/207#issuecomment-751723263
Replaced commons-logging.jar with jcl-over-SLF4J and actually used the
slf4j-simple artifact - applied via SVN release 1884873
-
asfgit closed pull request #211:
URL: https://github.com/apache/poi/pull/211
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
centic9 commented on pull request #211:
URL: https://github.com/apache/poi/pull/211#issuecomment-752691804
Applied via r1884948 in a slightly different way to use the same approach
across two similar code-places.
This is an
artragis opened a new pull request #213:
URL: https://github.com/apache/poi/pull/213
This API uses XSSFColor built with alpha channel to set up the right value.
We must take care of the fact Excel uses 1000th of percent and positive
numbers
-
artragis closed pull request #213:
URL: https://github.com/apache/poi/pull/213
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
artragis opened a new pull request #214:
URL: https://github.com/apache/poi/pull/214
This API uses XSSFColor built with alpha channel to set up the right value.
We must take care of the fact Excel uses 1000th of percent and positive
numbers
-
pjfanning commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551555862
##
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##
@@ -863,6 +864,41 @@ private boolean
fetchParagraphProperty(ParagraphPro
artragis commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551569055
##
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##
@@ -863,6 +864,41 @@ private boolean
fetchParagraphProperty(ParagraphProp
pjfanning commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551570755
##
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##
@@ -863,6 +864,41 @@ private boolean
fetchParagraphProperty(ParagraphPro
artragis commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551577785
##
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##
@@ -863,6 +864,41 @@ private boolean
fetchParagraphProperty(ParagraphProp
pjfanning commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551579754
##
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##
@@ -863,6 +864,41 @@ private boolean
fetchParagraphProperty(ParagraphPro
artragis commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551584317
##
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##
@@ -863,6 +864,41 @@ private boolean
fetchParagraphProperty(ParagraphProp
cor3000 opened a new pull request #215:
URL: https://github.com/apache/poi/pull/215
improves parseDouble performance by about 85%-90%
10 invocations
before ~230ms
after ~28ms (using a precompiled regex)
I am not sure how to add a meaningful performance unit test for thi
manuel-buchner opened a new pull request #216:
URL: https://github.com/apache/poi/pull/216
Am I wrong or did a copy / paste error occur?
This is an automated message from the Apache Git Service.
To respond to the message, ple
asfgit closed pull request #215:
URL: https://github.com/apache/poi/pull/215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
pjfanning commented on pull request #215:
URL: https://github.com/apache/poi/pull/215#issuecomment-762280392
Thanks. Merged with 06ea5ad
Will appear in v5.0.1 release
This is an automated message from the Apache Git Servic
valfirst opened a new pull request #217:
URL: https://github.com/apache/poi/pull/217
Gradle Wrapper was not upgraded properly. See details:
https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper
pjfanning commented on pull request #217:
URL: https://github.com/apache/poi/pull/217#issuecomment-762386835
I updated to gradle 6.8 and ran `./gradlew wrapper` and committed the changes
This is an automated message from the
valfirst closed pull request #217:
URL: https://github.com/apache/poi/pull/217
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
valfirst commented on pull request #217:
URL: https://github.com/apache/poi/pull/217#issuecomment-762389899
Superseded by ab90b2b4534cd700ebdf7f37d683ac5bb9c78fcc
This is an automated message from the Apache Git Service.
To r
valfirst opened a new pull request #218:
URL: https://github.com/apache/poi/pull/218
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
valfirst commented on pull request #217:
URL: https://github.com/apache/poi/pull/217#issuecomment-762392090
@pjfanning to make sure Gradle Wrapper is updated properly it's needed to
run `gradle wrapper` once or `./gradlew wrapper` twice. I've opened a new PR to
align the versions: https://
pjfanning commented on pull request #218:
URL: https://github.com/apache/poi/pull/218#issuecomment-762397534
Thanks, my mistake. Loaded
https://github.com/apache/poi/commit/c67b26c138f93ac03f90d52e5c71eaa72e366fec
This is an
valfirst closed pull request #218:
URL: https://github.com/apache/poi/pull/218
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
valfirst opened a new pull request #219:
URL: https://github.com/apache/poi/pull/219
See: https://github.com/gradle/wrapper-validation-action
This is an automated message from the Apache Git Service.
To respond to the message
Alain-Bearez opened a new pull request #220:
URL: https://github.com/apache/poi/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Alain-Bearez opened a new pull request #221:
URL: https://github.com/apache/poi/pull/221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
kiwiwings commented on pull request #221:
URL: https://github.com/apache/poi/pull/221#issuecomment-763112086
Thank you for providing a fix so fast - applied via release 1885699 with an
additional test
This is an automated me
Alain-Bearez closed pull request #221:
URL: https://github.com/apache/poi/pull/221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez commented on pull request #220:
URL: https://github.com/apache/poi/pull/220#issuecomment-763159647
applied with r1885700
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez closed pull request #220:
URL: https://github.com/apache/poi/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez commented on pull request #201:
URL: https://github.com/apache/poi/pull/201#issuecomment-764947548
applied with r1885771
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez closed pull request #201:
URL: https://github.com/apache/poi/pull/201
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez closed pull request #201:
URL: https://github.com/apache/poi/pull/201
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez commented on pull request #201:
URL: https://github.com/apache/poi/pull/201#issuecomment-764947548
applied with r1885771
This is an automated message from the Apache Git Service.
To respond to the message, please
centic9 commented on pull request #216:
URL: https://github.com/apache/poi/pull/216#issuecomment-766019416
Related bug-report: https://bz.apache.org/bugzilla/show_bug.cgi?id=65099
This is an automated message from the Apache
Alain-Bearez opened a new pull request #222:
URL: https://github.com/apache/poi/pull/222
Also small changes in examples code to avoid bug reports.
This is an automated message from the Apache Git Service.
To respond to the me
Alain-Bearez closed pull request #222:
URL: https://github.com/apache/poi/pull/222
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez commented on pull request #222:
URL: https://github.com/apache/poi/pull/222#issuecomment-766423126
applied with r1885886
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez commented on pull request #222:
URL: https://github.com/apache/poi/pull/222#issuecomment-766423126
applied with r1885886
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez closed pull request #222:
URL: https://github.com/apache/poi/pull/222
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
centic9 commented on pull request #216:
URL: https://github.com/apache/poi/pull/216#issuecomment-770262005
Applied via via r1886063,
https://github.com/apache/poi/commit/caf2d32393f6179673a615e9f0db5ef06956654e
now
This is
Alain-Bearez opened a new pull request #223:
URL: https://github.com/apache/poi/pull/223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Alain-Bearez closed pull request #223:
URL: https://github.com/apache/poi/pull/223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez commented on pull request #223:
URL: https://github.com/apache/poi/pull/223#issuecomment-770487905
Applied with r1886087
This is an automated message from the Apache Git Service.
To respond to the message, please
MariusVolkhart opened a new pull request #224:
URL: https://github.com/apache/poi/pull/224
Hi devs! Here is iteration 1 of switching the logging to be entirely based
on Log4j 2 and removing `POILogger` & co. It would be helpful if you could try
this out in your workflows (running/analyzing
MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567910736
##
File path: build.xml
##
@@ -289,7 +288,7 @@ under the License.
-
+
Review comment:
We could keep using `slf4j-simple
pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567934075
##
File path: build.xml
##
@@ -289,7 +288,7 @@ under the License.
-
+
Review comment:
best to drop slf4j if log4j2 is what w
pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567935392
##
File path: osgi/pom.xml
##
@@ -104,7 +103,8 @@
commons-math3,
commons-compress,
pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567936892
##
File path: build.gradle
##
@@ -437,6 +439,7 @@ project('scratchpad') {
compile project(':main')
compile "commons-codec:commons-codec:${co
centic9 commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r568637101
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
Is there a way to move the two xml-configuration files away from the
root-direct
MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r569002478
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
> Is there a way to move the two xml-configuration files away from the
ro
MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r569002478
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
> Is there a way to move the two xml-configuration files away from the
ro
centic9 commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r568637101
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
Is there a way to move the two xml-configuration files away from the
root-direct
MariusVolkhart opened a new pull request #225:
URL: https://github.com/apache/poi/pull/225
Hey Devs, I'd appreciate a review of the following code for any obvious
flaws you see with this approach of enabling picture editing in
`HSLFPictureData`. In my initial testing I haven't seen any iss
kiwiwings commented on pull request #225:
URL: https://github.com/apache/poi/pull/225#issuecomment-774511158
Hi Marius,
I've just quickly browsed the changes.
Maybe we should add a small testcase with encryption enabled, i.e. create
encrypted hslf with an image > save/reopen > add / e
asfgit closed pull request #219:
URL: https://github.com/apache/poi/pull/219
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
MariusVolkhart commented on pull request #219:
URL: https://github.com/apache/poi/pull/219#issuecomment-774654713
@valfirst Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please l
manuel-buchner closed pull request #216:
URL: https://github.com/apache/poi/pull/216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
manuel-buchner commented on pull request #216:
URL: https://github.com/apache/poi/pull/216#issuecomment-774664959
Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Alain-Bearez opened a new pull request #226:
URL: https://github.com/apache/poi/pull/226
This was a low hanging fruit which I neglected for too long.
This is an automated message from the Apache Git Service.
To respond to the
Alain-Bearez commented on pull request #226:
URL: https://github.com/apache/poi/pull/226#issuecomment-775436892
Applied with r1886338
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez closed pull request #226:
URL: https://github.com/apache/poi/pull/226
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez opened a new pull request #227:
URL: https://github.com/apache/poi/pull/227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
MariusVolkhart commented on pull request #225:
URL: https://github.com/apache/poi/pull/225#issuecomment-776197161
@kiwiwings I added a test. It uses a premade encrypted slideshow, but
otherwise does what you described.
This
MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r569002478
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
> Is there a way to move the two xml-configuration files away from the
ro
MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r574903527
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
@centic9 I took a stab at moving the logging configs to be more how a
pro
centic9 commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r575051285
##
File path: log4j2-console.xml
##
@@ -0,0 +1,42 @@
+
Review comment:
Thanks for the effort, to me it looks clearer this way as it makes it
easy to se
Alain-Bearez closed pull request #227:
URL: https://github.com/apache/poi/pull/227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Alain-Bearez commented on pull request #227:
URL: https://github.com/apache/poi/pull/227#issuecomment-780188917
Applied with r1886605
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez opened a new pull request #228:
URL: https://github.com/apache/poi/pull/228
This should implement the feature requested some months ago on
https://pt.stackoverflow.com/questions/472162/mudar-a-cor-de-apenas-uma-das-barras-colunas-do-gr%c3%a1fico-gerado-no-pptx-apache
-
Alain-Bearez commented on pull request #228:
URL: https://github.com/apache/poi/pull/228#issuecomment-780885560
Applied with r1886642
This is an automated message from the Apache Git Service.
To respond to the message, please
Alain-Bearez closed pull request #228:
URL: https://github.com/apache/poi/pull/228
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kiwiwings commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782765896
When is this applied to SVN?
I'd like to change to Log4j 2 also on XmlBeans too, but I think this makes
only sense, when POI is already migrated.
---
MariusVolkhart commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782766136
I was waiting for 5.0.1 to be released, but I can commit this to SVN this
weekend.
On Sun, Feb 21, 2021, 00:37 Andreas Beeker wrote:
> When is this applied to S
kiwiwings commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782771057
SLF4J is missing in XmlBeans module-info, but it's used. So we might want to
release a new version there anyway, i.e. before POI 5.0.1.
And if the logging matches that would make
pjfanning commented on pull request #224:
URL: https://github.com/apache/poi/pull/224#issuecomment-782771632
@kiwiwings the logging in xmlbeans is minimal and the slf4j was only added
recently by me - since the last release so it could be replaced by log4j2x
without any major impact - if w
asfgit closed pull request #224:
URL: https://github.com/apache/poi/pull/224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
asfgit closed pull request #225:
URL: https://github.com/apache/poi/pull/225
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
MariusVolkhart closed pull request #210:
URL: https://github.com/apache/poi/pull/210
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MariusVolkhart closed pull request #209:
URL: https://github.com/apache/poi/pull/209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MariusVolkhart commented on pull request #209:
URL: https://github.com/apache/poi/pull/209#issuecomment-787563131
@centic9 No, we have not seen these as hotspots. Just things I come across
as I'm becoming more familiar with the internals. Closing this as it was part
of https://github.com/a
centic9 commented on pull request #209:
URL: https://github.com/apache/poi/pull/209#issuecomment-788094928
It's fine, "new ByteArrayOutputStream(int size)" would allow to populate
the stream without additional allocation, but toByteArray() performs a full
array-copy again, so doing it our
aschott-looker opened a new pull request #229:
URL: https://github.com/apache/poi/pull/229
* Negative numbers do not work as expected if they are used in the
conditional part of a format string. For example, using `[<-10]#" Wow"` will
blow up (poi thinks it is an elapsed time format).
*
centic9 commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-793544990
The included test-file seems to be an empty file, is this intended?
This is an automated message from the Apache Git S
aschott-looker commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-794250839
It's an XLSX file. GitHub can't render the diff.
This is an automated message from the Apache Git Service.
To r
MariusVolkhart opened a new pull request #230:
URL: https://github.com/apache/poi/pull/230
Batik-all is a strange artifact. It's POM declares dependencies on all the
sub-JARs, but its JAR has all of the sub-jars repackaged. This results in two
JARs with the package "org.apache.batik.transc
MariusVolkhart opened a new pull request #231:
URL: https://github.com/apache/poi/pull/231
PR to make sure GitHub Action completes
This is an automated message from the Apache Git Service.
To respond to the message, please lo
asfgit closed pull request #230:
URL: https://github.com/apache/poi/pull/230
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
MariusVolkhart closed pull request #231:
URL: https://github.com/apache/poi/pull/231
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aschott-looker commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-801317185
@centic9 -- Any thoughts on this change/estimation on when this would be
available in a new POI release? We are relying on this functionality working
and it would be great to n
aschott-looker edited a comment on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-801317185
@centic9 -- Any thoughts on this change/estimation on when this would be
available in a new POI release? We are trying to transition from
https://github.com/SheetJS/ssf
centic9 commented on pull request #229:
URL: https://github.com/apache/poi/pull/229#issuecomment-802695291
Applied to trunk via
https://svn.apache.org/viewvc?view=revision&revision=1887802 but I cannot state
when exactly this will be released, as the developer community did not decide
ful
asfgit closed pull request #229:
URL: https://github.com/apache/poi/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
sboe0705 opened a new pull request #232:
URL: https://github.com/apache/poi/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
sboe0705 closed pull request #232:
URL: https://github.com/apache/poi/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
sboe0705 commented on pull request #232:
URL: https://github.com/apache/poi/pull/232#issuecomment-803255797
Wrong pull request direction! :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tobiasstadler opened a new pull request #233:
URL: https://github.com/apache/poi/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
asfgit closed pull request #233:
URL: https://github.com/apache/poi/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
pjfanning commented on pull request #233:
URL: https://github.com/apache/poi/pull/233#issuecomment-806494563
Thanks - merged with the other changes needed for this upgrade -
https://github.com/apache/poi/commit/226ae7245895f34eca39a252e673349d5becfa5a
--
This is an automated message from
1 - 100 of 1012 matches
Mail list logo
