MariusVolkhart commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567910736
##########
File path: build.xml
##########
@@ -289,7 +288,7 @@ under the License.
<dependency prefix="main.byte-buddy"
artifact="net.bytebuddy:byte-buddy:1.10.19" usage="main-tests"/>
<dependency prefix="main.byte-buddy-agent"
artifact="net.bytebuddy:byte-buddy-agent:1.10.19" usage="main-tests"/>
<dependency prefix="main.objenesis" artifact="org.objenesis:objenesis:3.1"
usage="main-tests"/>
- <dependency prefix="main.slf4j-simple"
artifact="org.slf4j:slf4j-simple:1.7.30" usage="main-tests"/>
+ <dependency prefix="main.log4j-core"
artifact="org.apache.logging.log4j:log4j-core:2.14.0" usage="main-tests"/>
Review comment:
We could keep using `slf4j-simple`, but would need to add an additional
"bridge" dependency
##########
File path: log4j2-console.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<Configuration status="WARN" name="console">
+ <Appenders>
+ <Console name="Console" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d [%t] %-5p %c - %m%n" />
+ </Console>
+ </Appenders>
+ <Loggers>
+ <Logger name="org.apache.poi.poifs.nio.FileBackedDataSource" level="ERROR"
/>
+ <Logger name="org.apache.poi.hdgf.chunks.Chunk" level="FATAL" />
+ <Logger name="org.apache.poi.hpsf.CodePageString" level="ERROR" />
+ <Logger name="org.apache.poi.hdgf.chunks.ChunkFactory" level="ERROR" />
+ <Logger name="org.apache.poi.hslf.model.textproperties.BitMaskTextProp"
level="ERROR" />
+ <Logger name="org.apache.poi.hslf.usermodel.HSLFTextParagraph"
level="ERROR" />
+ <Logger name="org.apache.poi.openxml4j.opc.ZipPackage" level="ERROR" />
+ <Logger name="org.apache.poi.POIDocument" level="WARN" />
+ <Logger name="org.apache.poi.openxml4j.opc.OPCPackage" level="ERROR" />
+ <Logger name="org.apache.poi.xssf.usermodel.XSSFWorkbook" level="ERROR" />
+ <Logger name="org.apache.poi.hslf.usermodel.HSLFGroupShape" level="WARN" />
+ <Logger name="org.apache.poi.hslf.record.Record" level="ERROR" />
Review comment:
These logger/level pairs are an aggregation of various logging files I
saw
##########
File path: legal/LICENSE
##########
@@ -285,29 +285,9 @@ CurvesAPI / Curve API
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-SLF4J library (slf4j-api-*.jar)
+Log4j 2 library (log4j-api-*.jar)
- Copyright (c) 2004-2017 QOS.ch
- All rights reserved.
-
- Permission is hereby granted, free of charge, to any person obtaining
- a copy of this software and associated documentation files (the
- "Software"), to deal in the Software without restriction, including
- without limitation the rights to use, copy, modify, merge, publish,
- distribute, sublicense, and/or sell copies of the Software, and to
- permit persons to whom the Software is furnished to do so, subject to
- the following conditions:
-
- The above copyright notice and this permission notice shall be
- included in all copies or substantial portions of the Software.
-
- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
- LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
- OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
- WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ Apache License Version 2.0
Review comment:
Not sure if this is necessary, or the right way to document this?
##########
File path: osgi/pom.xml
##########
@@ -104,7 +103,8 @@
commons-math3,
commons-compress,
commons-collections4,
- commons-codec
+ commons-codec,
+ log4j-api
Review comment:
I don't know how this works or how to verify it. I'd appreciate any help
or guidance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
