pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567934075
##########
File path: build.xml
##########
@@ -289,7 +288,7 @@ under the License.
<dependency prefix="main.byte-buddy"
artifact="net.bytebuddy:byte-buddy:1.10.19" usage="main-tests"/>
<dependency prefix="main.byte-buddy-agent"
artifact="net.bytebuddy:byte-buddy-agent:1.10.19" usage="main-tests"/>
<dependency prefix="main.objenesis" artifact="org.objenesis:objenesis:3.1"
usage="main-tests"/>
- <dependency prefix="main.slf4j-simple"
artifact="org.slf4j:slf4j-simple:1.7.30" usage="main-tests"/>
+ <dependency prefix="main.log4j-core"
artifact="org.apache.logging.log4j:log4j-core:2.14.0" usage="main-tests"/>
Review comment:
best to drop slf4j if log4j2 is what we really want to support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
