pjfanning commented on a change in pull request #224:
URL: https://github.com/apache/poi/pull/224#discussion_r567936892
##########
File path: build.gradle
##########
@@ -437,6 +439,7 @@ project('scratchpad') {
compile project(':main')
compile "commons-codec:commons-codec:${commonsCodecVersion}"
compile "org.apache.commons:commons-math3:${commonsMathVersion}"
+ implementation "org.apache.logging.log4j:log4j-api:${log4jVersion}"
Review comment:
can you stick with 'compile' and we can change all compile to
implementation later
##########
File path: build.gradle
##########
@@ -437,6 +439,7 @@ project('scratchpad') {
compile project(':main')
compile "commons-codec:commons-codec:${commonsCodecVersion}"
compile "org.apache.commons:commons-math3:${commonsMathVersion}"
+ implementation "org.apache.logging.log4j:log4j-api:${log4jVersion}"
Review comment:
can you stick with 'compile' and we can change all compile to
implementation later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
