been reported in Ubuntu 12.04 :
https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/1379201
Here is a proposed patch by Chris J Arges (only
patching tunnel.c is sufficient to build openvswitch-datapath-dkms) :
--- datapath/tunnel.c.orig 2014-11-04 23:12:12.0 +0100
+++ datapath/
96
Also she feels even better than that, if man has taken our bonus thirty minutes
before that night.
p{margin:10px 0;padding:0;}
table{border-collapse:collapse;}
h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;}
img,a img{border:0;height:auto;outline:none;text-decoration:none;}
b
ank you in advance.
Regards,
--
Chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The original message was received at Fri, 25 Sep 2015 12:57:52 +0700
from 14.242.26.243
- The following addresses had permanent fatal errors -
- Transcript of session follows -
... while talking to 164.212.16.121:
550 5.1.2 ... Host unknown (Name server: host not found)
ities operate on trust built between individuals.
thanks,
-chris
P.S. I know you know, but full disclosure -- I work for Red Hat.
> Sorry if you find this comment disturbing. My affiliation is clearly listed
> in my email address. But this is my private opinion
>
> Thx
>
Just a note; this adds datapath/linux/compat/include/linux/bug.h but doesn’t
add that filename to datapath/linux/Modules.mk, breaking the build with this
error:
The distribution is missing the following files:
datapath/linux/compat/include/linux/bug.h
This seems to fix the build:
diff --git a/da
Pravin Shelar wrote (on Sun 22 Dec, 2013 at 20:12 GMT):
On Sun, Dec 22, 2013 at 9:21 AM, Chris Luke wrote:
Just a note; this adds datapath/linux/compat/include/linux/bug.h but doesn?t
add that filename to datapath/linux/Modules.mk, breaking the build with this
error:
The distribution is
}
/* Must be called with rcu_read_lock. */
-static void netdev_port_receive(struct vport *vport, struct sk_buff *skb)
+static int netdev_port_receive(struct vport *vport, struct sk_buff *skb)
{
if (unlikely(!vport))
goto error;
@@ -198,22 +199,30 @@ static void netdev_port_receive(
Jesse Gross wrote (on Tue 24 Dec, 2013 at 03:05 GMT):
On Mon, Dec 23, 2013 at 12:13 AM, Chris Luke wrote:
Open vSwitch handles the OPFF_NORMAL action by passing packets
into a simple layer 2 learning switch. This commit adds the option to have
packets passed back to the kernel as though Open
Quick update on where I am with this:
Chris Luke wrote (on Tue 24 Dec, 2013 at 04:46 GMT):
Jesse Gross wrote (on Tue 24 Dec, 2013 at 03:05 GMT):
On Mon, Dec 23, 2013 at 12:13 AM, Chris Luke wrote:
[...]
* I agree that upcalls shouldn't work with this model - this seems
like it cou
output action using 'OVSP_NORMAL'.
Signed-off-by: Chris Luke
---
Revision 1:
- Alter kernel hook to be able to return packets to the kernel.
- Add tweak to vswitch to use this feature instead of a learning
switch when it encounters OFPP_NORMAL.
Revision 2: (supercedes patch 2606)
- Re
> On Jan 2, 2014, at 16:51, Jesse Gross wrote:
>
>> On Mon, Dec 23, 2013 at 11:46 PM, Chris Luke wrote:
>> Jesse Gross wrote (on Tue 24 Dec, 2013 at 03:05 GMT):
>>>
>>>> On Mon, Dec 23, 2013 at 12:13 AM, Chris Luke wrote:
>>>>
>>
ackets.
My bad, I answered this incorrectly. My phone hid the context from me.
I was mistaken about LLDP working previously - it was CDP I was seeing, in
lldpd. But with the later patchset, it *does* work.
Chris.
___
dev mailing list
dev@openvswitch.or
Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT):
On Thu, Jan 2, 2014 at 6:01 PM, Chris Luke wrote:
On Jan 2, 2014, at 16:51, Jesse Gross wrote:
On Mon, Dec 23, 2013 at 11:46 PM, Chris Luke wrote:
Jesse Gross wrote (on Tue 24 Dec, 2013 at 03:05 GMT):
* This type of concept has come up
double-delivered to lldpd and it does get
counted in the flow stats.
I think I would be inclined to argue that lldpd is doing it the
wrong way, that ETH_P_ALL packet sockets are meant as monitoring
taps, not protocol handlers.
Chris.
Chris Luke wrote (on Fri 03 Jan, 2014 at 01:33 GMT):
Jesse Gr
Jesse Gross wrote (on Fri 03 Jan, 2014 at 23:48 GMT):
On Thu, Jan 2, 2014 at 8:33 PM, Chris Luke wrote:
Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT):
On Thu, Jan 2, 2014 at 6:01 PM, Chris Luke wrote:
On Jan 2, 2014, at 16:51, Jesse Gross wrote:
On Mon, Dec 23, 2013 at 11:46 PM
Jesse Gross wrote (on Mon 06 Jan, 2014 at 20:29 GMT):
On Fri, Jan 3, 2014 at 10:00 PM, Chris Luke wrote:
Jesse Gross wrote (on Fri 03 Jan, 2014 at 23:48 GMT):
On Thu, Jan 2, 2014 at 8:33 PM, Chris Luke wrote:
Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT):
On Thu, Jan 2, 2014 at 6
Signed-off-by: Chris Luke
---
AUTHORS |1 +
FAQ | 87 +++
NEWS|2 ++
3 files changed, 80 insertions(+), 10 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 218fe76..1f03203 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -21,6
If available, use netif_receive_skb_finish() to asynchronously
return packets to the network input path after the point where
they were handed to us when the flow action is back_to_kernel.
Signed-off-by: Chris Luke
---
acinclude.m4|3 +++
datapath/vport-netdev.c |6 +-
2
stats. This is
since we have no way to avoid having the packet hit the rx_handler
hook a second time and relying on it matching its flow.
- In the userspace datapath, look at whether AF_PACKET can reinsert
packets at the right place in the input path, otherwise use a tap
interface to do same.
S
This OpenFlow action triggers the 'back_to_kernel' datapath action
to ask the datapath to return packets to the kernel.
Signed-off-by: Chris Luke
---
include/openflow/nicira-ext.h |1 +
lib/odp-execute.c |5 -
lib/ofp-actions.c
Signed-off-by: Chris Luke
---
datapath/actions.c | 40 ++
datapath/datapath.c | 23 +--
datapath/datapath.h |9 +++-
datapath/flow_netlink.c |6 ++-
datapath/vport-netdev.c | 96 +--
datapa
This list has been busy just recently, so I am wondering if my teeny
patchset has been overlooked. :)
Cheers,
Chris.
> -Original Message-
> From: dev-boun...@openvswitch.org [mailto:dev-
> boun...@openvswitch.org] On Behalf Of Chris Luke
> Sent: Wednesday, January 15, 2014
socket's file descripitor. With this change, the loop does
not end if the byte queue is non-empty unless the parser has completed,
in which case the message pointer will always be set to the parsed
message.
Signed-off-by: Chris Hydon
---
lib/jsonrpc.c | 13 +++--
1 files chang
On 2014-04-03 3:34 PM, Ben Pfaff wrote:
On Thu, Apr 03, 2014 at 03:06:03PM -0700, Chris Hydon wrote:
Previously, if the final iteration of the loop in jsonrpc_recv reads or
parses the last portion of a json object, it will return EAGAIN, with
the next call to jsonrpc_recv setting the message
On 2014-04-03 4:00 PM, Ben Pfaff wrote:
On Thu, Apr 03, 2014 at 03:56:44PM -0700, Chris Hydon wrote:
It looks like your change also fixes the problem, and I don't see
any bugs. I agree entirely: the current code is needlessly complex!
My only comment is that with your change, for long mes
GFP_ATOMIC))
return NULL;
}
...
}
pskb_expand_head(skb, 0, eat > 0 ? eat + 128 : 0, GFP_ATOMIC)
{
...
if (skb_shared(skb))
BUG(); <<< BOOM!!!
...
}
----
On Fri, Feb 27, 2015 at 11:08:21AM -0800, Pravin Shelar wrote:
> On Thu, Feb 26, 2015 at 9:13 PM, Chris Dunlop wrote:
> > Hi,
> >
> > "Me too" on Simon's BUG() described below (apologies for the top post).
> > Basically:
> >
> &g
On Fri, Feb 27, 2015 at 06:06:25PM -0500, Xu (Simon) Chen wrote:
> On Friday, February 27, 2015, Chris Dunlop wrote:
> > Simon, are you able to try your test running direct hypervisor
> > to hypervisor?
>
> Nope... I have only seen this between VMs. After repeated tests, it
On Fri, Feb 27, 2015 at 11:08:21AM -0800, Pravin Shelar wrote:
> On Thu, Feb 26, 2015 at 9:13 PM, Chris Dunlop wrote:
> > Hi,
> >
> > "Me too" on Simon's BUG() described below (apologies for the top post).
> > Basically:
> >
> &g
On Fri, Feb 27, 2015 at 08:30:42PM -0500, Xu (Simon) Chen wrote:
> On Fri, Feb 27, 2015 at 6:14 PM, Pravin Shelar wrote:
> > So it looks like vhost is generating shared skb. Can you try same test
> > on latest upstream kernel?
>
> I don't know whether it's vhost, as for me the VM receiving high v
On Fri, Feb 27, 2015 at 08:31:46PM -0500, Xu (Simon) Chen wrote:
> On Fri, Feb 27, 2015 at 6:49 PM, Chris Dunlop wrote:
> > On Fri, Feb 27, 2015 at 06:06:25PM -0500, Xu (Simon) Chen wrote:
> > > On Friday, February 27, 2015, Chris Dunlop wrote:
> > > > Simon,
On Fri, Feb 27, 2015 at 08:33:13PM -0500, Xu (Simon) Chen wrote:
> On Fri, Feb 27, 2015 at 7:13 PM, Chris Dunlop wrote:
> > On Fri, Feb 27, 2015 at 11:08:21AM -0800, Pravin Shelar wrote:
> > > Can you reproduce this bug on hypervisor to hypervisor
> > > test without a
On Mon, Mar 02, 2015 at 11:45:11AM +1100, Chris Dunlop wrote:
> Heads up...
>
> We've hit this BUG() in v3.10.70, v3.14.27 and v3.18.7:
>
> net/core/skbuff.c:
> 1027 int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
> 1028 gfp_t
On Sat, Feb 28, 2015 at 12:49:31PM +1100, Chris Dunlop wrote:
> On Fri, Feb 27, 2015 at 08:30:42PM -0500, Xu (Simon) Chen wrote:
> > On Fri, Feb 27, 2015 at 6:14 PM, Pravin Shelar wrote:
> > > So it looks like vhost is generating shared skb. Can you try same test
> > >
sflow collection, the permanent solution is to
install v2.3.2 once it's out, and in the meantime you can cherry-pick
commit d7ff93d75 on top of v2.3.1 to get your sflow collection working
again.
Cheers!
Chris
> On Wednesday, March 4, 2015, Chris Dunlop wrote:
>
> > On Sat, Feb 28,
On Mon, Mar 02, 2015 at 11:45:11AM +1100, Chris Dunlop wrote:
> Heads up...
>
> We've hit this BUG() in v3.10.70, v3.14.27 and v3.18.7:
>
> net/core/skbuff.c:
> 1027 int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
> 1028 gfp_t
* Justin Pettit (jpet...@nicira.com) wrote:
> On Apr 26, 2013, at 10:40 AM, Kyle Mestery wrote:
>
> > +Q: How much of the VXLAN protocol does Open vSwitch currently support?
> > +
> > +A: Open vSwitch currently supports the framing format for packets on the
> > + wire. There is currently no sup
kport".
Reported-by: Andrei Andone
Signed-off-by: Chris Wright
Cc: Thomas Graf
Cc: Pravin Shelar
---
datapath/linux/compat/include/linux/netdevice.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/linux/compat/include/linux/netdevice.h
b/datapath/linux/comp
his for
> >> stable in 3.4/3.5? It's currently in Linus's tree as
> >> 7fe99e2d434eafeac0c57b279a77e5de39212636.
> >>
> >
> > What vendor is shipping openvswitch enabled and requires the fix to
> > be in -stable before they'll ship it to cus
e
> up as well.
You should look at the Fedora packages. They won't build the kmod, but
have all the Fedora-isms worked out.
thanks,
-chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Sep 25, 2012, at 12:06 PM, Chris Wright wrote:
> > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> >> They are different, and not as flexible as the RHEL ones.
> >>
> >> Let me give the RH
still
> need to zero it here?
And with quoting, now shows up as whitespace damaged (if kept, should
fix...quick check shows a handful of other lines added w/ spaces rather
than tabs, sorry for content free review, but caught my eye).
thanks,
-chris
_
* Kyle Mestery (kmest...@cisco.com) wrote:
> @@ -23,6 +23,7 @@
> /kmemdup.c
> /loop_counter.c
> /modules.order
> +/net_namespace.c
> /netdevice.c
> /net_namespace.c
> /random32.c
spurious change?
> @@ -39,5 +40,6 @@
> /vport-internal_dev.c
> /vport-netdev.c
> /vport-patch.c
> +/vport-vxl
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote:
> > * Kyle Mestery (kmest...@cisco.com) wrote:
> >> +
> >> + vxlan_port->port = dst_port;
> >> + vxlan_port->count++;
>
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 28, 2012, at 10:34 AM, Chris Wright
> wrote:
> > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> >> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote:
> >>> * Kyle M
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 28, 2012, at 11:01 AM, Chris Wright wrote:
> > Right. OTV is commonly, but not exclusively, used now. Post draft
> > we should expect a final port number. But it's a relatively small set
> > of functionali
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote:
> > * Kyle Mestery (kmest...@cisco.com) wrote:
> >> + udp_encap_enable();
> >
> > This is a new function, did you provide a fallback/noop (since it looks
> &
* christopher barry (cba...@rjmetrics.com) wrote:
> What will be the latest valid tag to build from to include brcompat?
it's still there (just deprecated and gives a warning). so at least
v1.9.x tags will have it (in deprecated/warning form).
thanks
* Jesse Gross (je...@nicira.com) wrote:
> On Wed, Mar 7, 2012 at 10:28 AM, Chris Wright wrote:
> > This renames the datapath modules:
> >
> > openvswitch_mod -> openvswitch
> > brcompat_mod -> brcompat
> >
> > The first makes the module name consist
* Jesse Gross (je...@nicira.com) wrote:
> On Thu, Mar 8, 2012 at 2:52 PM, Chris Wright wrote:
> > * Jesse Gross (je...@nicira.com) wrote:
> >> On Wed, Mar 7, 2012 at 10:28 AM, Chris Wright wrote:
> >> > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
> &
27;s coming from upstream
linux or built from datapath/ as part of a local build.
Signed-off-by: Chris Wright
---
Minor NEWS conflict w/ Ethan's patch nicira-ext: Add a 6th NXM register.
INSTALL.Linux | 14 +++---
INSTALL.XenServer
ath: omit _mod from module names).
Sorry about that, initial grep of _mod turned up enough noise that I
completley missed that.
FWIW:
Acked-by: Chris Wright
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This short series adds ability to disable building brcompat user and
kernel space bits. I've done some light testing to verify it's doing
what I expected, but may have missed some subtleties of the build
system.
thanks,
-chris
Chris Wright (2):
datapath: split out linux/Modules.mk
build stages which have differing conditional syntax.
Signed-off-by: Chris Wright
---
datapath/Makefile.am |3 +-
datapath/linux/Kbuild.in |3 +-
datapath/linux/Makefile.main.in |3 +-
datapath/linux/Module-brcompat.mk|3 +
datapath/linux/M
This adds ability to do:
./configure --disable-brcompat
to disable building userspace and kernel module associated with
providing linux bridge compatibility.
Signed-off-by: Chris Wright
---
configure.ac|1 +
datapath/Makefile.am|2 ++
datapath/linux
* Ben Pfaff (b...@nicira.com) wrote:
> Without this change, these tests try to write to /var/run, which fails
> unless "make check" is run as root.
Yay! This was breaking for me on Friday too.
I'm still hitting this from make distcheck (haven't dug into it yet):
mv ovsdb/ovsdb-server.1.tmp ovsd
* Ben Pfaff (b...@nicira.com) wrote:
> On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > Without this change, these tests try to write to /var/run, which fails
> > > unless "make check" is run as root.
ion number changes, so we can just "touch" it when it doesn't
> really need to change.
>
> The same pattern is used elsewhere in the tree for other files in the same
> situation, e.g. the various RPM spec files.
Thanks.
Acked-by: Chris Wright
___
Thanks.
Acked-by: Chris Wright
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > This adds ability to do:
> >
> > ./configure --disable-brcompat
> >
> > to disable building userspace and kernel module associated with
> &g
* Ben Pfaff (b...@nicira.com) wrote:
> On Mon, Mar 12, 2012 at 11:18:58AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > > > This adds ability to do:
> > > >
relevant for brcompat module.
Signed-off-by: Chris Wright
---
v2:
- changed the conditional to allow keeping linux/Modules.mk as one file
- split build_modules and dist_modules setting to ensure brcompat
module source is distributed
- verified against distcheck w/ both --{disable,enable
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Mar 13, 2012 at 12:18:07PM -0700, Chris Wright wrote:
> > This adds ability to do:
> >
> > ./configure --disable-brcompat
> >
> > to disable building userspace and kernel module associated with
> > providi
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Mar 13, 2012 at 02:58:30PM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > In the OVS_CHECK_BRCOMPAT macro definition, the "yes" case and the
> > > "not specified" case ar
relevant for brcompat module.
Cc: Jesse Gross
Signed-off-by: Chris Wright
---
v2:
- changed the conditional to allow keeping linux/Modules.mk as one file
- split build_modules and dist_modules setting to ensure brcompat
module source is distributed
- verified against distcheck w/ both --{disable
emporary workaround for lack of DHCP support (the
upstream initscripts should fix this, which I'll test and apply to
Fedora's package).
thanks,
-chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Ben Pfaff (b...@nicira.com) wrote:
> On Wed, Mar 14, 2012 at 10:24:53AM -0700, Chris Wright wrote:
> > The recipe above is working around the network initscripts lack of DHCP
> > support (I'll fix that in Fedora). It's also being careful to not
> > trigger Networ
tests/interface-reconfigure.at:BUILD_NUMBER='24648p'
xenserver/etc_init.d_openvswitch:set "$@"
--system-version="$PRODUCT_VERSION-$BUILD_NUMBER"
thanks,
-chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 16, 2012 at 04:03:23PM -0700, Jesse Gross wrote:
> > On Fri, Mar 16, 2012 at 1:13 PM, Ben Pfaff wrote:
> > > diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
> > > index 0d858a1..57f76d5 100644
> > > --- a/utilities/ovs-vsctl.8.in
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 16, 2012 at 04:30:17PM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Fri, Mar 16, 2012 at 04:03:23PM -0700, Jesse Gross wrote:
> > > > On Fri, Mar 16, 2012 at 1:13 PM, Ben Pfaff
would it be in line with
the projects goals?
Cheers,
Chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
through the switch and observe the load,
hack the kernel path to layer 2 only and replay the same trace again and
compare results.
Cheers,
Chris
On Thu, 29 Mar 2012 15:50:50 Jesse Gross wrote:
> On Wed, Mar 28, 2012 at 4:30 PM, Chris Browning
wrote:
> > First, the kernel module
* Ethan Jackson (et...@nicira.com) wrote:
> @@ -1039,7 +1079,8 @@ add_del_bridges(const struct ovsrec_open_vswitch *cfg)
> * port already belongs to a different datapath, so we must do all port
> * deletions before any port additions. */
> static void
> -bridge_del_ofproto_ports(struct bridge
ay be missing something
> though, could you please give a bit more detail about what worries
> you?
With iface->netdev set to NULL I thought it might not get deleted.
thanks,
-chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Ethan Jackson (et...@nicira.com) wrote:
> It will be garbage collected later when the bridge notices a port in
> the datapath which it doesn't know about.
OK, thanks for clarifying.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
* ravi kerur (rke...@gmail.com) wrote:
> Thanks Ben, I don't remember seeing core file under
> tests/testsuite.dir/0449 directory. I will double-check, if its
> available it will be definitely helpful.
Core file creation might be disabled (check ulimit).
___
would love to see it in the get
through into the upstream to guarantee its maintained into the future.
Cheers,
Chris
On Fri, 06 Jul 2012 16:50:32 ravi kerur wrote:
On Fri, Jul 6, 2012 at 3:31 PM, Jesse Gross wrote:
On Thu, Jul 5, 2012 at 9:45 PM, ravi kerur wrote:
> As mentioned earlier
is whether you're
talking about the internals only, or also the netlink interface?
thanks,
-chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* John Fastabend (john.r.fastab...@intel.com) wrote:
> He is pushing and popping entire tags off 802.1Q for now but
> you can easily imagine MPLS tags and all sorts of other things
> people will _need_.
Right, already doing some generic encap/decap for tunnelling.
> Do we want tc and likely the s
t; Either branch-1.4 or master should be compatible with the code that
> is being upstreamed. Currently, they are very similar, but branch-1.4
> will only get bugfixes from now on whereas master is where active
> development is occurring.
What are the plans for tags, ta
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Dec 06, 2011 at 12:17:34PM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> > > > If I pull the userspace utils from git, which ones ar
> > I'm somewhat surprised at this because this code is pretty old so I
> > would have thought that we would have run into it before.
> >
> I don't see this in mainline kernel. I think it was added in recent RH update.
It was in since 5.1
thanks,
-chris
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Brian Haley (brian.ha...@hp.com) wrote:
> On 12/06/2011 06:55 PM, Ben Pfaff wrote:
> > The comment on this function says that negative values indicate errors, and
> > the callers assume that too, but in fact it was returning positive errno
> > values, which are indistinguishable from valid fd num
Fix this rpmlint warning:
W: spurious-executable-perm /usr/share/doc/openvswitch-1.4.0/README.RHEL
by specifying mode on install.
Signed-off-by: Chris Wright
---
rhel/openvswitch.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rhel/openvswitch.spec.in b/rhel
Here's a short series of small cleanups that have come from packaging
openvswitch for Fedora. Nothing terribly exciting here, the last two
may not be to everyone's taste. I'm happy to rework if needed.
Chris Wright (7):
Update FSF address in LGPL notices in bugtool
-configuration.xml
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/network-status/openvswitch.xml
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/kernel-info/openvswitch.xml
Signed-off-by: Chris Wright
---
.../bugtool/plugins/kernel-info/openvswitch.xml|2 +-
.../bugtool/plugins
Fixes rpmlint warning:
W: spurious-executable-perm /etc/logrotate.d/openvswitch
W: non-conffile-in-etc /etc/logrotate.d/openvswitch
E: script-without-shebang /usr/share/openvswitch/scripts/sysconfig.template
Define rhel_cp() shell func and include file mode on install.
Signed-off-by: Chris
Currently, ovs-lib.sh is installed as an executable. It's meant to be
sourced by external scripts, so install as data. Fixes rpmlint error:
E: script-without-shebang /usr/share/openvswitch/scripts/ovs-lib.sh
Could drop the .sh suffix in another commit.
Signed-off-by: Chris W
Rename this helper script to simply ovs-lib, since it's primarily
a library of helper functions.
Signed-off-by: Chris Wright
---
debian/openvswitch-switch.init |2 +-
debian/openvswitch-switch.install |2 +-
rhel/etc_init.d_openvswitch |2 +-
. Of course, the rpmlint warnings are as well,
however, this seems like a more logical place for the bugtool plugins.
Signed-off-by: Chris Wright
---
debian/openvswitch-common.install |2 +-
rhel/openvswitch.spec.in |2 +-
utilities/bugtool/automake.mk |2 +-
utilities/bu
27;
However, rpmlint generates the same warning as manpage-check was (it
uses -Tutf8), and manpages are generated using -Tutf8 (leading to an
fairly unreadable drawing). So let's change the logic a bit and allow
pdf generation w/ nice drawing and kill it for tty's.
Cc: Ethan Jackson
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Dec 08, 2011 at 11:35:59PM -0800, Chris Wright wrote:
> > Here's a short series of small cleanups that have come from packaging
> > openvswitch for Fedora. Nothing terribly exciting here, the last two
> > may not be to every
folks agree it's useful
to adopt DCO.
thanks,
-chris
[1]Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under
This adds the Developer's Certificate of Origin to SubmittingPatches
to document the requirement to add Signed-off-by to patches.
Signed-off-by: Chris Wright
---
SubmittingPatches | 51 +++
1 files changed, 51 insertions(+), 0 deletions(-)
This adds the Developer's Certificate of Origin to SubmittingPatches
to document the requirement to add Signed-off-by to patches.
Signed-off-by: Chris Wright
---
v2 Use new commit to illustrate S-o-b
SubmittingPatches | 151 +
1
* Ben Pfaff (b...@nicira.com) wrote:
> Pushed to master.
Thanks.
> Now I'm working on a Git hook to reject commits without S-o-b.
Nice idea.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
and the lib/sflow* sources). Let me know if
> this looks OK or not.
This looks good to me, thanks for doing that Neil.
Not sure if debian/copyright.in should get an update (never actually
mentioned sFlow to begin with).
> Signed-off-by: Neil McKee
Acke
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Dec 09, 2011 at 09:41:11AM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > All applied to master, thanks Chris. Do you want these on branch-1.4
> > > also?
> >
> > Yes, please.
&g
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Dec 22, 2011 at 10:00:34AM -0800, Chris Wright wrote:
> > Looks like one is missing for branch-1.4:
> >
> > b4059ef Update FSF address in LGPL notices in bugtool plugins.
>
> Thanks for pointing that out. I cherry-pic
1 - 100 of 119 matches
Mail list logo
