* Pravin Shelar (pshe...@nicira.com) wrote:
> On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery <kmest...@cisco.com> wrote:
> > @@ -458,6 +477,9 @@ int ovs_execute_actions(struct datapath *dp, struct 
> > sk_buff *skb)
> >         struct sw_flow_actions *acts = 
> > rcu_dereference(OVS_CB(skb)->flow->sf_acts);
> >         struct loop_counter *loop;
> >         int error;
> > +       struct ovs_key_ipv4_tunnel tun_key;
> > +
> > +        memset(&tun_key, 0, sizeof(tun_key));
> >
> tun key will zeroed while executing tunnel set action, Do we still
> need to zero it here?

And with quoting, now shows up as whitespace damaged (if kept, should
fix...quick check shows a handful of other lines added w/ spaces rather
than tabs, sorry for content free review, but caught my eye).

thanks,
-chris
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to