* Ben Pfaff (b...@nicira.com) wrote: > On Mon, Mar 12, 2012 at 11:18:58AM -0700, Chris Wright wrote: > > * Ben Pfaff (b...@nicira.com) wrote: > > > On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote: > > > > This adds ability to do: > > > > > > > > ./configure --disable-brcompat > > > > > > > > to disable building userspace and kernel module associated with > > > > providing linux bridge compatibility. > > > > > > > > Signed-off-by: Chris Wright <chr...@sous-sol.org> > > > > > > I've had a little bit of trouble in the past with Automake not > > > distributing some kinds of files that are conditionally built. So, > > > with this patch applied, does > > > ./configure --disable-brcompat > > > make distcheck > > > pass, e.g. does "make dist" still distribute the source files and > > > (especially) the manpages that are now conditional? > > > > Yes, you're right, it does seem to effect the datapath. > > One solution is to make sure that anything that must be distributed is > in noinst_HEADERS, e.g. see this commit from a while back:
Heh, I came across your automake posting while trying to debug this patchset. Ideal would be in Module-brcompat.mk to make only the .o/.ko build conditional, but that hits the issue that the same file is used in two different contexts. I'll try noinst_HEADERS, and see if distcheck passes. thanks, -chris _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
