Re: [ovs-dev] oops in if_nlmsg_size

2015-01-15 Thread Thomas Graf
On 01/15/15 at 01:53pm, Jorge Nevado wrote: > Yes, you are right Thomas. > Suse12, although issuing Kernel 3.12.28, has applied some patches including > the " rtnl_link_get_slave_info_data_size" method but without the patch. Cool. /me strikes "Providing SUSE support as former Red Hat employee" of

Re: [ovs-dev] OVN architecture

2015-01-15 Thread Thomas Graf
On 01/15/15 at 07:04am, Gurucharan Shetty wrote: > On Thu, Jan 15, 2015 at 4:06 AM, Thomas Graf wrote: > > On 01/15/15 at 03:36pm, YAMAMOTO Takashi wrote: > >> > On Thu, Jan 15, 2015 at 10:38:45AM +0900, YAMAMOTO Takashi wrote: >

Re: [ovs-dev] [PATCH 2/3] autotest: add autotest framework for adding kernel module unit tests

2015-01-15 Thread Thomas Graf
I've been meaning to do something like for a while. Thanks! On 01/13/15 at 05:28pm, Andy Zhou wrote: > +# Kernel module testing > +check-kmod: all tests/atconfig tests/atlocal $(KMOD_TESTSUITE) > + $(MAKE) modules_install > + $(SHELL) '$(KMOD_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST

Re: [ovs-dev] [PATCH 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-15 Thread Thomas Graf
ot. Switch > Vagrantfile provisions to run as root user. However, vagrant can > still be launched as normal user. > > Signed-off-by: Andy Zhou LGTM Acked-by: Thomas Graf We might need to move the providers into the individual vm definitions when we start adding more distributions

Re: [ovs-dev] [PATCH 2/3] autotest: add autotest framework for adding kernel module unit tests

2015-01-15 Thread Thomas Graf
On 01/15/15 at 12:22pm, Andy Zhou wrote: > On Thu, Jan 15, 2015 at 9:56 AM, Thomas Graf wrote: > >> +m4_define([OVS_KMOD_VSWITCHD_START], > >> + [ AT_CHECK([modprobe openvswitch]) > > > > Assuming that we want to use this outside of Vagrant as well: > &g

Re: [ovs-dev] [PATCH 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-15 Thread Thomas Graf
On 01/15/15 at 12:26pm, Andy Zhou wrote: > Do you have thoughts how we can support multiple kernel versions (for > testing compat code) > May be even multiple kernel versions over multiple distributions? We could use 'packer' to automatically create boxes for various kernel versions and upload the

Re: [ovs-dev] net-next openvswitch vport netlink corner case broken?

2015-01-15 Thread Thomas Graf
On 01/15/15 at 01:41pm, Joe Stringer wrote: > I'm running OVS master (afc3987) with the net-next kernel module > (4e7a84b), and if I run ovs-dpctl I sometimes get the following error: > > dpif|WARN|failed to enumerate system datapaths: Protocol error > > I made some local changes to OVS lib/netli

Re: [ovs-dev] [PATCH 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-16 Thread Thomas Graf
On 01/16/15 at 03:22pm, Motonori Shindo wrote: > That being said, I just found that there is a way to control which machine > to bring up in Vagrantfile by passing an argument to "vagrant up" command > (e.g. "vagrant up fedora" or "vagrant up ubuntu") and even specify the > default machine to bring

Re: [ovs-dev] [PATCH 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-16 Thread Thomas Graf
On 01/16/15 at 09:42am, Dave Tucker wrote: > The packer definitions for the "chef" boxes are here > https://github.com/opscode/bento > > It's possible to host the defintions in a git repo, have Jenkins handle > builds, upload the boxes to Amazon S3 and update the boxes in Atlas > (formerly Vagran

Re: [ovs-dev] [kmod-test V2 2/3] autotest: add autotest framework for adding kernel module unit tests

2015-01-16 Thread Thomas Graf
Thanks for incorporating all the feedback. LGTM from here. I'll play with the various modprobe scenarios a bit and will follow-up if needed. Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [kmod-test V2 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-16 Thread Thomas Graf
ot. Switch > Vagrantfile provisions to run as root user. However, vagrant can > still be launched as normal user. > > Signed-off-by: Andy Zhou As discussed in the v1 thread of this series. We are likely to make this more generic but nothing speaks against enabling

Re: [ovs-dev] [kmod-test V2 1/3] autotest: refactor OVS_VSWITCHD_START MACRO

2015-01-16 Thread Thomas Graf
On 01/15/15 at 06:12pm, Andy Zhou wrote: > Refactor in preparation for the next patch. > > Signed-off-by: Andy Zhou LGTM Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-16 Thread Thomas Graf
Just noticed that somehow we had openvswitch.com in the CC list ;-) Moving back to list. On 01/16/15 at 11:31am, Dave Tucker wrote: > > On 16 Jan 2015, at 10:40, Thomas Graf wrote: > > >On 01/16/15 at 09:42am, Dave Tucker wrote: > >>The packer definitions for the "c

Re: [ovs-dev] OVN architecture

2015-01-19 Thread Thomas Graf
On 01/16/15 at 04:28pm, Ben Pfaff wrote: > We have not yet contemplated that, but it could be possible. > > In my opinion, OVS is not releasing often enough in any case. I think > that 3 or 4 releases a year is about right (but that's off the cuff, not > some kind of official policy or anything).

Re: [ovs-dev] [PATCH] Add tests/kmod-testsuite to .gitignore

2015-01-19 Thread Thomas Graf
On 01/19/15 at 01:11pm, loja...@cisco.com wrote: > From: Lorand Jakab > > Signed-off-by: Lorand Jakab Acked-by: Thomas Graf This is so obviously correct that I pushed this right to master ___ dev mailing list dev@openvswitch

Re: [ovs-dev] [PATCH] rconn: Remove dead code and data.

2015-01-19 Thread Thomas Graf
On 01/18/15 at 04:26pm, Ben Pfaff wrote: > These functions had no callers, so remove them and the data maintained > just to implement them. > > Found by inspection. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ de

Re: [ovs-dev] [PATCH] pktbuf: Always initialize '*bufferp' even when 'pb == NULL'.

2015-01-19 Thread Thomas Graf
ctive rather than passive) > connections. > > Signed-off-by: Ben Pfaff Nice catch. Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Fix typo in NEWS

2015-01-19 Thread Thomas Graf
On 01/19/15 at 03:45pm, Lorand Jakab wrote: > Signed-off-by: Lorand Jakab Acked-by: Thomas Graf Same here, pushed to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVN architecture

2015-01-19 Thread Thomas Graf
On 01/19/15 at 10:01am, Ben Pfaff wrote: > I realize that a shared library was mentioned elsethread as having some > importance, but I don't understand why. ovn-controller and the other C > components of OVN will be just as useful whether they are statically or > dynamically linked to the OVS libr

Re: [ovs-dev] OVN architecture

2015-01-19 Thread Thomas Graf
On 01/19/15 at 09:58am, Ben Pfaff wrote: > To keep the discussion going, let's talk about each of those features. > > These days, OVS allows an ARP responder can be implemented in the > OpenFlow flow table (since all ARP fields are modifiable), but that has > only been true for a few versions. Be

Re: [ovs-dev] OVN architecture

2015-01-19 Thread Thomas Graf
On 01/19/15 at 09:19am, Ben Pfaff wrote: > I really prefer feature negotiation in any case, because it means that > OVN can work with OVS that has custom version numbers or backports of > individual features. You are absolutely right. Thinking about this more, I guess we don't even have a choice a

Re: [ovs-dev] OVN architecture

2015-01-19 Thread Thomas Graf
On 01/19/15 at 03:13pm, Ben Pfaff wrote: > I think that this can be simply tested for with an OFPT_PACKET_OUT whose > packet is an ARP and whose actions modify ARP header fields and then > send the packet back to the controller. If the packet comes back in an > OFPT_PACKET_IN, with the requested A

Re: [ovs-dev] [PATCH] stream-fd: Fix log message.

2015-01-20 Thread Thomas Graf
On 01/19/15 at 09:26pm, Ben Pfaff wrote: > The log message for a send operation should refer to "send", not "recv". > Looks like an old cut-and-paste error. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev

Re: [ovs-dev] location of vconn struct definitions

2015-01-20 Thread Thomas Graf
On 01/19/15 at 03:43pm, Ben Pfaff wrote: > Commit 4a1f523f2d760 (lib: Move vconn.h to ) moved > the definitions of struct vconn and struct pvconn from lib/ to > include/openvswitch/ but I'm not sure why. The size and content of > those structs is not obviously part of the ABI. Can you remind why?

Re: [ovs-dev] [PATCH] vconn: Move struct definitions back to provider interface.

2015-01-20 Thread Thomas Graf
t moves them back. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 0/2] Add support to control Reports forwarding

2015-01-20 Thread Thomas Graf
On 01/20/15 at 01:08pm, Flavio Leitner wrote: > On Tuesday, January 20, 2015 04:38:21 AM Ben Pfaff wrote: > > On Tue, Jan 20, 2015 at 10:03:59AM -0200, Flavio Leitner wrote: > > > The RFC4541 section 2.1.1 item 1 allows the snooping switch > > > to provide an administrative control to allow Report

Re: [ovs-dev] [PATCH 0/2] Add support to control Reports forwarding

2015-01-20 Thread Thomas Graf
d fx6sm51814624wjc.39.2014.12.29.16.20.16 +by mx.google.com with ESMTPSA id je12sm54959581wic.22.2015.01.02.10.35.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); -Mon, 29 Dec 2014 16:20:16 -0800 (PST) +Fri, 02 Jan 2015 10:35:43 -0800 (PST)

Re: [ovs-dev] [PATCH] netdev-vport: Add Stateless TCP Tunneling protocol

2015-01-21 Thread Thomas Graf
On 01/20/15 at 02:55pm, Jesse Gross wrote: > On Tue, Jan 20, 2015 at 12:26 PM, Pravin B Shelar wrote: > > From: Jesse Gross > > > > Add STT netev-vport so that vswitchd can create STT vport in kernel > > datapath. > > > > Signed-off-by: Jesse Gross > > Signed-off-by: Pravin B Shelar > > The re

Re: [ovs-dev] [PATCH 1/2] ofp-errors: Explain the whole "expected duplications" thing.

2015-01-21 Thread Thomas Graf
On 01/21/15 at 09:46am, Ben Pfaff wrote: > enum ofperr { > /* Expected duplications. */ > > /* Expected: 0x0,3,5 in OF1.1 means both OFPBIC_BAD_EXPERIMENTER and > * OFPBIC_BAD_EXP_TYPE. */ > > +/* Expected: 0x0,1,5 in OF1.0 means both OFPBRC_EPERM and > + * OFPBRC_IS_SLAVE.

Re: [ovs-dev] [PATCH 1/2] ofp-errors: Explain the whole "expected duplications" thing.

2015-01-22 Thread Thomas Graf
On 01/21/15 at 08:47pm, Ben Pfaff wrote: > On Thu, Jan 22, 2015 at 12:21:20AM +0100, Thomas Graf wrote: > > On 01/21/15 at 09:46am, Ben Pfaff wrote: > > > enum ofperr { > > > /* Expected duplications. */ > > > > > > /* Expected: 0x0,3,5 in

Re: [ovs-dev] [PATCH] setup n_upcall_pids for vport_request when destroy all channels

2015-01-22 Thread Thomas Graf
On 01/22/15 at 05:01pm, Gao feng wrote: > Setup the n_upcall_pids to 1, otherwise the > OVS_VPORT_ATTR_UPCALL_PID nlattr will be incorrect. > > Signed-off-by: Gao feng Fixed a style issue and pushed this to master, branch-2.3 and branch-2.2. ___ dev ma

Re: [ovs-dev] [PATCH] setup n_upcall_pids for vport_request when destroy all channels

2015-01-22 Thread Thomas Graf
On 01/22/15 at 12:35pm, Thomas Graf wrote: > On 01/22/15 at 05:01pm, Gao feng wrote: > > Setup the n_upcall_pids to 1, otherwise the > > OVS_VPORT_ATTR_UPCALL_PID nlattr will be incorrect. > > > > Signed-off-by: Gao feng > > Fixed a style issue and pushed this

[ovs-dev] [PATCH 01/11] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

2015-01-22 Thread Thomas Graf
uot; is misleading there") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath/actions.c| 4 ++-- datapath/datapath.c | 4 ++-- datapath/flow.c | 4 ++-- datapath/linux/comp

[ovs-dev] [PATCH 00/11] Datapath sync & VXLAN-GBP

2015-01-22 Thread Thomas Graf
attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Madhu Challa (1): ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS Thomas Graf (10): datapath: Account for "rename vlan_tx_* helpers since "tx" is m

[ovs-dev] [PATCH 02/11] datapath: Account for now exposed VXLAN definitions

2015-01-22 Thread Thomas Graf
t for header flags") Signed-off-by: Thomas Graf --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/vxlan.h | 14 +++- datapath/linux/compat/vxlan.c | 37 ++- 3 files changed, 41 insertions(+), 12 deletion

[ovs-dev] [PATCH 06/11] datapath: Support VXLAN Group Policy extension

2015-01-22 Thread Thomas Graf
TUNNEL_VXLAN_OPT is introduced. The attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 1dd144 ("openvswitch: Support VXLAN Group Policy exte

[ovs-dev] [PATCH 05/11] datapath: Allow for any level of nesting in flow attributes

2015-01-22 Thread Thomas Graf
attributes to arbitrary depth. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 81bfe3 ("openvswitch: Allow for any level of nesting in flow attributes") Signed-off-by: Thomas Graf --- datapath/flow_netlink.c | 107 +-

[ovs-dev] [PATCH 07/11] datapath: Account for "genetlink: pass only network namespace to genl_has_listeners()"

2015-01-22 Thread Thomas Graf
since it's an inline, but makes the caller less magic - there's never any reason to pass another socket. Signed-off-by: Johannes Berg Signed-off-by: David S. Miller Upstream: f8403a2 ("genetlink: pass only network namespace to genl_has_listeners()&quo

[ovs-dev] [PATCH 08/11] datapath: Account for "netlink: make nlmsg_end() and genlmsg_end() void"

2015-01-22 Thread Thomas Graf
genlmsg_end() no longer returns an error value. Not a problem as it never returned an error code anyway. Upstream: 053c09 ("netlink: make nlmsg_end() and genlmsg_end() void") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletion

[ovs-dev] [PATCH 04/11] datapath: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()

2015-01-22 Thread Thomas Graf
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic tunnel metadata options. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: d91641d ("openvswitch: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()") Signed-off-by: Thomas Graf --- datapath/flow.c

[ovs-dev] [PATCH 09/11] datapath: Allow building against 3.19.x

2015-01-22 Thread Thomas Graf
Signed-off-by: Thomas Graf --- FAQ.md | 1 + NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/FAQ.md b/FAQ.md index 02fe2d3..2de4936 100644 --- a/FAQ.md +++ b/FAQ.md @@ -147,6 +147,7 @@ A: The following table lists the Linux kernel

[ovs-dev] [PATCH 03/11] datapath: Account for "vxlan: Group Policy extension"

2015-01-22 Thread Thomas Graf
-ofctl add-flow br0 'in_port=1,actions=load:0x200->NXM_NX_TUN_GBP_ID[],NORMAL' # ovs-ofctl add-flow br0 'in_port=2,tun_gbp_id=0x200,actions=drop' [0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy [1] http://lwn.net/Articles/204905/ Signed-of

[ovs-dev] [PATCH 10/11] tunnel: Provide framework for tunnel extensions for VXLAN-GBP and others

2015-01-22 Thread Thomas Graf
Supports a new "exts" field in the tunnel configuration which takes a comma separated list of enabled extensions. The only extension supported so far is GBP but this can be used to enable RCO and possibly others as soon as the OVS datapath supports them. Signed-off-by: Thomas Graf ---

[ovs-dev] [PATCH 11/11] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-01-22 Thread Thomas Graf
From: Madhu Challa Introduces two new NXMs to represent VXLAN-GBP [0] fields. actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL tun_gbp_id=0x10,actions=drop This enables existing VXLAN tunnels to carry security label information such as a SELinux context to other network peers. The values are

Re: [ovs-dev] [PATCH 0/4] Apple Mac OSX Support for CTL commands

2015-01-23 Thread Thomas Graf
On 01/22/15 at 09:22pm, Ben Pfaff wrote: > On Fri, Jan 23, 2015 at 01:17:34AM +, Dave Tucker wrote: > > This patch sets adds Apple Mac OSX Support for the ovs-vsctl and > > ovs-ofctl. This is useful for administrators who are managing OVS > > instances and whose primary desktop environment is

Re: [ovs-dev] [PATCH] test-sflow: Fix error message when a socket cannot be opened.

2015-01-23 Thread Thomas Graf
On 01/22/15 at 10:03pm, Ben Pfaff wrote: > The error message should name the socket, which is 'target', not argv[1], > which might be anything. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list de

Re: [ovs-dev] [PATCH 1/4] autoconf: Add macros to detect Apple Mac OSX

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > Signed-off-by: Dave Tucker Looks good. You might want to move the whitespace fixes into a separate commit. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > diff --git a/lib/socket-util.c b/lib/socket-util.c > index 8949da7..732fd89 100644 > --- a/lib/socket-util.c > +++ b/lib/socket-util.c > @@ -112,6 +112,11 @@ set_dscp(int fd, uint8_t dscp) > return 0; > #endif > > +#ifdef __APPLE__ > +/* ToDo

Re: [ovs-dev] [PATCH 3/4] ofproto: Fix duplicate wait function from OSX

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > Signed-off-by: Dave Tucker > --- > ofproto/ofproto-dpif.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index bf15d04..a922544 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofprot

Re: [ovs-dev] [PATCH 4/4] docs: Add README.OSX.md

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > Signed-off-by: Dave Tucker Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 11/11] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-01-23 Thread Thomas Graf
On 01/22/15 at 03:07pm, Ben Pfaff wrote: > On Thu, Jan 22, 2015 at 10:44:33PM +0100, Thomas Graf wrote: > > From: Madhu Challa > > > > Introduces two new NXMs to represent VXLAN-GBP [0] fields. > > > > actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMA

Re: [ovs-dev] [PATCH 3/4] ofproto: Fix duplicate wait function from OSX

2015-01-23 Thread Thomas Graf
On 01/23/15 at 04:10pm, Dave Tucker wrote: > > > On 23 Jan 2015, at 11:38, Thomas Graf wrote: > >I doubt that the Darwin implementation takes a struct ofproto ;-) > > Yeah I brute-forced a way around it that only generates some compile time > warnings :) > > &

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Thomas Graf
On 01/23/15 at 04:07pm, Dave Tucker wrote: > >This needs some style changes ;-) > > Wait, you mean its obvious I'm not a C coder? > Will take a look and see what I can do... Have a look at CodingStyle.md ;-) ___ dev mailing list dev@openvswitch.org http

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-26 Thread Thomas Graf
On 01/26/15 at 05:30pm, Simon Horman wrote: > On Mon, Jan 26, 2015 at 04:40:49PM +0900, Simon Horman wrote: > > * Although somewhat cure the approach of setting the next field to NULL > > s/cure/crude/ > > > seems far less dangerous than trying to update the list infrastructure > > to handle

Re: [ovs-dev] [PATCH] autotest: Use modprobe for kernel module unloading

2015-01-26 Thread Thomas Graf
On 01/26/15 at 11:26am, Christoph Jaeger wrote: > rmmod fails if the module is not loaded; thus, Vagrant aborts provisioning > when started from a clean slate. Use modprobe, which does not fail, instead. > Unloading unused modules the to-be-unloaded module depends on may also be > desirable. > > S

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-27 Thread Thomas Graf
On 01/27/15 at 09:22am, Simon Horman wrote: > Hi Ben, Hi Thomas, > > On Mon, Jan 26, 2015 at 11:19:53AM -0800, Ben Pfaff wrote: > > On Mon, Jan 26, 2015 at 02:44:07PM +0100, Thomas Graf wrote: > > > list_moved() not handling the list_empty() case is somewhat rude. > &

Re: [ovs-dev] [PATCH] ofp-util: constify buckets parameter of ofputil_append*_group_desc_reply()

2015-01-27 Thread Thomas Graf
On 01/27/15 at 05:12pm, Simon Horman wrote: > This parameter is not modified so it may be marked as const. > > Signed-off-by: Simon Horman Straight forward, pushed to master. Thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailm

[ovs-dev] [PATCH 03/11] datapath: Account for "vxlan: Group Policy extension"

2015-01-27 Thread Thomas Graf
-ofctl add-flow br0 'in_port=1,actions=load:0x200->NXM_NX_TUN_GBP_ID[],NORMAL' # ovs-ofctl add-flow br0 'in_port=2,tun_gbp_id=0x200,actions=drop' [0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy [1] http://lwn.net/Articles/204905/ Signed-of

[ovs-dev] [PATCH 00/11 v2] Datapath sync & VXLAN-GBP

2015-01-27 Thread Thomas Graf
NXM_NX_TUN_GBP_FLAGS Thomas Graf (10): datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there" datapath: Account for now exposed VXLAN definitions datapath: Account for "vxlan: Group Policy extension" datapath: Rename GENEVE_T

[ovs-dev] [PATCH 02/11] datapath: Account for now exposed VXLAN definitions

2015-01-27 Thread Thomas Graf
t for header flags") Signed-off-by: Thomas Graf --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/vxlan.h | 14 +++- datapath/linux/compat/vxlan.c | 37 ++- 3 files changed, 41 insertions(+), 12 deletion

[ovs-dev] [PATCH 05/11] datapath: Allow for any level of nesting in flow attributes

2015-01-27 Thread Thomas Graf
attributes to arbitrary depth. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 81bfe3 ("openvswitch: Allow for any level of nesting in flow attributes") Signed-off-by: Thomas Graf --- datapath/flow_netlink.c | 107 +-

[ovs-dev] [PATCH 08/11] datapath: Account for "netlink: make nlmsg_end() and genlmsg_end() void"

2015-01-27 Thread Thomas Graf
genlmsg_end() no longer returns an error value. Not a problem as it never returned an error code anyway. Upstream: 053c09 ("netlink: make nlmsg_end() and genlmsg_end() void") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletion

[ovs-dev] [PATCH 09/11] datapath: Allow building against 3.19.x

2015-01-27 Thread Thomas Graf
Signed-off-by: Thomas Graf --- FAQ.md | 1 + NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/FAQ.md b/FAQ.md index 02fe2d3..2de4936 100644 --- a/FAQ.md +++ b/FAQ.md @@ -147,6 +147,7 @@ A: The following table lists the Linux kernel

[ovs-dev] [PATCH 01/11] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

2015-01-27 Thread Thomas Graf
uot; is misleading there") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath/actions.c| 4 ++-- datapath/datapath.c | 4 ++-- datapath/flow.c | 4 ++-- datapath/linux/comp

[ovs-dev] [PATCH 11/11] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-01-27 Thread Thomas Graf
From: Madhu Challa Introduces two new NXMs to represent VXLAN-GBP [0] fields. actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL tun_gbp_id=0x10,actions=drop This enables existing VXLAN tunnels to carry security label information such as a SELinux context to other network peers. The values are

[ovs-dev] [PATCH 04/11] datapath: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()

2015-01-27 Thread Thomas Graf
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic tunnel metadata options. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: d91641d ("openvswitch: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()") Signed-off-by: Thomas Graf --- datapath/flow.c

[ovs-dev] [PATCH 07/11] datapath: Account for "genetlink: pass only network namespace to genl_has_listeners()"

2015-01-27 Thread Thomas Graf
since it's an inline, but makes the caller less magic - there's never any reason to pass another socket. Signed-off-by: Johannes Berg Signed-off-by: David S. Miller Upstream: f8403a2 ("genetlink: pass only network namespace to genl_has_listeners()&quo

[ovs-dev] [PATCH 06/11] datapath: Support VXLAN Group Policy extension

2015-01-27 Thread Thomas Graf
TUNNEL_VXLAN_OPT is introduced. The attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 1dd144 ("openvswitch: Support VXLAN Group Policy exte

[ovs-dev] [PATCH 10/11] tunnel: Provide framework for tunnel extensions for VXLAN-GBP and others

2015-01-27 Thread Thomas Graf
Supports a new "exts" field in the tunnel configuration which takes a comma separated list of enabled extensions. The only extension supported so far is GBP but this can be used to enable RCO and possibly others as soon as the OVS datapath supports them. Signed-off-by: Thomas Graf ---

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-28 Thread Thomas Graf
On 01/28/15 at 01:22pm, Ben Pfaff wrote: > Are you sure? What *gms points to, that is, **gms, is freed, but *gms > should still point to the same location. list_moved() never > dereferences 'orig', only compares it against list->next. In a very > language-lawyer way, working with a pointer to fr

Re: [ovs-dev] [PATCH] vlog: Don't fail syslog initialization in chroot.

2015-01-29 Thread Thomas Graf
log to be skipped if /dev/log is not available so messages would still be logged to the console. Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] INSTALL.DPDK: Update documentation to indicate VFIO support

2015-01-29 Thread Thomas Graf
On 01/29/15 at 02:03pm, Mark D. Gray wrote: > 2. Setup DPDK devices: > + > + DPDK devices can be setup using either the VFIO (for DPDK 1.7+) or UIO > + modules. UIO requires inserting an out of tree driver igb_uio.ko that is > + available in DPDK. Setup for both methods are described below.

Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Update documentation to indicate VFIO support

2015-01-29 Thread Thomas Graf
On 01/29/15 at 03:22pm, Mark D. Gray wrote: > Since DPDK 1.7, VFIO is supported in place of UIO. This allows > a user to avoid having to insert a non-standard kernel module. > > This patch updates the documentation with instructions for > setting up OVS with VFIO. As part of this work, VFIO was al

Re: [ovs-dev] [PATCH 01/11] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

2015-01-30 Thread Thomas Graf
On 01/29/15 at 07:44pm, Pravin Shelar wrote: > > +#ifndef HAVE_SKB_VLAN_TAG_PRESENT > > +#define skb_vlan_tag_present(skb) vlan_tx_tag_present(skb) > > +#define skb_vlan_tag_get(skb) vlan_tx_tag_get(skb) > > +#endif > > + > > > No need to search skb_vlan_tag_present(), since it is macro we can us

Re: [ovs-dev] [PATCH 02/11] datapath: Account for now exposed VXLAN definitions

2015-01-30 Thread Thomas Graf
On 01/29/15 at 07:45pm, Pravin Shelar wrote: > > +#ifdef HAVE_NET_VXLAN_H > > #include_next > > +#endif > > + > > I do not see need for HAVE_NET_VXLAN_H. Is current check not working? Nothing wrong. We just don't include in some cases when it is available. I changed it back to USE_KERNEL_TUNNE

Re: [ovs-dev] [PATCH 03/11] datapath: Account for "vxlan: Group Policy extension"

2015-01-30 Thread Thomas Graf
On 01/29/15 at 07:45pm, Pravin Shelar wrote: > > +#ifdef HAVE_VXLAN_METADATA > > static inline int rpl_vxlan_xmit_skb(struct vxlan_sock *vs, > > struct rtable *rt, struct sk_buff *skb, > > __be32 src, __be32 dst, __u8 tos, __u8 ttl, __be16 df, > > -

[ovs-dev] [PATCH 01/13] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

2015-01-30 Thread Thomas Graf
uot; is misleading there") Signed-off-by: Thomas Graf --- datapath/actions.c| 4 ++-- datapath/datapath.c | 4 ++-- datapath/flow.c | 4 ++-- datapath/linux/compat/gso.c | 4 ++-- datapath/linux/

[ovs-dev] [PATCH 02/13] datapath: Account for now exposed VXLAN definitions

2015-01-30 Thread Thomas Graf
t for header flags") Signed-off-by: Thomas Graf --- datapath/linux/compat/include/net/vxlan.h | 12 ++ datapath/linux/compat/vxlan.c | 37 ++- 2 files changed, 38 insertions(+), 11 deletions(-) diff --git a/datapath/linux/compat/include/net/

[ovs-dev] [PATCH 04/13] datapath: Account for "vxlan: add x-netns support"

2015-01-30 Thread Thomas Graf
: Nicolas Dichtel Signed-off-by: David S. Miller Upstream: f01ec1c017de ("vxlan: add x-netns support") Signed-off-by: Thomas Graf --- datapath/linux/compat/include/net/vxlan.h | 6 +++--- datapath/linux/compat/vxlan.c | 4 ++-- datapath/vport-vxlan.c| 2 +

[ovs-dev] [PATCH 00/13 v3] Datapath sync & VXLAN-GBP

2015-01-30 Thread Thomas Graf
duced. The attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Madhu Challa (1): ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS Thomas Graf (12): datapath: Account for "rename vlan_tx_* helpers sin

[ovs-dev] [PATCH 03/13] datapath: Account for "vxlan: Group Policy extension"

2015-01-30 Thread Thomas Graf
-ofctl add-flow br0 'in_port=1,actions=load:0x200->NXM_NX_TUN_GBP_ID[],NORMAL' # ovs-ofctl add-flow br0 'in_port=2,tun_gbp_id=0x200,actions=drop' [0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy [1] http://lwn.net/Articles/204905/ Signed-of

[ovs-dev] [PATCH 05/13] datapath: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()

2015-01-30 Thread Thomas Graf
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic tunnel metadata options. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: d91641d ("openvswitch: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()") Signed-off-by: Thomas Graf --- datapath/flow.c

[ovs-dev] [PATCH 06/13] datapath: Allow for any level of nesting in flow attributes

2015-01-30 Thread Thomas Graf
attributes to arbitrary depth. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 81bfe3 ("openvswitch: Allow for any level of nesting in flow attributes") Signed-off-by: Thomas Graf --- datapath/flow_netlink.c | 107 +-

[ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-01-30 Thread Thomas Graf
TUNNEL_VXLAN_OPT is introduced. The attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 1dd144 ("openvswitch: Support VXLAN Group Policy exte

[ovs-dev] [PATCH 08/13] datapath: Account for "vxlan: Eliminate dependency on UDP socket in transmit path"

2015-01-30 Thread Thomas Graf
d-off-by: Tom Herbert Signed-off-by: David S. Miller Upstream: af33c1adae1e ("vxlan: Eliminate dependency on UDP socket in transmit path") Signed-off-by: Thomas Graf --- datapath/linux/compat/include/net/vxlan.h | 12 datapath/linux/compat/vxlan.c

[ovs-dev] [PATCH 10/13] datapath: Account for "netlink: make nlmsg_end() and genlmsg_end() void"

2015-01-30 Thread Thomas Graf
genlmsg_end() no longer returns an error value. Not a problem as it never returned an error code anyway. Upstream: 053c09 ("netlink: make nlmsg_end() and genlmsg_end() void") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletion

[ovs-dev] [PATCH 09/13] datapath: Account for "genetlink: pass only network namespace to genl_has_listeners()"

2015-01-30 Thread Thomas Graf
since it's an inline, but makes the caller less magic - there's never any reason to pass another socket. Signed-off-by: Johannes Berg Signed-off-by: David S. Miller Upstream: f8403a2 ("genetlink: pass only network namespace to genl_has_listeners()&quo

[ovs-dev] [PATCH 12/13] tunnel: Provide framework for tunnel extensions for VXLAN-GBP and others

2015-01-30 Thread Thomas Graf
Supports a new "exts" field in the tunnel configuration which takes a comma separated list of enabled extensions. The only extension supported so far is GBP but this can be used to enable RCO and possibly others as soon as the OVS datapath supports them. Signed-off-by: Thomas Graf ---

[ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-01-30 Thread Thomas Graf
Signed-off-by: Thomas Graf --- FAQ.md | 1 + NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/FAQ.md b/FAQ.md index 02fe2d3..2de4936 100644 --- a/FAQ.md +++ b/FAQ.md @@ -147,6 +147,7 @@ A: The following table lists the Linux kernel

[ovs-dev] [PATCH 13/13] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-01-30 Thread Thomas Graf
From: Madhu Challa Introduces two new NXMs to represent VXLAN-GBP [0] fields. actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL tun_gbp_id=0x10,actions=drop This enables existing VXLAN tunnels to carry security label information such as a SELinux context to other network peers. The values are

Re: [ovs-dev] [PATCH] NEWS: Mention group support in version 2.1.

2015-02-02 Thread Thomas Graf
On 02/01/15 at 01:50pm, Ben Pfaff wrote: > Someone asked about support and I realized that we forgot to mention it, > so do so belatedly. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH] ofp-util: Issue error when OFPGC_DELETE command includes buckets.

2015-02-02 Thread Thomas Graf
On 01/30/15 at 02:24pm, Ben Pfaff wrote: > An OFPGC_DELETE command deletes a whole group, including all of its > buckets, and so it doesn't make sense for the command itself to include any > specification of buckets. > > ONF-JIRA: EXT-510 > Signed-off-by: Ben Pfaff LGT

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Thomas Graf
On 02/03/15 at 10:08am, Pravin Shelar wrote: > On Fri, Jan 30, 2015 at 6:36 AM, Thomas Graf wrote: > > + flags = TUNNEL_KEY; > > + vxlan_port = vxlan_vport(vport); > > + if (vxlan_port->exts & VXLAN_F_GBP) > > + flags |= TUNNEL_VX

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Thomas Graf
On 02/03/15 at 02:25pm, Pravin Shelar wrote: > I agree port will continue to accept non GBP frames but sets > TUNNEL_VXLAN_OPT which is odd. Since it is checking extension for the > vport. > Why not set TUNNEL_VXLAN_OPT according to received packet header/metadata? Good point. I will change it to

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-04 Thread Thomas Graf
On 02/03/15 at 05:55pm, Jesse Gross wrote: > On Tue, Feb 3, 2015 at 3:18 PM, Jesse Gross wrote: > > It seems like in general userspace should not allow different > > extensions to share the same datapath port. This perhaps isn't much of > > an issue right now but if you enable an extension on one

Re: [ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-02-04 Thread Thomas Graf
On 02/03/15 at 10:09am, Pravin Shelar wrote: > When I tried this patch series against mainline 3.19-rc7, I got > following error on insert. > > openvswitch: Unknown symbol rpl_vxlan_xmit_skb (err 0) > openvswitch: Unknown symbol rpl_vxlan_sock_release (err 0) > openvswitch: Unknown symbol rpl_vxla

[ovs-dev] [PATCH] travis: Add 32 bit (-m32) cross-compile build

2015-02-04 Thread Thomas Graf
s SSL disabled as the Ubuntu libssl-devel package is not multiarch compatible on the travis build system. Signed-off-by: Thomas Graf --- .travis.yml| 1 + .travis/build.sh | 8 ++-- .travis/prepare.sh | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.travis.

[ovs-dev] [PATCH 0/6 v4] Datapath sync & VXLAN-GBP

2015-02-04 Thread Thomas Graf
nary value kept intact, a new flag TUNNEL_VXLAN_OPT is introduced. The attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Madhu Challa (1): ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS Thomas Graf (5): datapa

[ovs-dev] [PATCH 1/6] datapath: Fix missing symbols when required to use own VXLAN stack

2015-02-04 Thread Thomas Graf
in the compat header as required. This centralizes the decision when to include VXLAN compat code to a single place which eases further changes. Reported-by: Pravin Shelar Signed-off-by: Thomas Graf --- datapath/linux/compat/gso.c | 7 --- datapath/linux/compat/gso.h

[ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-04 Thread Thomas Graf
TUNNEL_VXLAN_OPT is introduced. The attributes OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS and existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS are implemented mutually exclusive. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: 1dd144 ("openvswitch: Support VXLAN Group Policy exte

<    3   4   5   6   7   8   9   10   11   >