On 01/20/15 at 07:13am, Ben Pfaff wrote: > What was the key change to the commit message? (I guess you might have > to describe it instead of showing it, if something in the change is > triggering a filter somewhere.)
Attaching diff ;-) Maybe the word "free" in the subject and body in combination with other keywords. --- o1 2014-12-30 01:20:17.000000000 +0100 +++ o2 2015-01-02 19:35:43.000000000 +0100 @@ -1,26 +1,22 @@ Return-Path: <tg...@noironetworks.com> Received: from lsx.localdomain (77-56-195-25.dclient.hispeed.ch. [77.56.195.25]) - by mx.google.com with ESMTPSA id fx6sm51814624wjc.39.2014.12.29.16.20.16 + by mx.google.com with ESMTPSA id je12sm54959581wic.22.2015.01.02.10.35.43 for <dev@openvswitch.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); - Mon, 29 Dec 2014 16:20:16 -0800 (PST) + Fri, 02 Jan 2015 10:35:43 -0800 (PST) From: Thomas Graf <tg...@noironetworks.com> To: dev@openvswitch.org -Subject: [PATCH 2/7] datapath: vlan: introduce __vlan_insert_tag helper which does not free skb -Date: Tue, 30 Dec 2014 01:19:59 +0100 -Message-Id: <840b9f4a18f7b6169e4140513f78ee484c4ffb4a.1419898508.git.tg...@noironetworks.com> +Subject: [PATCH 2/8] datapath: Add __vlan_insert_tag() compat helper if not available +Date: Fri, 2 Jan 2015 19:35:31 +0100 +Message-Id: <04eaa847d47abe5ac04344476c3912a962290290.1420223664.git.tg...@noironetworks.com> X-Mailer: git-send-email 1.9.3 -In-Reply-To: <cover.1419898508.git.tg...@noironetworks.com> -References: <cover.1419898508.git.tg...@noironetworks.com> -In-Reply-To: <cover.1419898508.git.tg...@noironetworks.com> -References: <cover.1419898508.git.tg...@noironetworks.com> -Content-Length: 2471 -Lines: 70 +In-Reply-To: <cover.1420223664.git.tg...@noironetworks.com> +References: <cover.1420223664.git.tg...@noironetworks.com> +In-Reply-To: <cover.1420223664.git.tg...@noironetworks.com> +References: <cover.1420223664.git.tg...@noironetworks.com> +Content-Length: 2339 +Lines: 66 -There's a need for a helper which inserts vlan tag but does not free the -skb in case of an error. - -Note on backwards compatibility: Since older kernels do not have skb->vlan_proto, it is assumed that kernels which don't provide their own __vlan_insert_tag() will also not have skb->vlan_proto. The backwards compat function therefore _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev