On 01/15/15 at 12:22pm, Andy Zhou wrote: > On Thu, Jan 15, 2015 at 9:56 AM, Thomas Graf <tg...@noironetworks.com> wrote: > >> +m4_define([OVS_KMOD_VSWITCHD_START], > >> + [ AT_CHECK([modprobe openvswitch]) > > > > Assuming that we want to use this outside of Vagrant as well: > > I wonder whether we should provide a config with -C ensuring that the > What do you mean?
The code currently assumes that 'modprobe openvswitch' will load the module that was just installed. There could be a modprobe config on the system which creates an alias and points it a module installed in a different location. I think this is fine now but we can consider providing a modprobe config which points directly to the absolute path where we just installed the kmod. > > freshly compiled kmod is actually loaded. We might also want to verify > > if a openvswitch kmod is already loaded. > Checking the return value is not enough? It would not return an error if an openvswitch module is already loaded, right? In that case we would not be testing the code that was compiled and installed. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
