On 09/24/14 at 03:01pm, Simon Horman wrote:
> > > + /* Only possible type of attributes is OVS_SELECT_GROUP_ATTR_BUCKET */
> > > + for (bucket = nla_data(attr), rem = nla_len(attr); rem > 0;
> > > + bucket = nla_next(bucket, &rem)) {
> > > + uint16_t weight = bucket_weight(bucket);
> >
On 09/23/14 at 06:32pm, Or Gerlitz wrote:
> Indeed.
>
> The idea is to leverage OVS to manage eSwitch (embedded NIC switch) as well
> (NOT to offload OVS).
>
> We envision a seamless integration of user environment which is based on OVS
> with SRIOV eSwitch and the grounds for that were very well
On 09/26/14 at 11:03pm, Or Gerlitz wrote:
> Yep, this can serve us for the architecture discussion @ LPC. Re the
> SRIOV case, you referred to the case where guest VF traffic goes
> through HW (say) VXLAN encap/decap -- just to make sure, we need also
> to support the simpler case, where guest traf
realloc during message
construction.
The nat patch is still very WIP. The configuration of the nat action
in the data path works but I haven't worked much further.
Justin Pettit (1):
RFC: Add support for connection tracking.
Thomas Graf (4):
datapath: Use central function to free sw_flow
WIP
---
datapath/actions.c | 8
datapath/flow.h | 1 +
datapath/flow_netlink.c | 22 ++
3 files changed, 31 insertions(+)
diff --git a/datapath/actions.c b/datapath/actions.c
index beed5d8..05b465c 100644
--- a/datapath/actions.c
+++ b/datapath/actions.
From: Justin Pettit
An RFC to get back early feedback on exposing Linux's kernel connection
tracker to OVS. The code has a few rough spots that will be addressed
in the next version:
- Need better interface than setting individual flags for the state.
- Need support for IP frags.
-
WIP
---
datapath/actions.c| 95 +++
datapath/flow.h | 6 +
datapath/flow_netlink.c | 139 ++
datapath/linux/compat/include/linux/openvswitch.h | 54 +
4 files cha
WIP
---
lib/dpif-netdev.c| 1 +
lib/dpif.c | 1 +
lib/odp-execute.c| 1 +
lib/odp-util.c | 113 +++
lib/ofp-actions.c| 104 +++
lib/ofp-actions.h
We are hitting spurious CI failures. I assume it's due to the VM
running relatively slow and thus the current ovs-appctl time/warp not
being sufficient. I'm not familiar with all the tests cases, can we
just +50% on the current values to account for the slowness? Better
fix?
Thomas
___
On 10/01/14 at 04:56pm, Justin Pettit wrote:
> Thomas, is there a reason not to consider this patch as-is right now? It
> seems like a straight-forward code cleanup with no direct association with
> the later patches.
No reason at all. Let me submit it separately and we can merge it.
On 10/06/14 at 11:47am, Or Gerlitz wrote:
> On Sat, Sep 27, 2014 at 12:02 AM, Thomas Graf wrote:
> > On 09/26/14 at 11:03pm, Or Gerlitz wrote:
> >> Also, this BoF needs to be double-len, two hours, can you act to
> >> get that done?
> >
> > This has already
Signed-off-by: Thomas Graf
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 43cc420..846172d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -69,7 +69,7 @@ EXTRA_DIST = \
INSTALL \
INSTALL.Debian
the upcoming multi-queue patch fix).
>
> Reviewed-by: Mark D. Gray
> Signed-off-by: Maryam Tahhan
Acked-by: Thomas Graf
> diff --git a/INSTALL.DPDK b/INSTALL.DPDK
> index d9a77c9..7484b4b 100644
> --- a/INSTALL.DPDK
> +++ b/INSTALL.DPDK
> @@ -14,10 +14,10 @@ an
On 10/16/14 at 05:57pm, Jesse Gross wrote:
> Proposals on a kernel offload API:
Additional notes from the switching offload BoF can be found
here: https://etherpad.fr/p/LPC2014_NetOffload
Slides: http://goo.gl/ChGFnx (still being uploaded)
___
dev maili
y name table changes.
>
> Signed-off-by: Pravin B Shelar
LGTM
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
;
> Signed-off-by: Pravin B Shelar
LGTM. Some minor comments belows. Nothing that should block this.
Acked-by: Thomas Graf
> +bool
> +ovs_router_lookup(ovs_be32 ip_dst, char output_bridge[], ovs_be32 *gw)
> +{
> +const struct cls_rule *cr;
> +struct flow flow;
> +
TEWAY]) {
> +change->rd.rta_gw = nl_attr_get_be32(attrs[RTA_GATEWAY]);
> +}
Note that this only works for single nexthop routes. Probably good
enough for now but we should eventually convert this to use the
fib lookup Netlink API to correctly work with multipath r
error prone maintenance of the global list
vport_ops_list.
Signed-off-by: Thomas Graf
---
net/openvswitch/Kconfig | 18 +++
net/openvswitch/Makefile | 14 ++---
net/openvswitch/datapath.c | 16 +-
net/openvswitch/vport-geneve.c | 23
On 10/22/14 at 11:04pm, Scott Mann wrote:
> On Wed, Oct 22, 2014 at 10:09 PM, Ben Pfaff wrote:
> > I see the failure.
> >
> > I suspect that the root cause is something different that we should fix
> > separately. I spent a few minutes investigating, but I did not
> > completely isolate the probl
VLOG_DEFINE_MODULE() to catch duplicate
definitions with a proper backtrace.
Cc: Scott Mann
Cc: Ben Pfaff
Cc: Gurucharan Shetty
Signed-off-by: Thomas Graf
---
lib/classifier.c| 61 +++---
lib/classifier.h| 65
On 10/23/14 at 11:38am, Jarno Rajahalme wrote:
> > On Oct 23, 2014, at 8:22 AM, Ben Pfaff wrote:
> >
> >> On Thu, Oct 23, 2014 at 12:04:18PM +0200, Thomas Graf wrote:
> >> Exposes the necessary structs and functions in classifier.h to allow
> >> test-cla
On 10/23/14 at 02:15pm, Jarno Rajahalme wrote:
> @@ -472,8 +470,8 @@ pvector_verify(const struct pvector *pvec)
> PVECTOR_FOR_EACH (ptr, pvec) {
> priority = cursor__.vector[cursor__.entry_idx].priority;
> if (priority > prev_priority) {
> -VLOG_ABORT("Priority ve
On 10/24/14 at 11:20am, Akshay Sahu wrote:
> But " insmod datapath/linux/openvswitch.ko " I'm not been able in OVS
> kernel module, it shows me an error
> " insmod: error inserting 'datapath/linux/openvswitch.ko': -1 Unknown
> symbol in module "
Install the module and use modprobe instead of insmo
First of all, great to see this work. This is awesome! I read through
the code a first time. Planning to do more reviewing but looks very
sane already.
On 10/16/14 at 11:38am, Pravin B Shelar wrote:
> + 192.168.1.1/24
> + +--+
> + |int-br|
On 10/24/14 at 10:47am, Pravin Shelar wrote:
> On Wed, Oct 22, 2014 at 8:29 AM, Thomas Graf wrote:
> > The internal and netdev vport remain part of openvswitch.ko. Encap
> > vports including vxlan, gre, and geneve can be built as separate
> > modules and are loaded on d
On 10/24/14 at 12:23pm, Pravin Shelar wrote:
> >> * enum ovs_action_attr - Action types.
> >> *
> >> @@ -633,6 +642,10 @@ enum ovs_action_attr {
> >> * data immediately followed by a mask.
> >> * The data must be zero for
On 10/24/14 at 01:43pm, Pravin Shelar wrote:
> On Fri, Oct 24, 2014 at 12:41 PM, Kyle Mestery wrote:
> > Neutron uses those for the physical bridge mappings when using the OVS
> > agent with the ML2 plugin [1] and VLANs.
> >
> > [1]
> > http://docs.openstack.org/havana/install-guide/install/apt/c
On 10/27/14 at 04:12pm, Simon Horman wrote:
> The original motivation for this change was to allow the helper to be used
> in files other than actions.c as part of work on an odp select group
> action.
>
> It was as pointed out by Thomas Graf that this helper would be best
On 10/24/14 at 04:17pm, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 10/21/14 at 04:02pm, Scott Mann wrote:
> lib/libopenvswitch.sym.in | 4
> lib/libsflow.sym.in | 4
> ofproto/libofproto.sym.in | 4
> ovsdb/libovsdb.sym.in | 4
Scott,
Can you add the generated .sym files to .gitignore?
On 10/27/14 at 10:14am, Pravin Shelar wrote:
> On Fri, Oct 24, 2014 at 2:57 PM, Thomas Graf wrote:
> > I was refering to how many other kernel APIs have been designed, a
> > registration API allowing a vport to be implemented exclusively in the
> > scope of a single file ten
On 10/27/14 at 05:27pm, Pravin Shelar wrote:
> On Mon, Oct 27, 2014 at 2:47 PM, Thomas Graf wrote:
> > What I mean specifically is the following dependency logic which will
> > no longer be required:
> >
> > depends on NET_IPGRE_DEMUX && !(OPENVSWITCH=y &
On 10/28/14 at 07:52am, Ben Pfaff wrote:
> On Tue, Oct 28, 2014 at 11:19:52AM +0100, Thomas Graf wrote:
> > Converts the majority of docs over to use the Markdown language for
> > pretty printing on GitHub. It's a rough first convertion without
> > exploiting the full pot
On 10/28/14 at 02:42pm, Alexei Starovoitov wrote:
> On Tue, Oct 28, 2014 at 2:27 PM, David Miller wrote:
> >>
> >> it fails the build when lockdep is on:
> >> ERROR: "lockdep_ovsl_is_held" [net/openvswitch/vport-gre.ko] undefined!
> >
> > I've fixed it thusly:
>
> thanks! that was quick. the fix
On 10/30/14 at 11:48am, Wang Sheng-Hui wrote:
> Hi,
>
> I used CentOS 6.5, and failed building the latest ovs:
>
> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
> -Wno-sign-compare -Wpointer-arith -Wno-forma
Signed-off-by: Thomas Graf
---
FAQ.md | 10 +-
INSTALL.Libvirt.md | 6 +++---
INSTALL.NetBSD.md| 3 ++-
INSTALL.SSL.md | 4 ++--
INSTALL.md | 16
INSTALL.userspace.md | 6 +++---
OPENFLOW-1.1+.md | 4 ++--
README.md
On 10/29/14 at 11:46pm, Ben Pfaff wrote:
> A "conjunctive match" allows higher-level matches in the flow table, such
> as set membership matches, without causing a cross-product explosion for
> multidimensional matches. Please refer to the documentation that this
> commit adds to ovs-ofctl(8) for
On 10/30/14 at 12:55pm, Lori Jakab wrote:
> Second, to improve readability, I would only put "[CONTRIBUTING.md]" in the
> text without the second part "(CONTRIBUTING.md)" the to avoid duplication,
> and add the reference at the end of the file as "[CONTRIBUTING.md]:
> CONTRIBUTING.md" once. The las
Suggested-by: Lori Jakab
Signed-off-by: Thomas Graf
---
- Use reference section at end of document to allow adding references
by simpling surrounding file names with [] as suggested by Lori.
CONTRIBUTING.md | 10 ++
FAQ.md | 18 +++---
INSTALL.DPDK.md
[Good news: FOSDEM will feature a dedicated networking DevRoom with half
a day reserved to SDN & NFV topics. See the announcement below for all
the details and deadlines.]
Hi everyone,
We are pleased to announce the Call for Participation in the FOSDEM
2015 Networking DevRoom!
Important dates:
On 11/10/14 at 02:52pm, Andy Zhou wrote:
> Implements ip_defrag action in Linux kenrel using ip_defrag kernel APIs.
>
> Signed-off-by: Andy Zhou
> ---
> datapath/actions.c | 39 ++-
> datapath/flow_netlink.c | 6 +-
> 2 files changed, 43 insertions(+
On 11/10/14 at 12:45pm, Pravin B Shelar wrote:
> Tunnel lookup is done in slow path but DPDK tunneling
> slow path is called in PMD context. Therefore it is
> better to convert rwlock to fat rwlock.
>
> Signed-off-by: Pravin B Shelar
Acked-
odp actions
> e.g. tun_push action.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
erate header for each packet and
> forward this packet to output port. Since tunnel-push action
> contains most of packet header vswitchd needs to lookup routing
> table and arp table to build this action.
>
> Signed-off-by: Pravin B Sh
flag.
Signed-off-by: Thomas Graf
---
.travis/build.sh | 7 +--
.travis/prepare.sh | 5 ++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/.travis/build.sh b/.travis/build.sh
index 5dba4fe..1bf0815 100755
--- a/.travis/build.sh
+++ b/.travis/build.sh
@@ -39,11 +39,14 @@ if
On 11/11/14 at 12:03pm, Andy Zhou wrote:
> On Tue, Nov 11, 2014 at 2:48 AM, Thomas Graf wrote:
> > Don't you need to pull off the ethernet header first? ip_defrag()
> > expects an IP header at skb->data.
> I could be wrong on this, but It looks to me ip_defrag uses ip_hd
Signed-off-by: Thomas Graf
---
.travis.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index cd6e623..f6177c7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -9,6 +9,8 @@ env:
- OPTS="--disable-ssl"
- TESTSUITE=1 KERNEL=1 OPTS="--with-linux
AM_LDFLAGS is not automatically passed to individual library LDFLAGS
and must be passed in explicitly.
Signed-off-by: Thomas Graf
---
lib/automake.mk | 6 --
ofproto/automake.mk | 3 ++-
ovsdb/automake.mk | 3 ++-
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib
Allows for installable headers in later commits.
Signed-off-by: Thomas Graf
---
Makefile.am | 6 ++-
configure.ac| 1 +
include/.gitignore | 1 +
include/Makefile.am | 19 +
include/automake.mk | 8
the headers. A next series will start exposing
existing APIs by moving some of the them to public headers.
Amit Bose (1):
lib: Avoid using C++ keywords as variable names
Rob Adams (1):
lib: Add support for pkgconfig for libopenvswitch
Thomas Graf (9):
lib: Correctly pass collected
Required to make the headers installable.
Signed-off-by: Thomas Graf
---
build-aux/check-structs| 2 +-
include/openflow/nicira-ext.h | 4 ++--
include/openflow/openflow-1.0.h| 2 +-
include/openflow/openflow-1.1.h| 2 +-
include/openflow/openflow-1.2.h| 2
Signed-off-by: Thomas Graf
---
INSTALL.md | 5 +
1 file changed, 5 insertions(+)
diff --git a/INSTALL.md b/INSTALL.md
index c3168dd..941cf37 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -166,6 +166,11 @@ Prerequisites section, follow the procedure below to build.
`% ./configure
Signed-off-by: Thomas Graf
---
include/openflow/automake.mk| 2 +-
include/openvswitch/automake.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/openflow/automake.mk b/include/openflow/automake.mk
index 5e0e261..770a986 100644
--- a/include/openflow
From: Rob Adams
Add rule to generate pkgconfig .pc file from configure.
Install pkg-config file to $(libdir)/pkgconfig
Signed-off-by: Rob Adams
---
AUTHORS | 1 +
Makefile.am | 2 ++
configure.ac | 1 +
lib/.gitignore | 1 +
lib/automake.
Signed-off-by: Thomas Graf
---
configure.ac | 1 +
ofproto/.gitignore | 1 +
ofproto/automake.mk | 2 ++
ofproto/libofproto.pc.in | 11 +++
4 files changed, 15 insertions(+)
create mode 100644 ofproto/libofproto.pc.in
diff --git a/configure.ac b/configure.ac
Signed-off-by: Thomas Graf
---
configure.ac | 1 +
ovsdb/.gitignore | 1 +
ovsdb/automake.mk| 3 +++
ovsdb/libovsdb.pc.in | 11 +++
4 files changed, 16 insertions(+)
create mode 100644 ovsdb/libovsdb.pc.in
diff --git a/configure.ac b/configure.ac
index 03dd22f
Signed-off-by: Thomas Graf
---
configure.ac | 1 +
lib/.gitignore | 1 +
lib/automake.mk| 3 ++-
lib/libsflow.pc.in | 11 +++
4 files changed, 15 insertions(+), 1 deletion(-)
create mode 100644 lib/libsflow.pc.in
diff --git a/configure.ac b/configure.ac
index 2f86e39
Ignore both pkgconfig and headers in RHEL package for now as there
is no -devel package yet.
Cc: Flavio Leitner
Signed-off-by: Thomas Graf
---
rhel/openvswitch-fedora.spec.in | 1 +
rhel/openvswitch.spec.in| 1 +
2 files changed, 2 insertions(+)
diff --git a/rhel/openvswitch
From: Amit Bose
Signed-off-by: Amit Bose
---
AUTHORS | 1 +
lib/dynamic-string.h | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index b5ac696..84fca3a 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -8,6 +8,7 @@ Alexey I. Froloff ra...@altlin
On 11/12/14 at 02:13pm, Flavio Leitner wrote:
> It doesn't work here:
>
> master]$ git log --oneline -2
> 7f2f24e Build: Add support for shared libraries and versioning.
> 86f35fb util: Add be32_prefix_mask().
>
> master]$ ./boot.sh && ./configure --enable-shared && make
> [...]
> /bin/sh ./libt
On 11/12/14 at 02:47pm, Flavio Leitner wrote:
> > diff --git a/Makefile.am b/Makefile.am
> > index 8e6de5f..6d2a9f1 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -125,8 +125,10 @@ scripts_SCRIPTS =
> > scripts_DATA =
> > SUFFIXES =
> > check_DATA =
> > +pkgconfig_DATA =
>
> git com
On 11/12/14 at 10:33am, Ben Pfaff wrote:
> On Wed, Nov 12, 2014 at 10:26:52AM -0800, Ben Pfaff wrote:
> > On Wed, Nov 12, 2014 at 03:06:01PM +0100, Thomas Graf wrote:
> > > Allows for installable headers in later commits.
> > >
> > > Signed-off-by: Thomas Graf
On 11/12/14 at 04:06pm, Flavio Leitner wrote:
> On Wed, Nov 12, 2014 at 03:06:09PM +0100, Thomas Graf wrote:
> > Ignore both pkgconfig and headers in RHEL package for now as there
> > is no -devel package yet.
>
> Now we have the openvswitch-fedora.spec installing the he
devel package
The library is still mostly unusable at this point without an OVS
source tree to acquire the headers. A next series will start exposing
existing APIs by moving some of the them to public headers.
Rob Adams (1):
lib: Add support for pkgconfig for libopenvswitch
Thomas Graf (5):
in
Suggested-by: Ben Pfaff
Signed-off-by: Thomas Graf
---
include/openflow/automake.mk| 3 ++-
include/openvswitch/automake.mk | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/openflow/automake.mk b/include/openflow/automake.mk
index 4194996..512991e 100644
--- a
Signed-off-by: Thomas Graf
---
configure.ac | 1 +
ofproto/.gitignore | 1 +
ofproto/automake.mk | 2 ++
ofproto/libofproto.pc.in | 11 +++
4 files changed, 15 insertions(+)
create mode 100644 ofproto/libofproto.pc.in
diff --git a/configure.ac b/configure.ac
Signed-off-by: Thomas Graf
---
configure.ac | 1 +
ovsdb/.gitignore | 1 +
ovsdb/automake.mk| 3 +++
ovsdb/libovsdb.pc.in | 11 +++
4 files changed, 16 insertions(+)
create mode 100644 ovsdb/libovsdb.pc.in
diff --git a/configure.ac b/configure.ac
index d3b3d59
Signed-off-by: Thomas Graf
---
configure.ac | 1 +
lib/.gitignore | 1 +
lib/automake.mk| 3 ++-
lib/libsflow.pc.in | 11 +++
4 files changed, 15 insertions(+), 1 deletion(-)
create mode 100644 lib/libsflow.pc.in
diff --git a/configure.ac b/configure.ac
index ee12216
From: Rob Adams
Add rule to generate pkgconfig .pc file from configure.
Install pkg-config file to $(libdir)/pkgconfig
Signed-off-by: Rob Adams
---
AUTHORS | 1 +
Makefile.am | 2 ++
configure.ac | 1 +
lib/.gitignore | 1 +
lib/automake.
cleaned up headers will be exposed in openvswitch/ and openflow/
For the RHEL spec, both pkgconfig and headers are omitted as no -devel
package exists yet.
Cc: Flavio Leitner
Suggested-by: Flavio Leitner
Signed-off-by: Thomas Graf
---
rhel/openvswitch-fedora.spec.in | 15 +--
On 11/13/14 at 10:27am, Flavio Leitner wrote:
> On Thu, Nov 13, 2014 at 12:10:17PM +0100, Thomas Graf wrote:
> > Providing config.h seems pointless too. Whatever was available on the
> > build machine can't be taken for granted on another build machine.
>
> But it tell
On 11/11/14 at 03:11pm, Andy Zhou wrote:
> >
> > I would like to keep the option to share the same zones because I
> > can see a lot of value to match on CTs which have been created by
> > netfilter or vice versa.
> Is it sufficient if both ip_defrag and conntrack actions uses the same
> zone as th
On 01/06/16 at 01:33pm, David Wragg wrote:
> Prior to 4.3, vxlan vports could transmit vxlan packets of any size,
> constrained only by the ability to transmit the resulting UDP packets.
> 4.3 introduced vxlan netdevs corresponding to vxlan vports. These
> netdevs have an MTU, which limits the siz
On 01/06/16 at 04:46pm, Jesse Gross wrote:
> On Wed, Jan 6, 2016 at 4:14 PM, Hannes Frederic Sowa
> > I don't see any other way as to make MTUs part of the flow if we want to
> > have correct ip_local_error notifications. And those must also work across
> > VMs, so openvswitch in quasi brouting mod
On 01/07/16 at 08:35am, Jesse Gross wrote:
> On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote:
> > A simple start could be to add a new return code for > MTU drops in
> > the dev_queue_xmit() path and check for NET_XMIT_DROP_MTU in
> > ovs_vport_send() and emit proper I
On 01/07/16 at 06:50pm, Hannes Frederic Sowa wrote:
> On 07.01.2016 18:21, Thomas Graf wrote:
> >On 01/07/16 at 08:35am, Jesse Gross wrote:
> >>On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote:
> >>>A simple start could be to add a new return code for > MTU
On 01/09/16 at 10:39am, roopa wrote:
> On 1/6/16, 5:33 AM, David Wragg wrote:
> > Allow the MTU of vxlan devices without an underlying device to be set to
> > larger values (up to a maximum based on IP packet limits and vxlan
> > overhead).
> >
> > Previously, their MTUs could not be set to higher
On 01/08/16 at 10:29pm, Hannes Frederic Sowa wrote:
> On 07.01.2016 19:40, Thomas Graf wrote:
> >I think you are worried about an ICMP error from a hop which does not
> >decrement TTL. I think that's a good point and I think we should only
> >send an ICMP error if the
t;udp: Add udp_sock_create for UDP
tunnels to open listener socket")
Signed-off-by: Thomas Graf
Cc: Jesse Gross
---
datapath/linux/compat/include/net/udp_tunnel.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/linux/compat/include/net/udp_tunnel.h
b/datapath/linux/compat/include/n
On 03/25/15 at 02:48pm, Pravin Shelar wrote:
> Thanks for the patch. I saw couple of issues:-
> I saw following warning due to missing symbol.
> WARNING: "lockdep_ovsl_is_held"
> [/home/pravin/ovs/w8/datapath/linux/vport-gre.ko] undefined!
Thanks for catching! Fixed.
> Command to reload kernel da
y() is safe because
the module unregistration is blocked on ovs_lock which we hold
while destroying the datapath.
Fixes: 62b9c8d0372d ("ovs: Turn vports with dependencies into separate modules")
Reported-by: Pravin Shelar
Signed-off-by: Thomas Graf
---
@Dave: Please also queue for 3.19
We manually rmmod the loaded vports as using modprobe -r
only works if the modules are available through modules.dep
Upon restart, the vports get automatically reloaded when the
respective vports are added.
Reported-by: Pravin Shelar
Signed-off-by: Thomas Graf
---
utilities/ovs-ctl.in | 4
On 03/30/15 at 09:29am, Jesse Gross wrote:
> On Mon, Mar 30, 2015 at 3:27 AM, Thomas Graf wrote:
> > Account for kernels which provide udp_sock_create() in an
> > insufficient version.
> >
> > Avoids the following error when inserting openvswitch.ko on
> > respec
lifetime.
Allows to remove the error prone maintenance of the global list
vport_ops_list.
Signed-off-by: Thomas Graf
Signed-off-by: David S. Miller
Also folds in the follow-up commits 9ba559d9ca3 to turned the non-GPL
symbol exports to GPL exports, and fa2d8ff4e35 which
On 04/01/15 at 07:45am, Kavanagh, Mark B wrote:
>
> >What's wrong with setting CFLAGS on the "configure" or "make" command
> >line? This is the standard way to do this with Automake and Autoconf.
> >
>
> Sure. However, setting CFLAGS on the command line overwrites any values
> CFLAGS has attain
On 03/31/15 at 09:17pm, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> I'd like to order some OVN stickers for distribution at OpenStack and by
> mail, so here's my OVN logo proposal. Also available at:
> http://benpfaff.org/~blp/ovn.png
> http://benpfaff.org/~blp/ovn.svg
Should
On 04/01/15 at 11:52am, Thomas Graf wrote:
> On 03/31/15 at 09:17pm, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > I'd like to order some OVN stickers for distribution at OpenStack and by
> > mail, so here's my OVN logo proposal. Also available
On 04/01/15 at 09:17am, Ben Pfaff wrote:
> On Wed, Apr 01, 2015 at 11:12:39AM -0500, Kyle Mestery wrote:
> > On Wed, Apr 1, 2015 at 10:39 AM, Ben Pfaff wrote:
> > > How about like this:
> > > http://benpfaff.org/~blp/ovn4.png
> > > http://benpfaff.org/~blp/ovn4.svg
> > >
> > > The
On 04/01/15 at 08:06am, Ben Pfaff wrote:
> On Wed, Apr 01, 2015 at 11:34:39AM +0200, Thomas Graf wrote:
> > On 04/01/15 at 07:45am, Kavanagh, Mark B wrote:
> > > Agreed; given the precedent set by OVS_ENABLE_WERROR, I figured that
> > > this was the convention.
> >
On 04/02/15 at 10:17pm, Pravin Shelar wrote:
> On Mon, Mar 30, 2015 at 6:06 AM, Thomas Graf wrote:
> > We manually rmmod the loaded vports as using modprobe -r
> > only works if the modules are available through modules.dep
> >
> > Upon restart, the vports get auto
On 04/02/15 at 10:13pm, Pravin Shelar wrote:
> Looks good. Thanks for back-porting the patch.
>
> Acked-by: Pravin B Shelar
Thanks for the review. Pushed to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 04/06/15 at 03:12pm, Russell Bryant wrote:
> A logical port that represents a container that sits behind another
> logical port has both a parent_name and a tag set. The parent_name
> identifies the parent port and the tag is the VLAN ID used to identify
> which traffic comes from that containe
On 04/05/15 at 03:03pm, Ben Pfaff wrote:
> Thanks Justin and Ethan. Applied to master, with your acks.
>
> On Sun, Apr 05, 2015 at 01:46:55PM -0700, Ethan Jackson wrote:
> > I think this is fine. Though I agree with Justin the script
> > documentation should be update. I can take care of that t
On 04/05/15 at 01:36pm, Ben Pfaff wrote:
> On Sun, Apr 05, 2015 at 12:28:46PM -0700, Justin Pettit wrote:
> > Thanks for fixing this. In the "Open vSwitch kernel module" section,
> > there's a part where "openvswitch.ko" is listed under "Provides:".
> > Should the vport kernel modules also be incl
On 04/06/15 at 01:28pm, Ben Pfaff wrote:
> I'm an RPM programmer at "cargo cult" level only. Does this mean that
> we should change:
> /lib/modules/%{kernel}/kernel/extra/openvswitch/openvswitch.ko
> /lib/modules/%{kernel}/kernel/extra/openvswitch/vport-*.ko
> to
> /lib/modules/%{kerne
On 04/06/15 at 02:00pm, Gurucharan Shetty wrote:
> > I think lxc deployment inside the VM definitely makes sense from a
> > hardware isolation perspective but it may not be feasible for
> > everyone. A simple example is resource allocation across multiple
> > tenants on process level which becomes
Thomas Graf (3):
ovs-ctl: Unload & reload vport modules on force-reload-kmod
ovs-dev: Hint that vport modules may need to be loaded manually
NEWS: Leave a comment that vports are now separate kernel modules
NEWS | 3 +++
utilities/ovs-ctl.in
reported though.
Reported-by: Pravin Shelar
Signed-off-by: Thomas Graf
---
v2:
- Try to load previously unloaded vports as suggested by Pravin
utilities/ovs-ctl.in | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/utilities/ovs-ctl.in b/utilities/ovs
In case the openvswitch.ko is loaded manually without dependencies
built, the vport modules need to be loaded manually as well.
Signed-off-by: Thomas Graf
---
utilities/ovs-dev.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 9467df5
Signed-off-by: Thomas Graf
---
NEWS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/NEWS b/NEWS
index 9f9dc4c..9714831 100644
--- a/NEWS
+++ b/NEWS
@@ -77,6 +77,9 @@ Post-v2.3.0
numbers. OpenFlow is 6653 and OVSDB is 6640.
- Support for DPDK vHost.
- Support for outer UDP
301 - 400 of 1023 matches
Mail list logo
