On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: > > >What's wrong with setting CFLAGS on the "configure" or "make" command > >line? This is the standard way to do this with Automake and Autoconf. > > > > Sure. However, setting CFLAGS on the command line overwrites any values > CFLAGS has attained via the 'configure' step. The most obvious symptom of > this is significantly degraded performance, due to the fact that the > optimization flags passed to CFLAGS during 'configure' are overwritten by the > command line value of CFLAGS.
That should not be the case at all. 9562639 fixed this and stores the flags collected by configure in OVS_CFLAGS while the user can specify his own CFLAGS. If there is a bug, let's fix the bug. > >We should certainly not introduce a configure option for every single > >possible compiler flag. > > Agreed; given the precedent set by OVS_ENABLE_WERROR, I figured that this was > the convention. The only reason this still exists is for backwards compatibility to not break existing build scripts. Specifying CFLAGS=-Werror has the same effect and f.e. travis builds are doing exactly this. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
