Hi Daniel,
I had the same reaction as Ben.
I would prefer to see any efforts being made towards improving the existing
OpenFlow “sample” action.
Some more comments inline below.
> On Apr 25, 2016, at 8:48 PM, Daniel Ye wrote:
>
> Hi Ben,
>
> Thanks for your review. I have sent a second patch
Thanks for doing this!
Acked-by: Romain Lenglet
--
Romain Lenglet
On September 10, 2015 at 6:41:41 PM, Joe Stringer (joestrin...@nicira.com)
wrote:
Previously, we had no IPFIX tests in the testsuite. Now we have one.
Signed-off-by: Joe Stringer
---
tests/ofproto-dpif.at | 37
LGTM, thanks!
Acked-by: Romain Lenglet
--
Romain Lenglet
On September 10, 2015 at 6:41:42 PM, Joe Stringer (joestrin...@nicira.com)
wrote:
Rather than describing this intention after the fact, encode this
meaning in the name of a function.
Signed-off-by: Joe Stringer
---
ofproto
LGTM, thanks!
Acked-by: Romain Lenglet
--
Romain Lenglet
On September 10, 2015 at 6:41:43 PM, Joe Stringer (joestrin...@nicira.com)
wrote:
A divide-by-zero exception like the below could occur when IPFIX
configuration is cleared while handling sampled packets from the
datapath. While
t;template
>> sets with enterprise elements for the tunnel info, save the tunnel info
>> in IPFIX cache entries, and send IPFIX DATA with tunnel info.
>> Add flowDirection element in IPFIX templates.
>>
>> Signed-off-by: Wenyu Zhang
>> Acked-by: Romain Lenglet
> + bam.flags = bc->flags;
> + bam.msg = msg->data;
> +
> + request = ofputil_encode_bundle_add(version, &bam);
> + ofpbuf_delete(msg);
> + ofpmsg_update_length(request);
> +
> + run(vconn_transact_noreply(vconn, request, &reply), "talking to %s",
> + vconn_get_name(vconn));
> +
> + if (reply) {
> + const struct ofp_header *oh;
> + enum ofptype type;
> + enum ofperr error;
> +
> + oh = reply->data;
> + error = ofptype_decode(&type, oh);
> + if (error) {
> + goto error_out;
> + }
> +
> + if (type == OFPTYPE_ERROR) {
> + ofp_print(stderr, reply->data, reply->size, verbosity + 1);
> + fflush(stderr);
> + error = ofperr_decode_msg(oh, NULL);
> + goto error_out;
> + }
> + error = OFPERR_OFPBFC_UNKNOWN;
> +error_out:
> + ofpbuf_delete(reply);
> + return error;
> + }
> + return 0;
> +}
> +
> +static void
> +ofctl_bundle(struct ovs_cmdl_context *ctx)
> +{
> + enum ofputil_protocol usable_protocols, usable_protocols2;
> + enum ofputil_protocol protocol;
> + enum ofp_version version;
> + struct vconn *vconn;
> + const char *file;
> + struct ofputil_flow_mod *fms = NULL;
> + size_t n_fms = 0;
> + struct ofputil_bundle_ctrl_msg bc;
> + char *error;
> + enum ofperr ofperr;
> + size_t i;
> +
> + /* Parse bundle options, if any. */
> + if (ctx->argc > 3) {
> + error = parse_ofp_bundle_control_str(&bc, ctx->argv[2],
> + &usable_protocols);
> + if (error) {
> + ovs_fatal(0, "%s", error);
> + }
> + file = ctx->argv[3]; /* File name after the options. */
> + } else {
> + memset(&bc, 0, sizeof bc);
> + file = ctx->argv[2];
> + usable_protocols = OFPUTIL_P_OF14_UP;
> + }
> +
> + /* Parse flow mods from the file. */
> + error = parse_ofp_flow_mod_file(file, -2, &fms, &n_fms,
> + &usable_protocols2);
> + if (error) {
> + ovs_fatal(0, "%s", error);
> + }
> +
> + usable_protocols &= usable_protocols2;
> +
> + protocol = open_vconn_for_flow_mod(ctx->argv[1], &vconn, usable_protocols);
> + version = ofputil_protocol_to_ofp_version(protocol);
> +
> + ofperr = bundle_control_transact(vconn, version, &bc, OFPBCT_OPEN_REQUEST);
> + if (ofperr) {
> + ovs_fatal(0, "Bundle open failed (%s).", ofperr_to_string(ofperr));
> + }
> +
> + for (i = 0; i < n_fms; i++) {
> + struct ofputil_flow_mod *fm = &fms[i];
> +
> + if (!ofperr) {
> + ofperr = bundle_add_msg(vconn, version, &bc,
> + ofputil_encode_flow_mod(fm, protocol));
> + if (ofperr) {
> + fprintf(stderr, "Bundle flow mod #%"PRIuSIZE
> + " failed (%s), discarding bundle.",
> + i, ofperr_to_string(ofperr));
> + fflush(stderr);
> + }
> + }
> + free(CONST_CAST(struct ofpact *, fm->ofpacts));
> + }
> + free(fms);
> +
> + if (!ofperr) {
> + ofperr = bundle_control_transact(vconn, version, &bc,
> + OFPBCT_COMMIT_REQUEST);
> + if (ofperr) {
> + ovs_fatal(0, "Bundle commit failed (%s).",
> + ofperr_to_string(ofperr));
> + }
> + } else {
> + ofperr = bundle_control_transact(vconn, version, &bc,
> + OFPBCT_DISCARD_REQUEST);
> + if (ofperr) {
> + ovs_fatal(0, "Bundle discard failed (%s).",
> + ofperr_to_string(ofperr));
> + }
> + }
> + vconn_close(vconn);
> +}
> +
> static void
> ofctl_help(struct ovs_cmdl_context *ctx OVS_UNUSED)
> {
> @@ -3578,6 +3785,7 @@ static const struct ovs_cmdl_command all_commands[] = {
> 1, 2, ofctl_dump_group_stats },
> { "dump-group-features", "switch",
> 1, 1, ofctl_dump_group_features },
> + { "bundle", "switch [options] file", 2, 3, ofctl_bundle },
> { "help", NULL, 0, INT_MAX, ofctl_help },
> { "list-commands", NULL, 0, INT_MAX, ofctl_list_commands },
>
> --
> 1.7.10.4
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 15, 2015 at 7:45:31 AM, Jarno Rajahalme
(jrajaha...@nicira.com(mailto:jrajaha...@nicira.com)) wrote:
>
> > On May 14, 2015, at 23:44, Romain Lenglet wrote:
> >
> > Thanks Jarno!
> >
> >> On May 14, 2015 at 2:11:50 PM, Jarno Rajahalme
> &
Jarno,
Thanks a lot for this updated patch, this will be very useful.
Sorry, I don’t feel comfortable reviewing the other patches.
Acked-by: Romain Lenglet
--
Romain Lenglet
On May 18, 2015 at 4:26:12 PM, Jarno Rajahalme
(jrajaha...@nicira.com(mailto:jrajaha...@nicira.com)) wrote:
>
ointers to classifiers would lead to 2040 bytes (64-bit
> system). I'd like to avoid that especially when there are a handful of
> tables.
I believe you meant something like 2MB here?
--
Romain Lenglet
>
>
>
> Please let me know,
> Thanks,
>
> -
Signed-off-by: Romain Lenglet
---
third-party/ofp-tcpdump.patch |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/third-party/ofp-tcpdump.patch b/third-party/ofp-tcpdump.patch
index b1ac9a5..392d6cd 100644
--- a/third-party/ofp-tcpdump.patch
+++ b/third-party/ofp
This looks good to me. Thanks!
--
Romain Lenglet
- Original Message -
> From: "Ben Pfaff"
> To: dev@openvswitch.org
> Cc: "Ben Pfaff" , "Romain Lenglet"
> Sent: Monday, December 30, 2013 2:50:59 PM
> Subject: [PATCH v2] ofproto-dpif: Enable
Commit 96ed775f resizes all userspace metadata to be 8 bytes minimum.
Fix the upcall size checks accordingly.
Signed-off-by: Romain Lenglet
---
ofproto/ofproto-dpif-upcall.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto
Signed-off-by: Romain Lenglet
---
ofproto/ofproto-dpif-ipfix.c | 120 ++
1 file changed, 87 insertions(+), 33 deletions(-)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index 2500efd..a529884 100644
--- a/ofproto/ofproto-dpif
Signed-off-by: Romain Lenglet
---
NEWS |1 +
ofproto/ofproto-dpif-ipfix.c | 120 ++
2 files changed, 88 insertions(+), 33 deletions(-)
diff --git a/NEWS b/NEWS
index 34dde6b..7c6ae70 100644
--- a/NEWS
+++ b/NEWS
@@ -67,6 +67,7
That sounds right. Thanks Ben!
Acked-by: Romain Lenglet
--
Romain Lenglet
On February 22, 2015 at 11:30:49 AM, Ben Pfaff (b...@nicira.com) wrote:
I think that the critical commit is commit 4490108b4a5ada (openvswitch:
Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.), which first
The last patches on OF 1.4 bundles were from Jarno in Dec 2014.
Does anyone plan to implement that feature in OVS 2.4?
Thanks,
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
flows for a specific table, replace-flows
will empty that table.
We can work with this behavior for now. Passing the subset of tables to modify
is an optimization which we can add on top later.
Thanks Jarno!
--Romain Lenglet
This change is in OVS master and branch-2.5.
On Jan 9, 2013, at 4:00 PM, Ben Pfaff wrote:
> ipfix-gen-entities is only used at build time, that is, we do not
> install it, so I do not think it is worthwhile to generate it from a
> .in file. (For Python programs, that is mostly to get the right
> Python binary, which isn't necessary at buil
those patches since your previous reviews.
Regards,
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 19
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 83 +-
tests/odp.at | 1 +
4 files changed, 97 insertions(+), 15 deletions(-)
diff --git a/lib/odp
Signed-off-by: Romain Lenglet
---
ofproto/automake.mk | 2 +
ofproto/ofproto-dpif-ipfix.c | 126 +++
ofproto/ofproto-dpif-ipfix.h | 28 ++
ofproto/ofproto-dpif.c | 25 +
ofproto/ofproto-provider.h | 8 +++
ofproto
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding
OFPACT_SAMPLE_IPFIX OVS action.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
include/openflow/nicira-ext.h | 22 +
lib/ofp-actions.c | 45
arrived. So we need to get a bit more information from the kernel to
> userspace somehow.
I guess that will require increasing the cookie size or use the cookie as an
index?
[...]
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Jan 17, 2013, at 2:19 PM, Ben Pfaff wrote:
> On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote:
>> Signed-off-by: Romain Lenglet
>
> The schema limits each bridge to at most one IPFIX collector. Is
> there an a priori reason why this is limited? It se
Ben Pfaff wrote:
>>>>> On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote:
>>>> One more thing. sFlow and NetFlow configuration work somewhat
>>>> differently from IPFIX configuration. For sFlow and NetFlow, when the
>>>> admin
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding
OFPACT_SAMPLE_IPFIX OVS action.
Signed-off-by: Romain Lenglet
---
FAQ | 13 ++--
NEWS | 1 +
WHY-OVS | 17 ++---
debian/control
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 19
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 84 +-
tests/odp.at | 1 +
4 files changed, 98 insertions(+), 15 deletions(-)
diff --git a/lib/odp
Hi Ben,
Thanks for your comments!
I updated all patches to address your comments: forbid sampling
probability 0 in the sample_ipfix action, mention IPFIX in the
documentation where NetFlow is mentioned, etc.
--
Romain Lenglet
___
dev mailing list
dev
Signed-off-by: Romain Lenglet
---
ofproto/automake.mk | 2 +
ofproto/ofproto-dpif-ipfix.c | 126 +++
ofproto/ofproto-dpif-ipfix.h | 28 ++
ofproto/ofproto-dpif.c | 25 +
ofproto/ofproto-provider.h | 8 +++
ofproto
Define NXAST_SAMPLE OpenFlow vendor action and the corresponding
OFPACT_SAMPLE OVS action, to do per-flow packet sampling.
Signed-off-by: Romain Lenglet
---
FAQ | 13 ++--
NEWS | 1 +
WHY-OVS | 17 ++---
debian/control
The "ipfix" upcall is used to per-bridge packet sampling to IPFIX
collectors.
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 13 +
lib/odp-util.h | 7 ++-
ofproto/ofproto-dpif.c | 26 +-
tests/odp.at | 1 +
4 fil
Add IPFIX collector set configuration. Add support for per-bridge
IPFIX sampling.
Signed-off-by: Romain Lenglet
---
ofproto/automake.mk | 2 +
ofproto/ofproto-dpif-ipfix.c | 160 +++
ofproto/ofproto-dpif-ipfix.h | 29
ofproto/ofproto
per-flow statistical sampling to IPFIX collectors, and the possibility
to add support for per-flow sampling to sFlow collectors later, as
requested by Jesse.
Thanks!
Regards,
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The "flow_sample" upcall is is used to sample packets on a per-flow
basis.
Make the userspace action's userdata size variable depending on the
union member used.
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 111 +++--
Add support for configuring multiple IPFIX collectors for per-flow
packet sampling.
Signed-off-by: Romain Lenglet
---
ofproto/ofproto-dpif-ipfix.c | 238 +++
ofproto/ofproto-dpif-ipfix.h | 6 +-
ofproto/ofproto-dpif.c | 10 +-
ofproto/ofproto
Prepend "ovs|" to syslog logs to make them easier to filter out of all
LOG_DAEMON logs.
---
lib/vlog.h | 2 +-
python/ovs/vlog.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/vlog.h b/lib/vlog.h
index ab746c8..c7ab206 100644
--- a/lib/vlog.h
+++ b/lib/vlog.h
@
Prepend "ovs|" to syslog logs to make them easier to filter out of all
LOG_DAEMON logs.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
lib/vlog.h | 2 +-
python/ovs/vlog.py | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
ind
Prepend "ovs|" to syslog logs to make them easier to filter out of all
LOG_DAEMON logs.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
lib/vlog.h | 2 +-
python/ovs/vlog.py | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
ind
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Thursday, April 4, 2013 7:47:19 AM
> Subject: Re: [ovs-dev] [PATCH] vlog: extend syslog format to make OVS logs
> easier to filter
>
> On W
Hi Ben,
Thanks a lot for your detailed review!
Comments inline below.
On Apr 16, 2013, at 2:30 PM, Ben Pfaff wrote:
> On Mon, Mar 25, 2013 at 06:33:02PM -0700, Romain Lenglet wrote:
>> Define NXAST_SAMPLE OpenFlow vendor action and the corresponding
>> OFPACT_SAMPLE OVS action,
Define NXAST_SAMPLE OpenFlow vendor action and the corresponding
OFPACT_SAMPLE OVS action, to do per-flow packet sampling.
Signed-off-by: Romain Lenglet
---
FAQ | 13 ++--
NEWS | 1 +
WHY-OVS | 17 ++---
debian/control
The "ipfix" upcall is used to per-bridge packet sampling to IPFIX
collectors.
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 11 +++
lib/odp-util.h | 7 ++-
ofproto/ofproto-dpif.c | 26 +-
tests/odp.at | 1 +
4 fil
Add support for configuring multiple IPFIX collectors for per-flow
packet sampling.
Signed-off-by: Romain Lenglet
---
ofproto/ofproto-dpif-ipfix.c | 221 ---
ofproto/ofproto-dpif-ipfix.h | 6 +-
ofproto/ofproto-dpif.c | 10 +-
ofproto/ofproto
The "flow_sample" upcall is is used to sample packets on a per-flow
basis.
Make the userspace action's userdata size variable depending on the
union member used.
Signed-off-by: Romain Lenglet
---
FAQ| 7 ++-
lib/odp-util.
Add IPFIX collector set configuration. Add support for per-bridge
IPFIX sampling.
Signed-off-by: Romain Lenglet
---
ofproto/automake.mk | 2 +
ofproto/ofproto-dpif-ipfix.c | 160 +++
ofproto/ofproto-dpif-ipfix.h | 28
ofproto/ofproto
Hi Ben,
Would you like me to send you a squashed patch,
or will you squash the patches yourself?
Thanks,
--
Romain Lenglet
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org, je...@nicira.com
> Sent: Thursday, Apri
Thanks for your reviews and your changes!
--
Romain Lenglet
On Apr 22, 2013, at 2:44 PM, Ben Pfaff wrote:
> On Mon, Apr 22, 2013 at 10:01:14AM -0700, Romain Lenglet wrote:
>> Define a new NXAST_SAMPLE OpenFlow vendor action and the corresponding
>> OFPACT_SAMPLE OVS action,
at flag is set.
Enable packet timestamping in the Linux datapath for flows with
"sample" or "ipfix" actions. Send microsecond-precision timestamps
received in upcalls in IPFIX flow records.
Signed-off-by: Romain Lenglet
---
dat
LGTM. I introduced this bug. Thanks a lot for fixing it!
--
Romain Lenglet
- Original Message -
> From: "Ben Pfaff"
> To: dev@openvswitch.org
> Cc: "Ben Pfaff" , "Dhaval Badiani"
> Sent: Tuesday, April 30, 2013 11:07:11 AM
> Subject: [ovs-d
Looks good to me.
--
Romain Lenglet
- Original Message -
> From: "Ben Pfaff"
> To: dev@openvswitch.org
> Cc: "Ben Pfaff"
> Sent: Monday, May 6, 2013 3:38:58 PM
> Subject: [ovs-dev] [PATCH 1/2] ofproto-dpif: Avoid figuring out sFlow and
> IP
t going and it works out, then I'll stop
> using my reviews repository.
>
> Is there another tool that you have used and found to be valuable?
I've used Review Board, and I found it much more useful than Gerrit for reviews.
http://www.reviewboard.org/
It addresses several of your concerns with Gerrit:
- visualization of a change in a single page
- threading of comments / replies
- etc.
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This patch implements an aggregator in the IPFIX exporter, to reduce
the volume of IPFIX messages sent.
There might be issues with multithreading, since the flow caches are
accessed both by upcalls and by the main run loop. I had no problems
in my (very small scale) tests. Should I add locking t
ength", and "maximumIpTotalLength" to replace
"ethernetTotalLength". Add per-flow element "flowEndReason" to
indicate whether a flow has expired because of an active timeout, the
cache size limit being reached, or the exporter being s
ength", and "maximumIpTotalLength" to replace
"ethernetTotalLength". Add per-flow element "flowEndReason" to
indicate whether a flow has expired because of an active timeout, the
cache size limit being reached, or the exporter being s
Hi,
I updated this patch to use the new OVS_PACKED macro for the new
structs.
Thanks,
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi,
I updated my IPFIX caching patch to add mutex locking to the run() and
wait() functions.
Thanks,
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ength", and "maximumIpTotalLength" to replace
"ethernetTotalLength". Add per-flow element "flowEndReason" to
indicate whether a flow has expired because of an active timeout, the
cache size limit being reached, or the exporter being s
Hi Ben,
Thanks for your review!
My comments inline.
I'll send a revised patch shortly for review.
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Tuesday, August 20, 2013 1:25:16 PM
> Subject: R
ength", and "maximumIpTotalLength" to replace
"ethernetTotalLength". Add per-flow element "flowEndReason" to
indicate whether a flow has expired because of an active timeout, the
cache size limit being reached, or the exporter being s
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Tuesday, August 20, 2013 5:08:02 PM
> Subject: Re: [PATCH] ipfix: implement flow caching and aggregation in exporter
>
> On Tue, Aug 20, 2013
ength", and "maximumIpTotalLength" to replace
"ethernetTotalLength". Add per-flow element "flowEndReason" to
indicate whether a flow has expired because of an active timeout, the
cache size limit being reached, or the exporter being s
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Wednesday, August 21, 2013 1:25:59 PM
> Subject: Re: [PATCH] ipfix: implement flow caching and aggregation in exporter
>
> On Tue, Aug 20, 2013
ength", and "maximumIpTotalLength" to replace
"ethernetTotalLength". Add per-flow element "flowEndReason" to
indicate whether a flow has expired because of an active timeout, the
cache size limit being reached, or the exporter being stopped.
Signed-off-by: Romain Lenglet
Signed-off-by: Romain Lenglet
---
lib/odp-execute.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 0f03855..c91cc4a 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -182,10 +182,11 @@ odp_execute_actions(void
for your report,
--
Romain lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
e can get either sFlow-like caching behavior, or usual IPFIX caching in
the exporter.
Thanks for your comment.
--
Romain Lenglet
>
>
> On Aug 21, 2013, at 1:50 PM, Ben Pfaff wrote:
>
>> On Wed, Aug 21, 2013 at 01:47:45PM -0700, Romain Lenglet wrote:
>>> - Original
Looks good to me, thanks!
Acked-by: Romain Lenglet
--
Romain Lenglet
On Oct 7, 2013, at 2:33 PM, Ben Pfaff wrote:
> Before commit e995e3df57ea (Allow OVS_USERSPACE_ATTR_USERDATA to be
> variable length.) userdata attributes in userspace actions were expected
> to be exactly 64 bits l
On Oct 7, 2013, at 2:33 PM, Ben Pfaff wrote:
> This prevents using an older datapath from breaking forwarding.
>
> CC: Romain Lenglet
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif-ipfix.c | 28 ++---
> ofproto/ofproto-dpif-ipfix.h |5 ++-
>
On Oct 10, 2013, at 2:56 PM, Romain Lenglet wrote:
> On Oct 7, 2013, at 2:33 PM, Ben Pfaff wrote:
>
>> This prevents using an older datapath from breaking forwarding.
>>
>> CC: Romain Lenglet
>> Signed-off-by: Ben Pfaff
>> ---
>> ofproto/ofproto-dp
- Original Message -
> From: "Jesse Gross"
> To: "Romain Lenglet"
> Cc: "Neil Mckee" , dev@openvswitch.org
> Sent: Friday, October 18, 2013 5:50:05 PM
> Subject: Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel
> structures (for
se.
Consider the need to export virtual packet sFlow information to collectors
managed by tenants of virtual machines. In this case, NOT exposing physical
information such as tunnel headers is a requirement.
I consider the ability to turn this feature on/off as a requirement to
accepting this pat
- Original Message -
> From: "Jesse Gross"
> To: "Romain Lenglet"
> Cc: "Neil Mckee" , dev@openvswitch.org
> Sent: Friday, October 18, 2013 6:23:23 PM
> Subject: Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel
> structures (for
- Original Message -
> From: "Romain Lenglet"
> To: "Jesse Gross"
> Cc: dev@openvswitch.org
> Sent: Friday, October 18, 2013 6:46:05 PM
> Subject: Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel
> structures (for GRE, VXLAN etc.)
>
- Original Message -
> From: "Jesse Gross"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Tuesday, October 22, 2013 3:46:54 PM
> Subject: Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel
> structures (for GRE, VXLAN etc.)
>
On Oct 24, 2013, at 5:46 PM, Jesse Gross wrote:
> On Thu, Oct 24, 2013 at 3:39 PM, Romain Lenglet wrote:
>> - Original Message -
>>> From: "Jesse Gross"
>>> To: "Romain Lenglet"
>>> Cc: dev@openvswitch.org
>>> Sen
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index fecae60..8f45870 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -995,7 +995,7 @@ bridge_configure_ipfix(struct
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c |6 --
vswitchd/vswitch.ovsschema |4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 8f45870..cf70b0c 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Monday, November 11, 2013 12:42:55 PM
> Subject: Re: [ovs-dev] [PATCH] ipfix: allow empty targets column in table
> IPFIX
>
> On Tue, Nov 05, 20
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Monday, November 11, 2013 12:40:29 PM
> Subject: Re: [ovs-dev] [PATCH] ipfix: fix segfault for
> Flow_Sample_Collector_Set without ipfix
>
&
iminates the
need to manually remove the "" target after row insertion.
This doesn't impact the behavior for any existing row, whether it has
a "" target or not.
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c | 14 +-
vswitchd/vswitch.ovsschema
Guard any access to an IPFIX row referenced from
Flow_Sample_Collector_Set by a test that the reference is not NULL.
Factorized that check into macro __VALID_FSCS.
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a
Guard any access to an IPFIX row referenced from
Flow_Sample_Collector_Set by a test that the reference is not NULL.
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
iminates the
need to manually remove the "" target after row insertion.
This doesn't impact the behavior for any existing row, whether it has
a "" target or not.
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c | 18 +-
vswitchd/vswitch.ovs
On Nov 20, 2013, at 4:37 PM, Ben Pfaff wrote:
> On Wed, Nov 20, 2013 at 10:57:52AM -0800, Romain Lenglet wrote:
>> Guard any access to an IPFIX row referenced from
>> Flow_Sample_Collector_Set by a test that the reference is not NULL.
>>
>> Signed-off-by: Romain
- Original Message -
> From: "Harold Lim"
> To: dev@openvswitch.org
> Cc: "Harold Lim"
> Sent: Monday, December 16, 2013 4:53:34 PM
> Subject: [ovs-dev] [PATCH] Update openvswitch to allow linking from C++
> projects
>
> 1. libopenvswitch is updated to be compiled with -fPIC.
> 2.
Define NXAST_SAMPLE OpenFlow vendor action and the corresponding
OFPACT_SAMPLE OVS action.
---
include/openflow/nicira-ext.h | 16 +++
lib/ofp-actions.c | 45 +++
lib/ofp-actions.h | 10 ++
lib/ofp-parse.c
---
lib/odp-util.c | 14
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 86 --
tests/odp.at | 1 +
4 files changed, 93 insertions(+), 17 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index de97fd
A similar patch has been discussed previously:
http://openvswitch.org/pipermail/dev/2010-October/004153.html
Have you looked at it?
Regards,
--
Romain Lenglet
- Original Message -
> From: "Rich Lane"
> To: dev@openvswitch.org
> Cc: "Rich Lane"
> Sent: M
I noticed this patch doesn't correctly handle the case of a zero sampling
probability.
I'll fix that by not translating the action in that case, and re-send a patch.
--
Romain Lenglet
- Original Message -
> From: "Romain Lenglet"
> To: dev@openvswitch.org
>
Define NXAST_SAMPLE OpenFlow vendor action and the corresponding
OFPACT_SAMPLE OVS action.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
include/openflow/nicira-ext.h | 16 +++
lib/ofp-actions.c | 45
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 14
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 88 +-
tests/odp.at | 1 +
4 files changed, 95 insertions(+), 17 deletions(-)
diff --git a/lib/odp
On Dec 11, 2012, at 10:47 AM, Ben Pfaff wrote:
> On Tue, Dec 11, 2012 at 09:54:50AM -0800, Romain Lenglet wrote:
>> Define NXAST_SAMPLE OpenFlow vendor action and the corresponding
>> OFPACT_SAMPLE OVS action.
>>
>> Signed-off-by: Romain Lenglet
>
> I think th
On Dec 11, 2012, at 1:19 PM, Ben Pfaff wrote:
> On Tue, Dec 11, 2012 at 11:17:33AM -0800, Romain Lenglet wrote:
>> On Dec 11, 2012, at 10:47 AM, Ben Pfaff wrote:
>>
>>> On Tue, Dec 11, 2012 at 09:54:50AM -0800, Romain Lenglet wrote:
>>>> Define NXAST_S
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 14 ++
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 76 --
tests/odp.at | 1 +
4 files changed, 85 insertions(+), 15 deletions(-)
diff --git a/lib/odp
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding
OFPACT_SAMPLE_IPFIX OVS action.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
include/openflow/nicira-ext.h | 23 ++
lib/ofp-actions.c | 45
Signed-off-by: Romain Lenglet
---
ofproto/automake.mk | 2 +
ofproto/ofproto-dpif-ipfix.c | 125 +++
ofproto/ofproto-dpif-ipfix.h | 28 ++
ofproto/ofproto-dpif.c | 25 +
ofproto/ofproto-provider.h | 8 +++
ofproto
This is the complete patch series to add a SAMPLE_IPFIX vendor action
to do statistical sampling of packets and send one IPFIX message for
every sample.
I have updated the first two patches (1/4 and 2/4) to use only 16 bits
for the probability in the OpenFlow action, making it 8 bytes shorter,
and
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding
OFPACT_SAMPLE_IPFIX OVS action.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
include/openflow/nicira-ext.h | 22 +
lib/ofp-actions.c | 45
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 19
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 81 +-
tests/odp.at | 1 +
4 files changed, 95 insertions(+), 15 deletions(-)
diff --git a/lib/odp
ges you suggested for the other
patches.
Would you like me to send a squashed patch with all 4 patches?
Thanks for your reviews!
--
Romain Lenglet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
1 - 100 of 104 matches
Mail list logo
