----- Original Message ----- > From: "Ben Pfaff" <b...@nicira.com> > To: "Romain Lenglet" <rleng...@vmware.com> > Cc: dev@openvswitch.org > Sent: Monday, November 11, 2013 12:40:29 PM > Subject: Re: [ovs-dev] [PATCH] ipfix: fix segfault for > Flow_Sample_Collector_Set without ipfix > > On Tue, Nov 05, 2013 at 10:43:20AM -0800, Romain Lenglet wrote: > > Signed-off-by: Romain Lenglet <rleng...@vmware.com> > > I had to stare at bridge_configure_ipfix() for a while before I could > see the bug. I think that this bug arises because this code: > > sset_add_array(&opts->targets, fe_cfg->ipfix->targets, > fe_cfg->ipfix->n_targets); > opts->cache_active_timeout = > fe_cfg->ipfix->cache_active_timeout > ? *fe_cfg->ipfix->cache_active_timeout : 0; > opts->cache_max_flows = fe_cfg->ipfix->cache_max_flows > ? *fe_cfg->ipfix->cache_max_flows : 0; > > wasn't bracketed by a test for nonnull fe_cfg->ipfix. Is that right? > (If so is there some way to describe this better in the commit > message?)
That's right. I will send an updated patch. Thanks, -- Romain Lenglet _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
