----- Original Message ----- > From: "Ben Pfaff" <b...@nicira.com> > To: "Kyle Mestery (kmestery)" <kmest...@cisco.com> > Cc: "<dev@openvswitch.org>" <dev@openvswitch.org> > Sent: Tuesday, May 21, 2013 9:58:26 AM > Subject: Re: [ovs-dev] my code for review is now available from github > > On Tue, May 21, 2013 at 04:05:50PM +0000, Kyle Mestery (kmestery) wrote: > > On May 21, 2013, at 10:44 AM, Ben Pfaff <b...@nicira.com> wrote: > > > As an organizational tool for developers who might be interested in > > > reviewing my code, I've now posted all my outstanding unreviewed (or > > > review in progress) code as branches in the github repository visible on > > > the web at: > > > https://github.com/blp/ovs-reviews/branches > > > > > > This is an experiment to see whether it helps to get my code reviewed > > > more promptly. For now, I plan to keep the repository up-to-date as I > > > post new patch series, apply feedback, and merge code into the master > > > repository. If the experiment is successful, then I'll continue to do > > > this indefinitely. > > > > > > You can clone the repository via: > > > git://github.com/blp/ovs-reviews.git > > > or > > > https://github.com/blp/ovs-reviews.git > > > and probably other ways too. > > > > This is actually quite handy Ben. One thing which I think would be > > interesting to look at in the context of reviewing OVS code would be > > to incorporate a tool like Gerritt. Have you given any thought to > > this? I realize this is perhaps heavy handed given the number of > > people contributing to upstream OVS at this time, but may help out > > specifically with reviews. > > If Gerrit is the tool like Gerrit, the short answer is no. The long > answer is here: > http://benpfaff.org/writings/gerrit.html > > We are thinking about setting up a patchwork instance like the one > used for netdev. If we get it going and it works out, then I'll stop > using my reviews repository. > > Is there another tool that you have used and found to be valuable?
I've used Review Board, and I found it much more useful than Gerrit for reviews. http://www.reviewboard.org/ It addresses several of your concerns with Gerrit: - visualization of a change in a single page - threading of comments / replies - etc. -- Romain Lenglet _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
