----- Original Message ----- > From: "Ben Pfaff" <b...@nicira.com> > To: "Romain Lenglet" <rleng...@vmware.com> > Cc: dev@openvswitch.org > Sent: Wednesday, August 21, 2013 1:25:59 PM > Subject: Re: [PATCH] ipfix: implement flow caching and aggregation in exporter > > On Tue, Aug 20, 2013 at 05:54:27PM -0700, Romain Lenglet wrote: > > Implement a per-exporter flow cache with active timeout expiration. > > Add columns "cache_active_timeout" and "cache_max_flows" into table > > "IPFIX" to configure each cache. > > > > Add per-flow elements "octetDeltaSumOfSquares", > > "minimumIpTotalLength", and "maximumIpTotalLength" to replace > > "ethernetTotalLength". Add per-flow element "flowEndReason" to > > indicate whether a flow has expired because of an active timeout, the > > cache size limit being reached, or the exporter being stopped. > > > > Signed-off-by: Romain Lenglet <rleng...@vmware.com> > > I'm happy with the code. I don't exactly understand what this > provides to users, so can you provide a brief item to add to NEWS that > explains it? (Is the benefit directly user-visible?)
This basically makes IPFIX usable. Without caching it generates one message for every sampled packet, which can be a lot of traffic. This can be useful as it makes it behave like sFlow, but it is not what users usually expect from an IPFIX exporter. I added this item into NEWS: - Added configurable flow caching support to IPFIX exporter. Updated patch following shortly. Thanks for your reviews! -- Romain Lenglet _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev