On Tue, May 17, 2016 at 8:27 PM, Yin Lin wrote:
> +static __inline NTSTATUS
> +OvsTunnelAttrToGeneveOptions(PNL_ATTR attr,
> + OvsIPv4TunnelKey *tunKey)
> +{
> +UINT32 optLen = NlAttrGetSize(attr);
> +GeneveOptionHdr *option;
> +if (optLen > TUN_OPT_MAX_LEN)
On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote:
> diff --git a/lib/dp-packet-lso.c b/lib/dp-packet-lso.c
> new file mode 100644
> index 000..14a5ed8
> --- /dev/null
> +++ b/lib/dp-packet-lso.c
> +void
> +fixup_packet_cheksum(struct dp_packet *pkt, int l4_offset, int csum_offset,
> +
On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote:
> This patch used userpsace tunneling mechanism for implementing
> STT tunneling protocol.
> For details about STT you can refer the draft:
> https://tools.ietf.org/html/draft-davie-stt-07
Minor but the current version of the draft is -08.
* Used to list lso segments. */
> +
> };
Extra blank line inserted here.
Otherwise it looks good though, modulo my general concerns about LSO:
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 10, 2016 at 10:31 AM, Pravin B Shelar wrote:
> diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
> index a716492..62ee945 100644
> --- a/lib/netdev-native-tnl.c
> +++ b/lib/netdev-native-tnl.c
> @@ -227,20 +227,32 @@ netdev_tnl_push_udp_header(struct dp_packet *packet,
[..
On Thu, May 19, 2016 at 2:49 PM, Yin Lin wrote:
> ---
> datapath-windows/ovsext/Actions.c | 82 +++-
> datapath-windows/ovsext/Debug.h| 1 +
> datapath-windows/ovsext/DpInternal.h | 29 ++-
> datapath-windows/ovsext/Flow.c | 171 ++--
> datapath-windows/
On Thu, May 19, 2016 at 5:54 PM, Yin Lin wrote:
> Hi Jesse,
>
> Thanks so much for the review! Somehow I didn't get your "previous" email
> about checksum. Can you send it again? I'll address format the commit message
> according to your suggestions. Thanks again!
This is the message I was refe
On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
> index 6ffcc53..0003f89 100644
> --- a/datapath/flow_netlink.c
> +++ b/datapath/flow_netlink.c
> static int metadata_from_nlattrs(struct net *net, struct sw_flow_match
> *matc
On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
> Following patch backports updated iptunnel pull function.
> Also brings in following upstream fix:
>
> commit a09a4c8dd1ec7f830e1fb9e59eb72bddc965d168
> Author: Jesse Gross
> Date: Sat Mar 19 0
On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/net/dst_cache.h
> b/datapath/linux/compat/include/net/dst_cache.h
> new file mode 100644
> index 000..5904f2c
> --- /dev/null
> +++ b/datapath/linux/compat/include/net/dst_cache.h
[...]
> +#def
On Fri, May 20, 2016 at 1:57 PM, Yin Lin wrote:
> diff --git a/datapath-windows/ovsext/Geneve.c
> b/datapath-windows/ovsext/Geneve.c
> new file mode 100644
> index 000..8184739
> --- /dev/null
> +++ b/datapath-windows/ovsext/Geneve.c
> +NDIS_STATUS OvsDecapGeneve(POVS_SWITCH_CONTEXT switchCon
On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
> From: Pravin B Shelar
>
> There is return type change in upstream handle-offload functions.
> Following patch brings these changes in.
>
> Signed-off-by: Pravin B Shelar
I think at this point, I need to ask you to align these patches with
On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
> Current tnl_skb_gso_segment() is written for ipv4 tunnels. Following
> patch make it generic so that it can also handle ipv6 tunnels.
>
> Signed-off-by: Pravin B Shelar
Acked-by:
On Sun, May 22, 2016 at 9:36 PM, pravin shelar wrote:
> On Fri, May 20, 2016 at 6:46 PM, Jesse Gross wrote:
>> On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
>>> diff --git a/datapath/linux/compat/include/net/dst_cache.h
>>> b/datapath/linux/compat/include/n
On Sun, May 22, 2016 at 9:44 PM, pravin shelar wrote:
> On Sat, May 21, 2016 at 9:12 AM, Jesse Gross wrote:
>> On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
>>> From: Pravin B Shelar
>>>
>>> There is return type change in upstream handle-offload f
ned-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, May 23, 2016 at 5:06 PM, Pravin B Shelar wrote:
> IPv6 tunnels ignores outer tos bits on recieve and does not
> set it on xmit. Following patch fixes it.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mail
On Tue, May 24, 2016 at 12:26 PM, pravin shelar wrote:
> On Mon, May 23, 2016 at 11:09 AM, Jesse Gross wrote:
>> On Sun, May 22, 2016 at 9:36 PM, pravin shelar wrote:
>>> On Fri, May 20, 2016 at 6:46 PM, Jesse Gross wrote:
>>>> On Wed, May 4, 2016 at 4:35 PM, Prav
On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/net/ipv6.h
> b/datapath/linux/compat/include/net/ipv6.h
> index 5cc5b6e..6faafb0 100644
> --- a/datapath/linux/compat/include/net/ipv6.h
> +++ b/datapath/linux/compat/include/net/ipv6.h
> @@ -81,4
On Thu, May 26, 2016 at 1:34 PM, Thadeu Lima de Souza Cascardo
wrote:
> One thing that may be seen as a regression is the MTU of those devices. It
> won't
> be IP_MAX_MTU as in latest upstream, but supporting older kernels restrict us
> to
> use 1500 for VXLAN and GENEVE.
Is it possible to dete
n OVN.
I think there is one other thing that we need before this change,
which is backporting the following bug fix to the out of tree OVS
kernel module. Without it, tunnel GRO performs horribly when sending
traffic to VMs. Pravin is in the process of doing this as part of a
larger patch set.
commi
On Thu, Jun 2, 2016 at 3:18 AM, Thadeu Lima de Souza Cascardo
wrote:
> If VXLAN-GBP and VXLAN are set on the same port, only one of those tunnel
> types
> is going to be created. As other tunnel flags are added, like VXLAN-GPE, and
> they are incompatible, reject any configuration that put incomp
On Thu, Jun 2, 2016 at 3:18 AM, Thadeu Lima de Souza Cascardo
wrote:
> Throughout the years, changes in netdev vport have removed the need for some
> of
> the headers, like shash, hmap, and many others. With the recent split of
> push/pop code, less headers are needed in each of the two modules.
On Thu, Jun 2, 2016 at 3:18 AM, Thadeu Lima de Souza Cascardo
wrote:
> Red Hat has contributed to the original code that has moved to
> netdev-native-tnl
> module and to code that has been kept in netdev-vport as well.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
Also applied to master.
___
On Thu, Jun 2, 2016 at 3:47 PM, Thadeu Lima de Souza Cascardo
wrote:
> On Thu, Jun 02, 2016 at 12:46:04PM -0700, Jesse Gross wrote:
>> On Thu, Jun 2, 2016 at 3:18 AM, Thadeu Lima de Souza Cascardo
>> wrote:
>> > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
>
On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson
wrote:
> I wanted to mention though, currently the type 2 metadata (MD2) isnt a top
> priority for us. It looks like its already been investigated how to use some
> existing OVS TLV code to implement this, so it should be easy to add MD2 in
> th
On Wed, Jul 13, 2016 at 7:55 AM, Jiri Benc wrote:
> On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote:
>> I think history tells us how this will end - similar to IPv4 options,
>> implementations that don't implement TLVs will become deployed and
>> then when there
at the current implementation is for ethernet+NSH and
> VXLAN+ethernet+NSH which doesnt require Simon's patch. Simon's patch would
> be needed for VXLAN-GPE+NSH, which is not in this implementation. Maybe the
> authors can verify this.
>
> Regards,
>
> Brady
>
>
>
> O
On Wed, Jul 13, 2016 at 6:38 PM, Yang, Yi wrote:
> On Wed, Jul 13, 2016 at 09:59:34AM -0700, Jesse Gross wrote:
>> On Wed, Jul 13, 2016 at 7:55 AM, Jiri Benc wrote:
>> > On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote:
>> >> I think history tells us how t
On Wed, Jul 13, 2016 at 7:56 PM, Yang, Yi wrote:
> On Wed, Jul 13, 2016 at 07:22:39PM -0700, Jesse Gross wrote:
>> >>
>> >> In any case, I don't think this is a fundamental issue, just a matter
>> >> of timing. Since the premise of the original questi
On Wed, Jul 13, 2016 at 10:44 PM, Elzur, Uri wrote:
> +1 on starting w MD Type = 1
>
> Not sure I understand the concern expressed with " implementations that don't
> implement TLVs will become deployed and then when there is a use for them
> it's no longer possible." - why will it not be possi
On Thu, Jul 14, 2016 at 10:53 AM, Elzur, Uri wrote:
> Jesse
>
> So maybe it is just me, but I really don't get the similarity w IPv4 options.
> Both Geneve and NSH have TLV options. I have not seen a definition of the
> Geneve TLV format either (pls excuse me if I have missed it, and pls point m
On Tue, Jul 12, 2016 at 10:23 PM, Pravin B Shelar wrote:
> @@ -1196,31 +1194,26 @@ int ovs_execute_actions(struct datapath *dp, struct
> sk_buff *skb,
> const struct sw_flow_actions *acts,
> struct sw_flow_key *key)
> {
[...]
> + static const
On Tue, Jul 12, 2016 at 10:23 PM, Pravin B Shelar wrote:
> Use newer API which is consistent with upstream.
>
> Signed-off-by: Pravin B Shelar
Just as a note on the commit message, this is actually an older API.
The upstream change is due to mmap netlink support being removed.
__
l field of the
> skb no longer occurs.
>
> Thus it is now safe to output MPLS to tunnel vports.
>
> Signed-off-by: Simon Horman
> Reviewed-by: Jesse Gross
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
I don't know if t
f this looks good to me:
Acked-by: Jesse Gross
Of the remaining patches, the only one that I'm actually concerned
about is the MPLS one. The other two are just trivial changes.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
e mmaped netlink removal this code can be removed.
>
> Signed-off-by: Florian Westphal
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 18, 2016 at 4:24 AM, Pravin B Shelar wrote:
> Update kernel list to latest stable release.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
Can you also update the supported kernel version in the FAQ and NEWS
either as part of the patches that add support or
of
> changes are not really required, they are here to make it consistent.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
l field of the
> skb no longer occurs.
>
> Thus it is now safe to output MPLS to tunnel vports.
>
> Signed-off-by: Simon Horman
> Reviewed-by: Jesse Gross
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
I'm still somewhat
On Mon, Jul 18, 2016 at 4:24 AM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/actions.c | 31 ---
> 1 file changed, 12 insertions(+), 19 deletions(-)
I have somewhat similar concerns and thoughts as with the MPLS patch:
Ack
On Mon, Jul 18, 2016 at 4:24 AM, Pravin B Shelar wrote:
> Most of changes are related to ip-fragment API and genetlink
> API changes.
>
> Signed-off-by: Pravin B Shelar
I'm getting some sparse warnings with this patch. Not all of them are
new but I wasn't able to run it before due to my local ke
e/linux/netdevice.h],
> +[netdev_master_upper_dev_link], [upper_priv],
> +
> [OVS_DEFINE([HAVE_NETDEV_MASTER_UPPER_DEV_LINK_PRIV])])
I think you don't need to first check that the function exists - it
should be safe to just directly u
On Mon, Jul 18, 2016 at 4:24 AM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/linux/if_ether.h
> b/datapath/linux/compat/include/linux/if_ether.h
> index b2cb56d..ac0f1ed 100644
> --- a/datapath/linux/compat/include/linux/if_ether.h
> +++ b/datapath/linux/compat/include/lin
On Mon, Jul 18, 2016 at 12:12 PM, Amru OM wrote:
> Greetings,
>
>
>
> I tried to load the STT module (vport-stt.ko), which is included with OVS
> 2.5 distribution, in order to configure STT overlay tunnels between virtual
> machines located in different hosts. However, when I insert vport-stt.ko
>
On Mon, Jul 18, 2016 at 11:43 PM, pravin shelar wrote:
> On Mon, Jul 18, 2016 at 11:28 AM, Jesse Gross wrote:
>> On Mon, Jul 18, 2016 at 4:24 AM, Pravin B Shelar wrote:
>> /home/jgross/openvswitch/datapath/linux/vxlan.c:1905:45: warning:
>> incorrect type in assignment
On Tue, Jul 19, 2016 at 12:14 AM, pravin shelar wrote:
> On Mon, Jul 18, 2016 at 2:59 PM, Joe Stringer wrote:
>> On 18 July 2016 at 14:42, pravin shelar wrote:
>>> On Mon, Jul 18, 2016 at 2:32 PM, Joe Stringer wrote:
On 17 July 2016 at 19:24, Pravin B Shelar wrote:
> This series conta
On Tue, Jul 19, 2016 at 12:13 AM, Pravin B Shelar wrote:
> Most of changes are related to ip-fragment API and genetlink
> API changes.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswi
On Tue, Jul 19, 2016 at 5:48 PM, Jan Scheurich
wrote:
> I hate to be pestering but I believe the answer to the question below will
> have significant impact on the design of the NSH patch as well as the way SDN
> controllers can use NSH. So could the OVS maintainers please have a look and
> pro
On Wed, Jul 20, 2016 at 5:06 PM, Paul Quinn (paulq) wrote:
>
>> On Jul 14, 2016, at 11:39 AM, Jesse Gross wrote:
>>
>> On Wed, Jul 13, 2016 at 10:44 PM, Elzur, Uri wrote:
>>> +1 on starting w MD Type = 1
>>>
>>> Not sure I understand the concern
On Wed, Jul 20, 2016 at 6:43 PM, Gray, Mark D wrote:
> [Gray, Mark D] I think we should focus on one or two use cases rather than
> a general offload like you discuss below. A general offload involves a huge
> amount of code
> churn and there are a lot of difficulties, some that you have highlig
On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote:
> In upstream linux kernel networking stack udp_set_csum() is called
> with only udp header applied but in case of compat layer it can
> be called with IP header. So following patch take the offset into
> account.
>
> Signed-off-by: Pravin B
On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c
> index 8368c6a..de9c8e1 100644
> --- a/datapath/linux/compat/gso.c
> +++ b/datapath/linux/compat/gso.c
> @@ -286,17 +282,15 @@ int rpl_ip_local_out(struct net *net, str
On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote:
> OVS compat layer can handle tunnel GSO packets. but it does
> keep skb encapsulation on for packet handled in GSO. This can
> confuse some NIC drivers. I have seen this issue on intel devices:
>
> i40e :42:00.0: TX driver issue detect
On Tue, Jun 7, 2016 at 11:52 AM, Ryan Moats wrote:
> As a side effect, tunnel context is persisted.
>
> Signed-off-by: Ryan Moats
When I was working on something else in this area, I noticed what
appear to be some regressions as a result of this change.
The one that I actually noticed from test
On Tue, Jul 26, 2016 at 10:56 AM, pravin shelar wrote:
> On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote:
>> On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote:
>>> OVS compat layer can handle tunnel GSO packets. but it does
>>> keep skb encapsulation on for
On Tue, Jul 26, 2016 at 12:30 PM, pravin shelar wrote:
> On Tue, Jul 26, 2016 at 11:14 AM, Jesse Gross wrote:
>> On Tue, Jul 26, 2016 at 10:56 AM, pravin shelar wrote:
>>> On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote:
>>>> On Mon, Jul 25, 2016 at 5
On Mon, Jul 25, 2016 at 6:40 PM, Pravin B Shelar wrote:
> Most of patch iron out USE_UPSTREAM_TUNNEL case where datapath
> directly use upstream tunneling modules.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mail
On Sun, Jul 24, 2016 at 10:53 AM, Ben Pfaff wrote:
> On Sun, Jul 24, 2016 at 08:39:31AM -0300, Thadeu Lima de Souza Cascardo wrote:
>> On Sat, Jul 23, 2016 at 08:59:35AM -0700, Ben Pfaff wrote:
>> > The proposed Open vSwitch release schedule calls for branching 2.6 from
>> > master on Aug. 1, foll
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/net/udp.h
> b/datapath/linux/compat/include/net/udp.h
> index fa49fa5..266e70a 100644
> --- a/datapath/linux/compat/include/net/udp.h
> +++ b/datapath/linux/compat/include/net/udp.h
> @@ -54,7 +54
42:00.0: TX driver issue detected, PF reset issued
>
> Following patch resets this bit in case compat layer handles the packet.
>
> VMware-BZ: 1698877
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvsw
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/linux/compat/gso.c | 82
> ++---
> 1 file changed, 33 insertions(+), 49 deletions(-)
Acked-
On Tue, Jul 26, 2016 at 3:59 PM, pravin shelar wrote:
> On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote:
>> On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote:
>>> diff --git a/datapath/linux/compat/include/net/udp.h
>>> b/datapath/linux/compat/include/
On Thu, Jul 21, 2016 at 3:40 PM, Jan Scheurich
wrote:
> 1. The pending question whether to model NSH headers as packet header match
> fields, metadata fields, or both applies in particular to the MD2 TLVs.
>
> We have three main OpenFlow use cases for the MD2 TLVs:
> a) Match on an MD2 TLV of an
On Thu, Jul 21, 2016 at 3:55 AM, Chandran, Sugesh
wrote:
> Hi Mark & Jesse
>
> Thank you for looking into the the proposal,
> Please find my answers inline below.
>
> Regards
> _Sugesh
>
>> -Original Message-
>> From: Gray, Mark D
>> Sent:
On Wed, Jul 27, 2016 at 1:40 PM, Daniele Di Proietto
wrote:
> On 27/07/2016 13:12, "Joe Stringer" wrote:
>
>>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
>>> The userspace connection tracker doesn't support ALGs, frag reassembly
>>> or NAT yet, so skip those tests.
>>>
>>> Also, connecti
of incremental processing
which the first two patches fix.
I'm targetting this for OVS 2.6 since the bulk of the changes are bug fixes
and the benefits from the UDP checksums are significant.
Jesse Gross (3):
ovn-controller: Fix memory leak when updating tunnels.
ovn-controller: Make
When a tunnel possibly needs to be updated, we are currently allocating
a new name for it. This is not necessary and in fact nothing uses the
name, which then results in the memory being leaked.
Fixes: 1d45d5a9 ("ovn-controller: Change encaps_run to work incrementally.")
Signed-off
work incrementally.")
Signed-off-by: Jesse Gross
---
ovn/controller/encaps.c | 469 +---
ovn/controller/ovn-controller.c | 1 +
2 files changed, 247 insertions(+), 223 deletions(-)
diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c
ind
ff-by: Jesse Gross
---
ovn/controller-vtep/gateway.c | 9 +
ovn/controller/chassis.c | 8
ovn/controller/encaps.c | 12 +++-
ovn/ovn-sb.xml| 10 --
ovn/utilities/ovn-sbctl.c | 2 ++
tests/ovn-controller-vtep.at | 1 +
tests/ovn-sbc
On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/linux/compat/include/net/udp.h | 2 +-
> datapath/linux/compat/udp.c | 19 ++-
> datapath/linux/compat/udp_tunnel.c | 17 +
> 3 files changed
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote:
> Remove kernel version check related to unsupported kernel.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
> Signed-off-by: Pravin B Shelar
It looks like RHEL 7.2 has already backported ndo_features_check, so
this should give an immediate improvement there - not just a
theoretical benefit.
Acked-by: Jesse Gross
___
dev mailing list
dev@op
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote:
> In case of OVS using compat fill metadata dst implementation we need to
> setup temperory dst.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@ope
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote:
> The check for tunnel GSO packet is done at ip-handle-offloads. Remove
> same check from udp-handle-offloads.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mail
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> FAQ.md | 2 +-
> NEWS | 2 +-
> acinclude.m4 | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
Should we also add 4.7 to Travis?
I noticed that there appear to be at least t
On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote:
> On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote:
>> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote:
>>> Signed-off-by: Pravin B Shelar
>>> ---
>>> datapath/linux/compat/include/net/udp.h | 2
On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote:
> struct ovs_gso_cb is stored in skb->cd. avoid going beyond size
> of skb->cb.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@op
On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/linux/compat/vxlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jesse Gross
___
dev mailing list
dev@ope
omas Graf
> Signed-off-by: Samuel Gauthier
> Acked-by: Joe Stringer
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
lation data, the max_mtu should subtract
> sizeof(ipv6hdr), instead of sizeof(iphdr).
>
> Signed-off-by: Haishuang Yan
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote:
> Few function can be compiled out for non GSO case. This
> patch make it bit cleaner to understand GSO compat code.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev
ng patch couple this function to USE_UPSTREAM_TUNNEL symbol
> rather than kernel version.
> This is not bug, But it helps in code readability.
>
> Signed-off-by: Pravin B Shelar
Since this is basically a subset of the other patch, with the same cav
On Wed, Aug 3, 2016 at 9:00 AM, pravin shelar wrote:
> On Tue, Aug 2, 2016 at 4:55 PM, Jesse Gross wrote:
>> On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote:
>>> On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote:
>>>> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B S
xlan: Flow based tunneling").
> Reported-by: Jakub Libosvar
> Signed-off-by: Pravin B Shelar
> Acked-by: Jiri Benc
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
_
and GRE.
>
> Fixes: ee122c79d42 ("vxlan: Flow based tunneling").
> Signed-off-by: Pravin B Shelar
> Acked-by: Jiri Benc
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
__
On Tue, Aug 9, 2016 at 7:52 AM, Simon Horman wrote:
> Hi Jesse,
>
> On Wed, Jul 13, 2016 at 07:35:59AM -0700, Jesse Gross wrote:
>> On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson
>> wrote:
>> > I wanted to mention though, currently the type 2 metadata (MD2) i
On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote:
> When using compat GSO there is no need to turn on skb
> encapsulation bit since OVS does not use any tunnel GSO
> functionality from the networking stack.
>
> Signed-off-by: Pravin B Shelar
I'm not sure that this is the best place to cle
On Thu, Jun 2, 2016 at 6:02 PM, Aaron Rosen wrote:
> This should prevent any additional files from sneaking in here.
>
> Signed-off-by: Aaron Rosen
I agree that this is better since these files are just autogenerated
and not very interesting.
I think that I would leave kcompat.h in the list tho
On Mon, Jun 6, 2016 at 11:41 AM, Aaron Rosen wrote:
> This should prevent any additional *.c files from sneaking in here.
>
> Signed-off-by: Aaron Rosen
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/
On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote:
[...]
> datapath/vport-netdev.c | 3 +-
> datapath/vport-vxlan.c| 17 ++-
These changes aren't upstream yet. Please do that before backporting them here.
However, the changes to vport-vxlan.c
As both OVS and tunnel protocols themselves have evolved, some changes
have caused the documentation to drift from current reality.
Signed-off-by: Jesse Gross
---
vswitchd/vswitch.xml | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/vswitchd
On Tue, Jun 7, 2016 at 4:24 PM, Ben Pfaff wrote:
> On Tue, Jun 07, 2016 at 04:17:51PM -0700, Jesse Gross wrote:
>> As both OVS and tunnel protocols themselves have evolved, some changes
>> have caused the documentation to drift from current reality.
>>
>> Signed-off-by
On Tue, Jun 7, 2016 at 11:09 AM, Johnson Li wrote:
> In this patch set, we implement the NSH metadata type 1 support for
> the openvswtich.
> Since the overlay could be VxLAN-GPE which is upstreamed by Jiri
> at Linux kernel tree
> commit
> So we also add VxLAN-GPE support for openvswitch.
>
> On
On Wed, Jun 8, 2016 at 7:33 PM, Alexander Duyck
wrote:
> Agreed, but what are we really getting by adding the port value? In
> the case of the Intel hardware it isn't much as I can take advantage
> of checksum offload if I just turn on the outer headers. Then I don't
> even need to enable the Rx
On Thu, Jun 9, 2016 at 7:31 AM, Ryan Moats wrote:
> From: RYAN D. MOATS
>
> We've been compiling and testing against the 4.6.0 kernel
> tree and 2.5.90 looks pretty good. So, let's start the
> update pieces.
>
> Signed-off-by: RYAN D. MOATS
There are a bunch of patches from 4.4-4.6 that aren't
test for this exact use case, since the same
bug was present in both reading and writing code, everything appeared to work
as normal from the outside.
Signed-off-by: Jesse Gross
---
lib/tun-metadata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/tun-metadata.c b/lib
he flow key rather than that in the set field action.
>
> Fixes: 83d2b9ba1abc ("net: openvswitch: Support masked set actions.")
> Cc: Jarno Rajahalme
> Signed-off-by: Simon Horman
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acke
d the possibility of
forgetting to initialize the extra parameter.
Signed-off-by: Jesse Gross
---
lib/dpif-netdev.c | 3 ---
lib/odp-util.c| 6 +++---
lib/odp-util.h| 6 --
lib/tnl-ports.c | 2 --
ofproto/ofproto-dpif-upcall.c | 3 ---
tests
s,
at the moment, it's possible to convert between the two formats on demand as
we have a global metadata table. In the future, though this won't be possible
as the metadata table becomes per-bridge which the datapath won't have access
to.
Signed-off-by: Jesse Gross
---
lib/dpi
101 - 200 of 3414 matches
Mail list logo