ls.
We are looking forward to working with you and your team.
Thank you,
Eitan
-Original Message-
From: Alessandro Pilotti [mailto:apilo...@cloudbasesolutions.com]
Sent: Friday, July 25, 2014 6:48 AM
To: Ben Pfaff
Cc: dev@openvswitch.org; Alin Serdean; Saurabh Shah; Nithin Raju; Guolin
: Friday, July 25, 2014 8:26 AM
To: Eitan Eliahu
Cc: Ben Pfaff; dev@openvswitch.org; Alin Serdean; Saurabh Shah; Nithin Raju;
Guolin Yang; Rajiv Krishnamurthy; Peter Pouliot
Subject: Re: plan to integrate Hyper-V support
Hi Eitan,
On 25 Jul 2014, at 18:08, Eitan Eliahu wrote:
>
> Hi Ales
Hi Alessandro,
I had some initial thoughts about jumpstarting the integration. Obviously, we
need to sort out the user/kernel mode interface before we could have a working
solution to start with.
I would like to suggest that Cloudbase would address the user mode code
including Ben's comments o
The change difficulty we came across with the INS was when we changed the
driver GUID. This one should go smoothly :-)
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Justin Pettit
Sent: Wednesday, July 30, 2014 2:08 PM
To: Nithin Raju; Alessandro Pil
, July 30, 2014 2:55 PM
To: Eitan Eliahu
Cc: Justin Pettit; Nithin Raju; dev@openvswitch.org; Gurucharan Shetty; Kaushik
Guha; Ben Pfaff; Rajiv Krishnamurthy
Subject: Re: [ovs-dev] Meeting summary and action items (7/29)
Hi Eitan,
The Guid must be changed both in the inf and the code, when we changed
BSOD while setting AllowManagementOS on $false #13
https://github.com/openvswitch/ovs/issues/13
Signed-off-by: Eitan Eliahu
---
datapath-windows/ovsext/OvsActions.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/OvsActions.c
b/datapath-windows
BSOD while setting AllowManagementOS on $false #13
https://github.com/openvswitch/ovs/issues/13
Signed-off-by: Eitan Eliahu
Reported-by: Alin Serdean
---
datapath-windows/ovsext/OvsActions.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext
Hi Saurabh, I removed the assert in the next patch I posted. But, in anyway,
since ASSERT does not generate any code for release build it does work.
Thanks,
Eitan
-Original Message-
From: Saurabh Shah
Sent: Thursday, July 31, 2014 4:40 PM
To: Eitan Eliahu; dev@openvswitch.org
Subject
Raju
Sent: Thursday, July 31, 2014 5:01 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] datapath-windows - fix crash when internal port
is removed
On Aug 1, 2014, at 12:17 AM, Eitan Eliahu
wrote:
> BSOD while setting AllowManagementOS on $false #13
> https://urldefense.proofpoint.c
uld not asserts if OvsTunnelPortTx fails.
Thanks.
Eitan
-Original Message-
From: Nithin Raju
Sent: Thursday, July 31, 2014 5:30 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] datapath-windows - fix crash when internal port
is removed
On Jul 31, 2014, at 5:22 PM, Eitan Eliahu
wrote:
&g
BSOD while setting AllowManagementOS on $false #13
Github Issue: #13
Signed-off-by: Eitan Eliahu
Reported-by: Alin Serdean
---
datapath-windows/ovsext/OvsActions.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/OvsActions.c
b/datapath-windows
It was tested on Debug and on Release build as well.
Thanks,
Eitan
-Original Message-
From: Saurabh Shah
Sent: Friday, August 01, 2014 9:51 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when
internal port is removed
I
Hi Alin,
Please go ahead and test the patch, There is no v2. The patch is here.
Thank you!
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Friday, August 01, 2014 9:57 AM
To: Saurabh Shah; Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev
)ovsFwdCtx->switchContext->internalVport)->portNo;
Thanks Alin.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu
Sent: Friday, August 01, 2014 10:05 AM
To: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subject: Re: [ovs-dev] [PAT
Hi Samuel,
You are correct and we are well aware of this issue, in fact this issue was
in our to do list for a long time. The plan is to create an NBL from each NB
and to run the new created NBL(s) against the flow table.
If you guys have some free cycles please go ahead and implement it.
Eita
Hi Samuel, my initial implementation was holding a reference to NBLs which were
indicated to user mode. However, there is an issue with that as in general not
all packets are returned to back to the kernel and some packets could be
modified in user space. Perhaps, Ben could confirm?
Thanks,
Ei
Yes.
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Tuesday, August 05, 2014 5:12 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: WFP and tunneling and packet fragments
Thanks Eitan!
Regarding point 2: do you mean to set the MTU from
AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: WFP and tunneling and packet fragments
Hello Eitan,
I personally do not find that a viable solution: I mean,I don't think we can
requests the clients (i.e. those using the OS-s from within the VMs) to change
their MTU to each of their O
different machine, for it to send
it?
Basically, if "won't be returned back to the kernel" means dropped, I guess
that's ok.
Sam
From: Samuel Ghinet
Sent: Tuesday, August 05, 2014 3:08 PM
To: Ben Pfaff; Eitan Eliahu
Cc: dev@openvsw
-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Tuesday, August 05, 2014 7:24 AM
To: Nithin Raju; Ben Pfaff; Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] Queuing packets to userspace and NBL info problem
Hello Nithin,
Even with having this IPSec problem:
a) The other
flows etc..).
Thanks,
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Tuesday, August 05, 2014 7:52 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: WFP and tunneling and packet fragments
Hi Eitan,
The approach is different in the
Yes agree:-)
Thank you.
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Tuesday, August 05, 2014 9:50 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: WFP and tunneling and packet fragments
Eitan,
What I'm trying to say is:
1.
Hi Sam, could you come up with some directory structure for the Move part? I
noticed you has a directory structure for your other driver.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Samuel Ghinet
Sent: Tuesday, August 05, 2014 1:36 PM
To:
ectories. Another basis of comparison is how lib/ is
> > organized in userspace.
> >
> > But, I'd be interested in listening to a proposal.
> >
> > thanks,
> > Nithin
> >
> >> On Aug 5, 2014, at 2:48 PM, Eitan Eliahu wrote:
> >>
&
Hi Sam,
Since the switch extension driver is an NDIS filter driver it would be
preferable to use NDIS memory allocation functions rather direct executive
system calls.
On another thing: since this driver is basically two combined drivers
(Extension and WFP) it would be nice if we could pass
order to acquire WHQL
certification"
Thanks,
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Wednesday, August 06, 2014 8:53 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [PATCH] datapath-windows: Add Core.h
Hello Eitan,
Just foun
Hi Sam,
I was wondering if you could add an explanation for how (or if) each patch is
related to the open issues or enhancements that we filed in Github.
I think we need to see a motivation which is aligned with the priority we
assigned to the open issues we filed. Otherwise, it would be hard
Hello all,
Here is a summary of our initial design. Not all areas are covered so we would
be glad to discuss anything listed here and any other code/features we could
leverage.
Thanks!
Eitan
A. Objectives:
[1] Create a NetLink (NL) driver interface for Windows which interoperates with
the
Sure Alin, we would be glad to add details or to clarify any issue.
Thanks,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, August 06, 2014 2:12 PM
To: Nithin Raju; Eitan Eliahu
Cc: dev@openvswitch.org; Rajiv Krishnamurthy; Ben Pfaff
t;original device" the "DPIF device" and the
"secondary device" the "Netlink device".
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, August 06, 2014 4:28 PM
To: Eitan Eliahu; dev@openvswitch.org; Rajiv
Hi Sam,
Here are some clarifications:
>o) "Transaction based DPIF primitive": does this mean that we do Reads and
>Writes here?
Transaction based DPIF primitives are mapped into synchronous device I/O
control system calls.
The NL reply would be returned in the output buffer of the IOCTL parame
produce this case :-)
Thanks,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Thursday, August 07, 2014 10:50 AM
To: Eitan Eliahu; dev@openvswitch.org; Rajiv Krishnamurthy; Ben Pfaff; Kaushik
Guha; Ben Pfaff; Justin Pettit; Nithin Raju; Ankur
Hi Sam,
Please find inline.
>Do you mean we will no longer use nl_sock_transact_multiple in userspace for
>these DPIF transactions?
No, we will use nl_sock_transact_multiple, but nl_sock_transact_multiple will
be implemented through the call of DeviceIOControl() system call rather than se
seri
m]
Sent: Friday, August 08, 2014 10:00 AM
To: Eitan Eliahu; Alin Serdean; dev@openvswitch.org; Rajiv Krishnamurthy; Ben
Pfaff; Kaushik Guha; Ben Pfaff; Justin Pettit; Nithin Raju; Ankur Sharma; Linda
Sun; Keith Amidon
Subject: RE: Design notes for provisioning Netlink interface from the OVS
Window
nl_dump_next().
The IOCTRT command sent from dump_next should be self contained (which means
specifies the "offset: and the output buffer length).
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Friday, August 08, 2014 10:25 AM
To: Eitan
-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Friday, August 08, 2014 11:12 AM
To: Eitan Eliahu; Alin Serdean; dev@openvswitch.org; Rajiv Krishnamurthy; Ben
Pfaff; Kaushik Guha; Ben Pfaff; Justin Pettit; Nithin Raju; Ankur Sharma; Linda
Sun; Keith Amidon
Subject: RE: Design
. But for
flow the dump is done in iteration. This means that someone needs to keep track
on the progress (maintain current offset)
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Friday, August 08, 2014 11:16 AM
To: Eitan Eliahu; Alin Serdean; de
uffer) and that each user / kernel mode transaction is self
contained (which means the driver does not have to "remember" anything).
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Friday, August 08, 2014 11:32 AM
To: Eitan Eliahu; Al
nel for the buffer, while the process will read in chunks of
say, 8KB.
Sam
________
From: Eitan Eliahu [elia...@vmware.com]
Sent: Friday, August 08, 2014 9:38 PM
To: Samuel Ghinet; Alin Serdean; dev@openvswitch.org; Rajiv Krishnamurthy; Ben
Pfaff; Kaushik Guha;
No problem Sam. It must be late there :-) Thank you for looking into the
details.
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Friday, August 08, 2014 1:14 PM
To: Eitan Eliahu; Alin Serdean; dev@openvswitch.org; Rajiv Krishnamurthy; Ben
s done on IRP_MJ_CLEANUP
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Friday, August 08, 2014 12:43 PM
To: Eitan Eliahu; Alin Serdean; dev@openvswitch.org; Rajiv Krishnamurthy; Ben
Pfaff; Kaushik Guha; Ben Pfaff; Justin Pettit; Nithin Raju; Anku
Hi Alin,
Should we able to specify Debug or Release build when building with MSBuild.exe?
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Wednesday, August 27, 2014 7:33 AM
To: Saurabh Shah; dev@openvswitch.org
Subject: Re: [o
Thanks Alin. We probably don't need Win8 but definitely Release and Debug
builds of Win8.1.
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, August 27, 2014 7:46 AM
To: Eitan Eliahu; Saurabh Shah; dev@openvswitch.org
Subject: RE:
+if (!DeviceIoControl(sock->handle, OVS_IOCTL_READ,
+ NULL, 0, tail, sizeof tail, &bytes, NULL))
...
+memcpy(ofpbuf_data(buf), tail, retval);
+ofpbuf_set_size(buf, retval);
We probably want to send down the "struct iovec iov" (ra
Yes, I'll open a gerrit issue for that.
Thnks,
Eitan
From: Nithin Raju
Sent: Wednesday, August 27, 2014 1:16 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org; aserd...@cloudbasesolutions.com
Subject: Re: [ovs-dev] [PATCH] netlink-socket.c: use read/write
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu
Sent: Wednesday, August 27, 2014 1:47 PM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] netlink-socket.c: use read/write ioctl instead
of ReadFile
To: Alin Serdean
Cc: dev@openvswitch.org; Eitan Eliahu; Saurabh Shah; Nithin Raju
Subject: Re: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild
On Thu, Aug 28, 2014 at 01:49:24PM +, Alin Serdean wrote:
> +if VSTUDIO_DDK
> +ALL_LOCAL += ovsext_make
> +ovsext_make: datapat
Hi Guru,
Do we distinguish between Debug and Releases builds? ( I recall we discussed
this before but forgot what was the outcome)
Enabling optimization may cause some issues for the debugger to match the
source to the code.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun..
> Or it may be that InterlockedExchange64() already does that?
Doesn't look like alignment is checked:
LONGLONG val = 0;
InterlockedCompareExchange64(&val, 0, 0);
00013F811006 xor eax,eax
00013F811008 mov qword ptr [val],rcx
00013F81100D lock cm
s.com]
Sent: Thursday, August 28, 2014 6:53 PM
To: dev@openvswitch.org; Nithin Raju; Eitan Eliahu; Saurabh Shah
Subject: [ovs-dev] [PATCHv2] Changes needed to compile dpif-linux.c with MSVC
Rename dpif_linux -> dpif_netlink the actual file can be renamed as well
in the future.
Bypass all epoll funct
Thanks Alin, I am planning to post a patch for the event notification so we can
follow the same logic for the packet miss path.
Eitan
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Friday, August 29, 2014 7:14 AM
To: Eitan Eliahu; dev@openvswitch.org; Nithin Raju; Saurabh Shah
Hi Sam,
I was wondering if we could go ahead and acknowledge Nithin's change. I know
you have some reservations but this work should be considered as a bring up
which effort to enable other developers to continue with their own tasks. The
current situation is that we have a circular dependency
Unlike the compilation mode used for OVS x64 Linux Windows long word is
4 bytes for both 32 and 64 bit builds.
Replaced _UNCONST macro with CONST_CAST to avoid the intermediate casting
to an integer.
Testing: 32 and 64 Windows builds.
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
lib
Unlike the compilation mode used for OVS x64 Linux Windows long word is
4 bytes for both 32 and 64 bit builds.
Replaced _UNCONST macro with CONST_CAST to avoid the intermediate casting
to an integer.
Testing: 32 and 64 Windows builds.
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
lib
Unlike the compilation mode used for OVS x64 Linux Windows long word is
4 bytes for both 32 and 64 bit builds.
Replaced _UNCONST macro with CONST_CAST to avoid the intermediate casting
to an integer.
Testing: 32 and 64 Windows builds.
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
lib
I was not sure if I submitted the latest. Basically, v2 and v3 are just the
spaces to tab fix.
Thanks,
Eitan
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, September 02, 2014 12:47 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, September 02, 2014 6:05 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 4/5] OvsTypes.h : Added support for BE16
---
datapath-windows/ovsext/Types.h
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, September 02, 2014 6:05 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/5] NetlinkBuf.c: Netlink buffer mgmt apis.
In this change we have introduced
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, September 02, 2014 6:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/5] datapath-windows/Netlink: Move netlink files to
a new directory.
In this
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, September 02, 2014 6:05 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 3/5] NetlinkProto.h: Minor fix for typos and new
macro for padding.
Added a
In a later change we would like to have these functions inline.
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, September 02, 2014 6:05 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 5/5] Netlink.c
Hi, here are some items we would like to follow up on. Please feel free to add
anything you would like to discuss.
NetLink
--
i) #Action-item: Alin to send out patches for dpif-linux.c soon.
ii) Sam will be working on the vport commands - dump and add to start with,
and the rest late
We keep an outstanding, out of band, I/O request in the driver at all time.
Once an event generated the driver queues the event message, completes the
pending I/O and unblocks the calling thread through setting the event in the
overlapped structure n the NL socket. The thread will read all all eve
event
messages synchronous through the call of nl_sock_recv()
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/include/OvsDpInterfaceExt.h | 1 +
lib/netlink-socket.c | 82 ++--
2 files changed, 79 insertions(+), 4 deletions
> However, you should probably keep the version in your patch if you
> know that the alignment check can be computed at compile-time and/or
> there is some documentation that MSVC will not align 64-bit units on
> at 4-byte alignment.
https://urldefense.proofpoint.com/v1/url?u=http://msdn.micros
I'm not sure even why the device name is hard coded while it appears in the
interface header file.
Thanks Saurabh.
Eitan
-Original Message-
From: Saurabh Shah
Sent: Thursday, September 04, 2014 4:50 PM
To: Eitan Eliahu; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Windows Ne
Good catch!
I'll fix the typo and will send a new patch soon.
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Thursday, September 04, 2014 11:43 PM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v1] Windows NetLink Socke
event
messages synchronous through the call of nl_sock_recv()
Addressing review comments in v2.
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/include/OvsDpInterfaceExt.h | 1 +
lib/netlink-socket.c | 87 +---
2 files changed, 81
Hi Alin,
I'm sorry I don't follow you on this one. Which style issue you refer to? I
would like to fix it before checking in.
Thanks,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Friday, September 05, 2014 11:03 AM
To: Eitan E
event
messages synchronous through the call of nl_sock_recv()
Addressing review comments in v2.
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/include/OvsDpInterfaceExt.h | 1 +
lib/netlink-socket.c | 87 +---
2 files changed, 81
Acked-by: Alin Gabriel Serdean
Acked-by: Ankur Sharma
-Original Message-
From: Eitan Eliahu [mailto:elia...@vmware.com]
Sent: Friday, September 05, 2014 7:39 PM
To: dev@openvswitch.org
Cc: Eitan Eliahu
Subject: [PATCH v3] Windows NetLink Socket - Support for asynchronous event
Thanks Sam!
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Saturday, September 06, 2014 6:03 PM
To: dev@openvswitch.org; Eitan Eliahu
Cc: Alin Serdean
Subject: [ovs-dev] [PATCH] Windows NetLink Socket - Support for asynchronous
event
event
messages synchronous through the call of nl_sock_recv()
Addressing review comments in v2-4.
Signed-off-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/include/OvsDpInterfaceExt.h | 1 +
lib/netlink-socket.c | 86 +---
2 files changed
event
messages synchronous through the call of nl_sock_recv()
Signed-off-by: Eitan Eliahu
acked-by: Samuel Ghinet
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
Acked-by: Saurabh Shah
---
V3-4 Addressed reviews style comments
---
datapath-windows/include/OvsDpInterfaceExt.h | 1 +
lib
Hi, here are some items we would like to follow up on. Please feel free to add
anything you would like to discuss.
Outstanding review status
[1] NET_BUFFER_LIST to NET_BUFFER (Sam, Alin)
[2] Asynchronous Event user mode (Eitan)
[3] dpif_linux.c (Alin)
[4] Port Dump (Sam, Ali
Hi Guru,
The Windows definition refers to "DDE" monitors. I'm not sure you want to use
this semantics here.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty
Sent: Tuesday, September 09, 2014 1:23 PM
To: dev@openvswitch.org
C
...@nicira.com]
Sent: Tuesday, September 09, 2014 3:23 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-dev] [PATCH] rconn: Prevent redefinition of 'MAX_MONITORS' in
Windows.
On Tue, Sep 9, 2014 at 3:20 PM, Eitan Eliahu wrote:
>
> Hi Guru,
> The Window
Yes, I see, my bad. MAXIMUM_MONITORS instead of MAX_MONTIORS.
Looks good.
Thanks,
Eitan
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, September 09, 2014 3:51 PM
To: Eitan Eliahu
Cc: Gurucharan Shetty; dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs
Thanks Nithin. Will fix the parameter alignment in the first opportunity.
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, September 10, 2014 6:25 AM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH v4] Windows NetLink Socket - Support for
asynchronous event notification
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
---
datapath-windows/include/OvsDpInterfaceExt.h | 7 +++
lib/netlink-socket.c | 81 +---
2 files
Nithin, I can't align it since if aligned this line will go over the 80
character limit.
Thank you.
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, September 10, 2014 12:38 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC grou
Sure will do a)
Thanks
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, September 10, 2014 12:45 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for
event subscription
On Sep 10, 2014, at 12:40 PM, Eitan Eliahu
wrote
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
---
v1 CodingStyle fix alignment
---
datapath-windows/include
Hi Guru,
You can just suppress the warning by wrapping the code in a pragama warning
block:
#pragma warning( push )
#pragma warning( disable : 4707 )
// Some code
#pragma warning( pop )
You don't want to initialize to NULL just for suppressing the warning.
Thanks,
Eitan
-Original Message-
Thanks Alin, I will remove the space and rebase.
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, September 10, 2014 1:41 PM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v1] Netlink_socket.c Join/Unjoin an MC group for
n the header file as you
suggested.
Thank you,
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Wednesday, September 10, 2014 4:10 PM
To: dev@openvswitch.org; Eitan Eliahu
Subject: RE: [ovs-dev] [PATCH v1] Netlink_socket.c Join/Unjoin an MC grou
HI Sam,
Please note that the cleanup callback is not called by NDIS rather called
directed by the I/O manager for the device we created for communicating with
the user mode process.
This device is not part of the network stack.
Per your question: Socket for sump operation are transient (i.e. cre
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove
: Thursday, September 11, 2014 1:07 AM
To: Eitan Eliahu; Gurucharan Shetty; dev@openvswitch.org
Cc: Gurucharan Shetty
Subject: RE: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
Hi Eitan,
I think putting in pragmas to disable warnings is a bit over our
Alin, I will send out a rebased version. (no short cuts here:-) )
Thank you,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Thursday, September 11, 2014 1:27 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v3
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove
rsday, September 11, 2014 1:32 AM
To: Eitan Eliahu; Gurucharan Shetty; dev@openvswitch.org
Cc: Gurucharan Shetty
Subject: RE: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
Hi Eitan,
For a limited scope just to suppress the warnings the code will get very
cumbe
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove
s an l-value does not work in OVS source files.
Anyway, usage of the warning pragma is fine for now.
Thanks,
Eitan
-Original Message-
From: Gurucharan Shetty [mailto:shet...@nicira.com]
Sent: Thursday, September 11, 2014 8:30 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org; Gurucharan Shetty
;, l1);
return 0;
}
Eitan
-Original Message-
From: Gurucharan Shetty [mailto:shet...@nicira.com]
Sent: Thursday, September 11, 2014 10:46 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSET
r the issue with decltype () operator in the OVS code base.
Please go ahead with your change as we don't have anything better right now.
Thanks,
Eitan
-Original Message-
From: Gurucharan Shetty [mailto:shet...@nicira.com]
Sent: Thursday, September 11, 2014 12:44 PM
To: Eitan Elia
ginal Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Thursday, September 11, 2014 12:27 PM
To: Eitan Eliahu
Cc: Gurucharan Shetty; dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
On Thu, Se
Ben Pfaff [mailto:b...@nicira.com]
Sent: Friday, September 12, 2014 8:12 AM
To: Eitan Eliahu
Cc: Gurucharan Shetty; dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
On Fri, Sep 12, 2014 at 02:11:00PM +
-
From: Gurucharan Shetty [mailto:shet...@nicira.com]
Sent: Thursday, September 11, 2014 12:44 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
On Thu, Sep 11, 2014 at 12:20 PM
1 - 100 of 378 matches
Mail list logo
