Hi Saurabh, I removed the assert in the next patch I posted. But, in anyway, since ASSERT does not generate any code for release build it does work. Thanks, Eitan
-----Original Message----- From: Saurabh Shah Sent: Thursday, July 31, 2014 4:40 PM To: Eitan Eliahu; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when internal port is removed Hey Eitan, >BSOD while setting AllowManagementOS on $false #13 >https://urldefense.proofpoint.com/v1/url?u=https://github.com/openvswit >ch/ >ovs/issues/13&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPp >gqS >OJMdMjuZPbesVsNhCUc0E%3D%0A&m=HCvhWNhGzijQI9QgNS1Zm2FCfEDPf3DswRG1vK1p1 >xA% >3D%0A&s=3baeac3a021beacd5bca20512dd65dd5ec8ae5704a6e841fc8e49dd8854d962 >c > >Signed-off-by: Eitan Eliahu <elia...@vmware.com> >--- > datapath-windows/ovsext/OvsActions.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/datapath-windows/ovsext/OvsActions.c >b/datapath-windows/ovsext/OvsActions.c >index 79fb50f..62a98fa 100644 >--- a/datapath-windows/ovsext/OvsActions.c >+++ b/datapath-windows/ovsext/OvsActions.c >@@ -581,7 +581,12 @@ OvsTunnelPortTx(OvsForwardingContext *ovsFwdCtx) > * Setup the source port to be the internal port to as to >facilitate the > * second OvsLookupFlow. > */ >- ASSERT(ovsFwdCtx->switchContext->internalVport); >+ if (ovsFwdCtx->switchContext->internalVport == NULL) { >+ ASSERT(ovsFwdCtx->switchContext->internalVport); This can¹t work because you are still asserting in the if() case. Perhaps you forgot to remove the assert? >+ OvsCompleteNBLForwardingCtx(ovsFwdCtx, >+ L"OVS-Dropped - internal port >removed"); >+ return NDIS_STATUS_FAILURE; >+ } > ovsFwdCtx->srcVportNo = > >((POVS_VPORT_ENTRY)ovsFwdCtx->switchContext->internalVport)->portNo; > >-- >1.9.4.msysgit.0 > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailm >an/ >listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpg >qSO >JMdMjuZPbesVsNhCUc0E%3D%0A&m=HCvhWNhGzijQI9QgNS1Zm2FCfEDPf3DswRG1vK1p1x >A%3 >D%0A&s=07541f072b93faa9856ed01110b08324cb70c378a3d546fd5ea1e1d16ac13ac4 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
