Nithin, I can't align it since if aligned this line will go over the 80 character limit. Thank you. Eitan
-----Original Message----- From: Nithin Raju Sent: Wednesday, September 10, 2014 12:38 PM To: Eitan Eliahu Cc: <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription Eitan, Thanks for doing this. I had some minor comments. LG otherwise. Acked-by: Nithin Raju <nit...@vmware.com> > + OVS_NL_ATTR_MCAST_JOIN, /*1/0 - Join/Unjoin */ minor: need a space before '1/0'. > + nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0, > + OVS_CTRL_CMD_MC_SUBSCRIBE_REQ, > OVS_WIN_CONTROL_VERSION); minor: alignment of 'OVS_CTRL_CMD_MC_SUBSCRIBE_REQ' is off. thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
