We almost forgot what grep is :-) we use a full blown IDE with a string search feature which searches in all the files contained in the IDE project.
-----Original Message----- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff Sent: Tuesday, August 05, 2014 5:16 PM To: Jarno Rajahalme Cc: dev@openvswitch.org; Samuel Ghinet Subject: Re: [ovs-dev] datapath-windows: Could we rename the files please? I always use "git grep", which is recursive by default. On Tue, Aug 05, 2014 at 04:57:39PM -0700, Jarno Rajahalme wrote: > I for one like the fact that it is possible to find almost any (*) > symbol that matters day-to-day in OVS source code with a simple "grep > foo */*.[ch]". I'm not working on the Windows port, but this is an > argument for a current flat directory structure. > > Jarno > > (*) include directory and Linux compat code are exceptions, but > usually that does not matter. include/openflow is about the only > significant directory there, and it is rather stable :-) > > > On Aug 5, 2014, at 3:43 PM, Nithin Raju <nit...@vmware.com> wrote: > > > > Sam, > > One thing to note is that there's thought that has gone into organizing the > > files by functionality, and the names of the files indicate so. For someone > > familiar with how a OVS datapath works, it should not take a lot of time to > > figure out which file implements a particular functionality. I don't know > > how much creating separate directories would buy us. > > > > A basis of comparison we have is to look at the kernel module on Linux. The > > code is fairly well organized by functionality and file names. There are > > not a whole lot of directories. Another basis of comparison is how lib/ is > > organized in userspace. > > > > But, I'd be interested in listening to a proposal. > > > > thanks, > > Nithin > > > >> On Aug 5, 2014, at 2:48 PM, Eitan Eliahu <elia...@vmware.com> wrote: > >> > >> Hi Sam, could you come up with some directory structure for the Move > >> part? I noticed you has a directory structure for your other driver. > >> Thanks, > >> Eitan > >> > >> -----Original Message----- > >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Samuel > >> Ghinet > >> Sent: Tuesday, August 05, 2014 1:36 PM > >> To: dev@openvswitch.org > >> Subject: [ovs-dev] datapath-windows: Could we rename the files please? > >> > >> Hello guys, > >> > >> While we're still fresh with the windows kernel part, could we please > >> rename & move the files? > >> Rename: > >> All the files are Ovs-prefixed. The repository name is Ovs: It is obvious > >> that all files within it are Ovs. > >> Do we really need every file to be Ovs-prefixed? > >> > >> Move: > >> In time, I believe we should expect new files to be added. Perhaps we > >> should add folders in ovsext, such as Core (or whatever name you think > >> best for "needed everywhere stuff"), Protocol (for various net protocols), > >> Transfer (for Ingress, NBL management), HyperV (keep things such as > >> functionality for the Hyper-V Switch, Hyper-V Nics, Hyper-V Ports, OIDs), > >> Winetlink (or whatever name you prefer, for km-um) And, if we do this > >> "move" operation into folders, we would also create filters (i.e. logical > >> folders) in the Visual Studio Project file. > >> > >> I believe the movement of files into "component" based folder will > >> help modularize the project (i.e. people would less likely add > >> Hyper-V Nic functions in km-um files, buffer management in protocol > >> files, etc.) > >> > >> Thanks! > >> Sam > >> _______________________________________________ > >> dev mailing list > >> dev@openvswitch.org > >> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/m > >> ailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA > >> 42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=pJELw5lpJP0zsKaXmHTIkD%2 > >> BGXGplbkr4HJyAX2bIF9M%3D%0A&s=a8fe7629ddafd79744993e6dcae1add9d664b > >> 67930a66becab1c7f34a68d4f37 > >> _______________________________________________ > >> dev mailing list > >> dev@openvswitch.org > >> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/m > >> ailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWav > >> CMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=x3NAfWhixTSOjgPxTVp6Ae > >> 1d3G%2FnQYLE1HGAx1mzHGM%3D%0A&s=ba46743fd6081512720bd67f48e308f3133 > >> 0d60ded61b677eada2a4393dd5c77 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/ma > > ilman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42 > > Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=6IuM34UeexRi1LFIgm8QrYzan1x > > tIG0ebDsNDLaCPfc%3D%0A&s=6614b75323bdf6cf5415d6c29a89e5d27feae3bf9f3 > > 5e45734e2209b6cda9515 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mail > man/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6V > iHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=6IuM34UeexRi1LFIgm8QrYzan1xtIG0eb > DsNDLaCPfc%3D%0A&s=6614b75323bdf6cf5415d6c29a89e5d27feae3bf9f35e45734e > 2209b6cda9515 _______________________________________________ dev mailing list dev@openvswitch.org https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=6IuM34UeexRi1LFIgm8QrYzan1xtIG0ebDsNDLaCPfc%3D%0A&s=6614b75323bdf6cf5415d6c29a89e5d27feae3bf9f35e45734e2209b6cda9515 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
