> >-UINT32 encapMss = OvsGetExternalMtu(switchContext) - sizeof(IPHdr) -
> >sizeof(TCPHdr);
> >+UINT32 encapMss = OvsGetExternalMtu(switchContext)
> >+ - sizeof(IPHdr)
> >+ - sizeof(TCPHdr);
> > if (ipTotalLen > encapMss) {
> >-lsoInfo.V
Beside the alignment problems, looks good to me.
Acked-by: Alin Gabriel Serdean
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Monday, April 25, 2016 2:16 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH] datap
Just a small nit: we could use the values from ipmib.h/netiodef.h instead of
defining our own types.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, April 14, 2016 11:23 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-d
Initial support for multiple internal / external ports on
Windows.
Alin Gabriel Serdean (2):
datapath-windows: Add multiple switch internal ports support
datapath-windows: Fix VPORT when it is allocated by OVS
windows: Add internal switch port per OVS bridge
windows: document multiple NIC
When an OID for an exeternal NIC create is done first try to find it
by its friendly name.
Also when an OID NIC delete is requested only remove it from the hyper-v
hash array not from both.
Some parts of the code have been cleaned since they are not used anymore.
Signed-off-by: Alin Gabriel Serde
From: Alin Serdean
This patch updates the documentation in how to set up OVS with multiple
NICs.
Signed-off-by: Alin Gabriel Serdean
---
INSTALL.Windows.md | 70 +++---
1 file changed, 67 insertions(+), 3 deletions(-)
diff --git a
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
This patch adds multiple internal ports support to the windows datapath.
All tunnels types have been updated to accommodate this new functionality.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Sorin Vinturis
---
datapath-windows/ovsext/Actions.c | 35 +-
datapath-windows/ovsext/Gre.c
Remove ununsed variables, found by inspection.
On fail reset extInfo name.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index d04b1
OpenSSL version changed from 1.0.2g to 1.0.2h this patch bumps the
version.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 422c4af..0fd003b 100644
--- a/appveyor.yml
+++ b/appveyor.y
> >>
> >>I am not sure why Windows kernel doesn't compute UDP checksum for all
> >>tunnels. I added Nithin to the thread to see if he has some idea. My
> >>wild guess is that it tries to save some computational workload.
> >
> >My guess is that it is because VXLAN originally specified that
> >check
Introduce UDP checksum if it was specified in the tunnel information
on Tx.
Set the tunnel checksum information flag on the flow if the UDP checksum
was non zero on the Rx.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vxlan.c | 46 ++---
1
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Offload.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Offload.c
b/datapath-windows/ovsext/Offload.c
index 1e43a9e..e64487d 100644
--- a/datapath-windows/o
Introduce UDP checksum if it was specified in the tunnel information
on Tx.
Set the tunnel checksum information flag on the flow if the
UDP checksum was non zero on the Rx.
Signed-off-by: Alin Gabriel Serdean
---
v2: Address comments
---
datapath-windows/ovsext/Vxlan.c | 43
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
---
v2: Add Acked
---
datapath-windows/ovsext/Offload.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Offload.c
b/datapath-windows/ovsext/Offload.c
index 1e43a9e
This patch introduces GRE checksum computation if the userspace requires
it on Tx. On Rx we verify the GRE checksum if the checksum bit was
specified and also inform the userspace about it.
Also fix the GRE header length as specified by the GRE flags not the
tunnel flags.
Signed-off-by: Alin Gabr
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Tuesday, May 17, 2016 8:15 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 2/4 v2] datapath-windows: Make
> _MapTunAttrToFlowPut() global
>
> Mo
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Tuesday, May 17, 2016 8:15 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 1/4 v2] datapath-windows: add nlMsgHdr to
> OvsPacketExecute
>
> We'l
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Tuesday, May 17, 2016 8:15 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 3/4 v2] datapath-windows: Use l2 port and tunkey
> during execute
>
>
We need to update the "layers" after an action. Think about the following
scenario:
Mpls_pop,recirc
We do not update the "layers" after mpls_pop so we will have the initial values.
That is why we did another flow extract just to update the layers.
Alin.
> -Mesaj original-
> De la: dev [m
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Friday, May 20, 2016 1:32 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 1/2] datapath-windows: don't map output buffer
> in OVS_IOCTL_WRITE
>
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Friday, May 20, 2016 1:32 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 2/2] datapath-windows: o/p buffer must fit NL
> error message
>
> OVS
Beside moving the new functions from Random.h to Util.h, LGTM.
> >+
> >+elem = OvsCreateQueueNlPacket(NlAttrData(userdataAttr),
> >+ NlAttrGetSize(userdataAttr),
>
> The existing code passes ŒuserdataAttr¹ as-is and not the payload.
> Basically, it passes the
I am unsure if we actual need another file but that maybe a personal preference.
Other comments inlined.
Alin.
> +
> +static const long long other_timeouts[] = {
> +[OTHERS_FIRST] = 60 * 1000,
> +[OTHERS_MULTIPLE] = 60 * 1000,
> +[OTHERS_BIDIR] = 30 * 1000,
> +};
[Alin Gab
Testing out the named pipe implementation revealed a problem in
"daemon --detach startup errors". If the daemon actually started nobody
is stopping it.
In the case of test failure kill the daemon.
Signed-off-by: Alin Gabriel Serdean
---
tests/daemon.at | 3 ++-
1 file changed, 2 insertions(+), 1
This patch series is intended to switch the current
implementation of TCP sockets to a named pipe implementation.
One test had to be changed in order for the current state of unit
tests to be the same.
Alin Gabriel Serdean (3):
Windows: Local named pipe implementation
Windows: Drop TCP sockets
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
Signed-off-by: Alin Gabriel
We do not write anything to the file created by the punix/unix arguments.
Switch tests to plain file existence.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovsdb-server.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
in
This patch drops the TCP socket implementation behind command line
arguments punix/unix and switches to the local named pipe implementation.
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 1 +
lib/stream-tcp.c | 115 ---
2 files c
Thanks for the patch.
Overall it looks good my only suggestion would be to move it to a common ground
rather than multiplying the code wherever it is needed.
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July
I am wondering why you get an OSError instead of a select error?
The order of the exception should be inverted (first the select one and after
the OSerror one), or add a general exception at the end.
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În num
Thanks for the patch. I will change the test after the named pipe
implementation gets in.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July 6, 2016 3:38 PM
> Către: dev@openvswitch.org
> Su
I am wondering if it is better if we could just import the shared library and
call the detach function
(https://github.com/openvswitch/ovs/blob/master/lib/daemon-windows.c#L342)
instead of duplicating the effort.
I wonder if the same could be applied un the *unix side as well.
Thanks,
Alin.
>
Thanks for the review!
> -Mesaj original-
> De la: Paul Boca
> Trimis: Tuesday, July 12, 2016 10:29 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: RE: [PATCH 1/3] Windows: Local named pipe implementation
>
> Hi Alin!
>
> As discussed offline,
This patch series is intended to switch the current implementation of
TCP sockets to a named pipe implementation.
One test had to be changed in order for the current state of unit tests
to be the same.
Alin Gabriel Serdean (3):
Windows: Local named pipe implementation
Windows: Drop TCP socket
We do not write anything to the file created by the punix/unix arguments.
Switch tests to plain file existence.
Acked-by: Paul Boca
Signed-off-by: Alin Gabriel Serdean
---
v2: Add acked
---
tests/ovsdb-server.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/ovs
This patch drops the TCP socket implementation behind command line
arguments punix/unix and switches to the local named pipe implementation.
Acked-by: Paul Boca
Signed-off-by: Alin Gabriel Serdean
---
v2: Add acked
---
lib/automake.mk | 1 +
lib/stream-tcp.c | 115 ---
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
Signed-off-by: Alin Gabriel
> -Mesaj original-
> De la: Paul Boca
> Trimis: Wednesday, July 13, 2016 11:24 AM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python
> daemon to Windows
>
> Hi Alin,
>
> It was easier for me
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July 13, 2016 8:35 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7] windows: Added lockf function and lock PID
> file
>
> If the PI
>
> Hi Alin,
>
> It was easier for me to call Windows APIs from python, that mimics
> detach_process, and to be in a better control on what's happening, than
> creating a *DLL and loading it in order to call this function.
> *On Windows the LIB file cannot be loaded as-is; a DLL with entry point
>
> > +flock(filep_pidfile, LOCK_EX);
> >
> Won't the above call block indefinitely if the lock has already been taken by
> someone else? We don't want the behavior when someone starts a daemon
> and it simply hang there.
[Alin Gabriel Serdean: ] Hard to say from the MSDN documentation we could a
Thanks a lot for the patch.
In my opinion I think this part should go in a different file.
The patch looks good overall some comments questions/inlined.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July 6, 2016 3:38 PM
> Că
Thanks for the review! Comments inlined.
Thanks,
Alin.
De la: Guru Shetty [mailto:g...@ovn.org]
Trimis: Friday, July 15, 2016 1:27 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v2 1/3] Windows: Local named pipe implementation
On 12 July 2016 at 20:32, Alin
[Alin Gabriel Serdean: ]
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365203(v=vs.85).aspx
The part:
"If the same range is locked with an exclusive and a shared lock, two unlock
operations are necessary to unlock the region; the first unlock operation
unlocks the exclusive lock, t
On 12 July 2016 at 20:32, Alin Serdean
mailto:aserd...@cloudbasesolutions.com>> wrote:
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arg
De la: Guru Shetty [mailto:g...@ovn.org]
Trimis: Friday, July 15, 2016 5:49 AM
Către: Alin Serdean
Cc: Paul Boca ; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH V7] windows: Added lockf function and lock PID
file
On 14 July 2016 at 19:25, Alin Serdean
mailto:aserd
Currently we do not validate ports prior a VM being started. This patch
allows ports to be validated during creation.
Validation ports have the same lifecycle as an operational port so allow
them to have the same treatment as an operational port.
Beside the above this also allows us to add OVS po
can write to it).
De la: Guru Shetty [mailto:g...@ovn.org]
Trimis: Friday, July 15, 2016 5:49 AM
Către: Alin Serdean
mailto:aserd...@cloudbasesolutions.com>>
Cc: Paul Boca
mailto:pb...@cloudbasesolutions.com>>;
dev@openvswitch.org<mailto:dev@openvswitch.org>
Subiect: Re: [
I still think a new file would be more suited it :), but maybe that's just me.
As discussed offline I think you can remove the DuplicateHandle part.
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21
Looks more clean now :).
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 14/16] python tests: Ignore stderr output
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 09/16] python tests: Fixed OSError not iterable
> on Windows
>
> On Windows if this exception is tr
Beside a small alignment problem:
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 03/16] python tests: Fixed ctl fi
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 05/16] python tests: Added fcntl module for
> Windows
>
> This is
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 02/16] python tests: Register signal handlers
> only on supported t
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 01/16] python tests: Implemented signal.alarm
> for Windows
>
> sig
Please do not forget to update the documentation with the python libraries
needed on Windows.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Friday, July 15, 2016 5:21 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V7 00/16]
Hi Yin,
Thanks for the patch one. Just one small question from me inlined.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Yin Lin
> Trimis: Thursday, July 14, 2016 6:21 AM
> Către: dev@openvswitch.org
> Cc: Yin Lin
> Subiect: [ovs-dev] [PATCH] datapath-win
Hi Sai,
Thanks a lot for the series.
As a general comment could you please squash commits and have one per concept
(I find them hard to follow):
i.e. 1 and 3 (https://patchwork.ozlabs.org/patch/648116/ ,
https://patchwork.ozlabs.org/patch/648110/ ) can be a single commit since you
are renamin
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Monday, July 18, 2016 9:27 PM
> Către: Yin Lin
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c
> around subscribe and lock
>
> H
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
> Trimis: Thursday, July 21, 2016 4:30 PM
> Către: Yin Lin ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs
>
> Hi Yin,
>
@Guru, @Ben what do you suggest?
> -Mesaj original-
> De la: Paul Boca
> Trimis: Thursday, July 21, 2016 7:36 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: RE: [ovs-dev] [PATCH V7 12/16] python tests: Ported Python
> daemon to Windows
>
> Hi Alin
Către: Alin Serdean
Cc: Yin Lin ; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs
Hi Alin,
I know this can be confusing but after a second thought I think mine is
correct. Your suggestion is equivalent to (abbreviated):
!(port == geneve && port =
k specific to
> gOvsSwitchContext inside OvsGetOpenInstance() and not rely on
> EventQueue lock to enforce it.
>
> Thanks,
> Sairam
>
>
>
>
> On 7/21/16, 6:58 AM, "Alin Serdean"
> wrote:
>
> >> -Mesaj original-
> >
> >
I would prefer if you did the squash because it makes it easier to revert/look
over later on.
I will review the patches as is.
Thanks,
Alin.
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Thursday, July 21, 2016 9:19 PM
> Către: Alin Ser
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 1/9] datapath-windows: Rename
> OVS_EVENT_ENTRY to OVS_VPORT
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 2/9] datapath-windows: Add supported netlink
> family protoc
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 3/9] datapath-windows: Explicitly name vport
> related event
Looks good just one question inlined.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast
> conntrack
It looks like a mistake was done when setting them up, don't know if it such a
good idea to propagate it.
Thanks,
Alin.
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Friday, July 22, 2016 11:15 PM
> Către: Alin Serdean ;
>
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 6/9] datapath-windows: Modify
> OvsCreateNlMsgFromCtEntry to
Looks good. Just a few questions from my side so I get up to speed with the
changes in events.
Why do we need a lock per eventid ?
> +typedef struct _OVS_CT_EVENT_ENTRY {
> +OVS_CT_ENTRY entry;
> +UINT8 type;
> +UINT64 pad[10];
> +} OVS_CT_EVENT_ENTRY, *POVS_CT_EVENT_ENTRY;
Why such
Just one comment inlined.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 8/9] datapath-windows: Update
> OvsReadEventCmdHandler in Datapath.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 9/9] datapath-windows: Post Conntrack delete
> and new event
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Thursday, July 21, 2016 9:52 PM
> Către: Alin Serdean ; Yin Lin
>
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c
> around su
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
gt; De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Monday, July 25, 2016 11:19 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 7/9] datapath-windows: Add support for
> multiple event queue in Event.c
>
> I added the
_get_osfhandle returns an errno value not a GetLastErrorValue.
(https://msdn.microsoft.com/en-us/library/ks2530z6(v=vs.120).aspx)
Signed-off-by: Alin Gabriel Serdean
---
lib/daemon-windows.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/daemon-windows.c b/lib/daemon-win
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Tuesday, July 26, 2016 3:01 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V9 09/17] python tests: Fixed OSError not iterable
> on Windows
>
> O
LGTM.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Tuesday, July 26, 2016 3:03 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V9 12/17] python tests: Prepare porting Python
> daemon on Window
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Tuesday, July 26, 2016 3:03 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V9 13/17] python tests: Ported Python daemon to
> Windows
>
> Used su
gt; subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and
> store it as part of OVS_EVENT_SUBSCRIBE structure.
>
> v2: Squashed patches 2/9 and 5/9 into one. Addressed review comments
> from Yin Lin and Alin Serdean
>
> Signed-off-by: Sairam Venugopal
existing
> workflow.
>
> v2: Address review comments from Alin Serdean (Not default values to 0 and
> instead read from msgIn). Added Acked-By
>
> Signed-off-by: Sairam Venugopal
> Acked-by: Paul Boca
> ---
> datapath-windows/ovsext/Datapath.c | 66
> ++
I wanted to ask you about OvsWaitEventIoctl lock but you fixed in 5/7
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Tuesday, July 26, 2016 3:05 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev
> -Mesaj original-
> De la: Alin Serdean
> Trimis: Tuesday, July 26, 2016 4:08 PM
> Către: 'Sairam Venugopal' ; dev@openvswitch.org
> Subiect: RE: [ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for
> multiple event queue in Event.c
>
> I wanted
s not enforce a safe read for
> gOvsSwitchContext->dpNo. Use the gOvsSwitchContext->dispatchLock for
> accessing the parameter.
>
> v2: Address review comments from Alin Serdean and Yin Lin (around keeping
> OvsGetOpenInstance safe).
>
> Signed-off-by: Sairam Venugopal
> -
This patch updates the documentation in how to set up OVS with multiple
NICs.
Signed-off-by: Alin Gabriel Serdean
---
v2: Rebase
---
INSTALL.Windows.md | 70 +++---
1 file changed, 67 insertions(+), 3 deletions(-)
diff --git a/INSTALL.Windows.md b
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
When an OID for an exeternal NIC create is done first try to find it
by its friendly name.
Also when an OID NIC delete is requested only remove it from the hyper-v
hash array not from both.
Some parts of the code have been cleaned since they are not used anymore.
Signed-off-by: Alin Gabriel Serde
This patch adds multiple internal ports support to the windows datapath.
All tunnels types have been updated to accommodate this new functionality.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Sorin Vinturis
---
v2: Rebase
---
datapath-windows/ovsext/Actions.c | 41 +-
datapath-windows
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
FYI
> -Mesaj original-
> De la: Ben Pfaff [mailto:b...@ovn.org]
> Trimis: Friday, July 29, 2016 11:53 PM
> Către: Alin Serdean
> Cc: Guru Shetty ; Sairam Venugopal
> ; Nithin Raju ; Justin Pettit
> ; Alessandro Pilotti
> Subiect: Re: OVS branching 2.6
>
>
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
De la: Guru Shetty [mailto:g...@ovn.org]
Trimis: Thursday, July 28, 2016 7:41 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v4] Windows: Local named pipe implementation
On 26 July 2016 at 12:57, Alin Serdean
mailto:aserd...@cloudbasesolutions.com>>
Error log:
1153. ofproto-dpif.at:8215: testing ofproto-dpif - conntrack - output action ...
./ofproto-dpif.at:8216: ovsdb-tool create conf.db
$abs_top_srcdir/vswitchd/vswitch.ovsschema
./ofproto-dpif.at:8216: ovsdb-server --detach --no-chdir --pidfile --log-file
--remote=punix:$OVS_RUNDIR/db.soc
1161. ofproto-dpif.at:8585: testing ofproto-dpif - conntrack - ct_label
datapath flow ...
./ofproto-dpif.at:8586: ovsdb-tool create conf.db
$abs_top_srcdir/vswitchd/vswitch.ovsschema
./ofproto-dpif.at:8586: ovsdb-server --detach --no-chdir --pidfile --log-file
--remote=punix:$OVS_RUNDIR/db.sock
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v3: Add acked
v2: Rebase
---
---
INSTALL.Windows.md | 143 +++
101 - 200 of 799 matches
Mail list logo
