Thanks for the patch. Overall it looks good my only suggestion would be to move it to a common ground rather than multiplying the code wherever it is needed.
Thanks, Alin. > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Wednesday, July 6, 2016 3:38 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V6 01/17] python tests: Implemented signal.alarm > for Windows > > signal.alarm is not available in Windows and would trigger an exception when > called. Implemented this to mentain compatibility between Windows and > Linux for python tests. > > Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> > --- > V2: No changes > V3: Code styling changes > V4: No changes > V5: No changes > V6: No changes > --- > tests/appctl.py | 27 ++++++++++++++++++++++++++- > tests/test-ovsdb.py | 26 +++++++++++++++++++++++++- > tests/test-unix-socket.py | 26 +++++++++++++++++++++++++- > 3 files changed, 76 insertions(+), 3 deletions(-) > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
