Hi Sai, Thanks a lot for the series.
As a general comment could you please squash commits and have one per concept (I find them hard to follow): i.e. 1 and 3 (https://patchwork.ozlabs.org/patch/648116/ , https://patchwork.ozlabs.org/patch/648110/ ) can be a single commit since you are renaming events to vport_events 2, 5 and maybe 8 can be a single commit as well since they are using the newly introduced NETLINK_NETFILTER, NETLINK_GENERIC. Thanks, Alin. > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:38 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 0/9] Add support for sending Conntrack events > > Send out events when a Conntrack entry is created or destroyed. The events > can be listened using the netlink multicast subscription. Also fix few bugs in > Event.c around event handling. > > Sairam Venugopal (9): > datapath-windows: Rename OVS_EVENT_ENTRY to > OVS_VPORT_EVENT_ENTRY > datapath-windows: Add supported netlink family protocols to > NetlinkProto.h > datapath-windows: Explicitly name vport related event to vportEvent > datapath-windows: Fix bugs in Event.c around subscribe and lock > datapath-windows: Define new multicast conntrack events > datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it > reusable > datapath-windows: Add support for multiple event queue in Event.c > datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to > support different events > datapath-windows: Post Conntrack delete and new events > > datapath-windows/ovsext/Conntrack.c | 44 +++- > datapath-windows/ovsext/Conntrack.h | 9 + > datapath-windows/ovsext/Datapath.c | 81 +++++-- > datapath-windows/ovsext/Datapath.h | 3 +- > datapath-windows/ovsext/DpInternal.h | 25 ++- > datapath-windows/ovsext/Event.c | 279 ++++++++++++++++++++-- > --- > datapath-windows/ovsext/Event.h | 22 +- > datapath-windows/ovsext/Netlink/NetlinkProto.h | 3 + > datapath-windows/ovsext/Vport.c | 12 +- > 9 files changed, 383 insertions(+), 95 deletions(-) > > -- > 2.9.0.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
