Beside moving the new functions from Random.h to Util.h, LGTM.
> >+ > >+ elem = OvsCreateQueueNlPacket(NlAttrData(userdataAttr), > >+ NlAttrGetSize(userdataAttr), > > The existing code passes ŒuserdataAttr¹ as-is and not the payload. > Basically, it passes the NL_ATTR structure and not just the payload. Any > reason to strip off the header? [Alin Gabriel Serdean: ] You get the header twice in the userspace hence the bad length we need just the payload when passing the userdata. We could leave it as is or change the way we put the attribute in OvsCreateQueueNlPacket. > > If you follow through to how OvsCreateQueueNlPacket() uses this, you¹ll end > up with NlMsgPutTailUnspec() and that needs the NL_ATTR header to be > present as part of the data. > Thanks, Alin. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
