[ovs-dev] [PATCH v12 1/6] netdev-dpdk: Restore thread affinity after DPDK init

2016-04-26 Thread Aaron Conole
hread affinity after calling dpdk_init(). Co-authored-by: Kevin Traynor Signed-off-by: Kevin Traynor Signed-off-by: Aaron Conole Tested-by: RobertX Wojciechowicz Tested-by: Sean K Mooney Acked-by: Panu Matilainen Acked-by: Flavio Leitner --- Previous: http://openvswitch.org/pipermail/dev

[ovs-dev] [PATCH v12 2/6] netdev-dpdk: Convert initialization from cmdline to db

2016-04-26 Thread Aaron Conole
initialization until after the OVS database connection is established, at which point ovs initializes librte. It pulls all of the config data from the OVS database, and assembles a new argv/argc pair to be passed along. Signed-off-by: Aaron Conole Acked-by: Kevin Traynor --- Previous: http

[ovs-dev] [PATCH v12 0/6] Convert DPDK configuration from command line to DB based

2016-04-26 Thread Aaron Conole
upstream * Dropped path canonicalization * Squashed NEWS changes into their specific commits. Aaron Conole (6): netdev-dpdk: Restore thread affinity after DPDK init netdev-dpdk: Convert initialization from cmdline to db netdev-dpdk: Restrict vhost_sock_dir netdev-dpdk: Autofill lcore coremask

[ovs-dev] [PATCH v12 4/6] netdev-dpdk: Autofill lcore coremask if absent

2016-04-26 Thread Aaron Conole
lcore mask, in addition to the dpdk lcore threads. Signed-off-by: Aaron Conole Tested-by: Sean K Mooney Tested-by: RobertX Wojciechowicz Tested-by: Kevin Traynor Acked-by: Panu Matilainen Acked-by: Kevin Traynor Acked-by: Flavio Leitner --- Previous: http://openvswitch.org/pipermail/dev/2016

[ovs-dev] [PATCH v12 3/6] netdev-dpdk: Restrict vhost_sock_dir

2016-04-26 Thread Aaron Conole
crafted names. To prevent this, use the introduced ovs_realpath function to resolve the filesystem location and ensure that it resolves under the ovs_rundir. Signed-off-by: Aaron Conole --- Previous: http://openvswitch.org/pipermail/dev/2016-April/069030.html v12: * Converted to using strstr instead

[ovs-dev] [PATCH v12 5/6] netdev-dpdk: Allow arbitrary eal arguments

2016-04-26 Thread Aaron Conole
it to the argument list. The only argument which will not be supported with this change is '--no-huge', which appears to break the system in other ways. Signed-off-by: Aaron Conole Tested-by: Sean K Mooney Tested-by: RobertX Wojciechowicz Tested-by: Kevin Traynor Acked-by: Panu

[ovs-dev] [PATCH v12 6/6] netdev-dpdk: Check dpdk-extra when reading db

2016-04-26 Thread Aaron Conole
A previous patch introduced the ability to pass arbitrary EAL command line options via the dpdk_extras database entry. This commit enhances that by warning the user when such a configuration is detected and prefering the value in the database. Suggested-by: Sean K Mooney Signed-off-by: Aaron

Re: [ovs-dev] [PATCH v12 2/6] netdev-dpdk: Convert initialization from cmdline to db

2016-04-29 Thread Aaron Conole
. I > think we should register the classes only when DPDK is initialized. I had an issue doing this, back when the I had the lazy initialization. I don't remember the details, though. I'll try it again, and see what happens. > Two minor nits inline, > > Thanks Thanks so m

Re: [ovs-dev] [PATCH v12 3/6] netdev-dpdk: Restrict vhost_sock_dir

2016-04-29 Thread Aaron Conole
t; On 26/04/2016 12:42, "Aaron Conole" wrote: > >>Since the vhost-user sockets directory now comes from the database, it is >>possible for any user with database access to program an arbitrary filesystem >>location for the sockets directory. This could result in u

Re: [ovs-dev] [PATCH v12 6/6] netdev-dpdk: Check dpdk-extra when reading db

2016-04-29 Thread Aaron Conole
Daniele Di Proietto writes: > Hi Aaron, one more comment inline > > The rest of the series looks good to me > > Thanks, > > Daniele Thanks (majorly!) for reviewing this series, Daniele! I owe you a beer, I think :) -Aaron > > On 26/04/2016 12:42, "Aaron Cono

[ovs-dev] [PATCH v13 1/6] netdev-dpdk: Restore thread affinity after DPDK init

2016-04-29 Thread Aaron Conole
hread affinity after calling dpdk_init(). Co-authored-by: Kevin Traynor Signed-off-by: Kevin Traynor Signed-off-by: Aaron Conole Tested-by: RobertX Wojciechowicz Tested-by: Sean K Mooney Acked-by: Panu Matilainen Acked-by: Flavio Leitner --- v13: * No change from v12 lib/netdev-dpdk.c

[ovs-dev] [PATCH v13 0/6] Convert DPDK configuration from command line to DB based

2016-04-29 Thread Aaron Conole
://openvswitch.org/pipermail/dev/2016-April/069025.html v13: * Rebased to latest upstream * Addressed sparse errors * Removed the dpdk-mem-channels option * Switched to using the other_config smap directly. * Moved the netdev_dpdk_register() to the dpdk_init__ routine. Aaron Conole (6): netdev-dpdk

[ovs-dev] [PATCH v13 3/6] netdev-dpdk: Restrict vhost_sock_dir

2016-04-29 Thread Aaron Conole
crafted names. To prevent this, use the introduced ovs_realpath function to resolve the filesystem location and ensure that it resolves under the ovs_rundir. Signed-off-by: Aaron Conole --- v13: * Handle the case where vhost-sock-dir is not set in the database lib/netdev-dpdk.c| 31

[ovs-dev] [PATCH v13 2/6] netdev-dpdk: Convert initialization from cmdline to db

2016-04-29 Thread Aaron Conole
initialization until after the OVS database connection is established, at which point ovs initializes librte. It pulls all of the config data from the OVS database, and assembles a new argv/argc pair to be passed along. Signed-off-by: Aaron Conole Acked-by: Kevin Traynor --- v13: * Address sparse

[ovs-dev] [PATCH v13 4/6] netdev-dpdk: Autofill lcore coremask if absent

2016-04-29 Thread Aaron Conole
lcore mask, in addition to the dpdk lcore threads. Signed-off-by: Aaron Conole Tested-by: Sean K Mooney Tested-by: RobertX Wojciechowicz Tested-by: Kevin Traynor Acked-by: Panu Matilainen Acked-by: Kevin Traynor Acked-by: Flavio Leitner --- v13: * No change lib/netdev-dpdk.c | 38

[ovs-dev] [PATCH v13 6/6] netdev-dpdk: Check dpdk-extra when reading db

2016-04-29 Thread Aaron Conole
A previous patch introduced the ability to pass arbitrary EAL command line options via the dpdk_extras database entry. This commit enhances that by warning the user when such a configuration is detected and prefering the value in the database. Suggested-by: Sean K Mooney Signed-off-by: Aaron

[ovs-dev] [PATCH v13 5/6] netdev-dpdk: Allow arbitrary eal arguments

2016-04-29 Thread Aaron Conole
it to the argument list. The only argument which will not be supported with this change is '--no-huge', which appears to break the system in other ways. Signed-off-by: Aaron Conole Tested-by: Sean K Mooney Tested-by: RobertX Wojciechowicz Tested-by: Kevin Traynor Acked-by: Panu

[ovs-dev] [PATCH] utilities/ovs-ctl.in: Only add_managers with vswitchd

2016-05-02 Thread Aaron Conole
the effect of the add_managers call if the `--no-ovs-vswitchd` argument is given. Fixes: 7fc28c50c012 ("ovs-ctl: Allow selective start for db and switch") Signed-off-by: Aaron Conole --- utilities/ovs-ctl.in | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a

[ovs-dev] [PATCH 1/2] chutil: introduce a new change-utils lib

2016-05-03 Thread Aaron Conole
side is implemented. Signed-off-by: Aaron Conole --- configure.ac| 2 +- lib/automake.mk | 2 + lib/chutil-unix.c | 360 lib/chutil.h| 32 + lib/daemon-unix.c | 141 +--- lib/util.c

[ovs-dev] [PATCH 0/2] vhost-user: Add the ability to control ownership/permissions

2016-05-03 Thread Aaron Conole
manual intervention required to connect QEMU and OVS via DPDK. The first patch adds chmod and chown calls to lib, with unit tests. The second patch hooks those calls into the netdev_dpdk_vhost_user_construct function, after the socket is created. Aaron Conole (2): chutil: introduce a new change

[ovs-dev] [PATCH 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-03 Thread Aaron Conole
rship, and 'vhost-sock-perms' to set the permissions bits for the vhost_user sockets. Signed-off-by: Aaron Conole --- INSTALL.DPDK.md | 7 +++ NEWS | 2 ++ lib/netdev-dpdk.c| 26 +++--- vswitchd/vswitch.xml | 23 +++

Re: [ovs-dev] [PATCH v2] lib: protect daemon_set_new_user against non existing user:group specs

2016-05-03 Thread Aaron Conole
Christian Ehrhardt writes: > Aarons last patch reminded me that we didn't went on on the fixed patch for > this code path that Aaron just modified. > So giving this a bump to show up again. > > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > > On Mon, Apr 25, 2016 at 2:12

Re: [ovs-dev] [PATCH] netdev-dpdk: print default vhost-sock-dir if none provided

2016-05-05 Thread Aaron Conole
Hi Ciara, Please add a Fixes: tag. Ciara Loftus writes: > Signed-off-by: Ciara Loftus > --- > lib/netdev-dpdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index b488c60..67b9e0d 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Print default vhost-sock-dir value & update documentation

2016-05-06 Thread Aaron Conole
ther_config) > } > free(sock_dir_subcomponent); > } else { > -vhost_sock_dir = xstrdup(ovs_rundir()); > -free(sock_dir_subcomponent); > +vhost_sock_dir = sock_dir_subcomponent; > #endif > } Acked-by: Aaron Conole Thanks, Ciara! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] doc: Refactor DPDK install guide, add ADVANCED doc

2016-05-13 Thread Aaron Conole
Hi Bhanuprakash, Bhanuprakash Bodireddy writes: > Add INSTALL.DPDK-ADVANCED document that is forked off from original > INSTALL.DPDK guide. This document is targeted at users looking for > optimum performance on OVS using dpdk datapath. > > Signed-off-by: Bhanuprakash Bodireddy > --- > INSTALL

Re: [ovs-dev] [PATCH 1/2] doc: Refactor DPDK install documentation

2016-05-13 Thread Aaron Conole
Bhanuprakash Bodireddy writes: > Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and > INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the > novice user in setting up the OVS DPDK and running it out of box, the > ADVANCED document is targeted at expert users l

Re: [ovs-dev] [PATCH 0/2] vhost-user: Add the ability to control ownership/permissions

2016-05-16 Thread Aaron Conole
Ping for this series? Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created,

Re: [ovs-dev] [PATCH] utilities/ovs-ctl.in: Only add_managers with vswitchd

2016-05-16 Thread Aaron Conole
Aaron Conole writes: > The ovs-ctl script was changed recently to have per-service start/stop > control. However, when that change was made the add_managers() call was > overlooked. This results in calls to `ovs-ctl --no-ovs-vswitchd start` > telling the ovsdb-server to connect t

Re: [ovs-dev] [PATCH] utilities/ovs-ctl.in: Only add_managers with vswitchd

2016-05-18 Thread Aaron Conole
Ben Pfaff writes: > On Mon, May 02, 2016 at 01:08:53PM -0400, Aaron Conole wrote: >> The ovs-ctl script was changed recently to have per-service start/stop >> control. However, when that change was made the add_managers() call was >> overlooked. This results in calls

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix coremask logic.

2016-05-18 Thread Aaron Conole
"Traynor, Kevin" writes: >> -Original Message- >> From: Traynor, Kevin >> Sent: Tuesday, May 10, 2016 2:41 PM >> To: dev@openvswitch.org >> Cc: Traynor, Kevin ; Aaron Conole >> >> Subject: [PATCH v2 1/2] netdev-dpdk: Fix coremask lo

Re: [ovs-dev] [ovs-dev, 1/2] chutil: introduce a new change-utils lib

2016-05-19 Thread Aaron Conole
Ben Pfaff writes: > On Tue, May 03, 2016 at 01:26:39PM -0400, Aaron Conole wrote: >> It will be useful in the future to be able to set ownership and permissions >> on files which Open vSwitch creates. Allowing the specification of such >> ownership and permissions using th

[ovs-dev] [PATCH v2] utilities/ovs-ctl.in: Only add_managers with vswitchd

2016-05-20 Thread Aaron Conole
will defer signaling to remote managers until the following are both true: 1. At least one of OVSDB_SERVER or OVS_VSWITCHD was told to start 2. Both daemons are running. Fixes: 7fc28c50c012 ("ovs-ctl: Allow selective start for db and switch") Signed-off-by: Aaron Conole --- v1->v2: -

[ovs-dev] [PATCH v2] gcov: Runtime configurable destination output

2016-05-20 Thread Aaron Conole
From: Aaron Conole The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be untouched by libgcov for certain tests. This change allows configuring the gcov output via an environment variable which will

Re: [ovs-dev] [PATCH v2] gcov: Runtime configurable destination output

2016-05-20 Thread Aaron Conole
Oops. Bad send-email command line. Disregard. Aaron Conole writes: > From: Aaron Conole > > The previous gcov behavior was to always output errors on the stderr channel. > This is fine for most uses, but some programs will require stderr to be > untouched by libgcov for cert

[ovs-dev] [PATCH] utilities/checkpatch.py: Check for appropriate bracing

2016-05-20 Thread Aaron Conole
Teach checkpatch.py to understand that if/for/while blocks should always end with braces on the same line (if possible). This does not address multi-line if/for/while blocks, but provides a point where such blocks could be added. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 30

[ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-20 Thread Aaron Conole
rship, and 'vhost-sock-perms' to set the permissions bits for the vhost_user sockets. Signed-off-by: Aaron Conole --- v1->v2: * Rebased to latest INSTALL.DPDK.md | 7 +++ NEWS | 2 ++ lib/netdev-dpdk.c| 26 +++--- vs

[ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-05-20 Thread Aaron Conole
manual intervention required to connect QEMU and OVS via DPDK. The first patch adds chmod and chown calls to lib, with unit tests. The second patch hooks those calls into the netdev_dpdk_vhost_user_construct function, after the socket is created. Aaron Conole (2): chutil: introduce a new change

[ovs-dev] [PATCH v2 1/2] chutil: introduce a new change-utils lib

2016-05-20 Thread Aaron Conole
side is implemented. Signed-off-by: Aaron Conole --- v1->v2: * Rebased to latest * Added multi- and assign- actions to ovs_chmod * Re-ran checkpatch with the latest round of enhancments lib/automake.mk | 2 + lib/chutil-unix.c |

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-05-23 Thread Aaron Conole
t want to apply and test it before giving your tags. That said, I'm glad you're confident enough in my work. That makes one of us :-) > Kind regards, > Christian > > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > > On Fri, May 20, 2016 at

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-24 Thread Aaron Conole
MAC layer enforces access, but even without MAC, the DAC layer can provide appropriate whitelisting behavior. I hope that makes sense. Thanks for your input on this, as always, Daniele! -Aaron > Thanks, > > Daniele > > > > > On 20/05/2016 13:32, "Aaron Conole" wrote

[ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-24 Thread Aaron Conole
on the mirror port (allowing the user to specify additional arguments), and dump data to the screen (or otherwise). Signed-off-by: Aaron Conole --- NEWS | 2 + utilities/automake.mk | 5 + utilities/ovs-tcpdump.8.in | 38 + utilities/ovs-tcpdump.in | 398

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-25 Thread Aaron Conole
Flavio Leitner writes: > On Tue, May 24, 2016 at 04:35:29PM -0400, Aaron Conole wrote: >> Currently, there is some documentation which describes setting up and >> using port mirrors for bridges. This documentation is helpful to setup >> a packet capture for specific por

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-25 Thread Aaron Conole
Lance Richardson writes: > - Original Message - >> From: "Aaron Conole" >> To: dev@openvswitch.org >> Sent: Tuesday, May 24, 2016 4:35:29 PM >> Subject: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility >> >> Currently, there

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-26 Thread Aaron Conole
Flavio Leitner writes: > On Wed, May 25, 2016 at 11:08:37AM -0400, Aaron Conole wrote: >> Flavio Leitner writes: >> > On Tue, May 24, 2016 at 04:35:29PM -0400, Aaron Conole wrote: > [...] >> >> + >> >> +ovsdb = OVSDB(db

Re: [ovs-dev] [PATCH 0/5] Fixes for big-endian architectures

2016-05-27 Thread Aaron Conole
his for be->host) and 4/5. Thank goodness for coffee. I haven't had a chance to test this (I have a be machine somewhere...), but it looks good to me. Acked-by: Aaron Conole ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Aaron Conole
Russell Bryant writes: > On Tue, May 24, 2016 at 4:35 PM, Aaron Conole wrote: > > > Currently, there is some documentation which describes setting up and > using port mirrors for bridges. This documentation is helpful to setup > a packet capture for specific ports. > >

[ovs-dev] [RFC v2] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Aaron Conole
on the mirror port (allowing the user to specify additional arguments), and dump data to the screen (or otherwise). Signed-off-by: Aaron Conole --- v1->v2: - Added a framework for auto-creating a tap device - Hooked up linux tun calls for this (note: since the device needs to be opened

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Aaron Conole
Russell Bryant writes: > On Fri, May 27, 2016 at 2:02 PM, Aaron Conole wrote: > > > Russell Bryant writes: > > > On Tue, May 24, 2016 at 4:35 PM, Aaron Conole wrote: > > > > > > Currently, there is some documentation which describes setting up

Re: [ovs-dev] [PATCH] ovn-northd.8.xml: fix sock path of NB and SB database.

2016-05-31 Thread Aaron Conole
Li Wei writes: > commit 60bdd01 ("Separating OVN NB and SB database processes") introduced > a separating OVN NB and SB database process, the path of sock file need > to be updated. > > Fixes: 60bdd01 ("Separating OVN NB and SB database processes") > Signed-off-by: Li Wei > --- > ovn/northd/ovn

Re: [ovs-dev] [PATCH] ovsdb: Expose vhost-user socket directory in ovsdb

2016-05-31 Thread Aaron Conole
"Fischetti, Antonio" writes: > Hi Robert, > one comment below. > I've checked it applies cleanly to the latest master branch. > Also with utilities/checkpatch.py is ok. > > Thanks, > Antonio > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Robert >> W

Re: [ovs-dev] [PATCH] ovsdb: Expose vhost-user socket directory in ovsdb

2016-05-31 Thread Aaron Conole
Hi Robert, Robert Wojciechowicz writes: > In order to correctly interoperate with Openstack and ODL, > the vhost-user socket directory must be exposed from OVS via OVSDB. > Different distros may package OVS in different ways, > so the locations of these sockets may vary depending on how > ovs-v

[ovs-dev] [PATCH] ovs-tcpdump: Add a tcpdump wrapper utility

2016-06-01 Thread Aaron Conole
on the mirror port (allowing the user to specify additional arguments), and dump data to the screen (or otherwise). Signed-off-by: Aaron Conole --- NEWS | 2 + utilities/automake.mk | 8 +- utilities/ovs-tcpdump.8.in | 51 + utilities/ovs-tcpdump.in | 453

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-06-01 Thread Aaron Conole
Ansis Atteka writes: > On 20 May 2016 at 13:32, Aaron Conole wrote: > >> Currently, when using Open vSwitch with DPDK and qemu guests, the >> recommended >> method for joining the guests is via the dpdkvhostuser interface. This >> interface uses Unix Domain sock

Re: [ovs-dev] [PATCH v2 1/2] chutil: introduce a new change-utils lib

2016-06-03 Thread Aaron Conole
Ben Pfaff writes: > On Fri, May 20, 2016 at 04:32:05PM -0400, Aaron Conole wrote: >> It will be useful in the future to be able to set ownership and permissions >> on files which Open vSwitch creates. Allowing the specification of such >> ownership and permissions using th

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-03 Thread Aaron Conole
Christian Ehrhardt writes: > On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: > >> Daniele Di Proietto writes: >> >> > Hi Aaron, >> > >> > I'm still a little bit nervous about calling chown on a (partially) >> > user c

Re: [ovs-dev] [RFC PATCH 1/1] netdev-dpdk: vHost client mode and reconnect

2016-07-12 Thread Aaron Conole
Ciara Loftus writes: > A new other_config DB option has been added called 'vhost_driver_mode'. > By default this is set to 'server' which is the mode of operation OVS > with DPDK has used up until this point - whereby OVS creates and manages > vHost user sockets. > > If set to 'client', OVS will

Re: [ovs-dev] Backport Request for 2.5.0

2016-07-14 Thread Aaron Conole
Ben Pfaff writes: > On Tue, Jul 05, 2016 at 11:39:06AM -0400, Aaron Conole wrote: >> Hello, >> >> I'd like to request for the following 5 commits to be backported to >> 2.5.0, if it's appropriate: >> >> 314ce6479a8380e2aeaa

[ovs-dev] [BUG] netdev-dpdk deadlock in dpdk_watchdog

2016-07-19 Thread Aaron Conole
I haven't fully had a chance to investigate this, but it seems there's a possible deadlock with the dpdk netdev - specifically vhostuser class. I've seen it intermittently with 2.4, 2.5, and now master. It's quite rare to reproduce. Below is a sample stack trace. In it, notice that thread 12 (dp

Re: [ovs-dev] [ovs-discuss] ovs+dpdk hang?

2016-07-19 Thread Aaron Conole
Apologies for the top post, I believe I might be reproducing this or a similar failure, intermittently. See http://openvswitch.org/pipermail/dev/2016-July/075673.html Thanks, Aaron "Kavanagh, Mark B" writes: >> >>>Hi Mark, >>> >>>I observed the same issue using Ubuntu 16.04 server > with 4.4.0

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: Support user-defined socket attribs

2016-07-20 Thread Aaron Conole
rship, and 'vhost-sock-perms' to set the permissions bits for the vhost_user sockets. These settings apply to all vhost-user sockets. Signed-off-by: Aaron Conole --- INSTALL.DPDK.md | 7 +++ lib/netdev-dpdk.c| 37 ++--- vswit

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-07-20 Thread Aaron Conole
Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created, they inherit the per

[ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-07-20 Thread Aaron Conole
for chmod/chown on already opened files. There exist known implementations for other systems, including FreeBSD, but only linux is implemented. ENOTSUP is set when these calls fail on non-linux systems. Aaron Conole (3): chutil: introduce a new change-utils lib lib/chutil: Add chmod and

[ovs-dev] [PATCH v3 1/3] chutil: introduce a new change-utils lib

2016-07-20 Thread Aaron Conole
and fchown calls are implemented. Signed-off-by: Aaron Conole Acked-by: Ben Pfaff --- lib/automake.mk | 2 + lib/chutil-unix.c | 347 lib/chutil.h| 32 + lib/daemon-unix.c | 149 +- tests/automake.mk

[ovs-dev] [PATCH v3 2/3] lib/chutil: Add chmod and chown for opened files

2016-07-20 Thread Aaron Conole
implementation also resolves some unix domain sockets to their filenames. Signed-off-by: Aaron Conole --- lib/chutil-unix.c | 108 lib/chutil.h| 4 ++ tests/test-chutil.c | 6 +++ 3 files changed, 118 insertions(+) diff --git a/lib

[ovs-dev] [PATCH 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-20 Thread Aaron Conole
will start the ovs-vswitchd service as well. A future commit will clean this up, and change the ifup configuration in the process. Signed-off-by: Aaron Conole Acked-by: Flavio Leitner --- rhel/automake.mk | 2 +- rhel/etc_sysconfig_network-scripts_ifdown

[ovs-dev] [PATCH 0/3] redhat: Improve the systemd integration

2016-07-20 Thread Aaron Conole
Fedora 23 and RHEL-7. Aaron Conole (3): utilities/ovs-ctl.in: Allow non-monitoring daemons rhel/ovsdb-server.service: Rename the nonetwork service Red Hat Systemd Integration rhel/automake.mk | 3 ++- rhel/etc_sysconfig_network-scripts_ifdown-ovs

[ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-20 Thread Aaron Conole
This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole Acked-by: Ben Pfaff Acked-by: Flavio Leitner --- utilities/ovs-ctl.8 | 5

[ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-07-20 Thread Aaron Conole
daemons. Signed-off-by: Aaron Conole --- rhel/automake.mk | 1 + rhel/etc_sysconfig_network-scripts_ifup-ovs | 6 +++--- rhel/openvswitch-fedora.spec.in | 3 ++- rhel/usr_lib_systemd_system_openvswitch.service | 6 -- rhel

Re: [ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-07-21 Thread Aaron Conole
Markos Chandras writes: > Hi Aaron, > > On 07/20/2016 10:21 PM, Aaron Conole wrote: >> This commit builds upon some of the recent ovs-ctl changes to build a >> more integrated systemd setup. A new service (ovs-vswitchd) is >> added to track the ovs-vswitchd, and ovsdb

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-21 Thread Aaron Conole
Hi Ben, Ben Pfaff writes: > This document has two different kinds of text: > >- The first sections of the document, "Release Strategy" and "Release > Numbering", describe what we've already been doing for most of the > history of Open vSwitch. If there is anything surprising in th

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-24 Thread Aaron Conole
Hi Daniele, Daniele Di Proietto writes: > Thanks for the patch. > > I have another concern with this. If we're still going to rely on RCU to > protect the vhost device (and as pointed out by Ilya, I think we should) we > need to use RCU-like semantics on the vid array index. I'm not sure a > bo

Re: [ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-25 Thread Aaron Conole
Flaviof writes: > On Wed, Jul 20, 2016 at 4:21 PM, Aaron Conole wrote: > > This commit allows the ovs-ctl command to spawn daemons without the > internal process monitor. This is useful when integrating with, > ex. systemd, which provides its own monitoring facilities. >

[ovs-dev] [PATCH v2 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-25 Thread Aaron Conole
This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras Acked-by: Ben Pfaff Acked-by: Flavio

[ovs-dev] [PATCH v2 0/3] redhat: Improve the systemd integration

2016-07-25 Thread Aaron Conole
Fedora 23 and RHEL-7. v2: * Cleanup ovs-lib.in to be consistent with other tests for Xno * Cleanup cleanup the rhel ovsdb-server service to not reference the vswitchd Aaron Conole (3): utilities/ovs-ctl.in: Allow non-monitoring daemons rhel/ovsdb-server.service: Rename the nonetwork ser

[ovs-dev] [PATCH v2 3/3] rhel: Improved Systemd Integration

2016-07-25 Thread Aaron Conole
daemons. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras --- v2: * Removed reference to ovs-vswitchd service from ovsdb-server service rhel/automake.mk | 1 + rhel/etc_sysconfig_network-scripts_ifup-ovs | 6 +++--- rhel/openvswitch

[ovs-dev] [PATCH v2 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-25 Thread Aaron Conole
will start the ovs-vswitchd service as well. A future commit will clean this up, and change the ifup configuration in the process. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras Acked-by: Flavio Leitner --- v2: * No change (added tags, only) rhel/automake.mk

Re: [ovs-dev] [PATCH] rhel: Add support for DPDK Bond

2016-07-26 Thread Aaron Conole
ort", if is a DPDK ring port (name must >start with dpdkr and end with portid, eg "dpdkr0") > > * "OVSDPDKVhostPort" if is a DPDK vhost-cuse port > > * "OVSDPDKVhostUserPort" if is a DPDK vhost-user port > > +* "OVSDP

Re: [ovs-dev] [PATCH v2 0/3] redhat: Improve the systemd integration

2016-08-01 Thread Aaron Conole
Aaron Conole writes: > These patches make adjustments to the way systemd is done so that we have: > > * one daemon started per service > * services which correspond to actual daemon names > * a single 'dummy' service to start all at once > * some convenient info

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-01 Thread Aaron Conole
Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created, they inherit the per

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

2016-08-10 Thread Aaron Conole
y, >> Sean K >> Sent: Wednesday, July 20, 2016 2:37 PM >> To: Aaron Conole >> Cc: dev@openvswitch.org; Flavio Leitner >> Subject: Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory >> in ovsdb >> >> Hi sorry for the delay >> Replie

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add DPDK pdump capability

2016-08-10 Thread Aaron Conole
Ciara Loftus writes: > This commit provides the ability to 'listen' on DPDK ports and save > packets to a pcap file with a DPDK app that uses the librte_pdump > library. One such app is the 'pdump' app that can be found in the DPDK > 'app' directory. Instructions on how to use this can be found i

Re: [ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-08-10 Thread Aaron Conole
Russell Bryant writes: > On Fri, Jul 22, 2016 at 10:40 AM, Flavio Leitner wrote: > > On Thu, Jul 21, 2016 at 10:18:51AM -0400, Aaron Conole wrote: > > Markos Chandras writes: > > > > > Hi Aaron, > > > > > > On 07/20/2016 10:21 PM, Aaron Co

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-11 Thread Aaron Conole
Thanks so much for the review, Ben! Wall of text follows (apologies), so I suggest having your breakfast first :) Ben Pfaff writes: > On Mon, Aug 01, 2016 at 08:24:40AM -0400, Aaron Conole wrote: >> Aaron Conole writes: >> >> > Currently, when using Open vSwitch w

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-11 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Aug 11, 2016 at 11:33:59AM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Mon, Aug 01, 2016 at 08:24:40AM -0400, Aaron Conole wrote: >> >> Aaron Conole writes: >> >> >> >> > Cu

[ovs-dev] [PATCH v2 0/3] ovs-tcpdump: A utility for convenient port mirroring

2016-06-08 Thread Aaron Conole
similar utility to monitor the mirror. The `ovs-tcpdump` utility is also added to the fedora and debian distribution packages. Aaron Conole (3): ovs-tcpdump: Add a tcpdump wrapper utility fedora: Add pcap, tcpdump and tcpundump utilities to test debian: Add the tcpdump utility to the debian

[ovs-dev] [PATCH v2 2/3] fedora: Add pcap, tcpdump and tcpundump utilities to test

2016-06-08 Thread Aaron Conole
The openvswitch-test package is setup for enabling / performing tests for openvswitch setups. Adding these utilities would enable a richer set of debugging utilities for performing diagnostics. Signed-off-by: Aaron Conole --- v1->v2: * Introduced rhel/openvswitch-fedora.spec.in |

[ovs-dev] [PATCH v2 3/3] debian: Add the tcpdump utility to the debian package

2016-06-08 Thread Aaron Conole
Add ovs-tcpdump to the debian build. Signed-off-by: Aaron Conole --- * Introduced debian/openvswitch-switch.install | 1 + debian/openvswitch-switch.manpages | 1 + 2 files changed, 2 insertions(+) diff --git a/debian/openvswitch-switch.install b/debian/openvswitch-switch.install index

[ovs-dev] [PATCH v2 1/3] ovs-tcpdump: Add a tcpdump wrapper utility

2016-06-08 Thread Aaron Conole
on the mirror port (allowing the user to specify additional arguments), and dump data to the screen (or otherwise). Signed-off-by: Aaron Conole --- v1->v2: * Added .gitignore entries * Fixed a manpages distribution error NEWS | 2 + manpages.mk|

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix flake8 errors.

2016-06-10 Thread Aaron Conole
Russell Bryant writes: > On Thu, Jun 9, 2016 at 4:55 PM, Ben Pfaff wrote: > >> On Thu, Jun 09, 2016 at 09:22:10PM +0100, Russell Bryant wrote: >> > A previous commit added this file to be checked by flake8, but the file >> > failed a number of checks done by the 'hacking' flake8 plugin. >> > >>

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-10 Thread Aaron Conole
Aaron Conole writes: > Christian Ehrhardt writes: > >> On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: >> >>> Daniele Di Proietto writes: >>> >>> > Hi Aaron, >>> > >>> > I'm still a little bit nervous about ca

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-10 Thread Aaron Conole
Ansis Atteka writes: > On 10 June 2016 at 10:51, Aaron Conole wrote: > > > Aaron Conole writes: > > > Christian Ehrhardt writes: > > > >> On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: > >> > >>> Daniele Di Proietto writes

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-13 Thread Aaron Conole
Daniele Di Proietto writes: > On 10/06/2016 10:51, "Aaron Conole" wrote: > >>Aaron Conole writes: >> >>> Christian Ehrhardt writes: >>> >>>> On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: >>>> >>>>> Da

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-15 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Jun 13, 2016 at 05:36:34PM -0400, Aaron Conole wrote: >> > If these limitations are unacceptable, I can see how we can use >> > chmod. After all, as you point out, it's probably better to do it >> > in OVS than in some script. &

Re: [ovs-dev] [PATCH] netlink-notifier: change message to a less scary one

2016-06-17 Thread Aaron Conole
> message > contained "unexpected contents" will avoid some interpretation that there may > be > some netlink message corruption. > > Signed-off-by: Thadeu Lima de Souza Cascardo > Cc: Aaron Conole > --- > lib/netlink-notifier.c | 2 +- > 1 file chang

Re: [ovs-dev] [PATCH v2 0/3] ovs-tcpdump: A utility for convenient port mirroring

2016-06-23 Thread Aaron Conole
Ping. I'll gladly trade some review time for this :-D Just point me to the patches. Aaron Conole writes: > Open vSwitch ships with a mirroring facility. However, this facility can > sometimes be cumbersome to setup. To make this easier for end users, this > patch series introd

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix using uninitialized link_status.

2016-06-24 Thread Aaron Conole
nk Up - speed 1 Mbps - full-duplex > > Fix that by calling 'check_link_status()' only for physical ports. > > Signed-off-by: Ilya Maximets > --- LGTM Acked-by: Aaron Conole ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] rhel: Fix RHEL package build breakage

2016-06-24 Thread Aaron Conole
Ansis Atteka writes: > This patch fixes following error: > > error: Installed (but unpackaged) file(s) found: >/usr/bin/ovs-tcpdump >/usr/share/man/man8/ovs-tcpdump.8.gz > > Signed-off-by: Ansis Atteka > --- You have my ACK as well. Sorry. __

[ovs-dev] [PATCH 0/2] Misc. fixes to ovs-tcpdump

2016-07-01 Thread Aaron Conole
From: Aaron Conole The ovs-tcpdump framework has a few minor issues related to edge cases, such as dpdk bonds, and some tcpdump / tshark command line options. These changes are some minor fixups for these cases. This was tested with DPDK ports, non-dpdk ports, and by torturing the dump-cmd to

[ovs-dev] [PATCH 1/2] utilities/ovs-tcpdump.in: Fix port lookups

2016-07-01 Thread Aaron Conole
From: Aaron Conole The original implementation of ovs-tcpdump conflated interfaces and ports needlessly. This commit changes ovs-tcpdump to only consider the port name when looking up the corresponding bridge. Reported-by: Jean-Tsung Hsiao Tested-by: Jean-Tsung Hsiao Signed-off-by: Aaron

[ovs-dev] [PATCH 2/2] utilities/ovs-tcpdump.in: Poll the process status

2016-07-01 Thread Aaron Conole
From: Aaron Conole Some options (such as -c X), when passed to tcpdump will cause it to halt. When this occurs, ovs-tcpdump will not recognize that such an event has happened, and will spew newlines across the screen running forever. To fix this, ovs-tcpdump can poll and then raise a

  1   2   3   4   >