"Traynor, Kevin" <kevin.tray...@intel.com> writes: >> -----Original Message----- >> From: Traynor, Kevin >> Sent: Tuesday, May 10, 2016 2:41 PM >> To: dev@openvswitch.org >> Cc: Traynor, Kevin <kevin.tray...@intel.com>; Aaron Conole >> <acon...@redhat.com> >> Subject: [PATCH v2 1/2] netdev-dpdk: Fix coremask logic. >> >> Only set the thread affinity back to the pre rte_eal_init() value >> when the user has not specified a coremask. > > Hi Aaron - Do these patches look ok to you? I noticed while running > that the dpdk-lcore-mask was not having an effect due to a typo that > crept in late on.
Whoops, sorry - thought I had responded, but looks like I didn't. Yes, this and 2/2 look good to me. They both have my Ack. Apologies for the time. > Thanks, > Kevin. > >> >> Fixes: 88964e6428dc("netdev-dpdk: Autofill lcore coremask if >> absent") >> CC: Aaron Conole <acon...@redhat.com> >> Signed-off-by: Kevin Traynor <kevin.tray...@intel.com> >> --- >> lib/netdev-dpdk.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >> index af86d19..79fcd1a 100644 >> --- a/lib/netdev-dpdk.c >> +++ b/lib/netdev-dpdk.c >> @@ -3188,7 +3188,7 @@ dpdk_init__(const struct smap >> *ovs_other_config) >> } >> >> /* Set the main thread affinity back to pre rte_eal_init() >> value */ >> - if (!auto_determine) { >> + if (auto_determine) { >> err = pthread_setaffinity_np(pthread_self(), >> sizeof(cpu_set_t), >> &cpuset); >> if (err) { >> -- >> 1.7.4.1 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev