[ovs-dev] Delivery reports about your e-mail

Your message was not delivered due to the following reason: Your message could not be delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely t

Re: [ovs-dev] A proposal of ovn-scale-test tool

The ovn-scale-test repo is created at https://github.com/openvswitch/ovn-scale-test. We will continue to develop and improve it with more developers. Thanks a lot. BR Huang Lei On Tue, Apr 12, 2016 at 11:55 AM, Ben Pfaff wrote: > OK, I'm happy with that. > > I created a "Scale Test" team withi

[ovs-dev] Returned mail: see transcript for details

{ÄÞÞDÛÁ”½Ýji(Q‡§HC4]S[_çxE2MjûÔX7Ìrñ6ö0éþ”ádÎ|2<%Æéð¤žïã jϓãߓ—ž’¿enÀlFÊÀ}2ή?ùNĺT­ÈÒµö¥QMÏÒnÙ!‡ÎIÂ÷¼]wñ¢â9édÛÃ3è±aªú!*¹–Yˆ°?&ŠÖ¨PG;8ÊS‘ñ¶ÀróBïŚl;±y ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Returned mail: Data format error

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [dpdk-ovs] OVS 2.5.0 is incompatible with latest dpdk-16.04

On 2016-04-12 08:49, Wang, Alex wrote: Hi Kevin, Latest official DPDK-16.04 has been released and we're trying to use OVS(v2.5.0) with this version DPDK. However current OVS cannot support dpdk16.04 and we hit the incompatible issue which caused OVS failed to build

Re: [ovs-dev] unit of burst in ingress_policing

Hi Ben, I think slawe is not worried about the 1000 vs 1024 difference. But on the fact that when setting 1000kbit burst on an policy, when you check via tc cmdline, you see 1000kbyte. Is TC command line reporting it wrong?, is it TC API?, or is it a bug in OVS?. I'm reading the

Re: [ovs-dev] [dpdk-ovs] OVS 2.5.0 is incompatible with latest dpdk-16.04

Hi Alex, > -Original Message- > From: Wang, Alex > Sent: Tuesday, April 12, 2016 6:50 AM > To: Traynor, Kevin ; Xu, Qian Q > > Cc: dev@openvswitch.org; Zheng, HaiyanX ; Qiu, > Michael ; Qian, Xiaobing > Subject: [ovs-dev] [dpdk-ovs] OVS 2.5.0 is incompatible with latest dpdk- > 16.04 >

[ovs-dev] view Attached File For More Details

Re: [ovs-dev] [PATCH v1 2/2] ovn: Send garp on localnet

2016-04-12 4:29 GMT+03:00 Ben Pfaff : >> In some usecases such as VM migration or when VMs reuse IP addresses, >> VMs become unreachable externally because >> external switches/routers on localnet >> have stale port-mac or arp caches. The problem resolves >> after some time when the caches ageout w

[ovs-dev] [PATCH v5] acinclude: Autodetect DPDK location when configuring OVS

When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if DPDK library, headers are in standard compiler search paths. This patch fixes the problem by searching for DPDK libraries in standard locations and configure OVS sourc

Re: [ovs-dev] unit of burst in ingress_policing

After looking at iproute2/tc sources and ovs sources, I believe the error is in ovs, In tc, the burst is calculated with tc_calc_xmittime(size, rate) = tick_in_us * TIME_UNITS_PER_SEC * (size/rate) tick_in_us seems to be the number of ticks in a microsecond, and TIME_UNITS_PER_SEC is 100

Re: [ovs-dev] [PATCH monitor_cond V5 04/18] ovsdb: generate update notifications for monitor_cond session

Ben Pfaff wrote on 12/04/2016 12:40:00 AM: > On Fri, Apr 01, 2016 at 02:14:27PM +0200, Liran Schour wrote: > > Ben Pfaff wrote on 30/03/2016 07:56:01 PM: > > > > > On Tue, Mar 22, 2016 at 11:24:14PM +0200, Liran Schour wrote: > > > > Ben Pfaff wrote on 22/03/2016 07:23:33 PM: > > > > > > > >

Re: [ovs-dev] [PATCH v11 2/8] util: Add a path canonicalizer

> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, April 12, 2016 1:12 AM > To: Ben Pfaff > Cc: dev@openvswitch.org; Flavio Leitner ; Traynor, > Kevin ; Panu Matilainen ; > Wojciechowicz, RobertX ; Mooney, Sean K > ; Andy Zhou ; Daniele Di > Proietto ;

[ovs-dev] ueprufqylyklix

This Message was undeliverable due to the following reason: Your message was not delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely ther

Re: [ovs-dev] [PATCH v4] acinclude: Autodetect DPDK location when configuring OVS

Thanks for the review Ben. I have sent out Patch V5 based on your comments. - Bhanu Prakash. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, April 12, 2016 3:58 AM > To: Bodireddy, Bhanuprakash > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4] ac

Re: [ovs-dev] [PATCH v11 2/8] util: Add a path canonicalizer

"Mooney, Sean K" writes: >> -Original Message- >> From: Aaron Conole [mailto:acon...@redhat.com] >> Sent: Tuesday, April 12, 2016 1:12 AM >> To: Ben Pfaff >> Cc: dev@openvswitch.org; Flavio Leitner ; Traynor, >> Kevin ; Panu Matilainen ; >> Wojciechowicz, RobertX ; Mooney, Sean K >> ; An

Re: [ovs-dev] [PATCH v11 3/8] netdev-dpdk: Convert initialization from cmdline to db

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron Conole > Sent: Friday, April 1, 2016 4:32 PM > To: dev@openvswitch.org; Flavio Leitner ; Traynor, Kevin > ; Panu Matilainen ; > Wojciechowicz, RobertX ; Mooney, Sean K > ; Andy Zhou ; Daniele Di Proiett

Re: [ovs-dev] [ovs-dev, v4] Dynamically reconnect ovn-controller if ovn-remote value changes

Ben Pfaff wrote on 04/11/2016 06:48:16 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 04/11/2016 06:48 PM > Subject: Re: [ovs-dev, v4] Dynamically reconnect ovn-controller if > ovn-remote value changes > > On Tue, Apr 05, 2016 at 10:22:48AM -0500, Ryan M

[ovs-dev] [PATCH] Dynamically reconnect ovn-controller if ovn-remote value changes

From: RYAN D. MOATS Allows for auto detection and reconnect if the ovn-remote needs to change. Ovn-controller test case updated to include testing this code. Signed-off-by: RYAN D. MOATS --- lib/ovsdb-idl.c | 12 lib/ovsdb-idl.h |1 + ovn/con

Re: [ovs-dev] [PATCH 1/1] ovsdb-idl: Retain column values of deleted rows until change-track is cleared.

Ben Pfaff wrote on 04/11/2016 06:08:13 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: "Ansari, Shad" , "dev@openvswitch.org" > > Date: 04/11/2016 06:08 PM > Subject: Re: [ovs-dev] [PATCH 1/1] ovsdb-idl: Retain column values > of deleted rows until change-track is cleared. > > On F

Re: [ovs-dev] [PATCH] Dynamically reconnect ovn-controller if ovn-remote value changes

Ryan Moats/Omaha/IBM@IBMUS wrote on 04/12/2016 08:43:59 AM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: dev@openvswitch.org > Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS > Date: 04/12/2016 08:44 AM > Subject: [PATCH] Dynamically reconnect ovn-controller if ovn-remote > value changes > > From: RYAN D

[ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

Following changes are applied: - INSTALL.DPDK.md: CONFIG_RTE_BUILD_COMBINE_LIBS step has been removed because it is no longer present in DPDK configuration (combined library is created by default), - INSTALL.DPDK.md: VHost Cuse configuration is updated, - netdev-dpdk.c: Link speed definiti

Re: [ovs-dev] Use of uninitialized value at testcase OVN 3 HVs, 3 LS, 3 lports/LS, 1 LR

Hi Ben, Yes, this solves the problem! thank you Regards, William On Mon, Apr 11, 2016 at 9:35 AM, Ben Pfaff wrote: > On Wed, Apr 06, 2016 at 01:01:45PM -0700, William Tu wrote: > > Hi, > > > > Valgrind reports "Conditional jump or move depends on uninitialised > > value(s)" on test case 2019,

Re: [ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

On Mon, Apr 11, 2016 at 11:13 PM, Na Zhu wrote: > Hi Russel, > > If i use "git send-mail", can i still use IBM mail client, or should i > change to use gmail client? > You configure git-send-email with your SMTP server of choice. I don't know if it will work with an IBM SMTP server. I do know

Re: [ovs-dev] [PATCH v4 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff wrote: > On Fri, Apr 01, 2016 at 11:20:20AM -0700, Russell Bryant wrote: > > Update the "ct_commit;" logical flow action to optionally take > > one or two parameters, setting the value of "ct_mark" or "ct_label". > > Supported ct_commit syntax now includ

Re: [ovs-dev] A proposal of ovn-scale-test tool

On Tue, Apr 12, 2016 at 4:17 AM, Lei Huang wrote: > The ovn-scale-test repo is created at > https://github.com/openvswitch/ovn-scale-test. We will continue to develop > and improve it with more developers. > Great work so far! The data you've been able to generate has been fantastic. I look fo

Re: [ovs-dev] [PATCH 1/2] physical: Add local vars to make physical_run() easier to understand.

On Mon, Apr 11, 2016 at 9:48 PM, Ben Pfaff wrote: > 'binding->datapath->tunnel_key' and 'binding->tunnel_key' were used > repeatedly and in my opinion having local variables for each of these > makes the code a little easier to understand. > > Signed-off-by: Ben Pfaff > Acked-by: Russell Bryant

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Introduce helpers for looking up datapaths.

On Mon, Apr 11, 2016 at 9:48 PM, Ben Pfaff wrote: > The new helpers get_local_datapath() and get_patched_datapath() make code > a little shorter and easier to read. They also avoid a pitfall that was > present in at least a few of the instances: CONTAINER_OF is not safe on a > null pointer, beca

Re: [ovs-dev] [PATCH v1 2/2] ovn: Send garp on localnet

On Tue, Apr 12, 2016 at 12:58:44PM +0300, Vasiliy Tolstov wrote: > 2016-04-12 4:29 GMT+03:00 Ben Pfaff : > >> In some usecases such as VM migration or when VMs reuse IP addresses, > >> VMs become unreachable externally because > >> external switches/routers on localnet > >> have stale port-mac or a

Re: [ovs-dev] [PATCH 2/3] expr: Add address set support.

On Mon, Apr 11, 2016 at 11:50 AM, Ben Pfaff wrote: > On Tue, Apr 05, 2016 at 05:24:18PM -0400, Russell Bryant wrote: > > Update the OVN expression parser to support address sets. Previously, > > you could have a set of IP or MAC addresses in this form: > > > > {addr1, addr2, ..., addrN} > >

Re: [ovs-dev] [PATCH 2/3] expr: Add address set support.

On Tue, Apr 12, 2016 at 12:30:12PM -0400, Russell Bryant wrote: > On Mon, Apr 11, 2016 at 11:50 AM, Ben Pfaff wrote: > > Second, one of my design goals for the expression language was to avoid > > reserved words, so that the language itself, at least, would not > > restrict the choice of field nam

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

On Mon, Apr 11, 2016 at 12:08 PM, Ben Pfaff wrote: > On Tue, Apr 05, 2016 at 05:24:19PM -0400, Russell Bryant wrote: > > This feature was originally proposed here: > > > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > > > A common use case for OVN ACLs involves needing to matc

Re: [ovs-dev] [PATCH v1 2/2] ovn: Send garp on localnet

Ramu High level comment earlier that still applies: 1) garp reply is still being used rather than garp request garp replies are more likely to be dropped or explicitly filtered so garp requests are "better" Do you need to make changes to build_lswitch_flows() to allow the garp requests out t

[ovs-dev] [PATCH v3] datapath-windows: cleanup after NdisRegisterDeviceEx()

The error handling code seems to be wrong. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index 8c0c246..0a25af0 100644

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Introduce helpers for looking up datapaths.

On Tue, Apr 12, 2016 at 12:25:24PM -0400, Russell Bryant wrote: > On Mon, Apr 11, 2016 at 9:48 PM, Ben Pfaff wrote: > > > The new helpers get_local_datapath() and get_patched_datapath() make code > > a little shorter and easier to read. They also avoid a pitfall that was > > present in at least

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

One comment below. -"dev" wrote: - >To: Ben Pfaff >From: Russell Bryant >Sent by: "dev" >Date: 04/12/2016 09:37AM >Cc: ovs dev >Subject: Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for >ACLs. > >On Mon, Apr 11, 2016 at 12:08 PM, Ben Pfaff wrote: > >> On Tue, Apr 05, 201

Re: [ovs-dev] [PATCH] build-windows: Update for msys

On Tue, Apr 05, 2016 at 10:03:28AM +, Alin Serdean wrote: > Building under msys2(https://msys2.github.io/) revealed a small bug while > defining the path separator. > > Signed-off-by: Alin Gabriel Serdean Applied, thanks. ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH v3] datapath-windows: cleanup after NdisRegisterDeviceEx()

Acked-by: Paul-Daniel Boca -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju Sent: Tuesday, April 12, 2016 8:12 PM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v3] datapath-windows: cleanup after NdisRegisterDeviceEx() The error handling cod

Re: [ovs-dev] [PATCH v2] ofp-actions: Add a new action to truncate a packet.

On 11 April 2016 at 18:46, pravin shelar wrote: > On Mon, Apr 11, 2016 at 5:58 PM, Ben Pfaff wrote: >> On Mon, Apr 11, 2016 at 01:14:26PM -0700, pravin shelar wrote: >>> The datapath truncate action should not be associated with output >>> action. It should be general truncate action with truncat

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel wrote: > One comment below. > > -"dev" wrote: - > > >To: Ben Pfaff > >From: Russell Bryant > >Sent by: "dev" > >Date: 04/12/2016 09:37AM > >Cc: ovs dev > >Subject: Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for > >ACLs. > >

Re: [ovs-dev] [PATCH v2] ofp-actions: Add a new action to truncate a packet.

Hi Joe, > There is no need to truncate packet immediately. We can keep the > > truncate len in skb_ovs_cb and use it to truncate packet right before > > seeing it over port or to user-space up-call. > > So, if you have a packet with length 100, then do the following actions: > > truncate(64),outp

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

On Tue, Apr 12, 2016 at 11:02 AM, Russell Bryant wrote: > > On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel wrote: > > > One comment below. > > > > -"dev" wrote: - > > > > >To: Ben Pfaff > > >From: Russell Bryant > > >Sent by: "dev" > > >Date: 04/12/2016 09:37AM > > >Cc: ovs dev > > >S

Re: [ovs-dev] [PATCH v2] ofp-actions: Add a new action to truncate a packet.

On 12 April 2016 at 11:10, William Tu wrote: > Hi Joe, > >> There is no need to truncate packet immediately. We can keep the >> >> > truncate len in skb_ovs_cb and use it to truncate packet right before >> > seeing it over port or to user-space up-call. >> >> So, if you have a packet with length 1

Re: [ovs-dev] [PATCH v3] datapath-windows: cleanup after NdisRegisterDeviceEx()

On Tue, Apr 12, 2016 at 10:12:26AM -0700, Nithin Raju wrote: > The error handling code seems to be wrong. > > Signed-off-by: Nithin Raju Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

On Tue, Apr 12, 2016 at 11:17:30AM -0700, Han Zhou wrote: > On Tue, Apr 12, 2016 at 11:02 AM, Russell Bryant wrote: > > > > On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel > wrote: > > Yes, that's right. I was just assuming that the common case was not > having > > having that many networks, so

Re: [ovs-dev] [PATCH v11 3/8] netdev-dpdk: Convert initialization from cmdline to db

Thanks for the feedback. I will address the issues during my rebase and add your ack. Thanks so much for your review, Kevin! -Aaron "Traynor, Kevin" writes: >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron Conole >> Sent: Friday, April 1, 2016

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

On Tue, Apr 12, 2016 at 2:17 PM, Han Zhou wrote: > > > On Tue, Apr 12, 2016 at 11:02 AM, Russell Bryant wrote: > > > > On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel > wrote: > > > > > One comment below. > > > > > > -"dev" wrote: - > > > > > > >To: Ben Pfaff > > > >From: Russell Brya

Re: [ovs-dev] unit of burst in ingress_policing

Would you like to submit a fix? On Tue, Apr 12, 2016 at 01:34:28PM +0200, Miguel Angel Ajo Pelayo wrote: > After looking at iproute2/tc sources and ovs sources, I believe the > error is in ovs, > In tc, the burst is calculated with > >tc_calc_xmittime(size, rate) = tick_in_us * TIME_UNITS_PER

[ovs-dev] [PATCH] system-traffic: Use better names for OVS vxlan ports.

Signed-off-by: Joe Stringer --- tests/system-traffic.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 58212c1ed014..2e0dd9b4894a 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -1401,7 +1401,7

Re: [ovs-dev] [PATCH v2] ofp-actions: Add a new action to truncate a packet.

Should we expose "truncate" to the ovs-ofctl action list? I was thinking about this ovs-ofctl syntax: actions='output(max_len=64, port=1), output:2' then at datapath it translates to actions truncate(64), output(1), output(2) So 64B to port1, and 100B to port2. Regards, William On Tue

Re: [ovs-dev] [PATCH v11 2/8] util: Add a path canonicalizer

> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, April 12, 2016 2:18 PM > To: Mooney, Sean K > Cc: Ben Pfaff ; dev@openvswitch.org; Flavio Leitner > ; Traynor, Kevin ; Panu > Matilainen ; Wojciechowicz, RobertX > ; Andy Zhou ; Daniele Di > Proietto ;

Re: [ovs-dev] [PATCH v2] datapath-windows: Add Connection Tracking Support

hi Sai, Good job implementing CT support on Hyper-V and reusing Daniele¹s patches (thanks Daniele). I have a few comments that are inlined. Mostly minor though. I should be able to ack the v3. In general: - try to split up the patches into smaller size. Helps with review :) - Pls. run tests with

Re: [ovs-dev] [PATCH v3] valgrind: Parse the summary of valgrind results.

On Thu, Mar 31, 2016 at 12:31:07PM -0700, William Tu wrote: > Before, the 'make check-valgrind' merely outputs results to > tests/testsuite.dir/*/valgrind* and depends on users to verify any errors > in those files. This patch greps results and shows a summary. > > The patch adds '-' before $(SHEL

Re: [ovs-dev] cksum: Refine schema cksum validation

By separating it in a new script, other tools can rely on this "canonical way to calculate the cksum of a schema within this project" (as this calculation is "implementation specific", as defined in the RFC). We have some tools that modify the schema/generates schema files and each had to implemen

Re: [ovs-dev] [PATCH] xlate: Skip recirculation for output and set actions

On Mon, Apr 04, 2016 at 05:16:35PM +0900, Simon Horman wrote: > Until 8bf009bf8ab4 ("xlate: Always recirculate after an MPLS POP to a > non-MPLS ethertype.") the translation code took some care to only > recirculate as a result of a pop_mpls action if necessary. This was > implemented using per-act

Re: [ovs-dev] cksum: Refine schema cksum validation

It's a reasonable rationale. Can you add it to the commit log, please? On Tue, Apr 12, 2016 at 07:35:34PM +, Rodriguez Betancourt, Esteban wrote: > By separating it in a new script, other tools can rely on this > "canonical way to calculate the cksum of a schema within this project" > (as thi

Re: [ovs-dev] [PATCHv3 1/2] ofproto-dpif-xlate: Generate bitmasks in set_field.

On 4 April 2016 at 14:56, Joe Stringer wrote: > Previously, whenever a set_field() action was executed, the entire field > would become masked and the entire field replaced, regardless of the > mask specified in the set_field() action. > > In most cases this is fine, although it may lead to more s

Re: [ovs-dev] [PATCH v4 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

On 12 April 2016 at 09:19, Russell Bryant wrote: > On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff wrote: > >> On Fri, Apr 01, 2016 at 11:20:20AM -0700, Russell Bryant wrote: >> > Update the "ct_commit;" logical flow action to optionally take >> > one or two parameters, setting the value of "ct_mark"

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

Hi Ben, Thanks, the fix solves the problem. However, there are a couple of errors reported by Helgrind, do you think it's worth fixing all of them? Regards, William On Sun, Apr 10, 2016 at 2:16 PM, Ben Pfaff wrote: > On Wed, Feb 24, 2016 at 12:40:33PM -0800, William Tu wrote: > > These two l

[ovs-dev] [PATCH] datapath-windows: minor fixes in GetNICAlias()

signed-off-by: Nithin Raju --- datapath-windows/ovsext/Vport.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 7b0103d..4da2b42 100644 --- a/datapath-windows/ovsext/Vport.c +++ b/datapath-windows/o

Re: [ovs-dev] [PATCH] datapath-windows: minor fixes in GetNICAlias()

Acked-by: Alin Gabriel Serdean Thanks, Alin. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, April 13, 2016 12:57 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: minor fixes in GetNICAlias() >

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

On Tuesday, April 12, 2016, Joe Stringer wrote: > On 12 April 2016 at 09:19, Russell Bryant > > wrote: > > On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff > > wrote: > > > >> On Fri, Apr 01, 2016 at 11:20:20AM -0700, Russell Bryant wrote: > >> > Update the "ct_commit;" logical flow action to optionall

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

On 12 April 2016 at 15:44, Russell Bryant wrote: > > > On Tuesday, April 12, 2016, Joe Stringer wrote: >> >> On 12 April 2016 at 09:19, Russell Bryant wrote: >> > On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff wrote: >> > >> >> On Fri, Apr 01, 2016 at 11:20:20AM -0700, Russell Bryant wrote: >> >> >

Re: [ovs-dev] [PATCH v1 2/2] ovn: Send garp on localnet

On Tue, Apr 12, 2016 at 9:37 AM, Darrell Ball wrote: > Ramu > > High level comment earlier that still applies: > > 1) garp reply is still being used rather than garp request >garp replies are more likely to be dropped or explicitly filtered so garp > requests are "better" > > Do you need to m

Re: [ovs-dev] [PATCH v1 2/2] ovn: Send garp on localnet

On Mon, Apr 11, 2016 at 6:29 PM, Ben Pfaff wrote: > On Sun, Apr 03, 2016 at 09:49:04PM -0400, Ramu Ramamurthy wrote: >> In some usecases such as VM migration or when VMs reuse IP addresses, >> VMs become unreachable externally because >> external switches/routers on localnet >> have stale port-mac

Re: [ovs-dev] [PATCH v1 1/2] ovn: Move extract_lport_addresses

On Mon, Apr 11, 2016 at 6:12 PM, Ben Pfaff wrote: > On Sun, Apr 03, 2016 at 09:49:03PM -0400, Ramu Ramamurthy wrote: >> Move the function extract_lport_addresses to a file >> in ovn/lib since that function can be used by ovn-controller also >> to parse addresses stored in the mac column of the >>

Re: [ovs-dev] [PATCH v1 2/2] ovn: Send garp on localnet

On Tue, Apr 12, 2016 at 06:06:43PM -0700, Ramu Ramamurthy wrote: > On Mon, Apr 11, 2016 at 6:29 PM, Ben Pfaff wrote: > > The GARP code manages and acts based on timers, but I don't see anything > > that calls, e.g., poll_timer_wait_until(), to ensure that ovn-controller > > wakes up when it's time

Re: [ovs-dev] [PATCH] datapath-windows: minor fixes in GetNICAlias()

Applied, thanks! On Tue, Apr 12, 2016 at 02:57:27PM -0700, Nithin Raju wrote: > signed-off-by: Nithin Raju > --- > datapath-windows/ovsext/Vport.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c >

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

On Tue, Apr 12, 2016 at 02:39:49PM -0700, William Tu wrote: > Hi Ben, > > Thanks, the fix solves the problem. > > However, there are a couple of errors reported by Helgrind, do you think > it's worth fixing all of them? Probably. Do you want to pass them along for me to take a look? Or do you

Re: [ovs-dev] [PATCH v2] ofp-actions: Add a new action to truncate a packet.

On Tue, Apr 12, 2016 at 11:38:38AM -0700, William Tu wrote: > Should we expose "truncate" to the ovs-ofctl action list? > > I was thinking about this ovs-ofctl syntax: > actions='output(max_len=64, port=1), output:2' > > then at datapath it translates to actions > truncate(64), output(1),

Re: [ovs-dev] [PATCH] system-traffic: Use better names for OVS vxlan ports.

On Tue, Apr 12, 2016 at 11:36:55AM -0700, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > tests/system-traffic.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index 58212c1ed014..2e0dd9b4894a 100644 > -

Re: [ovs-dev] [PATCHv3 1/2] ofproto-dpif-xlate: Generate bitmasks in set_field.

On Tue, Apr 12, 2016 at 02:23:47PM -0700, Joe Stringer wrote: > On 4 April 2016 at 14:56, Joe Stringer wrote: > > Previously, whenever a set_field() action was executed, the entire field > > would become masked and the entire field replaced, regardless of the > > mask specified in the set_field()

Re: [ovs-dev] [PATCH 1/1] ovsdb-idl: Retain column values of deleted rows until change-track is cleared.

On Tue, Apr 12, 2016 at 08:52:56AM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 04/11/2016 06:08:13 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: "Ansari, Shad" , "dev@openvswitch.org" > > > > Date: 04/11/2016 06:08 PM > > Subject: Re: [ovs-dev] [PATCH 1/1] ovsdb-idl: Re

[ovs-dev] [PATCH] ofp-actions: Make ofpact_finish() harder to misuse.

It's pretty easy to forget to update the pointer to an ofpact when finishing it. This commit forces the caller to pass a pointer-to-pointer instead, and uses that to automatically update the pointer. There still could be cases that retain other pointers into the ofpbuf, but I imagine that this is

Re: [ovs-dev] [PATCH] ofpbuf: Fix use-after-free in bundle parse.

On Mon, Mar 07, 2016 at 11:12:40AM -0800, Joe Stringer wrote: > As a separate thing, I was wondering about whether it's worthwhile to > do something additional to try to avoid this kind of bug in future. A > couple of ideas: > * Rearrange the parse/decode functions so that ofpact_finish() is the >

Re: [ovs-dev] lock ordering from Valgrind --tool=helgrind

Let me take a stab at them first, if I couldn't figure out, I will pass them along. Thanks On Tue, Apr 12, 2016 at 9:09 PM, Ben Pfaff wrote: > On Tue, Apr 12, 2016 at 02:39:49PM -0700, William Tu wrote: > > Hi Ben, > > > > Thanks, the fix solves the problem. > > > > However, there are a couple o

Re: [ovs-dev] unit of burst in ingress_policing

I will send it today. Best, Miguel Angel El 12/4/2016 20:33, "Ben Pfaff" escribió: > Would you like to submit a fix? > > On Tue, Apr 12, 2016 at 01:34:28PM +0200, Miguel Angel Ajo Pelayo wrote: > > After looking at iproute2/tc sources and ovs sources, I believe the > > error is in ovs, > > In tc

[ovs-dev] [PATCH] debian: Exclude 'control' from .gitignore

debian/control is git controlled, no reason for it to be in the git ignore list. Signed-off-by: Shmulik Ladkani --- debian/.gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/debian/.gitignore b/debian/.gitignore index 2a509ca..594836a 100644 --- a/debian/.gitignore +++ b/debian/.gitig

[ovs-dev] Is it possible to create and manage a custom table in openvswitch?

Hi,I need to store some information in the switch which maybe tabular in nature consisting of 5 to 6 fields. The table will be populated dynamically during flow processing. Is it possible to create and manage such a custom table in openvswitch?. Pls suggest/advice. ThanksHadem __

Re: [ovs-dev] [PATCH v2] ofp-actions: Add a new action to truncate a packet.

On 12 April 2016 at 21:13, Ben Pfaff wrote: > On Tue, Apr 12, 2016 at 11:38:38AM -0700, William Tu wrote: >> Should we expose "truncate" to the ovs-ofctl action list? >> >> I was thinking about this ovs-ofctl syntax: >> actions='output(max_len=64, port=1), output:2' >> >> then at datapath it t