On Tue, Apr 12, 2016 at 06:06:43PM -0700, Ramu Ramamurthy wrote: > On Mon, Apr 11, 2016 at 6:29 PM, Ben Pfaff <b...@ovn.org> wrote: > > The GARP code manages and acts based on timers, but I don't see anything > > that calls, e.g., poll_timer_wait_until(), to ensure that ovn-controller > > wakes up when it's time to send a GARP. This call would ordinarily be > > made by adding another call to pinctrl_wait(). > > > The code assumes that pinctr_run() would be run often enough to not > need to fire timers. But this is not a correct assumption, as there > could be pauses between successive runs of pinctl_run(), causing > successive garps to be sent at arbitrary intervals. > An approach based on timers makes the fix deterministic. > I will look into this further in the next version.
I guess that the timers here don't have to be precise. It might be good enough to just call poll_timer_wait(1000); if there are any garps scheduled to be sent. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
