On 12 April 2016 at 15:44, Russell Bryant <russ...@ovn.org> wrote: > > > On Tuesday, April 12, 2016, Joe Stringer <j...@ovn.org> wrote: >> >> On 12 April 2016 at 09:19, Russell Bryant <russ...@ovn.org> wrote: >> > On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff <b...@ovn.org> wrote: >> > >> >> On Fri, Apr 01, 2016 at 11:20:20AM -0700, Russell Bryant wrote: >> >> > Update the "ct_commit;" logical flow action to optionally take >> >> > one or two parameters, setting the value of "ct_mark" or "ct_label". >> >> > Supported ct_commit syntax now includes: >> >> > >> >> > ct_commit; >> >> > ct_commit(); >> >> > ct_commit(ct_mark=1); >> >> > ct_commit(ct_label=1); >> >> > ct_commit(ct_mark=1, ct_label=1); >> >> >> >> I guess I must have reviewed this before but I have more comments now. >> > >> > >> > Thanks for the comments. They make sense. I will incorporate them into >> > the next revision. >> > >> > Justin also wanted me to add support for masking which bits get set. I >> > was >> > waiting on Joe to sort out some related issues before trying that, >> > though. >> >> FWIW there's one fix here: >> http://openvswitch.org/pipermail/dev/2016-April/069107.html >> >> And I'm sitting on another fix which depends on the above. > > > No rush from my side. I hope it didn't sound that way. This actually works > fine as is for now. I was just recounting my todo list for this code.
No problem, just thought I'd point out that if it /were/ blocking then it just needs some review to unblock. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
