Thanks for the feedback. I will address the issues during my rebase and add your ack.
Thanks so much for your review, Kevin! -Aaron "Traynor, Kevin" <kevin.tray...@intel.com> writes: >> -----Original Message----- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron Conole >> Sent: Friday, April 1, 2016 4:32 PM >> To: dev@openvswitch.org; Flavio Leitner <f...@sysclose.org>; Traynor, Kevin >> <kevin.tray...@intel.com>; Panu Matilainen <pmati...@redhat.com>; >> Wojciechowicz, RobertX <robertx.wojciechow...@intel.com>; Mooney, Sean K >> <sean.k.moo...@intel.com>; Andy Zhou <az...@ovn.org>; Daniele Di Proietto >> <diproiet...@vmware.com>; Zoltan Kiss <zoltan.k...@linaro.org>; Christian >> Ehrhardt <christian.ehrha...@canonical.com>; Ben Pfaff <b...@ovn.org> >> Subject: [ovs-dev] [PATCH v11 3/8] netdev-dpdk: Convert initialization from >> cmdline to db >> >> Existing DPDK integration is provided by use of command line options which >> must be split out and passed to librte in a special manner. However, this >> forces any configuration to be passed by way of a special DPDK flag, and >> interferes with ovs+dpdk packaging solutions. >> >> This commit delays dpdk initialization until after the OVS database >> connection is established, at which point ovs initializes librte. It >> pulls all of the config data from the OVS database, and assembles a >> new argv/argc pair to be passed along. >> >> Signed-off-by: Aaron Conole <acon...@redhat.com> >> --- > > hi Aaron, > > There's a few hunks in this patch that don't apply cleanly to master > anymore. It conflicts with the cleanup in d46285. > > > ----8<---------8<----- > >> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml >> index 7d6976f..c350247 100644 >> --- a/vswitchd/vswitch.xml >> +++ b/vswitchd/vswitch.xml >> @@ -171,11 +171,63 @@ >> </p> >> </column> >> >> + <column name="other_config" key="n-dpdk-rxqs" >> + type='{"type": "integer", "minInteger": 1}'> >> + <p> >> + Specifies the maximum number of rx queues to be created for each >> dpdk >> + interface. If not specified or specified to 0, one rx queue will >> + be created for each dpdk interface by default. >> + </p> >> + </column> > > This was removed from master - looks like it snuck back in through a rebase. > > I'll give it another review and quick test when it's rebased, but with > the issues > above addressed consider it to be acked. > > Acked-by: Kevin Traynor <kevin.tray...@intel.com> > <#secure method=pgpmime mode=encrypt> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
