Re: [ovs-dev] [PATCH v6 2/6] datapath-windows: Added recirculation support.

2016-03-24 Thread Sorin Vinturis
Hi Nithin, Thank you for reviewing this patch. Please see my answers inline. -Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 22 March, 2016 02:31 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6 2/6] datapath-windows: Adde

[ovs-dev] [CudaMailTagged] Addind Match to Match table

2016-03-24 Thread Amrane Ait Zeouay
Good morning everyone, I'm working on OpenvSwitch project, I want to add a vnf match to the match table but i didn't know how. 1- where is the source code of match table ? 2- can you explain to me how the match table is working ? 3- how can i call a function if there is a mat

Re: [ovs-dev] [PATCH v6 4/6] datapath-windows: Support for OVS_ACTION_ATTR_HASH attribute

2016-03-24 Thread Sorin Vinturis
Yes, the dpHash is only used for reporting purposes. -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 22 March, 2016 08:29 To: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6 4/6] datapath-windows: Support for OVS_ACTION_ATTR_HASH attrib

[ovs-dev] [PATCH] debian : upstream_version fix - resubmitted

2016-03-24 Thread Zoltán Balogh
Hi, The Debian Policy Manual (https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version) says that the upstream_version may contain only alphanumerics and the characters . + - : ~ (full stop, plus, hyphen, colon, tilde) and should start with a digit. Currently, the upstream_v

[ovs-dev] FW: Payment Receipt

2016-03-24 Thread Glen Baxter
Dear dev, Thank you for your payment. It is important that you print this receipt and record the receipt number as proof of your payment. You may be asked to provide your receipt details should you have an enquiry regarding this payment. Regards, Glen Baxter Managing Director - Property Advisor

Re: [ovs-dev] [RFC] lib/netdev-dpdk: add hotplug support

2016-03-24 Thread Mauricio Vásquez
Hi Aaron, First of all thank you very much for your feedback. I didn't pay that attention to the style, I'll correct all the issues when I send a proper patch, by the way, is there any script or tool to check the style?, I looked for it and I cannot find anything. On Wed, Mar 23, 2016 at 11:42 A

Re: [ovs-dev] [PATCH v2] rhel: Packaging for OVN is split as per functionality

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 2:07 AM, wrote: > rhel packaging for OVN is split to host(controller), central(northd), > common(command line utilities) and docker(docker network plugin). This is > similar to OVN packaging for Debian. > > Signed-off-by: Babu Shanmugam > This looks good to me. Flavio,

[ovs-dev] [PATCH] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

2016-03-24 Thread Ilya Maximets
According to QEMU documentation (docs/specs/vhost-user.txt) one queue should be enabled initially. More queues are enabled dynamically, by sending message VHOST_USER_SET_VRING_ENABLE. Currently all queues in OVS disabled by default. This breaks above specification. So, queue #0 should be enabled b

Re: [ovs-dev] vhost-user: port is dropping packets in transmission

2016-03-24 Thread Ilya Maximets
Try this patch: http://openvswitch.org/pipermail/dev/2016-March/068429.html Should work with older QEMU. Best regards, Ilya Maximets. On 23.03.2016 14:37, Federico Iezzi wrote: > Hello Ilya, > > When you have wrote the patch could you post it also here as well? > > Thanks! > Federico > > On We

[ovs-dev] Attached document(s)

2016-03-24 Thread Afifa Shohab
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/2] acinclude.m4: Allow building against a DPDK installation

2016-03-24 Thread Markos Chandras
It's possible for a system to not have the compiled DPDK sources around but it might have DPDK installed so use that instead if possible. Signed-off-by: Markos Chandras --- acinclude.m4 | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 in

[ovs-dev] [PATCH 2/2] INSTALL.DPDK: Update DPDK build instructions

2016-03-24 Thread Markos Chandras
The CONFIG_RTE_BUILD_COMBINE_LIBS has been removed in the DPDK commit 948fd64befc37 ("mk: replace the combined library with a linker script"). Moreover, add missing step for creating a configuration file prior to building the sources. Signed-off-by: Markos Chandras --- INSTALL.DPDK.md | 7 +++---

[ovs-dev] [PATCH 0/2] Minor DPDK fixes

2016-03-24 Thread Markos Chandras
Hi, This patchset contains a couple of minor DPDK fixes which I made whilst trying to build openvswitch against a DPDK installation on my system. The first patch allows using an installed DPDK instead of using the DPDK build directory. The other patch fixes the documentation a little bit by removi

Re: [ovs-dev] [PATCH] dpif-netdev: Remove PMD latency on seq_mutex

2016-03-24 Thread Flavio Leitner
On Thu, 24 Mar 2016 14:10:14 +0800 yewgang wrote: > So basically, you replace ovs_mutex_rwlock (or sth) into ovs_mutex_trylock > in the loop of "other tasks after some time processing the RX queues". > Is it ? It isn't replacing since the original locking remains the same. But yeah, it tries to

Re: [ovs-dev] [RFCv2] ovs-ctl: Allow selective start for db and switch

2016-03-24 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Mar 21, 2016 at 09:37:15AM -0400, Aaron Conole wrote: >> Currently, ``ovs-ctl start'' will attempt to start both the DB and >> vswitchd. This is quite convenient when the database already has all of >> the configuration values required, and when using a single services

Re: [ovs-dev] [PATCH v2] rhel: Packaging for OVN is split as per functionality

2016-03-24 Thread Flavio Leitner
On Thu, 24 Mar 2016 11:37:29 +0530 bscha...@redhat.com wrote: > rhel packaging for OVN is split to host(controller), central(northd), > common(command line utilities) and docker(docker network plugin). This is > similar to OVN packaging for Debian. I think this should update INSTALL.Fedora.md too

[ovs-dev] Document2

2016-03-24 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Document2

2016-03-24 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

2016-03-24 Thread Flavio Leitner
On Thu, 24 Mar 2016 14:55:15 +0300 Ilya Maximets wrote: > According to QEMU documentation (docs/specs/vhost-user.txt) one queue > should be enabled initially. More queues are enabled dynamically, by > sending message VHOST_USER_SET_VRING_ENABLE. > > Currently all queues in OVS disabled by defaul

[ovs-dev] [PATCH RFC] netdev-dpdk: Expand RSS hash calculation by MAC addresses

2016-03-24 Thread Robert Wojciechowicz
This patch configures RSS hash filter in DPDK in order to include source and destination MAC addresses into RSS hash calculation. This configuration considerably improves performance for flows with overlapping IP address spaces and non-overlapping Ethernet address spaces. Here is the example test r

Re: [ovs-dev] [PATCH 2/2] INSTALL.DPDK: Update DPDK build instructions

2016-03-24 Thread Mauricio Vásquez
Hi Markos, Currently DPDK 2.2.0 is required to build OVS master, DPDK 2.2.0 still requires setting the CONFIG_RTE_BUILD_COMBINE_LIBS option. I think we need to wait until we move to a new DPDK version to change the documentation. Mauricio V, On Thu, Mar 24, 2016 at 2:13 PM, Markos Chandras wro

[ovs-dev] [PATCH 1/1] Rationalize ovn-ctl arguments.

2016-03-24 Thread Ryan Moats
Define OVN_NB_ADDR and OVN_SB_ADDR to hold IP address Rather than overload OVN_NB_PORT and OVN_SB_PORT. Also define OVN_NORTHD_LOGFILE to avoid overloading OVN_NORTHD_LOG. Signed-off-by: Ryan Moats --- ovn/utilities/ovn-ctl | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) d

[ovs-dev] Document2

2016-03-24 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] acinclude.m4: Allow building against a DPDK installation

2016-03-24 Thread Bodireddy, Bhanuprakash
Hello Markos, While this patch allows OVS to build against DPDK even with install directory passed (i.e --with-dpdk=$DPDK_BUILD/install), I am reworking on another patch that handles auto discovery of DPDK library and fixes some issues in OVS configuration. http://openvswitch.org/pipermail/dev

Re: [ovs-dev] [PATCH 2/2] INSTALL.DPDK: Update DPDK build instructions

2016-03-24 Thread Markos Chandras
On 03/24/2016 02:32 PM, Mauricio Vásquez wrote: > Hi Markos, > > Currently DPDK 2.2.0 is required to build OVS master, DPDK 2.2.0 still > requires setting the CONFIG_RTE_BUILD_COMBINE_LIBS option. > > I think we need to wait until we move to a new DPDK version to change > the documentation. > >

[ovs-dev] [PATCH v10 0/9] Add Incremental Processing

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS The delta from v9 is threefold: 1. A rebase to up to date master - because of this one of the old patches was no longer applicable 2. to address Ben's comments - all of the sequence number magic used to make sure deleting works properly has been replaced by uuids (which make

[ovs-dev] [PATCH v10 5/9] Add incremental proessing to lflow_run

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS This code changes lflow_run to do incremental process of the logical flow table rather than processing the full table each run. Signed-off-by: RYAN D. MOATS --- ovn/controller/binding.c|3 ++ ovn/controller/lflow.c | 65 +++

[ovs-dev] [PATCH v10 2/9] Make flow table persistent in ovn controller

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS This is a prerequisite for incremental processing. Signed-off-by: RYAN D. MOATS --- lib/ofp-actions.c | 12 ++ lib/ofp-actions.h |2 + ovn/controller/lflow.c | 54 ++-- ovn/controller/lflow.h |3 +- ovn/controlle

[ovs-dev] [PATCH v10 6/9] Change encaps_run to work incrementally

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Side effects include tunnel context being persisted. Signed-off-by: RYAN D. MOATS --- ovn/controller/encaps.c | 161 +-- 1 files changed, 114 insertions(+), 47 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/e

Re: [ovs-dev] [PATCH] rhel: Packaging for OVN is split as per functionality

2016-03-24 Thread Guru Shetty
On 16 March 2016 at 19:17, Russell Bryant wrote: > > > On Wed, Mar 9, 2016 at 10:23 PM, wrote: > >> rhel packaging for OVN is split to host(controller), central(northd), >> common(command line utilities) and docker(docker network plugin). This is >> similar to OVN packaging for Debian. >> >> Sig

Re: [ovs-dev] [PATCH 1/2] acinclude.m4: Allow building against a DPDK installation

2016-03-24 Thread Markos Chandras
On 03/24/2016 02:58 PM, Bodireddy, Bhanuprakash wrote: > Hello Markos, > > While this patch allows OVS to build against DPDK even with install directory > passed (i.e --with-dpdk=$DPDK_BUILD/install), I am reworking on another patch > that handles auto discovery of DPDK library and fixes some is

[ovs-dev] [PATCH v10 3/9] Persist lport and mcgroup indexes

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Persisting these entries is a pre-requisite for incremental processing. Signed-off-by: RYAN D. MOATS --- ovn/controller/lport.c | 135 ++ ovn/controller/lport.h | 20 +- ovn/controller/ovn-controller.c | 14 ++--

[ovs-dev] [PATCH v10 1/9] Fix missing tracking reording of row deletes.

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Deletes need to be reordered as well as inserts and modifies, otherwise, following tracked changes will see out of order seqnos. Signed-off-by: RYAN D. MOATS --- lib/ovsdb-idl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-idl.c b/l

[ovs-dev] [PATCH v10 9/9] Change physical_run to incremental processing

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Persist localvif_to_ofport and tunnels structures and change physical_run to incremental processing. Signed-off-by: RYAN D. MOATS --- ovn/controller/lflow.c|3 + ovn/controller/physical.c | 99 +++- ovn/controller/physical.h

[ovs-dev] [PATCH v10 8/9] Reset lflow processing when adding/removing patch ports

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS As lflow processing is incremental, reset it whenever a patch port is added or removed. Signed-off-by: RYAN D. MOATS --- ovn/controller/patch.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c index

Re: [ovs-dev] [PATCH 2/2] INSTALL.DPDK: Update DPDK build instructions

2016-03-24 Thread Mauricio Vásquez
I am not sure if it is a good idea to match both master branches. What would happen if an OvS version is released before a DPDK one?, we can get in a situation that an OvS version would require an exact point in the tree of DPDK instead of a stable version. On Thu, Mar 24, 2016 at 4:24 PM, Markos

[ovs-dev] [PATCH v10 4/9] Persist local_datapaths

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Persist local_datapaths across runs so that a change can be used as a trigger to reset incremental flow processing. Signed-off-by: RYAN D. MOATS --- ovn/controller/binding.c| 41 -- ovn/controller/ovn-controller.c | 15 +++

[ovs-dev] [PATCH v10 7/9] Convert binding_run to incremental processing.

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Persist all_lports structure and ensure that binding_run resets to process the entire port binding table when chassis are added/removed or when get_local_iface_ids finds new ports on the local vswitch. Signed-off-by: RYAN D. MOATS --- ovn/controller/binding.c| 57

[ovs-dev] [PATCH v2] Dynamically reconnect ovn-controller if ovn-remote value changes

2016-03-24 Thread Ryan Moats
From: RYAN D. MOATS Allows for auto detection and reconnect if the ovn-remote needs to change. ovn-controller test case updated to include testing this code Signed-off-by: RYAN D. MOATS --- ovn/controller/ovn-controller.c | 13 + tests/ovn-controller.at | 16 ++

[ovs-dev] [PATCH] ofp-util: fix indirekt group delete message with no buckets as per OF v1.3.5 onwards

2016-03-24 Thread László Sürü
Hi, Using OpenFlow v1.3.5 and onwards OVS 2.5.0 returns OFPGMFC_INVALID_GROUP error when an INDIRECT type of group deletion requested, although the delete message is according to OpenFlow v1.3.5 standard. The reason is the conflicting protocol check in Open vSwitch's OpenFlow termination, that

Re: [ovs-dev] [PATCH] ovs-thread: Do not end quiescent state in ovs_thread_create().

2016-03-24 Thread Ben Pfaff
On Wed, Mar 23, 2016 at 06:02:58PM -0700, Daniele Di Proietto wrote: > A new thread must be started in a non quiescent state. There is a call > to ovsrcu_quiesce_end() in ovsthread_wrapper(), to enforce this. > > ovs_thread_create(), instead, is executed in the parent thread, and > calling ovsrcu

Re: [ovs-dev] [PATCH v3 3/7] tnl-neigh-cache: tighten arp and nd snooping.

2016-03-24 Thread pravin shelar
On Wed, Mar 23, 2016 at 9:15 PM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Mar 23, 2016 at 02:56:55PM -0700, Pravin B Shelar wrote: >> Currently arp and nd snooping is pretty loose. That causes >> unnecessary entries in neighbour cache. Following patch >> adds required checks. >> Thanks Casca

[ovs-dev] [PATCH v7 1/6] datapath-windows: Percpu allocation support function

2016-03-24 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Acked-by: Nithin Raju --- datapath-windows/ovsext/Util.c | 16 datapath-windows/ovsext/Util.h | 1 + 2 files changed, 17 insertions(+) diff --git a/datapath-windows/ovsext/Util.c b/datapath-windows/ovsext/Util

Re: [ovs-dev] [PATCH v5 10/12] dpif-netdev: Fix reconfigure_pmd_threads().

2016-03-24 Thread Kavanagh, Mark B
Hi Daniele, One minor comment below. Cheers, Mark > >This commit changes reconfigure_pmd_threads() to interact with the ports >cmap using RCU semantics (the content of the port structure is not >altered while concurrent readers might access it) and to fail more >gracefully in case of a set_multi

[ovs-dev] [PATCH v7 0/6] datapath-windows: Recirculation support

2016-03-24 Thread Sorin Vinturis
This patch series adds support for recirculation to the OVS extension. Sorin Vinturis (6): [PATCH v7 1/6] datapath-windows: Percpu allocation support function [PATCH v7 2/6] datapath-windows: Added recirculation support. [PATCH v7 3/6] datapath-windows: Allow recirculation feature probe. [

[ovs-dev] [PATCH v7 5/6] datapath-windows: Extract flow metadata in execute cmd handler.

2016-03-24 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal Acked-by: Nithin Raju --- datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/Flow.c | 19 +++ datapath-windows/ovsext/Flow.h | 2 ++ datapath-windows/ovsext/User.c | 7 +++ 4 files

[ovs-dev] [PATCH v7 2/6] datapath-windows: Added recirculation support.

2016-03-24 Thread Sorin Vinturis
Recirculation support for the OVS extension. Tested using PING and iperf with Driver Verifier enabled. Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/104 --- v2: Initialize flow key be

[ovs-dev] [PATCH v7 6/6] datapath-windows: Updated FAQ regarding Hyper-V recirculation.

2016-03-24 Thread Sorin Vinturis
Updated FAQ document to reflect recirculation support for Hyper-V. Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal Acked-by: Nithin Raju --- FAQ.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FAQ.md b/FAQ.md index 4830c44..04ffc84 100644 --- a/FAQ.md +++ b/FAQ.

[ovs-dev] [PATCH v7 3/6] datapath-windows: Allow recirculation feature probe.

2016-03-24 Thread Sorin Vinturis
Recirculation feature probe messages sent from userspace are suppressed by the OVS extension. This patch changes the current behaviour to allow feature probe for recirculation. Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal Acked-by: Nithin Raju --- datapath-windows/ovsext/Flow.c |

[ovs-dev] [PATCH v7 4/6] datapath-windows: Support for OVS_ACTION_ATTR_HASH attribute

2016-03-24 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal --- datapath-windows/ovsext/Actions.c| 38 datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/Flow.c | 14 + 3 files changed, 53 insertions(+) diff --git a/datap

Re: [ovs-dev] [PATCH v5 08/12] dpif-netdev: Change pmd thread configuration in dpif_netdev_run().

2016-03-24 Thread Kavanagh, Mark B
Hi Daniele, One comment inline. Cheers, Mark >-Original Message- >From: Daniele Di Proietto [mailto:diproiet...@vmware.com] >Sent: Wednesday, March 23, 2016 6:37 PM >To: dev@openvswitch.org >Cc: Ben Pfaff; Kavanagh, Mark B; Ilya Maximets; Daniele Di Proietto >Subject: [PATCH v5 08/12] dp

[ovs-dev] INTER EURO LOTTERIES ORGANISATION

2016-03-24 Thread FRANCISCO JIMENEZ
INTER EURO LOTTERIES ORGANISATION MADRID, SPAIN. LISBON, PORTUGAL. LONDON, ENGLAND. PARIS, FRANCE) AVDA. LOS PEREGRINOS 28, 28009 MADRID, ESPA?A. TEL./FAX.: +34 654 21 98. VON BER B?RO DES VIZE PRASIDENTEN,

[ovs-dev] [PATCH RFC v3] ovs-ctl: Allow selective start for db and switch

2016-03-24 Thread Aaron Conole
Currently, ``ovs-ctl start'' will attempt to start both the DB and vswitchd. This is quite convenient when the database already has all of the configuration values required, and when using a single services file for systemd integration. The same goes for the ``ovs-ctl stop'' command. However, ther

Re: [ovs-dev] [PATCH] python: Allow specifying the iterations in Idl.run

2016-03-24 Thread Terry Wilson
On Wed, Mar 23, 2016 at 2:31 PM, Jason Kölker wrote: > On Wed, Mar 23, 2016 at 6:29 PM, Ben Pfaff wrote: >> On Sun, Mar 20, 2016 at 03:29:06AM +, Jason Kölker wrote: >>> Callers to Idl.run() should be able to specify the number of iterations >>> to run in one call. Instrumentation revealed th

[ovs-dev] [PATH v4] ovn-controller: Add external-id 'ovn-remote-probe-interval'

2016-03-24 Thread Huang Lei
From: Huang Lei Add a external-id 'ovn-remote-probe-interval' for setting the activity probe interval of the json session from ovn-controller to the OVN southbound database. Signed-off-by: Huang Lei --- lib/ovsdb-idl.c | 9 + lib/ovsdb-idl.h |

[ovs-dev] [PATCH] tunnel-tests: Fix travis build failure.

2016-03-24 Thread Pravin B Shelar
Travis does not allow tcpdump utility which causes the neighbour discovery and ARP verification tests failures. Following patch fixes the issue by using ovs-pcap utility instead of tcpdump. Suggested-by: Daniele Di Proietto Signed-off-by: Pravin B Shelar --- tests/tunnel-push-pop-ipv6.at | 10 +

[ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Aaron Conole
Most projects have a checkpatch facility, which can be used as a pre-commit sanity check. This introduces such a mechanism to the Open vSwitch project to catch some of the more silly formatting mistakes which can occur. It is not meant to replace good code review practices, but it can help eliminat

Re: [ovs-dev] [PATCH] tunnel-tests: Fix travis build failure.

2016-03-24 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 11:22:03AM -0700, Pravin B Shelar wrote: > Travis does not allow tcpdump utility which causes the neighbour > discovery and ARP verification tests failures. Following patch > fixes the issue by using ovs-pcap utility instead of tcpdump. > > Suggested-by: Daniele Di Proietto

[ovs-dev] [PATCH v2] ovs-thread: Do not always end quiescent state in ovs_thread_create().

2016-03-24 Thread Daniele Di Proietto
A new thread must be started in a non quiescent state. There is a call to ovsrcu_quiesce_end() in ovsthread_wrapper(), to enforce this. ovs_thread_create(), instead, is executed in the parent thread. It must call ovsrcu_quiesce_end() on its first invocation, to put the main thread in a non quiesc

Re: [ovs-dev] [PATCH] ovs-thread: Do not end quiescent state in ovs_thread_create().

2016-03-24 Thread Daniele Di Proietto
On 24/03/2016 09:18, "Ben Pfaff" wrote: >On Wed, Mar 23, 2016 at 06:02:58PM -0700, Daniele Di Proietto wrote: >> A new thread must be started in a non quiescent state. There is a call >> to ovsrcu_quiesce_end() in ovsthread_wrapper(), to enforce this. >> >> ovs_thread_create(), instead, is ex

[ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Hui Kang
For the sake of clarity Signed-off-by: Hui Kang --- ovn/ovn-architecture.7.xml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index 13acaf5..a588a0e 100644 --- a/ovn/ovn-architecture.7.xml +++ b/ovn/ovn-architect

[ovs-dev] [PATCH] tests: Run Python 3 tests with Python 3.

2016-03-24 Thread Russell Bryant
I noticed one spot where there intention was to run some tests with Python 3, but a typo was making it still run with Python 2. Signed-off-by: Russell Bryant --- tests/ovsdb.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovsdb.at b/tests/ovsdb.at index 2e87ef3..5000

Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 02:50:47PM -0400, Hui Kang wrote: > For the sake of clarity > > Signed-off-by: Hui Kang > --- > ovn/ovn-architecture.7.xml | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml > index 13ac

Re: [ovs-dev] [PATCH] tests: Run Python 3 tests with Python 3.

2016-03-24 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 03:28:37PM -0400, Russell Bryant wrote: > I noticed one spot where there intention was to run some tests with > Python 3, but a typo was making it still run with Python 2. > > Signed-off-by: Russell Bryant Oops. I hope the tests actually pass with Python 3! Acked-by: Be

Re: [ovs-dev] [PATCH] tunnel-tests: Fix travis build failure.

2016-03-24 Thread pravin shelar
On Thu, Mar 24, 2016 at 11:28 AM, Ben Pfaff wrote: > On Thu, Mar 24, 2016 at 11:22:03AM -0700, Pravin B Shelar wrote: >> Travis does not allow tcpdump utility which causes the neighbour >> discovery and ARP verification tests failures. Following patch >> fixes the issue by using ovs-pcap utility i

Re: [ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 2:23 PM, Aaron Conole wrote: > Most projects have a checkpatch facility, which can be used as a pre-commit > sanity check. This introduces such a mechanism to the Open vSwitch project > to catch some of the more silly formatting mistakes which can occur. It is > not meant

Re: [ovs-dev] [PATCH] tests: Run Python 3 tests with Python 3.

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 3:30 PM, Ben Pfaff wrote: > On Thu, Mar 24, 2016 at 03:28:37PM -0400, Russell Bryant wrote: > > I noticed one spot where there intention was to run some tests with > > Python 3, but a typo was making it still run with Python 2. > > > > Signed-off-by: Russell Bryant > > Oo

Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 3:29 PM, Ben Pfaff wrote: > On Thu, Mar 24, 2016 at 02:50:47PM -0400, Hui Kang wrote: > > For the sake of clarity > > > > Signed-off-by: Hui Kang > > --- > > ovn/ovn-architecture.7.xml | 7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/

[ovs-dev] [PATCH v2] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Aaron Conole
Most projects have a checkpatch facility, which can be used as a pre-commit sanity check. This introduces such a mechanism to the Open vSwitch project to catch some of the more silly formatting mistakes which can occur. It is not meant to replace good code review practices, but it can help eliminat

Re: [ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 03:35:33PM -0400, Russell Bryant wrote: > I think the python directory should be limited to what we consider the ovs > Python library. That's largely what it is, except for the build/ and > ovstest/ directories. Going off on a tangent: should those be somewhere else, then,

Re: [ovs-dev] RFCv2: OVN database options

2016-03-24 Thread Russell Bryant
On Thu, Mar 10, 2016 at 7:01 PM, Ben Pfaff wrote: > Database txn ACID consist trk HA OSC Py format > - --- --- --- --- --- --- --- -- > ActorDByes ACID strong NO yes yes yes yes sql > Aerospike yes ACID strong NO

Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Hui Kang
"dev" wrote on 03/24/2016 03:29:28 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 03/24/2016 03:29 PM > Subject: Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the > definition of Binding table > Sent by: "dev" > > On Thu, Mar 24, 2016 at 02:50:47PM -0400, Hui

Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the definition of Binding table

2016-03-24 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 03:32:45PM -0500, Hui Kang wrote: > > > "dev" wrote on 03/24/2016 03:29:28 PM: > > > From: Ben Pfaff > > To: Hui Kang > > Cc: dev@openvswitch.org > > Date: 03/24/2016 03:29 PM > > Subject: Re: [ovs-dev] [PATCH] ovn-architecture.7.xml: Clarify the > > definition of Bind

Re: [ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 4:14 PM, Ben Pfaff wrote: > On Thu, Mar 24, 2016 at 03:35:33PM -0400, Russell Bryant wrote: > > I think the python directory should be limited to what we consider the > ovs > > Python library. That's largely what it is, except for the build/ and > > ovstest/ directories.

Re: [ovs-dev] [PATCH v2] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 4:12 PM, Aaron Conole wrote: > Most projects have a checkpatch facility, which can be used as a pre-commit > sanity check. This introduces such a mechanism to the Open vSwitch project > to catch some of the more silly formatting mistakes which can occur. It is > not meant

Re: [ovs-dev] [PATCH v2] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Aaron Conole
Russell Bryant writes: > On Thu, Mar 24, 2016 at 4:12 PM, Aaron Conole wrote: > >> Most projects have a checkpatch facility, which can be used as a pre-commit >> sanity check. This introduces such a mechanism to the Open vSwitch project >> to catch some of the more silly formatting mistakes whic

Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

2016-03-24 Thread Guru Shetty
I saw the following 3 issues when I did a git pull today. It is possible that I am not doing something the "new" way. 1. root@ovn1:~/git/routes# /usr/share/openvswitch/scripts/ovn-ctl restart_northd * Exiting ovn-northd (30705) 2016-03-24T10:56:44Z|1|unixctl|WARN|failed to connect to /var/run

Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 4:56 PM, Guru Shetty wrote: > I saw the following 3 issues when I did a git pull today. It is possible > that I am not doing something the "new" way. > Sorry for the trouble. > 1. > root@ovn1:~/git/routes# /usr/share/openvswitch/scripts/ovn-ctl > restart_northd > * Exi

Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

2016-03-24 Thread Guru Shetty
On 24 March 2016 at 14:16, Russell Bryant wrote: > > > On Thu, Mar 24, 2016 at 4:56 PM, Guru Shetty wrote: > >> I saw the following 3 issues when I did a git pull today. It is possible >> that I am not doing something the "new" way. >> > > Sorry for the trouble. > > >> 1. >> root@ovn1:~/git/rout

[ovs-dev] [PATCH v3] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Aaron Conole
Most projects have a checkpatch facility, which can be used as a pre-commit sanity check. This introduces such a mechanism to the Open vSwitch project to catch some of the more silly formatting mistakes which can occur. It is not meant to replace good code review practices, but it can help eliminat

[ovs-dev] [PATCH] ovn: Fix some split db issues in ovn-ctl.

2016-03-24 Thread Russell Bryant
The default location for databases should be $dbdir, not $rundir. The default location for log files comes from $logdir, not $OVS_LOGDIR. Fix ovs-appctl commands. The code assumed that passing --unixctl=ovnnb_db was sufficient to allow an argument of "-t ovnnb_db" to ovs-appctl. Unfortunately,

Re: [ovs-dev] [PATCH] ovn: Fix some split db issues in ovn-ctl.

2016-03-24 Thread Guru Shetty
On 24 March 2016 at 14:49, Russell Bryant wrote: > The default location for databases should be $dbdir, not $rundir. > > The default location for log files comes from $logdir, not $OVS_LOGDIR. > > Fix ovs-appctl commands. The code assumed that passing > --unixctl=ovnnb_db was sufficient to allow

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Expand RSS hash calculation by MAC addresses

2016-03-24 Thread Jesse Gross
On Thu, Mar 24, 2016 at 7:30 AM, Robert Wojciechowicz wrote: > This patch configures RSS hash filter in DPDK in order to include > source and destination MAC addresses into RSS hash calculation. > This configuration considerably improves performance for flows > with overlapping IP address spaces a

Re: [ovs-dev] [PATCH] ovn: Fix some split db issues in ovn-ctl.

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 6:07 PM, Guru Shetty wrote: > > > On 24 March 2016 at 14:49, Russell Bryant wrote: > >> The default location for databases should be $dbdir, not $rundir. >> >> The default location for log files comes from $logdir, not $OVS_LOGDIR. >> >> Fix ovs-appctl commands. The code

Re: [ovs-dev] [PATCH v2] rhel: Packaging for OVN is split as per functionality

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 9:55 AM, Flavio Leitner wrote: > On Thu, 24 Mar 2016 11:37:29 +0530 > bscha...@redhat.com wrote: > > > rhel packaging for OVN is split to host(controller), central(northd), > > common(command line utilities) and docker(docker network plugin). This is > > similar to OVN pac

[ovs-dev] [PATCH] debian: Ship ovn-[ns]b man pages in ovn-common.

2016-03-24 Thread Russell Bryant
Move ovn-nb and ovn-sb man pages to ovn-common so that the man pages for these DB schemas are always available with the corresponding command line utilities, ovn-nbctl and ovn-sbctl. Signed-off-by: Russell Bryant --- debian/ovn-central.manpages | 2 -- debian/ovn-common.manpages | 2 ++ 2 files

Re: [ovs-dev] [PATCH] debian: Ship ovn-[ns]b man pages in ovn-common.

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 8:04 PM, Russell Bryant wrote: > Move ovn-nb and ovn-sb man pages to ovn-common so that the man pages for > these DB schemas are always available with the corresponding command > line utilities, ovn-nbctl and ovn-sbctl. > > Signed-off-by: Russell Bryant > --- > debian/ov

Re: [ovs-dev] RFCv2: OVN database options

2016-03-24 Thread Justin Pettit
> On Mar 24, 2016, at 1:29 PM, Russell Bryant wrote: > > My preferred approach is to continue on the current path and build on the > success we've had with OVSDB so far. We should take regular checkpoints > and still remain willing to change course if needed as we continue to learn > more. I'm

Re: [ovs-dev] [RFC PATCH] tunneling: Improving vxlan performance using DPDK flow director feature.

2016-03-24 Thread Jesse Gross
On Fri, Mar 18, 2016 at 8:50 AM, Chandran, Sugesh wrote: > Hi Jesse, > Please find my answers inline. > > Regards > _Sugesh > > >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Thursday, March 17, 2016 11:50 PM >> To: Chandran, Sugesh >> Cc: dev@openvswitch.or

[ovs-dev] [PATCH 1/2] ovs-ctl: Store hostname as an external-id.

2016-03-24 Thread Russell Bryant
Update ovs-ctl to store the system hostname as an external-id, similar to the system-id. This is largely for convenience. ovn-controller will make use of it in a future commit. Someone in the OpenDaylight community requested the same thing in a discussion earlier this week. While we're at it, s

[ovs-dev] [PATCH 2/2] ovn: Get hostname from ovs external-ids.

2016-03-24 Thread Russell Bryant
A previous commit updated ovs-ctl to store the system's hostname as an external-id in the Open_vSwitch table by default. Make ovn-controller read this by default and fall back to gethostname() only if needed. Suggested-by: Justin Pettit Suggested-at: http://openvswitch.org/pipermail/dev/2016-Mar

[ovs-dev] [PATCH] ovn-controller: optimize lex_token memory usage

2016-03-24 Thread Huang Lei
From: Huang Lei During our scalability test '2k HVs + 20k lports' we found that lexer is a major user of heap memory: - 5.22% ovn-controller libjemalloc.so.1[.] free - free + 27.46% lexer_get + 18.00% ofctrl_put ... - 1.85% ovn-controller libjemalloc.so.1[.] m

Re: [ovs-dev] [PATCH 1/2] ovs-ctl: Store hostname as an external-id.

2016-03-24 Thread Justin Pettit
> On Mar 24, 2016, at 5:40 PM, Russell Bryant wrote: > > Update ovs-ctl to store the system hostname as an external-id, similar > to the system-id. This is largely for convenience. ovn-controller > will make use of it in a future commit. Someone in the OpenDaylight > community requested the s

Re: [ovs-dev] [PATCH 2/2] ovn: Get hostname from ovs external-ids.

2016-03-24 Thread Justin Pettit
> On Mar 24, 2016, at 5:40 PM, Russell Bryant wrote: > > A previous commit updated ovs-ctl to store the system's hostname as an > external-id in the Open_vSwitch table by default. Make ovn-controller > read this by default and fall back to gethostname() only if needed. > > Suggested-by: Justin

Re: [ovs-dev] [PATCH 2/2] ovn: Get hostname from ovs external-ids.

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 9:16 PM, Justin Pettit wrote: > > > On Mar 24, 2016, at 5:40 PM, Russell Bryant wrote: > > > > A previous commit updated ovs-ctl to store the system's hostname as an > > external-id in the Open_vSwitch table by default. Make ovn-controller > > read this by default and fa

Re: [ovs-dev] [PATCH] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

2016-03-24 Thread Ilya Maximets
On 24.03.2016 17:34, Flavio Leitner wrote: > On Thu, 24 Mar 2016 14:55:15 +0300 > Ilya Maximets wrote: > >> According to QEMU documentation (docs/specs/vhost-user.txt) one queue >> should be enabled initially. More queues are enabled dynamically, by >> sending message VHOST_USER_SET_VRING_ENABLE.

[ovs-dev] [PATCH v2] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

2016-03-24 Thread Ilya Maximets
According to QEMU documentation (docs/specs/vhost-user.txt) one queue should be enabled initially. More queues are enabled dynamically, by sending message VHOST_USER_SET_VRING_ENABLE. Currently all queues in OVS disabled by default. This breaks above specification. So, queue #0 should be enabled b

Re: [ovs-dev] [PATCH 1/3] VTEP Schema - Support mcast macs remote table updates

2016-03-24 Thread Darrell Ball
Thanks for reviewing I’m sending a V2 On 3/3/16, 1:55 PM, "dev on behalf of Guru Shetty" wrote: >On 12 February 2016 at 17:12, Darrell Ball wrote: > >> Signed-off-by: Darrell Ball >> --- >> AUTHORS| 1 + >> ovn/controller-vtep/vtep.c | 207 >> +++