On 16 March 2016 at 19:17, Russell Bryant <russ...@ovn.org> wrote:
>
>
> On Wed, Mar 9, 2016 at 10:23 PM, <bscha...@redhat.com> wrote:
>
>> rhel packaging for OVN is split to host(controller), central(northd),
>> common(command line utilities) and docker(docker network plugin). This is
>> similar to OVN packaging for Debian.
>>
>> Signed-off-by: Babu Shanmugam <bscha...@redhat.com>
>>
>
> I'm sorry for the review delay.
>
> I have some minor comments.
>
>
>> @@ -376,33 +428,39 @@ fi
>> /var/log/openvswitch
>> %ghost %attr(755,root,root) %{_rundir}/openvswitch
>>
>> -%files ovn
>> -%{_bindir}/ovn-controller
>> -%{_bindir}/ovn-controller-vtep
>> +%files ovn-docker
>> %{_bindir}/ovn-docker-overlay-driver
>> %{_bindir}/ovn-docker-underlay-driver
>> +
>> +%files ovn-common
>> %{_bindir}/ovn-nbctl
>> -%{_bindir}/ovn-northd
>> %{_bindir}/ovn-sbctl
>> %{_datadir}/openvswitch/scripts/ovn-ctl
>> %{_datadir}/openvswitch/scripts/ovn-bugtool-nbctl-show
>> %{_datadir}/openvswitch/scripts/ovn-bugtool-sbctl-lflow-list
>> %{_datadir}/openvswitch/scripts/ovn-bugtool-sbctl-show
>> -%{_mandir}/man8/ovs-testcontroller.8*
>> -%{_mandir}/man5/ovn-nb.5*
>> -%{_mandir}/man5/ovn-sb.5*
>> -%{_mandir}/man7/ovn-architecture.7*
>> -%{_mandir}/man8/ovn-controller.8*
>> -%{_mandir}/man8/ovn-controller-vtep.8*
>> %{_mandir}/man8/ovn-ctl.8*
>> %{_mandir}/man8/ovn-nbctl.8*
>> -%{_mandir}/man8/ovn-northd.8*
>> +%{_mandir}/man7/ovn-architecture.7*
>> %{_mandir}/man8/ovn-sbctl.8*
>> +
>> +%files ovn-central
>> +%{_bindir}/ovn-northd
>> +%{_mandir}/man5/ovn-nb.5*
>> +%{_mandir}/man5/ovn-sb.5*
>>
>
> I think I would put the ovn-nb and ovn-sb man pages in ovn-common so that
> they are always available with ovn-nbctl and ovn-sbctl.
>
> Guru, what would you think of making the same change to the debian
> packaging?
>
I completely missed this. I think it makes sense.
>
> +%{_mandir}/man8/ovn-northd.8*
>> %config %{_datadir}/openvswitch/ovn-nb.ovsschema
>> %config %{_datadir}/openvswitch/ovn-sb.ovsschema
>> +%{_unitdir}/ovn-northd.service
>> +
>> +%files ovn-host
>> +%{_bindir}/ovn-controller
>> +%{_bindir}/ovn-controller-vtep
>>
>
> It probably doesn't make sense to install ovn-controller-vtep on every OVN
> host. It wouldn't be used in most cases.
>
> If we're breaking things up this much, ovn-controller-vtep should probably
> just get its own sub-package. ovn-vtep perhaps?
>
>
>> +%{_mandir}/man8/ovs-testcontroller.8*
>>
>
> Oops. This shouldn't have been in the ovn package.
>
> http://openvswitch.org/pipermail/dev/2016-March/067924.html
>
>
>> +%{_mandir}/man8/ovn-controller.8*
>> +%{_mandir}/man8/ovn-controller-vtep.8*
>> %{_unitdir}/ovn-controller.service
>> %{_unitdir}/ovn-controller-vtep.service
>> -%{_unitdir}/ovn-northd.service
>>
>> %changelog
>> * Wed Jan 12 2011 Ralf Spenneberg <r...@os-s.net>
>> --
>> 2.5.0
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
>>
>
>
>
> --
> Russell Bryant
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
