I found it hard to drop belt sizes, until I tried this for myself
You can be better.
http://x.co/8jbft
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Dennis Flynn
This commit fixes a segmentation fault observed when enabling lldp prior to
establishing auto attach mappings.
Signed-off-by: Dennis Flynn
diff --git a/lib/ovs-lldp.c b/lib/ovs-lldp.c
index db97648..f71b40d 100644
--- a/lib/ovs-lldp.c
+++ b/lib/ovs-lldp.c
@@ -483,12 +483,14
There is always a need to slash you waistline
Watch the weight come off.
http://zzb.bz/wteD2
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
These two patches address 'up' state handling for logical ports. I
started by adding the 'lport-get-up' command for ovn-nbctl. While
testing that, I realized that the ovn-nbd handling for setting the 'up'
state had not been fixed to reflect that the logical_port column in the
Bindings table of th
When ovn-nbd is looking through bindings to figure out if any logical
ports in the northbound DB need to have their 'up' state changed, it
should be using the logical port's name instead of UUID for matching
up to rows in the OVN db.
The switch to using the name instead of UUID means we don't have
Add a command to get the 'up' state of a logical port.
Signed-off-by: Russell Bryant
---
ovn/ovn-nbctl.8.xml | 1 +
ovn/ovn-nbctl.c | 23 +++
2 files changed, 24 insertions(+)
diff --git a/ovn/ovn-nbctl.8.xml b/ovn/ovn-nbctl.8.xml
index 03c8e13..7cdef00 100644
--- a/ovn
On Thu, 2 Apr 2015 20:17:19 -0700
Ben Pfaff wrote:
> On Thu, Apr 02, 2015 at 06:44:08PM -0300, Flavio Leitner wrote:
> > On Thu, 2 Apr 2015 13:47:56 -0700
> > Ben Pfaff wrote:
> >
> > > On Thu, Apr 02, 2015 at 05:45:34PM -0300, Flavio Leitner wrote:
> > > > On Thu, 2 Apr 2015 13:37:06 -0700
> >
We're starting to see a number of people have trouble building the
kernel module because of -Werror=date-time (primarily on Fedora, I
think). Have you considered removing the use of __DATE__ and __TIME__
from the kernel build or, alternately, making the makefiles (or the
configure step) figure out
Release switchContext->dispatchLock in case the vport has bot been found.
v2: Modify commit message and add Acked-by lines.
Acked-by: Eitan Eliahu
Acked-by: Sorin Vinturis
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Allow the port to be updated if it the type is only:
NdisSwitchPortTypeSynthetic
v2: Add Acked-by lines.
Acked-by: Nithin Raju
Acked-by: Eitan Eliahu
Acked-by: Sorin Vinturis
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 4 ++--
1 file changed, 2 insertions(+), 2
On Mon, Apr 06, 2015 at 05:28:42PM +, Alin Serdean wrote:
> Allow the port to be updated if it the type is only:
> NdisSwitchPortTypeSynthetic
>
> v2: Add Acked-by lines.
>
> Acked-by: Nithin Raju
> Acked-by: Eitan Eliahu
> Acked-by: Sorin Vinturis
> Signed-off-by: Alin Gabriel Serdean
T
On Mon, Apr 06, 2015 at 05:22:06PM +, Alin Serdean wrote:
> Release switchContext->dispatchLock in case the vport has bot been found.
>
> v2: Modify commit message and add Acked-by lines.
>
> Acked-by: Eitan Eliahu
> Acked-by: Sorin Vinturis
> Signed-off-by: Alin Gabriel Serdean
Applied t
On Mon, Apr 06, 2015 at 01:04:43PM -0300, Flavio Leitner wrote:
> On Thu, 2 Apr 2015 20:17:19 -0700
> Ben Pfaff wrote:
>
> > On Thu, Apr 02, 2015 at 06:44:08PM -0300, Flavio Leitner wrote:
> > > On Thu, 2 Apr 2015 13:47:56 -0700
> > > Ben Pfaff wrote:
> > >
> > > > On Thu, Apr 02, 2015 at 05:45
On Mon, 6 Apr 2015 11:09:58 -0700
Ben Pfaff wrote:
> On Mon, Apr 06, 2015 at 01:04:43PM -0300, Flavio Leitner wrote:
> > On Thu, 2 Apr 2015 20:17:19 -0700
> > Ben Pfaff wrote:
> >
> > > On Thu, Apr 02, 2015 at 06:44:08PM -0300, Flavio Leitner wrote:
> > > > On Thu, 2 Apr 2015 13:47:56 -0700
> >
A recent patch updated the OVN design to include integration with containers
running inside of VMs:
https://github.com/openvswitch/ovs/commit/9fb4636f6c587060713ea0abf60ed6bcbe4f11f4
This series goes back through the code merged so far and makes the necessary
updates to incorporate the additions.
Add support for specifying a parent port name and tag when creating
logical ports. Also add commands for getting the parent_name or tag
set on a logical port. These are necessary for dealing with container
interfaces that sit behind normal interfaces.
Signed-off-by: Russell Bryant
---
ovn/ovn-
ovn-nbd updates the Bindings table of the OVN database when there are
updates to the OVN_Northbound database. This update makes ovn-nbd
copy over the container integration related fields from OVN_Northbound
into the Bindings table.
Signed-off-by: Russell Bryant
---
ovn/ovn-nbd.c | 6 ++
1 f
A logical port that represents a container that sits behind another
logical port has both a parent_name and a tag set. The parent_name
identifies the parent port and the tag is the VLAN ID used to identify
which traffic comes from that container. The combination of
parent_name and tag must always
On 04/06/15 at 03:12pm, Russell Bryant wrote:
> A logical port that represents a container that sits behind another
> logical port has both a parent_name and a tag set. The parent_name
> identifies the parent port and the tag is the VLAN ID used to identify
> which traffic comes from that containe
On Mon, Apr 06, 2015 at 10:59:19AM -0400, drfl...@avaya.com wrote:
> From: Dennis Flynn
>
> This commit fixes a segmentation fault observed when enabling lldp prior to
> establishing auto attach mappings.
>
> Signed-off-by: Dennis Flynn
Applied, thanks!
On 04/05/15 at 03:03pm, Ben Pfaff wrote:
> Thanks Justin and Ethan. Applied to master, with your acks.
>
> On Sun, Apr 05, 2015 at 01:46:55PM -0700, Ethan Jackson wrote:
> > I think this is fine. Though I agree with Justin the script
> > documentation should be update. I can take care of that t
On 04/05/15 at 01:36pm, Ben Pfaff wrote:
> On Sun, Apr 05, 2015 at 12:28:46PM -0700, Justin Pettit wrote:
> > Thanks for fixing this. In the "Open vSwitch kernel module" section,
> > there's a part where "openvswitch.ko" is listed under "Provides:".
> > Should the vport kernel modules also be incl
On Mon, Apr 06, 2015 at 10:10:07PM +0200, Thomas Graf wrote:
> On 04/05/15 at 01:36pm, Ben Pfaff wrote:
> > On Sun, Apr 05, 2015 at 12:28:46PM -0700, Justin Pettit wrote:
> > > Thanks for fixing this. In the "Open vSwitch kernel module" section,
> > > there's a part where "openvswitch.ko" is liste
On 04/06/15 at 01:28pm, Ben Pfaff wrote:
> I'm an RPM programmer at "cargo cult" level only. Does this mean that
> we should change:
> /lib/modules/%{kernel}/kernel/extra/openvswitch/openvswitch.ko
> /lib/modules/%{kernel}/kernel/extra/openvswitch/vport-*.ko
> to
> /lib/modules/%{kerne
> On Apr 5, 2015, at 10:13 AM, Ben Pfaff wrote:
>
> On Fri, Apr 03, 2015 at 03:55:43PM -0700, Jarno Rajahalme wrote:
>> Makes popping each member of the list a bit easier.
>>
>> Signed-off-by: Jarno Rajahalme
>
>> diff --git a/lib/list.h b/lib/list.h
>> index b40bbef..bca5d5c 100644
>> --- a/
Makes popping each member of the list a bit easier.
Signed-off-by: Jarno Rajahalme
---
lib/dp-packet.c |5 ++---
lib/list.h |3 +++
lib/lldp/lldpd-structs.c |5 ++---
lib/lldp/lldpd.c |5 ++---
lib/mcast-snooping.c |5 ++-
Since %install puts every .ko file into /lib/modules, %files should make
sure that all of them are packaged.
Suggested-by: Thomas Graf
Signed-off-by: Ben Pfaff
---
Not tested.
rhel/openvswitch-kmod-fedora.spec.in |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/rhel/ope
On Mon, Apr 06, 2015 at 10:42:46PM +0200, Thomas Graf wrote:
> On 04/06/15 at 01:28pm, Ben Pfaff wrote:
> > I'm an RPM programmer at "cargo cult" level only. Does this mean that
> > we should change:
> > /lib/modules/%{kernel}/kernel/extra/openvswitch/openvswitch.ko
> > /lib/modules/%{kern
On Mon, Apr 06, 2015 at 01:50:36PM -0700, Jarno Rajahalme wrote:
> Makes popping each member of the list a bit easier.
>
> Signed-off-by: Jarno Rajahalme
I didn't test this.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswi
> I think lxc deployment inside the VM definitely makes sense from a
> hardware isolation perspective but it may not be feasible for
> everyone. A simple example is resource allocation across multiple
> tenants on process level which becomes a lot more difficult if the
> host can no longer see the
Jarno, you're the expert on this stuff I think, do you have advice for
Flavio?
On Mon, Apr 06, 2015 at 04:03:23PM -0300, Flavio Leitner wrote:
> On Mon, 6 Apr 2015 11:09:58 -0700
> Ben Pfaff wrote:
>
> > On Mon, Apr 06, 2015 at 01:04:43PM -0300, Flavio Leitner wrote:
> > > On Thu, 2 Apr 2015 20:
On Tue, Mar 31, 2015 at 05:31:24PM -0700, Alex Wang wrote:
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Pushed to master, thanks for the reviews!
Jarno
> On Apr 6, 2015, at 1:57 PM, Ben Pfaff wrote:
>
> On Mon, Apr 06, 2015 at 01:50:36PM -0700, Jarno Rajahalme wrote:
>> Makes popping each member of the list a bit easier.
>>
>> Signed-off-by: Jarno Rajahalme
>
> I didn't test this.
>
> Acked
> On Apr 3, 2015, at 4:51 PM, Russell Bryant wrote:
>
> On 04/03/2015 06:55 PM, Jarno Rajahalme wrote:
>> Makes popping each member of the list a bit easier.
>>
>> Signed-off-by: Jarno Rajahalme
>
> Nice improvement! The changes look good to me. I think one bonus
> improvement would be to a
On Tue, Mar 31, 2015 at 05:31:25PM -0700, Alex Wang wrote:
> When ovsdb happens to get blocked for few seconds, the 'stats_timer'
> will not be updated due to incompletion of previous transaction.
> When the current time passes the 'stats_timer', the call to
> poll_timer_wait_until(stats_timer) wil
I'm determined not to let the terrible style of pseudo-parsing we have in
OVS leak into OVN. Here's the first step.
Signed-off-by: Ben Pfaff
Looks good in general. A few minor comments in line:
Acked-by: Andy Zhou
> +
> +static void
> +lex_token_format_masked_integer(const struct lex_token *
On Mon, Apr 06, 2015 at 11:27:05AM -0400, Russell Bryant wrote:
> Add a command to get the 'up' state of a logical port.
>
> Signed-off-by: Russell Bryant
Thanks!
For this kind of thing I prefer clear names over Booleans so I folded
in the following change and applied to ovn:
diff --git a/ovn/
Thx a lot for the review, adopt the suggestions and applied both patches to
master,
Alex Wang,
On Mon, Apr 6, 2015 at 2:08 PM, Ben Pfaff wrote:
> On Tue, Mar 31, 2015 at 05:31:25PM -0700, Alex Wang wrote:
> > When ovsdb happens to get blocked for few seconds, the 'stats_timer'
> > will not be u
On Tue, Mar 31, 2015 at 9:52 PM, Ben Pfaff wrote:
> To be used in upcoming commits.
>
> Signed-off-by: Ben Pfaff
> ---
Looks good.
Acked-by: Andy Zhou
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
CC: Russell Bryant
Signed-off-by: Ben Pfaff
---
lib/hmap.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/hmap.h b/lib/hmap.h
index 85241f0..6215be6 100644
--- a/lib/hmap.h
+++ b/lib/hmap.h
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2008, 2009, 2010, 2012, 2013
On Mon, Apr 06, 2015 at 11:27:06AM -0400, Russell Bryant wrote:
> When ovn-nbd is looking through bindings to figure out if any logical
> ports in the northbound DB need to have their 'up' state changed, it
> should be using the logical port's name instead of UUID for matching
> up to rows in the O
I don't really like the names of the two new functions, they're
verbose and don't convey much information (one or the other is fine,
both less so). I'm not sure what would be better, but off the top of
my head let me suggest something like:
cycle_reset()
cycle_tally()
Think about it, there's pro
On Mon, Apr 06, 2015 at 02:11:24PM -0700, Andy Zhou wrote:
> I'm determined not to let the terrible style of pseudo-parsing we have in
> OVS leak into OVN. Here's the first step.
>
> Signed-off-by: Ben Pfaff
>
> Looks good in general. A few minor comments in line:
> Acked-by: Andy Zhou
Thanks
On Mon, Apr 06, 2015 at 02:31:57PM -0700, Andy Zhou wrote:
> On Tue, Mar 31, 2015 at 9:52 PM, Ben Pfaff wrote:
> > To be used in upcoming commits.
> >
> > Signed-off-by: Ben Pfaff
> > ---
>
> Looks good.
>
> Acked-by: Andy Zhou
Thanks, I added your ack in the "ovn" branch in my github "review
Acked-by: Ethan Jackson
On Wed, Apr 1, 2015 at 9:21 AM, Daniele Di Proietto
wrote:
> This init function is called when the dpif class is registered. It will
> be used by following commits
>
> Signed-off-by: Daniele Di Proietto
> ---
> lib/dpif-netdev.c | 1 +
> lib/dpif-netlink.c | 1 +
>
On Mon, Apr 06, 2015 at 03:12:03PM -0400, Russell Bryant wrote:
> A logical port that represents a container that sits behind another
> logical port has both a parent_name and a tag set. The parent_name
> identifies the parent port and the tag is the VLAN ID used to identify
> which traffic comes
Add new ovn-controller daemon that runs locally on transport nodes.
This initial version registers itself in the Chassis table and registers
logical ports to the appropriate rows in the Bindings table.
Signed-off-by: Justin Pettit
---
ovn/.gitignore |2 +
ovn/TODO |
What's happening
My body looks so much improved.
http://zzb.bz/ea87t
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, Apr 4, 2015 at 8:45 AM, Neil McKee wrote:
>
> On Fri, Apr 3, 2015 at 3:14 PM, Jesse Gross wrote:
>>
>> On Wed, Apr 1, 2015 at 10:14 PM, Neil McKee wrote:
>> > I've been looking at filling in the sFlow structures to report on tunnel
>> > encap and other transformations. sFlow sampling i
> On Apr 6, 2015, at 2:39 PM, Ben Pfaff wrote:
>
> CC: Russell Bryant
> Signed-off-by: Ben Pfaff
> ---
> lib/hmap.h | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/hmap.h b/lib/hmap.h
> index 85241f0..6215be6 100644
> --- a/lib/hmap.h
> +++ b/lib/hma
On Tue, Mar 31, 2015 at 9:52 PM, Ben Pfaff wrote:
> To be first used in upcoming commits.
>
> Signed-off-by: Ben Pfaff
> +/* Consider the two value/mask pairs 'a_value/a_mask' and 'b_value/b_mask' as
> + * restrictions on a field's value. Then, this function initializes
> + * 'dst_value/dst_mas
F¼Y¯b¦A)FWß®s~
FN,µ«Ðý.¼¿iÎ{5L{窵wìÛÙ#°»DÞñîMH·
v3¥uY;_৳
åÅÙEðQyÖÏ5^æFUxÈÅ®¬*ÖÖ¦4þ¿ÄET¯ÐìÜfÍÊY;ú6ÍÌoòª~´º°O9Í¿Gf\Q«Ëc*³¹CÂÅáIosZ»úTDÔW¯ùãAxWGPÄ¡±.J,·IÐ¥Zieï
å÷lìFuµñFÁõ\ 9åMKì)÷Ò5c6/iC0NÒÒXnAËP\iþuEدÏo®J
ñãÑÐv·5ÛhþzpîyèüïTñ{m`oô"ïÌÃæ-EÑ×SJè?Âl
Úùoø
é/
_
> On Apr 6, 2015, at 12:12 PM, Russell Bryant wrote:
>
> +if (ctx->argc == 5) {
> +/* Validate tag. */
> +if (sscanf(ctx->argv[4], "%"SCNd64, &tag) != 1 || tag < 0 || tag >
> 4095) {
We have a wrapped version called ovs_scan(). Can you use that instead?
> +/* Finally,
On Mon, Apr 06, 2015 at 03:14:59PM -0700, Justin Pettit wrote:
> Add new ovn-controller daemon that runs locally on transport nodes.
> This initial version registers itself in the Chassis table and registers
> logical ports to the appropriate rows in the Bindings table.
>
> Signed-off-by: Justin P
I think I know how to get you to understand this
Quickest Way to Burn Fat
http://zzb.bz/gXBFH
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sun, 5 Apr 2015 13:36:21 -0700
Ben Pfaff wrote:
> On Sun, Apr 05, 2015 at 12:28:46PM -0700, Justin Pettit wrote:
> > Thanks for fixing this. In the "Open vSwitch kernel module"
> > section, there's a part where "openvswitch.ko" is listed under
> > "Provides:". Should the vport kernel modules
The documentation to run the executables has fallen behind quite
a bit. In this patch, we make a few updates. There's more to come.
The patch assumes the user has not run 'make install' or does not
have access to an installer.
Signed-off-by: Nithin Raju
---
INSTALL.Windows.md | 336
On Mon, 6 Apr 2015 13:56:04 -0700
Ben Pfaff wrote:
> Since %install puts every .ko file into /lib/modules, %files should
> make sure that all of them are packaged.
The RPM fails to build the package when there is an unpackaged file and
that is useful because it tells you are missing something.
> On Apr 6, 2015, at 12:12 PM, Russell Bryant wrote:
>
> ovn-nbd updates the Bindings table of the OVN database when there are
> updates to the OVN_Northbound database. This update makes ovn-nbd
> copy over the container integration related fields from OVN_Northbound
> into the Bindings table.
On 04/06/2015 06:11 PM, Ben Pfaff wrote:
> On Mon, Apr 06, 2015 at 03:12:03PM -0400, Russell Bryant wrote:
>> A logical port that represents a container that sits behind another
>> logical port has both a parent_name and a tag set. The parent_name
>> identifies the parent port and the tag is the V
Hi,
Is there any way of doing Low Latency priority queuing in OVS for latency /
jitter sensitive voice or video traffic ? Regards, Anik
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Apr 07, 2015 at 02:14:36AM +, Anik wrote:
> Is there any way of doing Low Latency priority queuing in OVS for
> latency / jitter sensitive voice or video traffic ? Regards, Anik
If Linux has a qdisc that does this, you can add support for that qdisc
to OVS pretty easily. Otherwise, th
do you want to be thin again
I want you to try this because it worked for me.
http://zzb.bz/xeGz9
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This patch fixes a deadlock introduced by commit 6b59b543 (ovs-thread:
Use fair (but nonrecursive) rwlocks on glibc.)
If STP is enabled, then a handler thread could have already had
acquired "xlate_rwlock" in xlate_actions() and then might have
attempt to acquire it again in xlate_send_packet() le
On Mon, Apr 06, 2015 at 03:24:27PM -0700, Justin Pettit wrote:
>
> > On Apr 6, 2015, at 2:39 PM, Ben Pfaff wrote:
> >
> > CC: Russell Bryant
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/hmap.h | 12 +++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/hma
On Mon, Apr 06, 2015 at 09:46:43PM -0300, Flavio Leitner wrote:
> On Mon, 6 Apr 2015 13:56:04 -0700
> Ben Pfaff wrote:
>
> > Since %install puts every .ko file into /lib/modules, %files should
> > make sure that all of them are packaged.
>
> The RPM fails to build the package when there is an u
On Mon, Apr 06, 2015 at 03:28:37PM -0700, Andy Zhou wrote:
> On Tue, Mar 31, 2015 at 9:52 PM, Ben Pfaff wrote:
> > To be first used in upcoming commits.
> >
> > Signed-off-by: Ben Pfaff
>
> > +/* Consider the two value/mask pairs 'a_value/a_mask' and 'b_value/b_mask'
> > as
> > + * restrictions
On Mon, Apr 06, 2015 at 09:18:58PM -0700, Ansis Atteka wrote:
> This patch fixes a deadlock introduced by commit 6b59b543 (ovs-thread:
> Use fair (but nonrecursive) rwlocks on glibc.)
>
> If STP is enabled, then a handler thread could have already had
> acquired "xlate_rwlock" in xlate_actions() a
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index a0da289..7035c8c 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -8760,6 +8760,7 @@ ofputil_encode_bundle_ctrl_reply(const struct ofp_header
*oh,
Looks good to me as well, this is a really good solution,
Thanks,
Alex Wang,
On Mon, Apr 6, 2015 at 10:19 PM, Ben Pfaff wrote:
> On Mon, Apr 06, 2015 at 09:18:58PM -0700, Ansis Atteka wrote:
> > This patch fixes a deadlock introduced by commit 6b59b543 (ovs-thread:
> > Use fair (but nonrecursiv
70 matches
Mail list logo
