> On Apr 6, 2015, at 12:12 PM, Russell Bryant <rbry...@redhat.com> wrote:
>
> + if (ctx->argc == 5) {
> + /* Validate tag. */
> + if (sscanf(ctx->argv[4], "%"SCNd64, &tag) != 1 || tag < 0 || tag >
> 4095) {
We have a wrapped version called ovs_scan(). Can you use that instead?
> + /* Finally, create the transaction. */
> +
Can you remove this extra blank line after the comment?
> + .name = "lport-get-parent-name",
> + .usage = "<lport>",
> + .min_args = 1,
> + .max_args = 1,
> + .handler = do_lport_get_parent_name,
I'd drop the "name" part of the function and command name, since it makes the
comment longer, and I'm not sure it adds much.
It might be nice to print the parent and tag in "lport-list".
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
